<p><b>@nicolas-cellier-aka-nice</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r240408264">build.win32x86/pharo.stack.spur/Makefile</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,38 @@
+#############################################################################
+# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin
+# Do make init to allow make -n to function.
+#############################################################################
+
+VM:=Pharo
+VM_NAME:=Pharo Virtual Machine
+
+VMSRCDIR:=../../spurstacksrc/vm
+# NOTES: 
+# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
+# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, 
+# then FFI module needs to adjust that. It is NOT the case of mingw.
+# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html
+#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0
</pre>
<p>These comments are troubling...<br>
Either these flags are necessary as the comment tells... but then why don't we find them in code?<br>
... or they are not anymore to date and should be removed.<br>
I know you did not add these lines by yourself, only copied them, but someone forgot to clean up, so while at it...<br>
(All these changes are marked as authored by Esteban, but I'm pretty sure that it was me who did perform the cleanup; at the time when wanting to work in a parallel pharo repository, git was somehow missused!)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW5Mo24Ot_3C2PhmUNYvtQHVG9d0Yks5u3uHhgaJpZM4ZGZOM">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyWxwUIWCdkh_0Y1do_ZLoEtvzuy_Hks5u3uHhgaJpZM4ZGZOM.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice commented on #317"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@nicolas-cellier-aka-nice commented on 317",
"sections": [
{
"text": "",
"activityTitle": "**Nicolas Cellier**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@nicolas-cellier-aka-nice",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421106572\n}"
}
],
"themeColor": "26292E"
}
]</script>