<p>Either we hardcode wide string and use explicit wide variant <code>CertOpenSystemStoreW</code>, or we use the generic <code></code>  <code>CertOpenSystemStore</code> function along with the <code>TEXT</code> macro, but mixing both is not a good idea IMO.<br>
I would vote for TEXT macro <a href="https://docs.microsoft.com/en-us/windows/desktop/api/winnt/nf-winnt-text" rel="nofollow">https://docs.microsoft.com/en-us/windows/desktop/api/winnt/nf-winnt-text</a></p>
<p>If the plugin requires a <code>-DUNICODE</code> then we should add this to the plugin Makefile...</p>
<p>Note that I compiled from a fresh cygwin64...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b2268f0d9af6907b3b913cae1251bef63d4ffe53#commitcomment-31641913">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW2hAmdvibOOJ275vOWid4fmevQEyks5u4BtLgaJpZM4ZNa2P">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW7_DV2ZHWJXOu3YwzcQHz8Yod6JBks5u4BtLgaJpZM4ZNa2P.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice on b2268f0: Either we hardcode wide string and use explicit wide variant `CertOpenSystemStoreW`, or we use the generic ` `  `CertOpenSystemStore` function along with the `TEXT` macro, but mixing both is not a good idea IMO.\r\nI would vote for TEXT macro https://docs.microsoft.com/en-us/windows/desktop/api/winnt/nf-winnt-text\r\n\r\nIf the plugin requires a `-DUNICODE` then we should add this to the plugin Makefile...\r\n\r\nNote that I compiled from a fresh cygwin64..."}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b2268f0d9af6907b3b913cae1251bef63d4ffe53#commitcomment-31641913"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b2268f0d9af6907b3b913cae1251bef63d4ffe53#commitcomment-31641913",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b2268f0d9af6907b3b913cae1251bef63d4ffe53#commitcomment-31641913",
"name": "View Commit"
},
"description": "View this Commit on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>