<p><b>@bencoman</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241049242">build.win32x86/pharo.stack.spur/Makefile</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,38 @@
+#############################################################################
+# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin
+# Do make init to allow make -n to function.
+#############################################################################
+
+VM:=Pharo
+VM_NAME:=Pharo Virtual Machine
+
+VMSRCDIR:=../../spurstacksrc/vm
+# NOTES: 
+# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
+# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, 
+# then FFI module needs to adjust that. It is NOT the case of mingw.
+# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html
+#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0
</pre>
<p>you are right, I just copied those lines from pharo.cog.spur.<br>
But is this PR the place to fix these? This PR is focused on build.win64x64/pharo.cog.spur and your concern seems a broader issue...</p>
<pre><code>$ find opensmaltalk-vm   -name Makefile  -print  -exec grep STACK_ALIGN_BYTES {} \;

./build.win32x86/pharo.cog.spur/Makefile
# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

./build.win32x86/pharo.cog.spur.lowcode/Makefile
# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

./build.win32x86/pharo.sista.spur/Makefile
# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

./build.win32x86/squeak.cog.spur.lowcode/Makefile
COGDEFS:= -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241049242">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW9MKb0zeAKU1t0K4cTkrkRialV5wks5u4RqmgaJpZM4ZGZOM">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyWzpNKviWTKnznnllwSAXMLohF-xxks5u4RqmgaJpZM4ZGZOM.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman commented on #317"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241049242"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241049242",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#discussion_r241049242",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>