On Mon, 17 Dec 2018 at 15:10, akgrant43 <notifications@github.com> wrote:<br>
<br>
> Hi Eliot,<br>
><br>
> This is an internal commit of the plugin I did during development, the<br>
> latest version from the merge is:<br>
><br>
> 94c54ed#diff-04cbc775a3686446b844a93e1520e706<br>
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94c54edc5bbb8dfac318686176e67ceaa20883bb#diff-04cbc775a3686446b844a93e1520e706><br>
><br>
> The repository is configured to not allow squash merges, so all the<br>
> commits that are part of a PR will always be present.<br>
><br>
To provide cleaner PRs, I tend to "git commit --amend" to my-branch that I<br>
issued a PR from and force push that to my github account.<br>
In spite of the general advice not to force push public branches, in<br>
reality it seems people rarely branch except from the canonical account.<br>
Actually this could be covered by a convention like...<br>
    "if you branch from someone's personal account, immediately push it to<br>
your account so it shows up in the network view."<br>
Forcing pushing only a problem if someone has branched from it the network<br>
view could be checked before forcing pushing.<br>
<br>
cheers -ben<br>
<br>
><br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31702943">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyWwi-7Ynxnk63KXIhXOsFMxVhcsh4ks5u57BZgaJpZM4ZVgm6">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW1nUWA34jp6uSiXWJR-py9_IMSjoks5u57BZgaJpZM4ZVgm6.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman on f6445ab: On Mon, 17 Dec 2018 at 15:10, akgrant43 \u003cnotifications@github.com\u003e wrote:\n\n\u003e Hi Eliot,\n\u003e\n\u003e This is an internal commit of the plugin I did during development, the\n\u003e latest version from the merge is:\n\u003e\n\u003e 94c54ed#diff-04cbc775a3686446b844a93e1520e706\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94c54edc5bbb8dfac318686176e67ceaa20883bb#diff-04cbc775a3686446b844a93e1520e706\u003e\n\u003e\n\u003e The repository is configured to not allow squash merges, so all the\n\u003e commits that are part of a PR will always be present.\n\u003e\nTo provide cleaner PRs, I tend to \"git commit --amend\" to my-branch that I\nissued a PR from and force push that to my github account.\nIn spite of the general advice not to force push public branches, in\nreality it seems people rarely branch except from the canonical account.\nActually this could be covered by a convention like...\n    \"if you branch from someone's personal account, immediately push it to\nyour account so it shows up in the network view.\"\nForcing pushing only a problem if someone has branched from it the network\nview could be checked before forcing pushing.\n\ncheers -ben\n\n\u003e\n"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31702943"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31702943",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31702943",
"name": "View Commit"
},
"description": "View this Commit on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>