<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Hi Alistair,<br><div dir="ltr"><br></div><div dir="ltr"><br>On Dec 30, 2018, at 9:29 AM, Alistair Grant <<a href="mailto:akgrant0710@gmail.com">akgrant0710@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div dir="ltr"><span></span><br><span>Hi All,</span><br><span></span><br><span>Recent versions of vmmaker are generating code similar to:</span><br><span></span><br><span>#if VM_PROXY_MAJOR > 1 || (VM_PROXY_MAJOR == 1 && VM_PROXY_MINOR >= 14)</span><br><span>extern sqInt primitiveFailForOSError(sqLong osError);</span><br><span>#else</span><br><span># define primitiveFailForOSError(osError) 0</span><br><span>#endif</span><br><span></span><br><span></span><br><span>This seems quite dangerous as compiling with an earlier version of the</span><br><span>VM will succeed, but the plugin will behave in strange ways when run.</span><br><span>Forcing a compiler failure seems like the safer option, e.g. something</span><br><span>like:</span><br><span></span><br><span>#error "Not supported on VMs earlier than 1.14"</span><br><span></span><br><span>What do you think?</span><br></div></blockquote><div><br></div>That’s one alternative. Another is<div><br><div><div dir="ltr"><font color="#000000"><span style="caret-color: rgb(0, 0, 0); background-color: rgba(255, 255, 255, 0);">#else<br># define primitiveFailForOSError(osError) </span></font><span style="background-color: rgba(255, 255, 255, 0);">primitiveFailFor(PrimErrOSError)</span></div><div dir="ltr"><font color="#000000"><span style="caret-color: rgb(0, 0, 0); background-color: rgba(255, 255, 255, 0);">#endif</span></font></div><div><br></div><div>or</div><div><br></div><div><div dir="ltr"><span style="background-color: rgba(255, 255, 255, 0);">#else<br># define primitiveFailForOSError(osError) primitiveFailFor(PrimErrUnsupported)</span></div><div dir="ltr"><span style="background-color: rgba(255, 255, 255, 0);">#endif</span></div><div dir="ltr"><br></div><blockquote type="cite"><div dir="ltr"><span></span><span>Thanks,</span><br><span>Alistair</span><br></div></blockquote></div></div></div></body></html>