<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">On Mon, 31 Dec 2018 at 07:45, Ben Coman <<a href="mailto:btc@openinworld.com">btc@openinworld.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, 31 Dec 2018 at 07:20, Fabio Niephaus <<a href="mailto:lists@fniephaus.com" target="_blank">lists@fniephaus.com</a>> wrote:<br>
><br>
> On Mon, 31 Dec 2018 at 12:07 am, Ben Coman <<a href="mailto:btc@openinworld.com" target="_blank">btc@openinworld.com</a>> wrote:<br>>><br>
>> I find the specification of the test image too implicit here...<br>
>>    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/tests/smalltalkCI.sh" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/tests/smalltalkCI.sh</a><br>
>> For example, its hard to tell at a glance whether lowcode testing is enabled/disabled.<br>
>> Could the test image be explicitly defined in travis.yml ? (I'll submit a concept PR for review)<br>
><br>
><br>
> Please do, happy to review a PR. The current version is still the very first version, I'm sure it can use some improvements :)<br></blockquote><div><br></div><div>Here are my proposed changes...</div><div><a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/331">https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/331</a><br></div><div><br></div><div>Here it is a sample log of the first job...</div><div><a href="https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/473714437#L441">https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/473714437#L441</a><br></div><div><a href="https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/473714437#L9438">https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/473714437#L9438</a><br></div><div><br></div><div>So the goal was that you can hover over the environment variables to easily review the test configuration here... </div><div><a href="https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/473714436">https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/473714436</a><br></div><div><br></div><div>I'm not sure how the newspeak builds should be handled differently,</div><div>since they use an alternate test script from here...</div><div><a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/tree/Cog/tests">https://github.com/OpenSmalltalk/opensmalltalk-vm/tree/Cog/tests</a><br></div><div><br></div><div>cheers -ben </div><div> </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">btw, are we indeed not testing VMs on Windows?<br>
  <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/.appveyor.yml#L123" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/.appveyor.yml#L123</a><br>
</blockquote></div></div></div></div></div></div></div></div>