<p>This fixes are mainly</p>
<ul>
<li>my own failure to respect the invariant <em>imageName and imageNameW must always be synched</em>, writing in imageNameT (the TCHAR* facade) cannot work!</li>
<li>SecurityPlugin broken by merge win minheadless experiments. I agree with the spirit of the changes (UNICODE), but this is unfinished.</li>
<li>a few potential security flaws coming from the past</li>
</ul>
<p>[skip travis] i don't know if this incantation will work the way i wish... These are platforms/win32 changes only</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>fix: squeakIniName cannot be both a WCHAR* (sqWin32Security.c) and TCHAR*</li>
  <li>fix: remove superfluous TEXT macro</li>
  <li>fix:  wcsncpy does not necessarily writes the terminating NULL</li>
  <li>fix: B3DAccelerator: dwState is used un-initialized if value is not 0,1 or 2.</li>
  <li>fix issue #336 potential buffer overrun in sqWin32Midi.c</li>
  <li>fix: use LoadLibraryA for -DUNICODE compatibility</li>
  <li>fix: LoadLibrary could fail</li>
  <li>fix: SecurityPlugin: RegQueryValueExW dwSize is buffer size in bytes</li>
  <li>SecurityPlugin: prefer wcs* functions to lstr*W</li>
  <li>Fix: securityPlugin: use WideCharToMultiByte and CP_UTF8</li>
  <li>SecurityPlugin use MultiByteToWideChar rather than sqUTF8toUTF16Copy</li>
  <li>fix: SecurityPlugin: restore expandMyDocuments</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files#diff-0">platforms/win32/plugins/B3DAcceleratorPlugin/sqWin32D3D.c</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files#diff-1">platforms/win32/plugins/CroquetPlugin/sqWin32CroquetPlugin.c</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files#diff-2">platforms/win32/plugins/MIDIPlugin/sqWin32MIDI.c</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files#diff-3">platforms/win32/plugins/SecurityPlugin/sqWin32Security.c</a>
    (138)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files#diff-4">platforms/win32/vm/sqWin32.h</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files#diff-5">platforms/win32/vm/sqWin32Backtrace.c</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files#diff-6">platforms/win32/vm/sqWin32Main.c</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files#diff-7">platforms/win32/vm/sqWin32Prefs.c</a>
    (23)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files#diff-8">platforms/win32/vm/sqWin32Window.c</a>
    (25)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338.patch'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338.patch</a></li>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338.diff'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW9gGu47RjWX0hQChz-BDoRvNCtYfks5u_cOYgaJpZM4ZnvBa">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW_49m-NAH7E7ri1JcMcCQosl-DDRks5u_cOYgaJpZM4ZnvBa.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Win64 fixes (#338)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>