<blockquote>
<p>The drawback of this approach is that we identify the VM by the commit id, and this will prevent the same commit id being present on all platforms whenever a change is made that doesn't affect Windows.</p>
</blockquote>
<p>Well shouldn't it work that way? I mean, there are other drawbacks of identifying VMs by commit id (e.g. the need for git hooks). More importantly, why rebuild all Linux/macOS VMs when only Windows code was modified? I have never expected bleeding edge "releases" on Bintray to be complete, no one really should because they are mainly for development and builds happen to fail from time to time. Stable release builds will still be triggered simultaneously on AppVeyor and Travis. So we should be fine, right?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/349#issuecomment-451702107">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW0-pgGZTiP1MJDgCZw4jYAfiDYS3ks5vATkzgaJpZM4ZyCx8">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW-emHsj3bJZ0_WNTKxwe9mzoeOhtks5vATkzgaJpZM4ZyCx8.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@fniephaus in #349: \u003eThe drawback of this approach is that we identify the VM by the commit id, and this will prevent the same commit id being present on all platforms whenever a change is made that doesn't affect Windows.\r\n\r\nWell shouldn't it work that way? I mean, there are other drawbacks of identifying VMs by commit id (e.g. the need for git hooks). More importantly, why rebuild all Linux/macOS VMs when only Windows code was modified? I have never expected bleeding edge \"releases\" on Bintray to be complete, no one really should because they are mainly for development and builds happen to fail from time to time. Stable release builds will still be triggered simultaneously on AppVeyor and Travis. So we should be fine, right? "}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/349#issuecomment-451702107"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/349#issuecomment-451702107",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/349#issuecomment-451702107",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>