<p><b>@bencoman</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395#discussion_r284257263">platforms/unix/vm/sqUnixMain.c</a>:</p>
<pre style='color:#555'>> @@ -863,13 +863,13 @@ sqInt  primitivePluginRequestState(void)       { return dpy->primitivePluginRequestSta
 
 static void outOfMemory(void)
 {
-  /* pushing stderr outputs the error report on stderr instead of stdout */
+  /* pushing VM_ERR() outputs the error report on VM_ERR() instead of stdout */
</pre>
<p>What is the significance of changing this comment?  (I'm not familiar with <em>pushOutputFile</em>)</p>

<hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395#discussion_r284258351">platforms/unix/vm/sqUnixMain.c</a>:</p>
<pre style='color:#555'>>    pushOutputFile((char *)STDERR_FILENO);
   error("out of memory\n");
 }
 
 /* Print an error message, possibly a stack trace, do /not/ exit.
- * Allows e.g. writing to a log file and stderr.
+ * Allows e.g. writing to a log file and VM_ERR().
</pre>
<p>Same again. Search/replaced within comment useful?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395?email_source=notifications&email_token=AIJPEW4U2F2NJITIQ63MWMDPVQGYTA5CNFSM4HKXXHEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBYWONUA#pullrequestreview-237823696">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW2OIOURZ23T6TQEP2DPVQGYTANCNFSM4HKXXHEA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AIJPEW4IDQPLP6742RVV6HDPVQGYTA5CNFSM4HKXXHEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBYWONUA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395?email_source=notifications\u0026email_token=AIJPEW4U2F2NJITIQ63MWMDPVQGYTA5CNFSM4HKXXHEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBYWONUA#pullrequestreview-237823696",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395?email_source=notifications\u0026email_token=AIJPEW4U2F2NJITIQ63MWMDPVQGYTA5CNFSM4HKXXHEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBYWONUA#pullrequestreview-237823696",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>