Hi Eliot,<br>
I will remove the translation to mac-roman, it's just that these dirty<br>
corners speed my progression down.<br>
If i understand correctly, either the legacy polling API is not<br>
internationalization friendly, or maybe the wParam does contain someting<br>
else than utf32/ucs4 code? Do we really need to support legacy polling API?<br>
Sharing platform code forever with old VM is not sustainable, it<br>
complexifies everything, IMO we have a license to cut useless code.<br>
<br>
Le mer. 12 juin 2019 à 03:39, Eliot Miranda <notifications@github.com> a<br>
écrit :<br>
<br>
> Hi Nicolas,<br>
><br>
> it's put code. Why not just fix it?<br>
><br>
> On Tue, Jun 11, 2019 at 2:40 PM Nicolas Cellier <notifications@github.com><br>
> wrote:<br>
><br>
> > I'm somehow amazed to not see a keymap[wParam & 0xff] buffer overrun<br>
> > protection here!<br>
> > This code is probably never executed since the image side presumably<br>
> > provide a non NULL inputSemaphoreIndex, but it's scary.<br>
> ><br>
> > —<br>
> > You are receiving this because you authored the thread.<br>
> > Reply to this email directly, view it on GitHub<br>
> > <<br>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e4736452282d6e71ffe624a76267?email_source=notifications&email_token=ADY5VUEFXNWVU5PSQB5VXCTP2ALUPA5CNFSM4HXDSVUKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAKSFO#commitcomment-33900718<br>
> >,<br>
> > or mute the thread<br>
> > <<br>
> https://github.com/notifications/unsubscribe-auth/ADY5VUCPLK4B7UBYBTM4ZWLP2ALUPANCNFSM4HXDSVUA<br>
> ><br>
> > .<br>
> ><br>
><br>
><br>
> --<br>
> _,,,^..^,,,_<br>
> best, Eliot<br>
><br>
> —<br>
> You are receiving this because you commented.<br>
> Reply to this email directly, view it on GitHub<br>
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e4736452282d6e71ffe624a76267?email_source=notifications&email_token=AAFRYIQWUXJJ72IA2SUNXELP2BHU3A5CNFSM4HXDSVUKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAKVEL#commitcomment-33903755>,<br>
> or mute the thread<br>
> <https://github.com/notifications/unsubscribe-auth/AAFRYIW3TBYQSMUTZVDSQILP2BHU3ANCNFSM4HXDSVUA><br>
> .<br>
><br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e4736452282d6e71ffe624a76267?email_source=notifications&email_token=AIJPEW4ELWTYVI3JMOU2GQ3P2CC4NA5CNFSM4HXDSVUKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAKW2Y#commitcomment-33905496">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEWZRYLM7TE7EPJ5OOUDP2CC4NANCNFSM4HXDSVUA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AIJPEWZTISZDCV7RCSTFSADP2CC4NA5CNFSM4HXDSVUKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAKW2Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e4736452282d6e71ffe624a76267?email_source=notifications\u0026email_token=AIJPEW4ELWTYVI3JMOU2GQ3P2CC4NA5CNFSM4HXDSVUKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAKW2Y#commitcomment-33905496",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e4736452282d6e71ffe624a76267?email_source=notifications\u0026email_token=AIJPEW4ELWTYVI3JMOU2GQ3P2CC4NA5CNFSM4HXDSVUKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBAKW2Y#commitcomment-33905496",
"name": "View Commit"
},
"description": "View this Commit on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>