<div dir="auto">Yes, sorry, I wanted to merge.<div dir="auto">But as usual, builds were red.</div><div dir="auto">So i switched to the build problem, which is more important IMO, and my dev cycles are sparse...</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mer. 23 oct. 2019 à 08:20, Fabio Niephaus <<a href="mailto:lists@fniephaus.com">lists@fniephaus.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div><div><div dir="auto">Hi Eliot,</div></div><div><br><div class="gmail_quote"></div></div></div><div><div dir="ltr" class="gmail_attr">On Wed, 23 Oct 2019 at 8:44 am, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank" rel="noreferrer">eliot.miranda@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr"><div dir="ltr">Hi Nicolas, Hi git mavens,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 22, 2019 at 3:24 AM Nicolas Cellier <<a href="mailto:noreply@github.com" target="_blank" rel="noreferrer">noreply@github.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"> <br>
Branch: refs/heads/small_fixes<br>
Home: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm</a><br>
Commit: f1bc1cce999b3bcca317baa84bd0b28f21a4d7b0<br>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f1bc1cce999b3bcca317baa84bd0b28f21a4d7b0" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f1bc1cce999b3bcca317baa84bd0b28f21a4d7b0</a><br>
Author: Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank" rel="noreferrer">nicolas.cellier.aka.nice@gmail.com</a>><br>
Date: 2019-10-20 (Sun, 20 Oct 2019)<br>
<br>
Changed paths:<br>
M platforms/unix/vm/sqUnixMain.c<br>
<br>
Log Message:<br>
-----------<br>
Fix copy/paste typo when printing registers<br></blockquote><div><br></div><div>Why is this commit not showing up when I pull? We need this fix asap. I don't understand where it is. Did I fail to merge it and overwrote it?</div></div></div></blockquote><div dir="auto"><br></div></div><div><div dir="auto">The commit is on the "small_fixes" branch, which isn't merged yet I guess. Not sure if Nicolas wants the branch to be merged already, but "git pull origin small_fixes" should do that for you.</div></div><div dir="auto"><br></div><div dir="auto">Fabio</div><div><div><div class="gmail_quote"><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div></div></div><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
<br>
Commit: 0e8de8580aedea1052fc771d6f301ba8fd17ef4e<br>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0e8de8580aedea1052fc771d6f301ba8fd17ef4e" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0e8de8580aedea1052fc771d6f301ba8fd17ef4e</a><br>
Author: Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank" rel="noreferrer">nicolas.cellier.aka.nice@gmail.com</a>><br>
Date: 2019-10-20 (Sun, 20 Oct 2019)<br>
<br>
Changed paths:<br>
M platforms/unix/plugins/SocketPlugin/sqUnixSocket.c<br>
<br>
Log Message:<br>
-----------<br>
Remove a pointer aliasing (replace by memcpy).<br>
<br>
Reason: gcc compiler barks.<br>
platforms/unix/plugins/SocketPlugin/sqUnixSocket.c:1452:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]<br>
*(int *)buf= 1;<br>
It's probably benign in this case, but rather than trying to confirm this for all current and future versions of compilers, it's far easier to just avoid breaking strict aliasing.<br>
<br>
<br>
Commit: 86e976be8ca1a830d16c2e9f320258e6e69f291e<br>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/86e976be8ca1a830d16c2e9f320258e6e69f291e" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/86e976be8ca1a830d16c2e9f320258e6e69f291e</a><br>
Author: Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank" rel="noreferrer">nicolas.cellier.aka.nice@gmail.com</a>><br>
Date: 2019-10-20 (Sun, 20 Oct 2019)<br>
<br>
Changed paths:<br>
M platforms/unix/vm-display-X11/sqUnixX11.c<br>
<br>
Log Message:<br>
-----------<br>
Remove a (false positive) -Wmaybe-uninitialized warning<br>
<br>
Tell why we do it, why it's not necessary (as long as int have 32 bits).<br>
Analyzing warnings again and again is time consuming.<br>
So even false positive should better be eliminated.<br>
<br>
<br>
Commit: 09878ce6d3ae50385ecd63685fb486f4b925d7d8<br>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/09878ce6d3ae50385ecd63685fb486f4b925d7d8" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/09878ce6d3ae50385ecd63685fb486f4b925d7d8</a><br>
Author: Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank" rel="noreferrer">nicolas.cellier.aka.nice@gmail.com</a>><br>
Date: 2019-10-20 (Sun, 20 Oct 2019)<br>
<br>
Changed paths:<br>
M platforms/unix/vm-display-X11/sqUnixX11.c<br>
<br>
Log Message:<br>
-----------<br>
Remove two warnings about incompatible pointer type<br>
<br>
Implementation should conform to SqDisplay.h<br>
<br>
platforms/unix/vm-display-X11/sqUnixX11.c:7453:1: warning: incompatible pointer types initializing 'long (*)(char *, int)' with an expression of type 'long (char *, long)' [-Wincompatible-pointer-types]<br>
SqDisplayDefine(X11);<br>
^~~~~~~~~~~~~~~~~~~~<br>
platforms/unix/vm/SqDisplay.h:108:3: note: expanded from macro 'SqDisplayDefine'<br>
display_winImageFind, \<br>
^~~~~~~~~~~~~~~~~~~~<br>
/platforms/unix/vm-display-X11/sqUnixX11.c:7453:1: warning: incompatible pointer types initializing 'long (*)(unsigned int *, long, long, long, long, long, long, long, long)' with an expression of type 'long (unsigned int *, long, long, long, int, int, int, int, int)' [-Wincompatible-pointer-types]<br>
SqDisplayDefine(X11);<br>
^~~~~~~~~~~~~~~~~~~~<br>
platforms/unix/vm/SqDisplay.h:157:3: note: expanded from macro 'SqDisplayDefine'<br>
display_hostWindowShowDisplay, \<br>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
<br>
<br>
Commit: 1c3a0ca9df711d31f6964a6511a2b7e98abab3e8<br>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1c3a0ca9df711d31f6964a6511a2b7e98abab3e8" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1c3a0ca9df711d31f6964a6511a2b7e98abab3e8</a><br>
Author: Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank" rel="noreferrer">nicolas.cellier.aka.nice@gmail.com</a>><br>
Date: 2019-10-21 (Mon, 21 Oct 2019)<br>
<br>
Changed paths:<br>
M platforms/unix/vm-display-null/sqUnixDisplayNull.c<br>
<br>
Log Message:<br>
-----------<br>
Same uncompatible pointer fix for display-null<br>
<br>
<br>
Compare: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/f1bc1cce999b%5E...1c3a0ca9df71" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/f1bc1cce999b%5E...1c3a0ca9df71</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div></div>
</blockquote></div></div>
</div>
</blockquote></div>