<p>So says the compiler:</p>
<blockquote>
<p>../../platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c:94:61: warning: result of comparison of constant 0 with boolean expression is always true [-Wtautological-constant-compare]<br>
if ((  (read(in, mem, stat.st_size) != stat.st_size) >= 0)<br>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~<br>
../../platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c:95:56: warning: result of comparison of constant 0 with boolean expression is always true [-Wtautological-constant-compare]<br>
&& (write(out, mem, stat.st_size) != stat.st_size) >= 0)</p>
</blockquote>
<p>The compiler is right, this makes not much sense:</p>
<pre><code>      if ((  (read(in, mem, stat.st_size) != stat.st_size) >= 0)
          && (write(out, mem, stat.st_size) != stat.st_size) >= 0)
</code></pre>
<p>Also, the <code>copy</code> function may leave open file descriptors in case of failure, so it badly need some attention.</p>
<p><a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c">https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/442?email_source=notifications&email_token=AIJPEW7AEQXHV3RPF5YFSPLQRSMUBA5CNFSM4JIAEQHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWG5QXQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW3NCNWWJQZKTYODKTTQRSMUBANCNFSM4JIAEQHA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEWZSUDYOITT236H3EWTQRSMUBA5CNFSM4JIAEQHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWG5QXQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/442?email_source=notifications\u0026email_token=AIJPEW7AEQXHV3RPF5YFSPLQRSMUBA5CNFSM4JIAEQHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWG5QXQ",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/442?email_source=notifications\u0026email_token=AIJPEW7AEQXHV3RPF5YFSPLQRSMUBA5CNFSM4JIAEQHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWG5QXQ",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>