<p><b>@krono</b> commented on this pull request.</p>

<p>Looks good overall</p><hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451#discussion_r355375045">build.linux64x64/squeak.cog.spur/build/mvm</a>:</p>
<pre style='color:#555'>> @@ -11,7 +11,7 @@ LDFLAGS=""
 case $(uname -s) in
   OpenBSD)
            CFLAGS="$CFLAGS -I/usr/local/include"
-           LIBS="$LIBS -lexecinfo"
+           LIBS="$LIBS -lexecinfo -lsndio"
</pre>
<p>This should go in <code>Makefile.inc</code> in the plugins dir as such:</p>
<pre><code>PLIBS=-lsndio
</code></pre>

<hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451#discussion_r355375464">platforms/unix/vm-sound-sndio/sqUnixSndioSound.c</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,201 @@
+/* sqUnixSndioSound.c -- sound module for sndio sound system
+ *
+ * Last edited: 2005-04-06 05:44:40 by piumarta on pauillac.hpl.hp.com
</pre>
<p>maybe adapt that one ;)</p>

<hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451#discussion_r355375659">platforms/unix/vm-sound-sndio/sqUnixSndioSound.c</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,201 @@
+/* sqUnixSndioSound.c -- sound module for sndio sound system
+ *
+ * Last edited: 2005-04-06 05:44:40 by piumarta on pauillac.hpl.hp.com
+ *
+ * This is a driver for the OpenBSD sndio sound drivers for Squeak.
+ *
+ */
+
+#include "sq.h"
+#include "sqaio.h"
+
+#include <stdio.h>
+#include <sndio.h>
+
+#define trace() fprintf(stderr, "%s:%d %s\n", __FILE__, __LINE__, __FUNCTION__)
</pre>
<p>Please add a debug guard</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications&email_token=AIJPEWZBKSQUY6UMNIH34ATQXYOIXA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOMYAAQ#pullrequestreview-328826882">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEWYY4KVHYPC5TPTXHRDQXYOIXANCNFSM4JYGZGYA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEW6L7IWM3ZRKXSIMDE3QXYOIXA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOMYAAQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEWZBKSQUY6UMNIH34ATQXYOIXA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOMYAAQ#pullrequestreview-328826882",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEWZBKSQUY6UMNIH34ATQXYOIXA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOMYAAQ#pullrequestreview-328826882",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>