<div dir="ltr">Thanks!!<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 8, 2020 at 2:55 AM smalltalking <<a href="mailto:noreply@github.com">noreply@github.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"> <br>
  Branch: refs/heads/Cog<br>
  Home:   <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm</a><br>
  Commit: f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e<br>
      <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e</a><br>
  Author: smalltalking <<a href="mailto:leves@caesar.elte.hu" target="_blank">leves@caesar.elte.hu</a>><br>
  Date:   2020-01-08 (Wed, 08 Jan 2020)<br>
<br>
  Changed paths:<br>
    M platforms/Cross/plugins/CroquetPlugin/CroquetPlugin.h<br>
    M platforms/Mac OS/vm/Developer/sqMacMinimal.c<br>
    M platforms/Mac OS/vm/osExports.c<br>
    M platforms/Mac OS/vm/sqMacMain.c<br>
    M platforms/Mac OS/vm/sqMacMain.h<br>
    M platforms/unix/vm-display-Quartz/zzz/sqUnixQuartz.m<br>
    M platforms/unix/vm-display-X11/sqUnixMozilla.c<br>
    M platforms/unix/vm/osExports.c<br>
    M platforms/win32/plugins/CroquetPlugin/sqWin32CroquetPlugin.c<br>
    M platforms/win32/vm/sqWin32Exports.c<br>
    M platforms/win32/vm/sqWin32Main.c<br>
    M platforms/win32/vm/sqWin32PluginSupport.c<br>
    M src/plugins/IA32ABI/IA32ABI.c<br>
    M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c<br>
<br>
  Log Message:<br>
  -----------<br>
  Fix type inconsistencies (int vs sqInt) (#464)<br>
<br>
* Fix type inconsistencies (int vs sqInt)<br>
<br>
Found by trying to compile with LTO enabled.<br>
The VM compiles with the updated types on linux with or without LTO enabled (the LTO VM is not functional).<br>
Didn't test with the OSes but changed the declarations in their files.<br>
Affected functions:<br>
- primInIOProcessEventsFlagAddress<br>
- ioGatherEntropy<br>
- GetAttributeString<br>
- primitivePluginBrowserReady<br>
- primitivePluginDestroyRequest<br>
- primitivePluginRequestFileHandle<br>
- primitivePluginRequestState<br>
- primitivePluginRequestURL<br>
- primitivePluginRequestURLStream<br>
- primitivePluginPostURL<br>
<br>
* Include sqMemoryAccess.h to have sqInt defined<br>
<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>