On Fri, Jan 10, 2020 at 1:57 PM Nicolas Cellier <notifications@github.com><br>
wrote:<br>
<br>
> I broke it in #448<br>
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/448><br>
> The function signature was already BADLY inconsistent!<br>
> But luckily, the erroneous 64 bits arguments did get copied into 32 bits<br>
> dstY before my fix...<br>
> I sort of broke the spell and the magic vanished ;)<br>
> Brittle code = hazardous life<br>
><br>
> What I'm very unsure of now, is if writing at negative offset is a good<br>
> idea (buffer underflow?), or if this uncovers yet another bug at upper<br>
> level...<br>
> If I just correct function signature, the game seems to work though...<br>
><br>
<br>
That's the right thing to do, no?  Just fix the signature.<br>
<br>
_,,,^..^,,,_<br>
best, Eliot<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/468?email_source=notifications&email_token=AIJPEW6MOHDFU7HICWI57YTQ5DW67A5CNFSM4KFNXE22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVLSPI#issuecomment-573225277">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW7CHCBGKBA4EOSAKE3Q5DW67ANCNFSM4KFNXE2Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEW76PWMY33JS47TD7WLQ5DW67A5CNFSM4KFNXE22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVLSPI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/468?email_source=notifications\u0026email_token=AIJPEW6MOHDFU7HICWI57YTQ5DW67A5CNFSM4KFNXE22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVLSPI#issuecomment-573225277",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/468?email_source=notifications\u0026email_token=AIJPEW6MOHDFU7HICWI57YTQ5DW67A5CNFSM4KFNXE22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVLSPI#issuecomment-573225277",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>