<div><div dir="auto">@Jakob: Eliot seems to have merged this without incorporating your feedback. Could you please open another PR with your suggestions?</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Fabio</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, 11 Apr 2020 at 9:46 pm, Jakob Reschke <<a href="mailto:notifications@github.com">notifications@github.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"> <p></p>
<p><b>@j4yk</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/485#discussion_r407103373" target="_blank">platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c</a>:</p>
<pre style="font-family:monospace;color:rgb(85,85,85)">>    DWORD dwReallyWritten;
-  WriteFile((HANDLE)(h-1), (LPVOID) ptr, count*sz, &dwReallyWritten, NULL);
-  return (size_t) (dwReallyWritten / sz);
+  size_t totalToWrite = count * sz;
+  squeakFileOffsetType position;
+
+  position = sqImageFilePosition(h);
+  while (reallyWritten != totalToWrite) {
+    DWORD toWrite = (totalToWrite - reallyWritten) > (size_t) MAX_DWORD ? MAX_DWORD : totalToWrite - reallyWritten;
+    BOOL ret = WriteFile((HANDLE)(h - 1), (LPVOID)((sqInt)ptr + (sqInt) reallyWritten), toWrite, &dwReallyWritten, NULL);
+    reallyWritten += dwReallyWritten;
+
+    if (!ret | dwReallyWritten != toWrite) {
</pre>
<p>See above.</p>

<p style="font-size:small;color:rgb(102,102,102)">—<br>You are receiving this because you are subscribed to this thread.<br>Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/485#pullrequestreview-391795361" target="_blank">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEWYSLSBS2AMBET6YZLTRMDCK3ANCNFSM4MGDV3UQ" target="_blank">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEW2SQ2JVEIVIUGCYU4LRMDCK3A5CNFSM4MGDV3U2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC5NFFII.gif" height="1" width="1" alt=""></p>
</blockquote></div></div>