<p>Also fixes a minor issue in MSVC Makefile for 64x64, which tried 0x0801 for Windows 8 and 0x1001 for Windows 10. The latter would actually be 0x0A00. See <a rel="nofollow" href="https://docs.microsoft.com/de-de/cpp/porting/modifying-winver-and-win32-winnt">https://docs.microsoft.com/de-de/cpp/porting/modifying-winver-and-win32-winnt</a></p>
<p>Also in the Makefile for 64x64, define both _WIN32 and _WIN64. See <a rel="nofollow" href="https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros">https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros</a></p>
<p>Also in the Makefile for 64x64, define both WIN32 and WIN64 because those can be used to identify the Windows platform in application code such as in processors/IA32/bochs. I am not aware of any #ifdef WIN64 at the moment. Most code uses #ifdef _WIN64 to check for that.</p>
<p>Note that, having defined both _WIN32 and _WIN64, code for 32-bit and 64-bit must always begin with #ifdef _WIN64 and only then #elif _WIN32.</p>
<p>I think that the MSVC compiler defines _WIN32 and _WIN64 automatically. Yet, now it is documented in the Makefile.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Bump minimal supported Windows version to Windows 8 (0x0602).</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499/files#diff-9254b396ffdc196ab6fc01554f54d079">build.win32x86/common/Makefile.msvc.tools</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499/files#diff-e01ad70a1f3633757eef39aa0e1713c9">build.win32x86/common/Makefile.tools</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499/files#diff-cea0102456becac9c773e141a35614fe">build.win64x64/common/Makefile.msvc.tools</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499/files#diff-ba62625b69927c70d7335af05de045be">build.win64x64/common/Makefile.tools</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499/files#diff-ea77aa3cf89ad27f0980e8a8b857fb1c">platforms/win32/vm/sqWin32.h</a>
    (41)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499/files#diff-b2861f6fae73ea2883296b82603a39eb">platforms/win32/vm/sqWin32Main.c</a>
    (77)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499.patch'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499.patch</a></li>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499.diff'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEWYLOTDDLBN2WEMFG2TRRDVUVANCNFSM4M6RJREQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEW5GXLNRO6LTL5ILHWTRRDVUVA5CNFSM4M6RJRE2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4JF5R53A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/499",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>