<p></p>
<p>Hi David,</p>
<p>thanks for sharing your observations, this fits in with my own results.</p>
<blockquote>
<p>By the way I did the same 3 tests with a VM which I compiled from the OpenSmalltalk Cog branch (not from the PR).</p>
<p>I seem to be having the same results.</p>
</blockquote>
<p>So there appears not to be any regression.</p>
<blockquote>
<p>But basically I don't understand what you are trying to fix.</p>
</blockquote>
<p>Here is how you can observe the erroneous under-the-hood behavior this PR aims to fix:</p>
<ol>
<li>In a recent Squeak image, browse <code>HandMorph >> #generateDropFilesEvent:</code> and insert the following line after the assignment of <code>dragType:</code>
<div class="highlight highlight-source-smalltalk"><pre><span class="pl-c1">Transcript</span> <span class="pl-c1">showln:</span> dragType.</pre></div>
</li>
<li>Open a Transcript</li>
<li>Drag a file into the image</li>
</ol>
<p>Transcript output on an X11 platform using the latest released plugin version:</p>
<pre><code>1 (dragEnter)
2 (dragMove)
2 (dragMove)
...
2 (dragMove)
3 (dragLeave)
4 (dragDrop)
3 (dragLeave)
</code></pre>
<p>Transcript when compiling the plugin with the proposed patch applied:</p>
<pre><code>1 (dragEnter)
2 (dragMove)
2 (dragMove)
...
2 (dragMove)
4 (dragDrop)
</code></pre>
<p>The current image implementation does not care about the additional, false dragLeave events, but my changeset which I am planning to put into the inbox will do so.</p>
<p>Is this comprehensible? <g-emoji class="g-emoji" alias="sweat_smile" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f605.png">😅</g-emoji></p>
<p>PS: For some reasons all your posts arrive multiple times in the repository. Also, they would be easier to read if you could use codefences (<code>```</code>) :-)</p>
<p>Best,<br>
Christoph</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676129131">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEWYYH3GME6IEAODSD5LSBOUPHANCNFSM4N4SXVFQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEWY7WLHET4IL2VFKIB3SBOUPHA5CNFSM4N4SXVF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFBGOS2Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676129131",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-676129131",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>