<p>-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA256</p>
<p>Support PKG_CONFIG in configure for UnicodePlugin :</p>
<p>PKG_CONFIG  path to pkg-config utility<br>
PKG_CONFIG_PATH<br>
directories to add to pkg-config's search path<br>
PKG_CONFIG_LIBDIR<br>
path overriding pkg-config's built-in search path<br>
UNICODE_PLUGIN_CFLAGS<br>
C compiler flags for UNICODE_PLUGIN, overriding pkg-config<br>
UNICODE_PLUGIN_LIBS<br>
linker flags for UNICODE_PLUGIN, overriding pkg-config</p>
<p>Note that I believe that Ian Piumarta's "cmake" system for squeak-4 also<br>
uses pkg-config (when he changed from autoconf to 'cmake').</p>
<p>The reason why I made this change, is for compiling on Solaris 11.4.</p>
<p>You can see in the "mvm" script that I set PKG_CONFIG_PATH for the 64bit:</p>
<p>On Solaris 11.4 32bit there is:</p>
<h1>pkg-config --cflags glib-2.0</h1>
<p>-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include</p>
<p>and on Solaris 11.4 64bit there is:</p>
<h1>PKG_CONFIG_PATH=/usr/lib/64/pkgconfig pkg-config --cflags glib-2.0</h1>
<p>-I/usr/include/glib-2.0 -I/usr/lib/amd64/glib-2.0/include</p>
<p>Note the '64' or 'amd64' subdirectories.</p>
<p>Finally a remark: I modified</p>
<pre><code>platforms/unix/config/make.cfg.in
</code></pre>
<p>because I don't see how to define the UNICODE_PLUGIN_CFLAGS in the plugin,<br>
locally, without setting the variable globally (in all Makefiles).</p>
<p>Because of the 'mkmf' script, this will thus modify all Unix Makefiles ...</p>
<p>If somebody has a better idea, let's hear it !</p>
<p>I understand from Eliot Miranda that abandoning 'configure' is an option.</p>
<p>But that still has the issue of multiple locations on various Unix flavors,<br>
for the GTK include files and libraries ...</p>
<p>David Stes</p>
<p>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2</p>
<p>iQEcBAEBCAAGBQJfY5HNAAoJEAwpOKXMq1MaLpEIAL0qgm0zmtJs3kqV9GHli96I<br>
+OQZHL9lLn9gNjyaohpPF7UXhXjr4VbXzjrPAjU8vDR7yImNwe11bcN39VH5nwtt<br>
VrbXA3PpKFNyz5gWBWpyVs1k5ey4UZBSFF/76KwgdruDlXR/aQ7QLwR8WcC6UIfV<br>
rYcvFyLaadwIDV2XoseoVpB91J+Vjy5x/hD+bT6MNybXuvWj5hYli8obdtiBi5aS<br>
8zhBGmZnnKS8+cyfBlmbAjKknUQuy11mhos6FDQX2Wbr/VtBUYgXphcF8cYMnSIe<br>
jV1ZOaA1IQgJ+0kXGKehjqMB/EPs5LA35sUJ8nI2YC3yww0z7n+rzC8n7UttFsg=<br>
=Miad<br>
-----END PGP SIGNATURE-----</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>configure change: use pkg-config (PKG_CONFIG)</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520/files#diff-9c15eae5fdd5e0c23617308bdb709f5e">build.sunos64x64/squeak.cog.spur/build/mvm</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520/files#diff-3207f05ceb3c7790f24d04cc0f3eca3d">build.sunos64x64/squeak.stack.spur/build/mvm</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520/files#diff-ae8e047a18054aebe5da831f301a47c7">platforms/unix/config/make.cfg.in</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520/files#diff-cd4a5312c33670400c2f3bc1e1f22838">platforms/unix/plugins/UnicodePlugin/Makefile.inc</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520/files#diff-6c902444b0f35ac893c267a43f90992d">platforms/unix/plugins/UnicodePlugin/README.UnicodePlugin</a>
    (21)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520/files#diff-8fa45e236fc371aa8bba4e3bb61ba006">platforms/unix/plugins/UnicodePlugin/acinclude.m4</a>
    (19)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520.patch'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520.patch</a></li>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520.diff'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEWYAX5OKN2NQOZM2ZXDSGI4ADANCNFSM4RQWRSGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEWYQ42TVUTRUJRTFDF3SGI4ADA5CNFSM4RQWRSG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KPSKCBQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>