<p>should close PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="427020404" data-permission-text="Title is private" data-url="https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/388" data-hovercard-type="pull_request" data-hovercard-url="/OpenSmalltalk/opensmalltalk-vm/pull/388/hovercard" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/388">#388</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Adding a custom Menu for Pharo VMs</li>
<li>Adding a optional URL for the help, only fr Pharo</li>
<li>Handling correctly the events of the about window</li>
<li>Making the about window property as weak.</li>
<li>Reverting a change I needed to compile in my machine</li>
<li>Use $(SYSTEM)-MainMenu.xib to determine which xib file to use</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-1b2b82d432d691b29a481dc2a7b41575">build.macos32x86/common/Makefile.app</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-1acf74633b78e3c9776af5417d6e1967">build.macos32x86/pharo.cog.spur.lowcode/Makefile</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-db69579b8f0a2f2336d8a67dea7da8ed">build.macos32x86/pharo.cog.spur.minheadless/Makefile</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-c57ef0a04a06b7df404378a5afe7d823">build.macos32x86/pharo.cog.v3/Makefile</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-8ddfea8a7a20b35db0bafcb71a49fa70">build.macos64x64/common/Makefile.app</a>
(4)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-c071e70ba7226e1a609fa8f2d5f5008f">platforms/iOS/vm/English.lproj/Newspeak-MainMenu-cg.xib</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-7dee389a7c2f0e0fd5621cdc628b6f95">platforms/iOS/vm/English.lproj/Newspeak-MainMenu-opengl.xib</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-43682730465942fa6f5564c4a8e0e0cc">platforms/iOS/vm/English.lproj/Newspeak-MainMenu.xib</a>
(0)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-72e800f0ccd0575341a06734faaaa073">platforms/iOS/vm/English.lproj/Pharo-MainMenu-opengl.xib</a>
(1261)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-33de018cf0bef1410a88d3dadc70cecf">platforms/iOS/vm/English.lproj/Pharo-MainMenu.xib</a>
(1261)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-f5b5ebadeea64effc2d6c7e8c8b7571e">platforms/iOS/vm/English.lproj/Squeak-MainMenu-cg.xib</a>
(1261)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-15473c1f9e93bd36b254126f8d99bbc6">platforms/iOS/vm/English.lproj/Squeak-MainMenu-opengl.xib</a>
(1261)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-bc416085c30dbba54e3ed7b493e8bfa1">platforms/iOS/vm/English.lproj/Squeak-MainMenu.xib</a>
(1261)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-7cf4e77fa3d81953a70c2229e5c0fb6f">platforms/iOS/vm/OSX/Pharo-Info.plist</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-7bb16d4474112b5df33757e16a47330a">platforms/iOS/vm/OSX/SqueakOSXApplication.m</a>
(30)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-b2d25ee26d1aea5981a6ae623c322b62">platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-e8c64aba7f00f5840025560b1ff5517f">platforms/iOS/vm/OSX/sqSqueakOSXApplication.h</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files#diff-4d64e566d89b722bd40442c62ac57130">platforms/iOS/vm/OSX/sqSqueakOSXApplication.m</a>
(1)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524.patch'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524.patch</a></li>
<li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524.diff'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW2BLURUBDNV5ZL727TSHQ34JANCNFSM4RZFKXAA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEW37OOLQ2EYEFIJZ753SHQ34JA5CNFSM4RZFKXAKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KR5XAIQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>