<p></p>
<p>-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA256</p>
<p>Any feedback please ?</p>
<p>The change to use <ifaddrs.h> only if the build target has it,<br>
seems a logical change ...</p>
<p>The only risk is perhaps that somebody unintentionally re-enables the<br>
'old code' by not defining HAVE_IFADDRS_H in their Makefile or config.h.</p>
<p>This is because by default</p>
<p>#undef HAVE_IFADDRS_H</p>
<p>and that will thus by default enable the 'old code'.</p>
<p>While the default now is to enable the 'new code' which uses <ifaddrs.h>.</p>
<p>But this can easily be solved by requiring to #define HAVE_IFADDRS_H,<br>
and the 'configure' script will do just that automatically if it finds the file.</p>
<p>Anyway -- with this patch the current COGVM compiles on Solaris 10.</p>
<p>By the way Solaris 10 still uses openssl 0.9.7 and I think the configure<br>
quite correctly disables SSL support so that works fine.</p>
<p>The SSL plugin is not built I think on Solaris 10, but no problem.</p>
<p>The real interest is in the support for Solaris 11 with openssl 1.0.2 etc.,<br>
but it is nice that the code still compiles on Solaris 10.</p>
<p>Regards,<br>
David Stes</p>
<p>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2</p>
<p>iQEcBAEBCAAGBQJfbZoGAAoJEAwpOKXMq1MaO3sH/26aTh31X//H3xC/bQn+jPdK<br>
ES/YFfFXJ/OB9i/WroLia8n4IHpoPCguwdLy5NPtMbo30s8VpQeVWe2OAun+jLOX<br>
Ekj9LbfFbKpAftetgD7O+2ONWmbikvx1nrPcl4qfkD1rcf1m+ESbftsf69vDvIrc<br>
rNC+Bgq4ZR84yQIxOySzZskN34mtPQfdOxw2B1JQP1cTtPvynkiBy+fGFM2m8Y3J<br>
7StRLKQx9q4dzI875xV3Vmd9gmhFxA4MNHMOmh1i4r9rZYbrQjCtaoHnuI9abQcf<br>
jPKI01K11kyj80aZlV3h9oaslTJnEIGWhJkHFYjQBamVJcqbj2wvYLCiwc9WHIY=<br>
=lu3K<br>
-----END PGP SIGNATURE-----</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523#issuecomment-698768019">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW3UIH4K5BYRWKVEJ2DSHRAFVANCNFSM4RW6UGAA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEW4QV5HPWR3SRUCVJTDSHRAFVA5CNFSM4RW6UGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFGTFVEY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523#issuecomment-698768019",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523#issuecomment-698768019",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>