<p></p>
Wow Levente, thank you!!!!<br>
<br>
_,,,^..^,,,_ (phone)<br>
<br>
> On Oct 18, 2020, at 4:59 PM, smalltalking <notifications@github.com> wrote:<br>
> <br>
> <br>
> When HAVE_CONFIG_H and HAVE_EPOLL is true (the former is pretty much always<br>
> true), the select-based aio implementation is replaced with an epoll-based one.<br>
> The epoll variant has a few advantages:<br>
> <br>
> it is free of the lost readSemaphore signals bug (see the comments of<br>
> Socket's various #waitFor* methods which wait on readSemaphore).<br>
> idle CPU usage is down from ~10% to ~2%<br>
> faster Socket operations<br>
> Known issue:<br>
> <br>
> when the VM quits, an error message appears from aioDisable() because<br>
> the file descriptor about to be removed from the epoll set has already<br>
> been closed, therefore it's not in the set. It can be worked around<br>
> by supressing error messages when aioDisable() is called by aioFini()<br>
> You can view, comment on, or merge this pull request online at:<br>
> <br>
>   https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/528<br>
> <br>
> Commit Summary<br>
> <br>
> Added epoll support for aio.c on unix<br>
> File Changes<br>
> <br>
> M platforms/unix/vm/aio.c (356)<br>
> Patch Links:<br>
> <br>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/528.patch<br>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/528.diff<br>
> —<br>
> You are receiving this because you are subscribed to this thread.<br>
> Reply to this email directly, view it on GitHub, or unsubscribe.<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/528#issuecomment-711458845">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW2GVZ4HKES4GQMG3YLSLOH5ZANCNFSM4SVNWBRA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AIJPEW4XTW44VI5OSIWGUYLSLOH5ZA5CNFSM4SVNWBRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFJUAAHI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/528#issuecomment-711458845",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/528#issuecomment-711458845",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>