<div dir="ltr"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hi David,<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 22, 2021 at 4:14 PM David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"> <br>
On Mon, Mar 22, 2021 at 11:46:27AM +0100, Bruce O'Neel wrote:<br>
> <br>
> <br>
> Hi, <br>
> <br>
> That fixed one problem I was tripping over on the ARMv8 build. <br>
> <br>
> There still seems to be a problem with the x86-64 build.???? <br>
> <br>
> Thanks. <br>
> <br>
> bruce <br>
<br>
I see the same issue on my Linux x86-64 PC. I cannot spot the exact cause of<br>
the problem, but it seems to have been introduced in this commit:<br>
<br>
commit 6d74c4b652c7780110fe327f97e98aaef5242fbc<br>
Author: Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>><br>
Date: Wed Feb 10 21:41:31 2021 -0800<br>
<br>
Revisions to core include files to get EXPORT defined correctly at the relevant points.<br>
Essentially move the default EXPORT definitions from sq.h to sqMemoryAccess.h.<br>
Include fbdev support in build.linux32ARMv6 builds and add -m32 to their CFLAGS<br>
to attempt to get the 32-bit VMs to be compilable on 64-bit ARM. [ci skip]<br>
cuz new cogit files will arrive soon.<br>
<br>
<br>
The changes seem straightforward, but for some reason the header files must<br>
not be getting included properly.<br>
<br>
Dave<br>
<br>
<br>
<br>
<br>
> <br>
> clang -Wall?? -g -O2 -DNDEBUG -DDEBUGVM=0 -msse2 -DCOGMTVM=0 -pthread -DLSB_FIRST=1 -m64 -Wno-missing-braces -Wno-unknown-pragmas -Wno-unused-value -Wno-unu <br>
> sed-label -Wno-unused-function -Wno-unused-variable?? -DHAVE_CONFIG_H?? -DSQUEAK_BUILTIN_PLUGIN -I/home/edoneel/tmp/opensmalltalk-vm/build.linux64x64/squeak. <br>
> [cog.spur/build](<a href="http://cog.spur/build" rel="noreferrer" target="_blank">http://cog.spur/build</a>) -I/home/edoneel/tmp/opensmalltalk-vm/build.linux64x64/[squeak.cog.spur/build](<a href="http://squeak.cog.spur/build" rel="noreferrer" target="_blank">http://squeak.cog.spur/build</a>) -I/home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm -I/home/e <br>
> doneel/tmp/opensmalltalk-vm/platforms/Cross/vm -I/home/edoneel/tmp/opensmalltalk-vm/spur64src/vm -I/usr/local/include -I/home/edoneel/tmp/opensmalltalk-vm/ <br>
> platforms/Cross/vm -I/home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm -I/home/edoneel/tmp/opensmalltalk-vm/spur64src/vm -I/home/edoneel/tmp/opensmallta <br>
> lk-vm/platforms/Cross/plugins/FilePlugin -I/home/edoneel/tmp/opensmalltalk-vm/platforms/unix/plugins/B3DAcceleratorPlugin -m64 -Wno-missing-braces -Wno-unk <br>
> nown-pragmas -Wno-unused-value -Wno-unused-label -Wno-unused-function -Wno-unused-variable???? -c -o sqUnixMain.o /home/edoneel/tmp/opensmalltalk-vm/platform <br>
> s/unix/vm/sqUnixMain.c <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:872:3: warning: implicit declaration of function 'pushOutputFile' is invalid in C99 [-Wim <br>
> plicit-function-declaration] <br>
> ?? pushOutputFile((char *)STDERR_FILENO); <br>
> ?? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:926:35: error: use of undeclared identifier 'REG_RBP' <br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">If you have a look at the code here the file is trying to</div><div class="gmail_default" style="font-size:small">- find out what platform it is on</div><div class="gmail_default" style="font-size:small">- pull in the relevant version of ucontext.h containing the relevant defines for extracting register values from an interrupt context</div><div class="gmail_default" style="font-size:small">- print out the registers for a crash report</div><div class="gmail_default" style="font-size:small"></div><div class="gmail_default" style="font-size:small">So please look to</div><div class="gmail_default" style="font-size:small">- find out if platforms/unix/vm/include_ucontext.h is working correctly on this platform</div><div class="gmail_default" style="font-size:small">- find out what are the platform defines (-E -dM is your friend here)</div><div class="gmail_default" style="font-size:small">- find out how ucontext.h defines the registers in a ucontext</div><div class="gmail_default" style="font-size:small"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
> ?????????????????????????????????????????????? void *fp = (void *)(uap ? uap->_FP_IN_UCONTEXT : 0); <br>
> ???????????????????????????????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/include_ucontext.h:78:44: note: expanded from macro '_FP_IN_UCONTEXT' <br>
> # define _FP_IN_UCONTEXT uc_mcontext.gregs[REG_RBP] <br>
> ???????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:927:35: error: use of undeclared identifier 'REG_RSP' <br>
> ?????????????????????????????????????????????? void *sp = (void *)(uap ? uap->_SP_IN_UCONTEXT : 0); <br>
> ???????????????????????????????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/include_ucontext.h:79:44: note: expanded from macro '_SP_IN_UCONTEXT' <br>
> # define _SP_IN_UCONTEXT uc_mcontext.gregs[REG_RSP] <br>
> ???????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:992:9: error: use of undeclared identifier 'REG_RAX' <br>
> ?????????????????????????????????????????????? regs[REG_RAX], regs[REG_RBX], regs[REG_RCX], regs[REG_RDX], <br>
> ???????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:992:24: error: use of undeclared identifier 'REG_RBX' <br>
> ?????????????????????????????????????????????? regs[REG_RAX], regs[REG_RBX], regs[REG_RCX], regs[REG_RDX], <br>
> ?????????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:992:39: error: use of undeclared identifier 'REG_RCX' <br>
> ?????????????????????????????????????????????? regs[REG_RAX], regs[REG_RBX], regs[REG_RCX], regs[REG_RDX], <br>
> ???????????????????????????????????????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:992:54: error: use of undeclared identifier 'REG_RDX' <br>
> ?????????????????????????????????????????????? regs[REG_RAX], regs[REG_RBX], regs[REG_RCX], regs[REG_RDX], <br>
> ?????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:993:9: error: use of undeclared identifier 'REG_RDI' <br>
> ?????????????????????????????????????????????? regs[REG_RDI], regs[REG_RSI], regs[REG_RBP], regs[REG_RSP], <br>
> ???????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:993:24: error: use of undeclared identifier 'REG_RSI' <br>
> ?????????????????????????????????????????????? regs[REG_RDI], regs[REG_RSI], regs[REG_RBP], regs[REG_RSP], <br>
> ?????????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:993:39: error: use of undeclared identifier 'REG_RBP' <br>
> ?????????????????????????????????????????????? regs[REG_RDI], regs[REG_RSI], regs[REG_RBP], regs[REG_RSP], <br>
> ???????????????????????????????????????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:993:54: error: use of undeclared identifier 'REG_RSP' <br>
> ?????????????????????????????????????????????? regs[REG_RDI], regs[REG_RSI], regs[REG_RBP], regs[REG_RSP], <br>
> ?????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? ^ <br>
> /home/edoneel/tmp/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:994:9: error: use of undeclared identifier 'REG_R8' <br>
> ?????????????????????????????????????????????? regs[REG_R8 ], regs[REG_R9 ], regs[REG_R10], regs[REG_R11], <br>
> ???????????????????????????????????????????????????????? ^ <br>
> <br>
> <br>
> <br>
> <br>
> <br>
> > On Mon, Mar 15, 2021 at 04:02:43AM -0700, Tom Beckmann wrote: <br>
> > > <br>
> > > The commit that removed it was this one: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/924a24bb54870a621c5283f23631261d5a792000" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/924a24bb54870a621c5283f23631261d5a792000</a> <br>
> > > <br>
> > > I saw that you did some cleanup of old event primitives, as documented in the commit message, @eliotmiranda. Was sqUnixEvent.c deleted by accident as part of this? <br>
> > > <br>
> > <br>
> > I restored the missing sqUnixEvent.c file, which I assume was mistakenly <br>
> > deleted in that earlier commit. <br>
> > <br>
> > Dave<br>
> <br>
> <br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div></div></div>