<p>Assuming there was an error during printing (<code>wvsprintf</code>) inside of <code>vprintLastError()</code>, the second call could have returned a different error code than expected.</p>
<p>Apart from that, to me, it looks to be an idiom to call GetLastError() only once per error. In every case, printing errors now should be a tiny little bit faster. :-)</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Save two redundant calls of GetLastError()</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589/files#diff-4dd0044d605251a30fd15beae21198eb949c7a83638e45f35c8bb38662a9e4d3">platforms/win32/vm/sqWin32Utils.c</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589.patch'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589.patch</a></li>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589.diff'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW7RYU7WO6DSQIZBC53T7QCUNANCNFSM5DC2N2QQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AIJPEW5GRUJF2F2WPDVDM2TT7QCUNA5CNFSM5DC2N2Q2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OU3PFIQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/589",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>