<p dir="auto">For more than one year, drag'n'drop from the host system into the VM was broken on Linux/X11 due to a regression introduced via <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/facfd9012e9f95679dc054fde69c13d5d4b514ca/hovercard" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/facfd9012e9f95679dc054fde69c13d5d4b514ca"><tt>facfd90</tt></a>. <code>primitiveDropRequestFileName</code> would always answer <code>home/Christoph/myfile.txt</code> rather than <code>/home/Christoph/myfile.txt</code>, causing the file to be ignored on the image-side in Squeak. Now I finally found the cause of the bug, it was a simple off-by-one error.</p>
<p dir="auto">Tested on Linux/Ubuntu with XDG/Nautilus under WSL/VcXsrv. The bug was also reported to occur on native Linux distributions, though.</p>
<p dir="auto">Notes:</p>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> I don't know any system or application that would pass paths in one of the other formats (<code>file:/path</code> or <code>/path</code>). If anyone knows such applications, this would make a nice reprocase. Could you please test this out in your environment?</li>
<li>Related issue: There was also a bug report for DnD on macOS always being one file behind, i.e., nothing appearing in the image on the first drop, the first file appearing on the drop, etc. However, I think this is unrelated to this bug (different platform) and I have also no option to reproduce this unless Apple provides usable visualization support. If anyone is addressing the issue, skimming the history around <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/facfd9012e9f95679dc054fde69c13d5d4b514ca/hovercard" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/facfd9012e9f95679dc054fde69c13d5d4b514ca"><tt>facfd90</tt></a> might be a good starting point, anyway.</li>
</ul>
<p dir="auto">Mentioning <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/eliotmiranda/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eliotmiranda">@eliotmiranda</a> as the author of <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/facfd9012e9f95679dc054fde69c13d5d4b514ca/hovercard" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/facfd9012e9f95679dc054fde69c13d5d4b514ca"><tt>facfd90</tt></a> and <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/marceltaeumel/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/marceltaeumel">@marceltaeumel</a> FYIO. :-)</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616/commits/e51c41fd40c139470e82530e7c0f3bc5e86b3a99" class="commit-link">e51c41f</a> DnD/Unix: Fix dropRequestFileName which removed the trailing slash from the path</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616/files">1 file</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616/files#diff-6897256c97145e1037506915ed980d7af1e015ee266c11429a2c04d4444dd7da">platforms/unix/plugins/DropPlugin/sqUnixDragDrop.c</a>
(20)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616.patch'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616.patch</a></li>
<li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616.diff'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW36PW6FAIWJL3JWXYDU5AIW7ANCNFSM5PLR6VZQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AIJPEW26KL4PSVYB7YAJH7DU5AIW7A5CNFSM5PLR6VZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4RE2P5QA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><OpenSmalltalk/opensmalltalk-vm/pull/616</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>