<p></p>
<p><b>@eliotmiranda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#discussion_r937173685">platforms/unix/config/configure</a>:</p>
<pre style='color:#555'>> @@ -12093,7 +12093,7 @@ $as_echo "$build_arch" >&6; }
                ;;
 
                riscv64) TARGET_ARCH="-march=rv64gcv -mabi=lp64d"
-                       CFLAGS="-g -O2 -D__linux__ -D__riscv64__"
+                       CFLAGS="-g -O2 -D__riscv64__"
</pre>
<p dir="auto">Ken,  I feel uneasy with the unique solution to the offset of the thunk.  I'd rather have riscv64 be consistent with all the other platforms and adjust the offset to the thunk in thunkEntry, not in specific code in Smalltalk.  Can you live with that?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#discussion_r937173685">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW2HSLM6R7Z7RJ5QMC3VXLT5LANCNFSM55M27RQQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AIJPEW2ZTQ64FWEMPORLT7TVXLT5LA5CNFSM55M27RQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOH47HW5A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><OpenSmalltalk/opensmalltalk-vm/pull/648/review/1061059444</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#discussion_r937173685",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#discussion_r937173685",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>