<p></p>
On Wed, Aug 3, 2022 at 5:23 PM Ken Dickey ***@***.***> wrote:<br>
<br>
> On 2022-08-03 15:01, Eliot Miranda wrote:<br>
><br>
> > @ELIOTMIRANDA commented on this pull request.<br>
> ..<br>
> > Ken, I feel uneasy with the unique solution to the offset of the thunk.<br>
> > I'd rather have riscv64 be consistent with all the other platforms and<br>
> > adjust the offset to the thunk in thunkEntry, not in specific code in<br>
> > Smalltalk. Can you live with that?<br>
><br>
> Sure. Just remove the overwritten method. If you look at the latest,<br>
> the offset is zero.<br>
><br>
<br>
OK.  Fix thunkEntry to put back the offset and then I can merge the pull<br>
request.<br>
<br>
_,,,^..^,,,_<br>
best, Eliot<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#issuecomment-1205666311">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEWYGK2YQKRKK6DTLCGDVXQINVANCNFSM55M27RQQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AIJPEWYNG7MQZXPAMIOO2JLVXQINVA5CNFSM55M27RQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI7OQEBY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><OpenSmalltalk/opensmalltalk-vm/pull/648/c1205666311</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#issuecomment-1205666311",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#issuecomment-1205666311",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>