<p></p>
On 2022-08-04 12:09, Eliot Miranda wrote:<br>
<br>
> On Wed, Aug 3, 2022 at 5:23 PM Ken Dickey ***@***.***> wrote:<br>
..<br>
>> Sure. Just remove the overwritten method. If you look at the latest,<br>
>> the offset is zero.<br>
<br>
> OK. Fix thunkEntry to put back the offset and then I can merge the pull<br>
> request.<br>
<br>
riscv64abicc.c as pull request should have<br>
...<br>
   vmcc.thunkp = thunkp;<br>
...<br>
which works fine without override of Callback>>addToThunkTable.  No <br>
offset required in either place.<br>
<br>
So color me confused.<br>
<br>
I can re-push the Alien-Core-Kend without the #addToThunkTable override <br>
if you like, but the current pull requiest should work with <br>
Alien-Core-Kend.124 as is.<br>
<br>
How about accepting the pull and the Alien-Code, let me re-retest, and <br>
we will fix any breakage from there.<br>
<br>
Epsilon close,<br>
-KenD<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#issuecomment-1205692365">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AIJPEW5YKLSZS6T2MYGYCTTVXQL63ANCNFSM55M27RQQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AIJPEW6REZQUZZFCMCYXTOLVXQL63A5CNFSM55M27RQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI7OWPTI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><OpenSmalltalk/opensmalltalk-vm/pull/648/c1205692365</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#issuecomment-1205692365",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648#issuecomment-1205692365",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>