Cryptography

cryptography@lists.squeakfoundation.org

364 discussions

Issues: Trying to build the RS vm with the mvm script...
by Robert Withers 27 May '21

27 May '21

I am trying to build the vm with RS external plugins I generated. I am getting some pushback: > rabbit@ganymede:~/vm-dev/opensmalltalk-vm/build.linux64x64/squeak.cog.spur/build$ ./mvm > clean? y > checking for gcc... clang > checking whether the C compiler works... no > configure: error: in `/home/rabbit/vm-dev/opensmalltalk-vm/build.linux64x64/squeak.cog.spur/build': > configure: error: C compiler cannot create executables > See `config.log' for more details How could I resolve this issue? I have the latest gcc, I think: > rabbit@ganymede:~/vm-dev/opensmalltalk-vm/build.linux64x64/squeak.cog.spur/build$ gcc --version > gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 I appreciate! -- --- Kindly, Robert

1 0

Implementing Reed Solomon plugins
by Robert Withers 27 May '21

27 May '21

I have the outlined definitions of 2 Plugins, 1 for RSErasurePlugin and 1 for RSFECPlugin. They are published to Cryptography. I am trying to understand how to write primitives to get the work done. Any and All assistance MOST WELCOME! Let's get her done! I believe I have properly implemented the #declareCVarsIn: and initialized for both plugins. I am looking at a primitive implementation in RSFECPlugin>>#primitiveInverseWithSize. A few questions: am I grabbing the stack arguments correctly? Testing their values correctly? Correctly calling a method to do the work. Manipulating the stack to setup a return value??? I am doing this...correct? > self pop: 2 thenPushInteger: multiplied. > ^interpreterProxy methodReturnInteger: multiplied. --- > primitiveInverseWithSize > <export: true> > <var: 'a' declareC: 'unsigned short' > > <var: 'size' declareC: 'unsigned short' > > > | a size multiplied | > interpreterProxy methodArgumentCount = 2 > ifFalse: [ ^interpreterProxy primitiveFailFor: PrimErrBadNumArgs ]. > a := interpreterProxy stackIntegerValue: 0. > size := interpreterProxy stackIntegerValue: 1. > > ((interpreterProxy isBytes: a) > and: [ (interpreterProxy stSizeOf: a) = 2 ]) > ifFalse: [ ^interpreterProxy primitiveFailFor: PrimErrBadArgument ]. > ((interpreterProxy isBytes: size) > and: [ (interpreterProxy stSizeOf: a) = 2 ]) > ifFalse: [ ^interpreterProxy primitiveFailFor: PrimErrBadArgument ]. > multiplied := self inverse: a withSize: size. > self pop: 2 thenPushInteger: multiplied. > ^interpreterProxy methodReturnInteger: multiplied. And: > inverse: a withSize: size > > (a = 0) > ifTrue: [RSErasureIllegalArgumentError signal: 'the argument is zero']. > ^ expTable at: (size - ((logTable at: (a + 1)) - 1)). -- --- Kindly, Robert

1 0

Reed Solomon Erasure Coding and Error Correction
by Robert Withers 26 May '21

26 May '21

Hey everyone, I hope you all are well, having the time of your lives! Would anyone wish to help me develop plugins to speedup ReedSolomon? I am feeling the dopamine high from finally finishing (mostly) my Reed Solomon implementation, both Erasure Coding from Backblaze [1] and Error Correction from ZXing [2]. I got decoding working correctly, with dataMatrix256 and QRCode, including corruption repair, within t/2 errors. It is VERY SLOOOW, way to slow to use yet. I am working on writing plugins for the hot spots, which are on the decode side: GFPoly evaluateAt (40.1%), Decoder runEuclideanAlgorithm(38.5%), Decoder findErrorLocations(12.6%) and Decoder find ErrorMagnitudes(2.3%). At the bottom, an exposition of performance profiling the GF FEC code. It is written in Squeak, my favorite all-time language environment. I have used it for over 20 years. It is so beautiful! The rule of development is #GetItWorking, #GetItWorkingRight #GetItWorkingFast. If you are interested in checking out the code, go to http://squeak.org and grab squeak. Once you have it running, right click for the World Menu and select open...Monticello Browser. Add a new repository of type HTTP and enter the Cryptography repository. MCHttpRepository location: ' https://www.squeaksource.com/Cryptography ' user: 'squeak' password: 'squeak' Open a Workspace (World Menu -> Workspace) & run this code (paste into Workspace, select it and right click do it.): Installer ss project: 'Cryptography'; install: 'ProCrypto-1-1-1'; install: 'ProCryptoTests-1-1-1'. Now you can open a Browser to look at the code (categories: CryptographyRSFEC & CryptographyRSFECTests) or open a TestRunner to test it (World Menu -> *). [1] Backblze RS erasure code - https://stackoverflow.com/posts/67696209/timeline I am feeling the dopamine high from finally finishing (mostly) my Reed Solomon implementation. I got decoding working correctly, with dataMatrix256 and QRCode, including corruption repair, within t/2 errors. It is VERY SLOOOW, way to slow to use yet. There are speedups possible in writing a plugin for the hot spots, which are on the decode side: GFPoly evaluateAt (40.1%), Decoder runEuclideanAlgorithm(38.5%), Decoder findErrorLocations(12.6%) and Decoder find ErrorMagnitudes(2.3%). It is written in Squeak, my favorite all-time language environment. I have used it for over 20 years. It is so beautiful! The rule of development is #GetItWorking, #GetItWorkingRight #GetItWorkingFast. If you are interested in checking out the code, go to http://squeak.org and grab squeak. Once you have it running, right click for the World Menu and select open...Monticello Browser. Add a new repository of type HTTP and enter the Cryptography repository. MCHttpRepository location: ' https://www.squeaksource.com/Cryptography ' user: 'squeak' password: 'squeak' Open a Workspace (World Menu -> Workspace) & run this code (paste into Workspace, select it and right click do it.): Installer ss project: 'Cryptography'; install: 'ProCrypto-1-1-1'; install: 'ProCryptoTests-1-1-1'. Now you can open a Browser to look at the code (categories: CryptographyRSFEC & CryptographyRSFECTests) or open a TestRunner to test it (World Menu -> *). [1] Backblaze Open-sources Reed-Solomon Erasure Coding Source Code - https://www.backblaze.com/blog/reed-solomon/ [2] ZXing github -https://github.com/zxing/zxing/tree/master/core/src/main/java/com/google/zxing/common/reedsolomon --- From the comment on CryptographyRSErrorCorrection-rww.12.mcz... Fixed decoding. Some test pass green (DataMatrix & QRCodes) with encoding, decoding AND error correction all working. So the algorithms are working correctly. #GetItWorking, #GetItWorkingRight #GetItWorkingFast. AztecParam GF is still failing. Do not allow values equal to the max 256. it passes tests but it is VERY SLOOOW. Profilie looks like, top tree branches, then summary. I may need to pluginize both GF and GFPoly. The costly methods are in decode, with GF Polynomial evaluation, the Euclidean Algorithm, the Chein's search (#findErrorLocations) and the Forney's formula (#findErrorMagnitudes). In the leaves, I can see that OrderedColection access is expensive. Top tree branches: [| 93.7% {136540ms} RSFECDecoder>>decode:twoS: [| 40.1% {58370ms} RSFECGenericGFPoly>>evaluateAt: [| 38.5% {56167ms} RSFECDecoder>>runEuclideanAlgorithmPoly:poly:rDegrees: [| 12.6% {18331ms} RSFECDecoder>>findErrorLocations: [| 2.3% {3423ms} RSFECDecoder>>findErrorMagnitudes:errorLlocations: [ 5.4% {7842ms} RSFECReedSolomonTest>>corrupt:howMany:random:max: **Leaves** 44.7% {65149ms} OrderedCollection>>at: 12.8% {18619ms} SmallInteger(Number)>>positive 8.0% {11589ms} RSFECGenericGF>>addOrSubtract:by: 5.7% {8332ms} RSFECGenericGF>>multiply:by: 5.0% {7352ms} RSFECGenericGFPoly>>evaluateAt: 5.0% {7270ms} OrderedCollection>>at:put: 4.6% {6727ms} False>>| 1.7% {2537ms} RSFECGenericGFPoly>>addOrSubtractPoly: 1.4% {1996ms} OrderedCollection(SequenceableCollection)>>replaceFrom:to:with:startingAt: 1.3% {1851ms} RSFECGenericGFPoly>>multiplyByMonomialDegree:coefficient: 1.1% {1562ms} LargePositiveInteger(Integer)>>bitShift: **Memory** old -16,777,216 bytes young +15,072,816 bytes used -1,704,400 bytes free -15,072,816 bytes **GCs** full 2 totalling 171 ms (0.12% uptime), avg 85.5 ms incr 4193 totalling 764 ms (0.5% uptime), avg 0.2 ms tenures 6,093 (avg 0 GCs/tenure) root table 0 overflows -- Kindly, Robert

1 3

KeyHolder!
by Chris Muller 20 Sep '20

20 Sep '20

Hi Ron, I just love this KeyHolder thingy! :) Such a clever idea to resist a side-channel attack. I'm curious how you came across the idea.. I did commit some improvements (see below), which I've tested, and plan to use in projects going forward. As always, review and feedback is welcome from anyone and everyone. Regards, Chris ________________________ Name: CryptographyCiphers-cmm.23 Author: cmm Time: 15 September 2020, 5:52:41.154778 pm UUID: 6ba3b5f5-47e3-48f7-a871-89a4cc4c0774 Ancestors: CryptographyCiphers-tpr.22 Improvements to KeyHolder: - It can now hold an Integer or ByteArray key. - Replaced use of KeyHolderData with a simple Array. KeyHolderData removed. - Destroys itself upon image save, to ensure not to save its contents in the image. - More secure, now uses Rijndael (AES) instead of TripleDES. - More secure, now destroys the prior encrypted key instead of waiting for GC. - Now relies on a Mutex for process syncronization rather than trapping Error and retrying. - Guards against invalid key access after it was destroyed. - Better printOn: reveals its status. - About 7X faster.

2 1

configurable random number generator
by Chris Muller 23 Aug '20

23 Aug '20

Hi all, I would like to make Fortuna the default secure random number generator in Squeak. I like using it because its implementation is so simple and utilizes another crypto primitive which I trust, a 256-bit AES cipher in counter (CTR) mode to generate the random stream. If it interests you, please take a look at CryptographyRandom-cmm.14.mcz, and let me know your thoughts. I'll plan on committing the remaining senders in a few days. - Chris _________________________________ Name: CryptographyRandom-cmm.14 Author: cmm Time: 20 August 2020, 11:45:55.957918 pm UUID: 8fa45a8b-cbb5-43be-8367-adcf78503be2 Ancestors: CryptographyRandom-ul.13 - Introduce RandomGenerator class>>#newSecureRandom to allow configuration of a preferred secure random number generator. To set this to SecureRandom, execute: RandomGenerator picker: SecureRandom withGeneratedKey otherwise, it will default to the Fortuna generator. Fortuna relies on 128-bit AES for its security, reducing security-sapping complexity. - Re-bolster #unpredictableStringsDo:. Chasing Pharo compatibility resulted in a too-significant cut to its security, with only time elements in there (which appear relatively easily brute-forcable). It utilizes the new primitive Random gatherEntropyInto: in combination with some of its original sources, in case the primitive fails or is compromised.

2 3

using Squeak RSA on ssh keys
by Chris Muller 23 Aug '20

23 Aug '20

Has anyone done it? Thanks.

2 1

Re: [Cryptography Team] [Vm-dev] Smalltalk code calling SHA2Plugin
by Robert Withers 02 Aug '20

02 Aug '20

Hi Levente, I must admit, after reflection, that I LIKE that SHA256 new may return a different class. Essentially, the #new method of SHA256, in this scenario, will be the factory method, instad of HshFunction newSHA256. This factory method may return a pluginized SHA256 concrete subclass or itself as default. The reason I like this is that we would reference the "abstract" class specific to the hash algorithm as SHA256, exactly the same lexeme. In our current case, the SHA256 is also a concrete class, the default when no plugins around. If this duality of SHA256 being both abstract and concrete, is an issue, we could copy SHA256 to SHA256InImage and then have a proper strict abstract class. This is my feeling that opposite of creating confusion it specifies the Lexeme of this hashFunction and so clarifies. Newbie: "How do I use SHA256?" Wise Council: "Code it as SHA256 new. Then send hashStream: to it.". Jester: "Watch out it is tricky picky. It may return an instance of a DIFFERENT concrete class....correctly so. my 2 pennies, Kindly, rabbit On 7/21/20 9:56 PM, Levente Uzonyi wrote: > Hi Robert, > > On Tue, 21 Jul 2020, Robert wrote: > >> Hub Levente, >> >> I like the idea of SHA256 and friends to throw an exception when #new is called directly >> SHA256 new. >> With a message to call newSHA256. >> >> What do you think? > > I think #new should return an instance of the receiver. That's what > everyone expects when #new is sent to a class, isn't it? > And if #new raised an error, what would #newSHA256 send to create an > instance? #basicNew + #initialize? I don't like that. > > Levente > >> Kindly, >> Robert >> >> On Tue, Jul 21, 2020 at 14:02, Levente Uzonyi >> [<leves(a)caesar.elte.hu>](mailto:leves@caesar.elte.hu) >> wrote: >> Hi Chris, >> >> On Mon, 20 Jul 2020, Chris Muller wrote: >> >> > Hi Levente, >> > >> > > > HashFunction newSHA256 >> > > > >> > > > instead of >> > > > >> > > > SHA256 new >> > > > >> > > > in order to take advantage of Levente's plugin. >> > > >> > > That is indeed some sort of a change but it only affects those who >> > > compiled the SHA256Plugin themselves since that plugin wasn't shipped with >> > > the VM. >> > >> > Ah, you're speaking about legacy code. I really hope we can include your plugin in future VM's. Are Eliot, et al, on board? >> >> The most recent VMs ship with the plugins. >> >> > > I decided against the practice of making #new return an instance of >> > > another class than the receiver, as it was with the previous >> > > implementation, because that makes it a lot harder for others to >> > > understand the code. >> > >> > Hm. I sort of agree, although I guess Factory is a recognized pattern. To me, the issue is that writing >> > >> > "SHA256 new" >> > >> > , is a perfectly intuitive and obvious way to use it, but sticking out like a sore thumb as a subversively-wrong-way to-use-it. It'd be better if it threw an error, and even better than that if it just worked. >> > >> > I know you care about the quantity of methods in the image (as do I), how about quality? Can SHA256 #new be improved by doing essentially what HashFunction #newSHA256 does, and simply sending some alternative >> to new (i.e., >> >> It's not clear what do you mean by caring about the quantity of methods. >> >> > basicNew initialize) to avoid the recursion? >> >> That would do exactly what I do not want to do: #new would return an >> object whose class is not SHA256. >> >> > >> > Above, you mentioned you decided against the practice, does that mean you're writing: >> > >> > SHA256 newSHA256 >> > >> > ? If not, how did you do it? >> >> Use HashFunction's class side #new* methods to create the instances. >> HashFunction is a facade and a factory at the same time. >> I originally wanted to create a separate class for this role named Hasher, >> but HashFunction seemed to work just as well. >> >> Levente >> >> > >> > Thanks again for this great work. >> > >> > - Chris >> > >> > >> > On Sun, Jul 19, 2020 at 9:55 PM Levente Uzonyi >> [<leves(a)caesar.elte.hu>](mailto:leves@caesar.elte.hu) >> wrote: >> > Hi Chris, >> > >> > On Sun, 19 Jul 2020, Chris Muller wrote: >> > >> > > Hi Robert and Levente, >> > > >> > > Yes, I *think* so! I'm just now getting up to speed after reading >> > > that epic thread between you and Levente (subject line: "SHA512 squeak >> > > implementation"). Thanks a ton to both of you, BTW, for this work! >> > > >> > > After loading >> > > >> > > ProCrypto-1-1-1 >> > > and ProCryptoTests-1-1-1, >> > > >> > > all 205 tests are passing, however, it took me a bit to realize I need to use >> > > >> > > HashFunction newSHA256 >> > > >> > > instead of >> > > >> > > SHA256 new >> > > >> > > in order to take advantage of Levente's plugin. This is great, thanks again! >> > >> > That is indeed some sort of a change but it only affects those who >> > compiled the SHA256Plugin themselves since that plugin wasn't shipped with >> > the VM. >> > I decided against the practice of making #new return an instance of >> > another class than the receiver, as it was with the previous >> > implementation, because that makes it a lot harder for others to >> > understand the code. >> > >> > > >> > > Quick side question: Is it okay to reuse a SHA256 instance, or should >> > > I just create a new one for each and every message to hash? >> > >> > All subinstances of HashFunction are reusable. The tests >> > (see HashFunctionTest) do exactly that. >> > >> > >> > Levente >> > >> > > >> > > Best, >> > > Chris >> > > >> > > >> > > On Sat, Jul 18, 2020 at 6:02 AM Robert Withers >> [<robert.withers(a)pm.me>](mailto:robert.withers@pm.me) >> wrote: >> > >> >> > >> Hey Chris, >> > >> >> > >> Did this approach fix your issues? >> > >> >> > >> Kindly, >> > >> rabbit >> > >> >> > >> On 7/13/20 11:46 PM, Robert wrote: >> > >> >> > >> Hi Chris, >> > >> >> > >> You should only need to run #3, which will load Registers. Hasher was from before we integrated the code into ProCrypto-1-1-1. >> > >> >> > >> Installer as project: ‘Cryptography’; install: ‘ProCrypto-1-1-1’. >> > >> >> > >> Then to load tests run: >> > >> >> > >> Installer as project: ‘Cryptography’; install: ‘ProCryptoTests-1-1-1’. >> > >> >> > >> Let us know if any tests fail and we can look into it. >> > >> >> > >> Kindly, >> > >> Robert >> > >> >> > >> >> > >> On Mon, Jul 13, 2020 at 19:52, Chris Muller >> [<asqueaker(a)gmail.com>](mailto:asqueaker@gmail.com) >> wrote: >> > >> >> > >> Hi Robert, hi Levente, >> > >> >> > >> I would like to utilize the latest crypto in my next project, would >> > >> you help me with the current proper way to configure my image, and my >> > >> vm with plugins? >> > >> >> > >> (image) >> > >> In going back through some recent messages on the mailing lists and >> > >> instructions on squeaksource.com, I came across these incantations as >> > >> current ways to load the image code: >> > >> >> > >> 1) Installer ss >> > >> project: 'Registers'; >> > >> install: 'Registers'; >> > >> project: 'Hasher'; >> > >> install: 'HAHasher-Core'; >> > >> install: 'HAHasher-Tests'. >> > >> >> > >> 2) Installer ss >> > >> project: 'Registers'; >> > >> install: 'Registers'; >> > >> project: 'Hasher'; >> > >> install: 'HAHasher'. >> > >> >> > >> 3) Installer ss project: 'Cryptography'; install: 'ProCrypto-1-1-1'. >> > >> >> > >> I like these one-click-for-everything scripts for crypto -- it >> > >> satisfies the good use-case of development and education, and also >> > >> knowing all what's available to Squeak in one glance. My app's build >> > >> script can cherry pick what it needs, but any advice on which starting >> > >> point above or otherwise is appreciated. >> > >> >> > >> (vm) >> > >> I put the SHA2Plugin.so from Roberts dropbox in the lib directory, >> > >> and it shows up as a "Loaded VM Module" in About Squeak. But, three >> > >> of the "WithPluginTest"'s are failing. My OS is linux_x64. I don't >> > >> know how to build Squeak or plugins from sources, but including it in >> > >> the standard precompiled vm would be so pertinent for Squeak today, >> > >> IMO. SHA256 is one of the ones I'm going to need, so would be nice to >> > >> have it work via plugin. I assume it's a lot faster? >> > >> >> > >> Thanks, >> > >> Chris >> > >> >> > >> On Tue, Mar 10, 2020 at 3:52 PM Levente Uzonyi >> [<leves(a)caesar.elte.hu>](mailto:leves@caesar.elte.hu) >> wrote: >> > >>> >> > >>> >> > >>> Hi Robert, >> > >>> >> > >>> With yesterday's help from Eliot and Nicolas, the SHA2Plugin is ready: >> > >>> >> http://squeaksource.com/Cryptography/CryptographyPlugins-ul.19.mcz >>> >>> The updated version of the image-side code is available in the Hasher >> > >>> repository. You can install it with: >> > >>> >> > >>> Installer ss >> > >>> project: 'Registers'; >> > >>> install: 'Registers'; >> > >>> project: 'Hasher'; >> > >>> install: 'HAHasher-Core'; >> > >>> install: 'HAHasher-Tests'. >> > >>> >> > >>> >> > >>> Levente >> > >>> >> > >>> >> > >>> On Tue, 10 Mar 2020, Levente Uzonyi wrote: >> > >>> >> > >>>> >> > >>>> Hi Robert, >> > >>>> >> > >>>> Please have a look at: >> > >>>> >> http://lists.squeakfoundation.org/pipermail/squeak-dev/2020-March/207851.ht… >>> >>>> It answers all your questions. >> > >>>> >> > >>>> >> > >>>> Levente >> > >>>> >> > >>>> On Tue, 10 Mar 2020, Robert wrote: >> > >>>> >> > >>>>> Hi Levente, >> > >>>>> >> > >>>>> I got the SHA2Plugin built and deployed to my Crypto plugins folder. Now I >> > >>>> am trying to figure out how to call it from SHA512. >> > >>>>> >> > >>>>> >> https://www.dropbox.com/sh/yhv253rwrhq0q5p/AAB7PKP2KPiGpDnIyule2h_Ia?dl=0 >>> >>>>> >> > >>>>> [plugin] I looked at it and please understand I think the classes you wrote >> > >>>> and the framework is really quite nice. I am thrilled we found SHA512! It's >> > >>>> impressive that your one plugin can handle a number of hash functions! >> > >>>>> Now all I need is to find the code that calls the SHA2Plugin. Levente, >> > >>>> would you share that code, please? >> > >>>>> >> > >>>>> Kindly, >> > >>>>> Robert >> > >>>>> >> > >>>>> >> > >>>> >> > >> >> > >> >> > >> >> > > >> > >> > >> >

3 3

Re: [Cryptography Team] [Vm-dev] Smalltalk code calling SHA2Plugin
by Chris Muller 22 Jul '20

22 Jul '20

> > What you referred to as "bloat" in the discussion about loading all crypto primitives or not. After Robert had mentioned the size in K bytes, you'd mentioned you cared about the number of methods in classes, not so much > > Can you point me to that discussion? It's the thread I mentioned in the top of this thread (subject line: "SHA512 squeak implementation"). Sorry I wasn't able to get you the direct link (why do we care about this?) because the site at http://lists.squeakfoundation.org/mailman/listinfo is down. If you have your own mail archive, the unique sentence string you can search for within that thread is, "By bloat I didn't mean that the size of the package is too large." > > their size in bytes. To which I agree, although I think you take it a lot further than me (i.e., Time microsecondClockValue). > > > > > basicNew initialize) to avoid the recursion? > > > > That would do exactly what I do not want to do: #new would return an > > object whose class is not SHA256. > > > > > > Okay, now I understand. This gets back to one of our core differences in philosophy -- your greater concern over types vs. mine over API's. You're okay with it for Strings (ByteString vs. WideString) and Numbers > > (LargePositive.., LargeNegative..., etc.), and probably a few others. But not SHA256. IMO, letting different implementations with the same API be interchangeable is what leverages Smalltalk's late-binding power. > > Um, I don't remember ever saying I'm okay with anything like that. Can > you give me a pointer where and when I did? Well, I was just referring to things like I assume you've used String streamContents: [ ...]. But, yes, it's an abstract class, so that's different. > The ByteString/WideString split was done before my time, but I'm sure the > goal there was backwards compatibility. The comparison with SHA256 is not > quite correct, because SHA256 is not an abstact class while String is. > > About "Numbers (LargePositive.., LargeNegative..., etc.)", you never send > #new to any of those. You sometimes send #new: to LargePositiveInteger or > LargeNegativeInteger, but those are not abstract, and you want an > instance of the class you sent #new: to. So, in that case #new: works as > it should. You're right. It was just a question whether you thought the API should guide or enforce the client into proper usage. I got a little zealous after seeing your plugin work. The current factory we have is fine. - Chris

1 0

Re: [Cryptography Team] [Vm-dev] Smalltalk code calling SHA2Plugin
by Chris Muller 22 Jul '20

22 Jul '20

Hi, The most recent VMs ship with the plugins. > I didn't know, that's good news! > > > I decided against the practice of making #new return an instance of > > > another class than the receiver, as it was with the previous > > > implementation, because that makes it a lot harder for others to > > > understand the code. > > > > Hm. I sort of agree, although I guess Factory is a recognized pattern. > To me, the issue is that writing > > > > "SHA256 new" > > > > , is a perfectly intuitive and obvious way to use it, but sticking out > like a sore thumb as a subversively-wrong-way to-use-it. It'd be better if > it threw an error, and even better than that if it just worked. > > > I know you care about the quantity of methods in the image (as do I), > how about quality? Can SHA256 #new be improved by doing essentially what > HashFunction #newSHA256 does, and simply sending some alternative to new > (i.e., > > It's not clear what do you mean by caring about the quantity of methods. > What you referred to as "bloat" in the discussion about loading all crypto primitives or not. After Robert had mentioned the size in K bytes, you'd mentioned you cared about the number of methods in classes, not so much their size in bytes. To which I agree, although I think you take it a lot further than me (i.e., Time microsecondClockValue). > basicNew initialize) to avoid the recursion? > > That would do exactly what I do not want to do: #new would return an > object whose class is not SHA256. > Okay, now I understand. This gets back to one of our core differences in philosophy -- your greater concern over *types* vs. mine over *API's*. You're okay with it for Strings (ByteString vs. WideString) and Numbers (LargePositive.., LargeNegative..., etc.), and probably a few others. But not SHA256. IMO, letting different implementations with the same API be interchangeable is what leverages Smalltalk's late-binding power. - Chris

1 0

Re: [Cryptography Team] [Vm-dev] Smalltalk code calling SHA2Plugin
by Robert 21 Jul '20

21 Jul '20

Hub Levente, I like the idea of SHA256 and friends to throw an exception when #new is called directly SHA256 new. With a message to call newSHA256. What do you think? Kindly, Robert On Tue, Jul 21, 2020 at 14:02, Levente Uzonyi <leves(a)caesar.elte.hu> wrote: > Hi Chris, > > On Mon, 20 Jul 2020, Chris Muller wrote: > >> Hi Levente, >> >> > > HashFunction newSHA256 >> > > >> > > instead of >> > > >> > > SHA256 new >> > > >> > > in order to take advantage of Levente's plugin. >> > >> > That is indeed some sort of a change but it only affects those who >> > compiled the SHA256Plugin themselves since that plugin wasn't shipped with >> > the VM. >> >> Ah, you're speaking about legacy code. I really hope we can include your plugin in future VM's. Are Eliot, et al, on board? > > The most recent VMs ship with the plugins. > >> > I decided against the practice of making #new return an instance of >> > another class than the receiver, as it was with the previous >> > implementation, because that makes it a lot harder for others to >> > understand the code. >> >> Hm. I sort of agree, although I guess Factory is a recognized pattern. To me, the issue is that writing >> >> "SHA256 new" >> >> , is a perfectly intuitive and obvious way to use it, but sticking out like a sore thumb as a subversively-wrong-way to-use-it. It'd be better if it threw an error, and even better than that if it just worked. >> >> I know you care about the quantity of methods in the image (as do I), how about quality? Can SHA256 #new be improved by doing essentially what HashFunction #newSHA256 does, and simply sending some alternative to new (i.e., > > It's not clear what do you mean by caring about the quantity of methods. > >> basicNew initialize) to avoid the recursion? > > That would do exactly what I do not want to do: #new would return an > object whose class is not SHA256. > >> >> Above, you mentioned you decided against the practice, does that mean you're writing: >> >> SHA256 newSHA256 >> >> ? If not, how did you do it? > > Use HashFunction's class side #new* methods to create the instances. > HashFunction is a facade and a factory at the same time. > I originally wanted to create a separate class for this role named Hasher, > but HashFunction seemed to work just as well. > > Levente > >> >> Thanks again for this great work. >> >> - Chris >> >> >> On Sun, Jul 19, 2020 at 9:55 PM Levente Uzonyi <leves(a)caesar.elte.hu> wrote: >> Hi Chris, >> >> On Sun, 19 Jul 2020, Chris Muller wrote: >> >> > Hi Robert and Levente, >> > >> > Yes, I *think* so! I'm just now getting up to speed after reading >> > that epic thread between you and Levente (subject line: "SHA512 squeak >> > implementation"). Thanks a ton to both of you, BTW, for this work! >> > >> > After loading >> > >> > ProCrypto-1-1-1 >> > and ProCryptoTests-1-1-1, >> > >> > all 205 tests are passing, however, it took me a bit to realize I need to use >> > >> > HashFunction newSHA256 >> > >> > instead of >> > >> > SHA256 new >> > >> > in order to take advantage of Levente's plugin. This is great, thanks again! >> >> That is indeed some sort of a change but it only affects those who >> compiled the SHA256Plugin themselves since that plugin wasn't shipped with >> the VM. >> I decided against the practice of making #new return an instance of >> another class than the receiver, as it was with the previous >> implementation, because that makes it a lot harder for others to >> understand the code. >> >> > >> > Quick side question: Is it okay to reuse a SHA256 instance, or should >> > I just create a new one for each and every message to hash? >> >> All subinstances of HashFunction are reusable. The tests >> (see HashFunctionTest) do exactly that. >> >> >> Levente >> >> > >> > Best, >> > Chris >> > >> > >> > On Sat, Jul 18, 2020 at 6:02 AM Robert Withers <robert.withers(a)pm.me> wrote: >> >> >> >> Hey Chris, >> >> >> >> Did this approach fix your issues? >> >> >> >> Kindly, >> >> rabbit >> >> >> >> On 7/13/20 11:46 PM, Robert wrote: >> >> >> >> Hi Chris, >> >> >> >> You should only need to run #3, which will load Registers. Hasher was from before we integrated the code into ProCrypto-1-1-1. >> >> >> >> Installer as project: ‘Cryptography’; install: ‘ProCrypto-1-1-1’. >> >> >> >> Then to load tests run: >> >> >> >> Installer as project: ‘Cryptography’; install: ‘ProCryptoTests-1-1-1’. >> >> >> >> Let us know if any tests fail and we can look into it. >> >> >> >> Kindly, >> >> Robert >> >> >> >> >> >> On Mon, Jul 13, 2020 at 19:52, Chris Muller <asqueaker(a)gmail.com> wrote: >> >> >> >> Hi Robert, hi Levente, >> >> >> >> I would like to utilize the latest crypto in my next project, would >> >> you help me with the current proper way to configure my image, and my >> >> vm with plugins? >> >> >> >> (image) >> >> In going back through some recent messages on the mailing lists and >> >> instructions on squeaksource.com, I came across these incantations as >> >> current ways to load the image code: >> >> >> >> 1) Installer ss >> >> project: 'Registers'; >> >> install: 'Registers'; >> >> project: 'Hasher'; >> >> install: 'HAHasher-Core'; >> >> install: 'HAHasher-Tests'. >> >> >> >> 2) Installer ss >> >> project: 'Registers'; >> >> install: 'Registers'; >> >> project: 'Hasher'; >> >> install: 'HAHasher'. >> >> >> >> 3) Installer ss project: 'Cryptography'; install: 'ProCrypto-1-1-1'. >> >> >> >> I like these one-click-for-everything scripts for crypto -- it >> >> satisfies the good use-case of development and education, and also >> >> knowing all what's available to Squeak in one glance. My app's build >> >> script can cherry pick what it needs, but any advice on which starting >> >> point above or otherwise is appreciated. >> >> >> >> (vm) >> >> I put the SHA2Plugin.so from Roberts dropbox in the lib directory, >> >> and it shows up as a "Loaded VM Module" in About Squeak. But, three >> >> of the "WithPluginTest"'s are failing. My OS is linux_x64. I don't >> >> know how to build Squeak or plugins from sources, but including it in >> >> the standard precompiled vm would be so pertinent for Squeak today, >> >> IMO. SHA256 is one of the ones I'm going to need, so would be nice to >> >> have it work via plugin. I assume it's a lot faster? >> >> >> >> Thanks, >> >> Chris >> >> >> >> On Tue, Mar 10, 2020 at 3:52 PM Levente Uzonyi <leves(a)caesar.elte.hu> wrote: >> >>> >> >>> >> >>> Hi Robert, >> >>> >> >>> With yesterday's help from Eliot and Nicolas, the SHA2Plugin is ready: >> >>> http://squeaksource.com/Cryptography/CryptographyPlugins-ul.19.mcz >> >>> The updated version of the image-side code is available in the Hasher >> >>> repository. You can install it with: >> >>> >> >>> Installer ss >> >>> project: 'Registers'; >> >>> install: 'Registers'; >> >>> project: 'Hasher'; >> >>> install: 'HAHasher-Core'; >> >>> install: 'HAHasher-Tests'. >> >>> >> >>> >> >>> Levente >> >>> >> >>> >> >>> On Tue, 10 Mar 2020, Levente Uzonyi wrote: >> >>> >> >>>> >> >>>> Hi Robert, >> >>>> >> >>>> Please have a look at: >> >>>> http://lists.squeakfoundation.org/pipermail/squeak-dev/2020-March/207851.ht… >> >>>> It answers all your questions. >> >>>> >> >>>> >> >>>> Levente >> >>>> >> >>>> On Tue, 10 Mar 2020, Robert wrote: >> >>>> >> >>>>> Hi Levente, >> >>>>> >> >>>>> I got the SHA2Plugin built and deployed to my Crypto plugins folder. Now I >> >>>> am trying to figure out how to call it from SHA512. >> >>>>> >> >>>>> https://www.dropbox.com/sh/yhv253rwrhq0q5p/AAB7PKP2KPiGpDnIyule2h_Ia?dl=0 >> >>>>> >> >>>>> [plugin] I looked at it and please understand I think the classes you wrote >> >>>> and the framework is really quite nice. I am thrilled we found SHA512! It's >> >>>> impressive that your one plugin can handle a number of hash functions! >> >>>>> Now all I need is to find the code that calls the SHA2Plugin. Levente, >> >>>> would you share that code, please? >> >>>>> >> >>>>> Kindly, >> >>>>> Robert >> >>>>> >> >>>>> >> >>>> >> >> >> >> >> >> >> > >> >> >>

2 1

← Newer
1
2
3
4
5
6
7
8
9
...
37
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Cryptography