No, #methodReference is not slow. But the PackageOrganizer is really expensive. I simply added the following line to #translated

PackageOrganizer default packageOfMethod: thisContext sender method methodReference.

and opening the World menu took a few seconds (opening a viewer is imposible).

Richo

On Tue, May 4, 2010 at 3:21 PM, Bert Freudenberg <bert@freudenbergs.de> wrote:
On 04.05.2010, at 10:48, Ricardo Moran wrote:
Oh, yes that's right. In #translated we should do something like this, right?

thisContext sender method methodReference

Yes. Maybe it is not so expensive nowadays. But look at the #methodReference method, it uses #who, which used to iterate over all classes to find the method ... But it seems Eliot's changes do already cache the class as well as the method selector. 

Also, performance testing should be done on the XO-1 which is the slowest machine we need to support.

- Bert -


On Tue, May 4, 2010 at 2:41 PM, Bert Freudenberg <bert@freudenbergs.de> wrote:
On 04.05.2010, at 10:39, Ricardo Moran wrote:


On Tue, May 4, 2010 at 2:26 PM, Hilaire Fernandes <hilaire.fernandes@edu.ge.ch> wrote:
Is it really expensive ? I can't evaluate.


PackageOrganizer default packageOfMethod: aMethodReference

It took in my machine 25 milliseconds average (tested with all the methods with phrases to translate). 

But in #translated you do not have the method reference yet.

- Bert -


_______________________________________________
etoys-dev mailing list
etoys-dev@squeakland.org
http://lists.squeakland.org/mailman/listinfo/etoys-dev






_______________________________________________
etoys-dev mailing list
etoys-dev@squeakland.org
http://lists.squeakland.org/mailman/listinfo/etoys-dev