Nicolas Cellier uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-nice.532.mcz
==================== Summary ====================
Name: Kernel-nice.532
Author: nice
Time: 29 December 2010, 10:59:42.464 am
UUID: 30e481ee-c2ee-4d10-8484-ec8da55ae54a
Ancestors: Kernel-ar.531
A] Clean-up Behavior and Metaclass copy by using postCopy paradigm.
Advantage 1:
This cleans up the false comment of Behavior>>copy (no, it does not copy without a list of subclasses).
This cleans up the false comment of Metaclass>>copy (no, it does share the reference to the sole instance).
Advantage 2:
The new code is shorter, simpler and avoids niling thisClass temporarily (this was dangerous).
B] Fix Class>>copy : the sharedPool shall not be shared
(if you #addSharedPool: to the copy and the original already has a sharedPool, then you #addSharedPool: to the original too...).
Move the comments "Answer a copy of the receiver without a list of subclasses." where it belongs, in Class>>copy.
=============== Diff against Kernel-ar.531 ===============
Item was removed:
- ----- Method: Behavior>>copy (in category 'copying') -----
- copy
- "Answer a copy of the receiver without a list of subclasses."
-
- | myCopy |
- myCopy := self shallowCopy.
- ^myCopy methodDictionary: self copyOfMethodDictionary!
Item was added:
+ ----- Method: Behavior>>postCopy (in category 'copying') -----
+ postCopy
+ super postCopy.
+ self methodDict: self methodDict copy!
Item was changed:
----- Method: Class>>copy (in category 'copying') -----
copy
+ "Answer a copy of the receiver without a list of subclasses."
| newClass |
newClass := self class copy new
superclass: superclass
methodDict: self methodDict copy
format: format
name: name
organization: self organization copy
instVarNames: instanceVariables copy
classPool: classPool copy
+ sharedPools: sharedPools copy.
- sharedPools: sharedPools.
Class instSize+1 to: self class instSize do:
[:offset | newClass instVarAt: offset put: (self instVarAt: offset)].
^ newClass!
Item was removed:
- ----- Method: Metaclass>>copy (in category 'copying') -----
- copy
- "Make a copy of the receiver without a list of subclasses. Share the
- reference to the sole instance."
-
- | copy t |
- t := thisClass.
- thisClass := nil.
- copy := super copy.
- thisClass := t.
- ^copy!
Item was added:
+ ----- Method: Metaclass>>postCopy (in category 'copying') -----
+ postCopy
+ "Don't share the reference to the sole instance."
+
+ super postCopy.
+ thisClass := nil.!
Matthew Fulmer uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mtf.168.mcz
==================== Summary ====================
Name: Graphics-mtf.168
Author: mtf
Time: 29 December 2010, 12:32:10.286 am
UUID: 42140ec9-4562-f74a-870d-01f72d53c3e0
Ancestors: Graphics-mtf.167
Chromatically symmetric versions of #darker #muchDarker. Cherrypicked from Croquet:
Name: Graphics-bgf.17
Author: bgf
Time: 1 February 2007, 11:08:10 pm
UUID: e3e570da-3857-4da6-a458-a7c6e1e3d582
Ancestors: Graphics-ar.16
Chromatically symmetric versions
of #darker #muchDarker
(increase saturation when darkening,
just as #lighter/#muchLighter already decrease it.)
The result is perceptually more consistent in gradients
like the system window titles.
=============== Diff against Graphics-mtf.167 ===============
Item was changed:
----- Method: Color>>twiceDarker (in category 'transformations') -----
twiceDarker
"Answer a significantly darker shade of this color."
+ ^ self adjustSaturation: 0.075 brightness: -0.15!
- ^ self adjustBrightness: -0.15!
Matthew Fulmer uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mtf.168.mcz
==================== Summary ====================
Name: Graphics-mtf.168
Author: mtf
Time: 29 December 2010, 12:32:10.286 am
UUID: 42140ec9-4562-f74a-870d-01f72d53c3e0
Ancestors: Graphics-mtf.167
Chromatically symmetric versions of #darker #muchDarker. Cherrypicked from Croquet:
Name: Graphics-bgf.17
Author: bgf
Time: 1 February 2007, 11:08:10 pm
UUID: e3e570da-3857-4da6-a458-a7c6e1e3d582
Ancestors: Graphics-ar.16
Chromatically symmetric versions
of #darker #muchDarker
(increase saturation when darkening,
just as #lighter/#muchLighter already decrease it.)
The result is perceptually more consistent in gradients
like the system window titles.
=============== Diff against Graphics-mtf.167 ===============
Item was changed:
----- Method: Color>>twiceDarker (in category 'transformations') -----
twiceDarker
"Answer a significantly darker shade of this color."
+ ^ self adjustSaturation: 0.075 brightness: -0.15!
- ^ self adjustBrightness: -0.15!
Matthew Fulmer uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mtf.168.mcz
==================== Summary ====================
Name: Graphics-mtf.168
Author: mtf
Time: 29 December 2010, 12:32:10.286 am
UUID: 42140ec9-4562-f74a-870d-01f72d53c3e0
Ancestors: Graphics-mtf.167
Chromatically symmetric versions of #darker #muchDarker. Cherrypicked from Croquet:
Name: Graphics-bgf.17
Author: bgf
Time: 1 February 2007, 11:08:10 pm
UUID: e3e570da-3857-4da6-a458-a7c6e1e3d582
Ancestors: Graphics-ar.16
Chromatically symmetric versions
of #darker #muchDarker
(increase saturation when darkening,
just as #lighter/#muchLighter already decrease it.)
The result is perceptually more consistent in gradients
like the system window titles.
=============== Diff against Graphics-mtf.167 ===============
Item was changed:
----- Method: Color>>twiceDarker (in category 'transformations') -----
twiceDarker
"Answer a significantly darker shade of this color."
+ ^ self adjustSaturation: 0.075 brightness: -0.15!
- ^ self adjustBrightness: -0.15!
Matthew Fulmer uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mtf.167.mcz
==================== Summary ====================
Name: Graphics-mtf.167
Author: mtf
Time: 29 December 2010, 12:26:33.488 am
UUID: 3c92ac5b-a54a-5943-8e85-8babdfeeff64
Ancestors: Graphics-mtf.166
bullet-proof StrikeFont>>derivativeFonts. Cherrypicked from Croquet:
Name: Graphics-bf.18
Author: bf
Time: 26 February 2007, 12:41:32 pm
UUID: 543c09fb-da52-448c-a86b-f3cadfe1a5a8
Ancestors: Graphics-bgf.17
- bullet-proof StrikeFont>>derivativeFonts to make font selection menu work again
=============== Diff against Graphics-mtf.166 ===============
Item was changed:
----- Method: StrikeFont>>derivativeFonts (in category 'accessing') -----
derivativeFonts
+ derivativeFonts ifNil: [^#()].
^derivativeFonts copyWithout: nil!
Matthew Fulmer uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mtf.167.mcz
==================== Summary ====================
Name: Graphics-mtf.167
Author: mtf
Time: 29 December 2010, 12:26:33.488 am
UUID: 3c92ac5b-a54a-5943-8e85-8babdfeeff64
Ancestors: Graphics-mtf.166
bullet-proof StrikeFont>>derivativeFonts. Cherrypicked from Croquet:
Name: Graphics-bf.18
Author: bf
Time: 26 February 2007, 12:41:32 pm
UUID: 543c09fb-da52-448c-a86b-f3cadfe1a5a8
Ancestors: Graphics-bgf.17
- bullet-proof StrikeFont>>derivativeFonts to make font selection menu work again
=============== Diff against Graphics-mtf.166 ===============
Item was changed:
----- Method: StrikeFont>>derivativeFonts (in category 'accessing') -----
derivativeFonts
+ derivativeFonts ifNil: [^#()].
^derivativeFonts copyWithout: nil!
Matthew Fulmer uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mtf.167.mcz
==================== Summary ====================
Name: Graphics-mtf.167
Author: mtf
Time: 29 December 2010, 12:26:33.488 am
UUID: 3c92ac5b-a54a-5943-8e85-8babdfeeff64
Ancestors: Graphics-mtf.166
bullet-proof StrikeFont>>derivativeFonts. Cherrypicked from Croquet:
Name: Graphics-bf.18
Author: bf
Time: 26 February 2007, 12:41:32 pm
UUID: 543c09fb-da52-448c-a86b-f3cadfe1a5a8
Ancestors: Graphics-bgf.17
- bullet-proof StrikeFont>>derivativeFonts to make font selection menu work again
=============== Diff against Graphics-mtf.166 ===============
Item was changed:
----- Method: StrikeFont>>derivativeFonts (in category 'accessing') -----
derivativeFonts
+ derivativeFonts ifNil: [^#()].
^derivativeFonts copyWithout: nil!