Packages February 2012

packages@lists.squeakfoundation.org

1 participants
72 discussions

The Trunk: Tests-nice.142.mcz
by commits＠source.squeak.org 21 Feb '12

21 Feb '12

Nicolas Cellier uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-nice.142.mcz ==================== Summary ==================== Name: Tests-nice.142 Author: nice Time: 21 February 2012, 3:00:38.727 pm UUID: 6af7860f-3bab-4beb-890b-c8bebe9a2b31 Ancestors: Tests-nice.141 Depending on the VM, I have testBecomeIdentityHash sometimes failing... As the test was not very expressive, I rewrote it to explain the purpose of identityHash preservation,. Doing so, I also isolated the bad behaviour description previously tested: The VM is spawning too many equal identityHash to be honest This happens on my COG version and this might require further analysis... =============== Diff against Tests-nice.141 =============== Item was changed: ----- Method: BecomeTest>>testBecomeIdentityHash (in category 'Testing') ----- testBecomeIdentityHash + | a b c d numberOfRetry newAIdentityHash newBIdentityHash oldAIdentityHash oldBIdentityHash | + numberOfRetry := 0. + + [a := 'ab' copy. - "Note. The identity hash of both objects seems to change after the become:" - - | a b c d | - - a := 'ab' copy. b := 'cd' copy. + "Note: the sets are allocated with enough room to reduce probability that two different hash lead to same slot" + (c := IdentitySet new: 1000) add: a; add: b. + (d := IdentitySet new: 1000) add: a. + oldAIdentityHash := a identityHash. + oldBIdentityHash := b identityHash. + oldAIdentityHash = oldBIdentityHash and: [numberOfRetry < 10]] + whileTrue: [numberOfRetry := numberOfRetry + 1]. + self assert: oldAIdentityHash ~= oldBIdentityHash description: 'The VM is spawning too many equal identityHash to be honest'. - c := a. - d := b. - a become: b. + newAIdentityHash := a identityHash. + newBIdentityHash := b identityHash. + self + "The set c & d can still retrieve their elements because elements did not change their expected position" + assert: (c includes: a); + assert: (c includes: b); + assert: (d includes: a); + deny: (d includes: b); + "Elements didn't change their expected position because identityHash did not change" + assert: oldAIdentityHash = newAIdentityHash; + assert: oldBIdentityHash = newBIdentityHash! - - self - assert: a identityHash = c identityHash; - assert: b identityHash = d identityHash; - deny: a identityHash = b identityHash. - !

1 0

The Trunk: Tests-nice.142.mcz
by commits＠source.squeak.org 21 Feb '12

21 Feb '12

1 0

The Trunk: Tests-nice.142.mcz
by commits＠source.squeak.org 21 Feb '12

21 Feb '12

1 0

The Trunk: Compiler-nice.224.mcz
by commits＠source.squeak.org 20 Feb '12

20 Feb '12

Nicolas Cellier uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-nice.224.mcz ==================== Summary ==================== Name: Compiler-nice.224 Author: nice Time: 20 February 2012, 10:56:20.223 pm UUID: 15070f34-9c69-4407-a041-7659522fc95a Ancestors: Compiler-nice.223 Just for fun, fix http://code.google.com/p/pharo/issues/detail?id=4915 The inlined and non inlined versions of to:do: should answer the same result. Implementation notes: This happens to be the receiver of to:do:, and thus the initial value of the loop index. So we can trivially - push the value of init statement on the stack, - remove the final nil that was pushed forValue, - and leave the rest of code generation unchanged =============== Diff against Compiler-nice.223 =============== Item was changed: ----- Method: MessageNode>>emitCodeForToDo:encoder:value: (in category 'code generation') ----- emitCodeForToDo: stack encoder: encoder value: forValue " var := rcvr. L1: [var <= arg1] Bfp(L2) [block body. var := var + inc] Jmp(L1) L2: " | loopSize initStmt limitInit test block incStmt blockSize | initStmt := arguments at: 4. limitInit := arguments at: 7. test := arguments at: 5. block := arguments at: 3. incStmt := arguments at: 6. blockSize := sizes at: 1. loopSize := sizes at: 2. limitInit == nil ifFalse: [limitInit emitCodeForEffect: stack encoder: encoder]. + + "This will return the receiver of to:do: which is the initial value of the loop" + forValue + ifTrue: [initStmt emitCodeForValue: stack encoder: encoder.] + ifFalse: [initStmt emitCodeForEffect: stack encoder: encoder]. - initStmt emitCodeForEffect: stack encoder: encoder. test emitCodeForValue: stack encoder: encoder. self emitCodeForBranchOn: false dist: blockSize pop: stack encoder: encoder. pc := encoder methodStreamPosition. block emitCodeForEvaluatedEffect: stack encoder: encoder. incStmt emitCodeForEffect: stack encoder: encoder. + self emitCodeForJump: 0 - loopSize encoder: encoder.! - self emitCodeForJump: 0 - loopSize encoder: encoder. - forValue ifTrue: [encoder genPushSpecialLiteral: nil. stack push: 1]! Item was changed: ----- Method: MessageNode>>sizeCodeForToDo:value: (in category 'code generation') ----- sizeCodeForToDo: encoder value: forValue " var := rcvr. L1: [var <= arg1] Bfp(L2) [block body. var := var + inc] Jmp(L1) L2: " | loopSize initStmt test block incStmt blockSize initSize limitInit | block := arguments at: 3. initStmt := arguments at: 4. test := arguments at: 5. incStmt := arguments at: 6. limitInit := arguments at: 7. + initSize := forValue + ifTrue: [initStmt sizeCodeForValue: encoder.] + ifFalse: [initStmt sizeCodeForEffect: encoder]. - initSize := initStmt sizeCodeForEffect: encoder. limitInit == nil ifFalse: [initSize := initSize + (limitInit sizeCodeForEffect: encoder)]. blockSize := (block sizeCodeForEvaluatedEffect: encoder) + (incStmt sizeCodeForEffect: encoder) + (encoder sizeJumpLong: -1). loopSize := (test sizeCodeForValue: encoder) + (self sizeCode: encoder forBranchOn: false dist: blockSize) + blockSize. sizes := Array with: blockSize with: loopSize. ^initSize + + loopSize! - + loopSize - + (forValue ifTrue: [encoder sizePushSpecialLiteral: nil] ifFalse: [0])!

1 0

The Trunk: Compiler-nice.224.mcz
by commits＠source.squeak.org 20 Feb '12

20 Feb '12

1 0

The Trunk: Compiler-nice.224.mcz
by commits＠source.squeak.org 20 Feb '12

20 Feb '12

1 0

The Trunk: Tests-nice.141.mcz
by commits＠source.squeak.org 20 Feb '12

20 Feb '12

Nicolas Cellier uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-nice.141.mcz ==================== Summary ==================== Name: Tests-nice.141 Author: nice Time: 20 February 2012, 10:51:18.193 pm UUID: fc5aab1f-fc9a-470f-adb0-b843a78c440b Ancestors: Tests-eem.140 Add #testEvaluationOfInlinedToDo for http://code.google.com/p/pharo/issues/detail?id=4915 The inlined and non inlined to:do: should return the same result. =============== Diff against Tests-eem.140 =============== Item was added: + ----- Method: CompilerTest>>testEvaluationOfInlinedToDo (in category 'testing') ----- + testEvaluationOfInlinedToDo + "Whether inlined or not, #to:do: should return the same value" + | inlinedResult notInlinedResult | + inlinedResult := Compiler new + evaluate: '1+1 to: 0 do: [:i | ]' + in: nil + to: nil + notifying: nil + ifFail: [^ #failedDoit] + logged: false. + notInlinedResult := Compiler new + evaluate: '| aBlock | aBlock := [:i | ]. 1+1 to: 0 do: aBlock' + in: nil + to: nil + notifying: nil + ifFail: [^ #failedDoit] + logged: false. + self assert: inlinedResult = notInlinedResult!

1 0

The Trunk: Tests-nice.141.mcz
by commits＠source.squeak.org 20 Feb '12

20 Feb '12

1 0

The Trunk: Tests-nice.141.mcz
by commits＠source.squeak.org 20 Feb '12

20 Feb '12

1 0

The Trunk: Graphics-nice.192.mcz
by commits＠source.squeak.org 20 Feb '12

20 Feb '12

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.192.mcz ==================== Summary ==================== Name: Graphics-nice.192 Author: nice Time: 20 February 2012, 7:30:30.765 pm UUID: 47abe0e7-0db5-4c46-9fc2-b01316877379 Ancestors: Graphics-cmm.191 Fix one of the issues at http://code.google.com/p/pharo/issues/detail?id=5335 self assert: (Color fromString: 'darkGray') = Color darkGray. =============== Diff against Graphics-cmm.191 =============== Item was changed: ----- Method: Color class>>fromString: (in category 'instance creation') ----- fromString: aString "for HTML color spec: #FFCCAA or white/black" "Color fromString: '#FFCCAA'. Color fromString: 'white'. Color fromString: 'orange'" | aColorHex | aString isEmptyOrNil ifTrue: [ ^self white ]. aString first = $# ifTrue: [ aColorHex := aString allButFirst ] ifFalse: [ aColorHex := aString ]. (aColorHex size = 6 and: [ aColorHex allSatisfy: [ :each | '0123456789ABCDEFabcdef' includes: each ] ]) ifTrue: [ | green red blue | red := (Integer readFrom: (aColorHex first: 2) base: 16) / 255. green := (Integer readFrom: (aColorHex copyFrom: 3 to: 4) base: 16) / 255. blue := (Integer readFrom: (aColorHex last: 2) base: 16) / 255. ^self r: red g: green b: blue ]. + "try to match aColorHex with known named colors, case insensitive" + ^self perform: (ColorNames detect: [:colorSymbol | aColorHex sameAs: colorSymbol] ifNone: [ #white ])! - "try to match aColorHex with known named colors" - ^self perform: (ColorNames like: aColorHex asLowercase ifAbsent: [ #white ])!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Packages February 2012