Packages October 2014

packages@lists.squeakfoundation.org

1 participants
165 discussions

The Trunk: KernelTests-nice.280.mcz
by commits＠source.squeak.org 27 Oct '14

27 Oct '14

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.280.mcz ==================== Summary ==================== Name: KernelTests-nice.280 Author: nice Time: 27 October 2014, 9:53:44.861 pm UUID: fc50e9f5-10d8-45d8-8c9e-e80806596878 Ancestors: KernelTests-dtl.279 Two more expectations for float literal equality: - zero and negativeZero are equal but not #literalEqual: - nan are not equals but can be #literalEqual: Thanks to Kris Gybels for reporting this case at https://pharo.fogbugz.com/f/cases/14316/ =============== Diff against KernelTests-dtl.279 =============== Item was added: + ----- Method: FloatTest>>testLiteralEqualityOfNan (in category 'testing compare') ----- + testLiteralEqualityOfNan + | nan | + nan := Float nan. + self assert: (nan literalEqual: nan) + description: 'Float nan is not equal to itself, though it is literally equal'.! Item was added: + ----- Method: FloatTest>>testLiteralEqualityOfZeroAndNegativeZero (in category 'testing compare') ----- + testLiteralEqualityOfZeroAndNegativeZero + self assert: -1 + equals: (Compiler evaluate: '1>2 ifTrue: [0.0] ifFalse: [-0.0]') sign + description: 'Float zero and negativeZero are not literally substituable'.!

1 0

The Trunk: KernelTests-nice.280.mcz
by commits＠source.squeak.org 27 Oct '14

27 Oct '14

1 0

The Trunk: KernelTests-nice.280.mcz
by commits＠source.squeak.org 27 Oct '14

27 Oct '14

1 0

The Trunk: System-ul.688.mcz
by commits＠source.squeak.org 27 Oct '14

27 Oct '14

Levente Uzonyi uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ul.688.mcz ==================== Summary ==================== Name: System-ul.688 Author: ul Time: 27 October 2014, 4:43:14.279 pm UUID: 77747387-55a5-4118-95b5-752979bf1cf7 Ancestors: System-dtl.685 Replaced ExternalSemaphoreTable with ExternalObjectTable to provide faster registration, and give better support to the current users of external objects. Notable changes: - the table is a separate object instead of a few class side methods - the whole API can be found in SmalltalkImage in the external objects category - #newExternalSemaphore, #newExternalSemaphoreDo: and #newExternalSemaphores: provide fast and easy creation and registration of Semaphores - #unregisterExternalObjects: can unregister multiple objects faster - #externalObjects will return a copy of the externalObjectsArray - better scalability - the maxExternalSemaphores VM parameter will be incremented as the externalObjectsArray grows =============== Diff against System-dtl.685 =============== Item was added: + Object subclass: #ExternalObjectTable + instanceVariableNames: 'semaphore externalObjectsArray freeSlotIndexes indexesByObjects' + classVariableNames: '' + poolDictionaries: '' + category: 'System-Support'! + ExternalObjectTable class + instanceVariableNames: 'current'! + + !ExternalObjectTable commentStamp: 'ul 10/27/2014 16:26' prior: 0! + I'm an enhanced version of JMM's ExternalSemaphoreTable. + I'm responsible for maintaining the externalObjectsArray, which can be found at slot 39 of Smalltalk specialObjectsArray. Manipulating the array directly is highly discouraged. + + My services are available via the methods of the "external objects" category of SmalltalkImage. + + To register anObject simply use Smalltalk registerExternalObject: anObject. Use #unregisterExternalObject: to unregister it. It your responsibility to always unregister these objects. + If you'd like the create one or more new Semaphores, and register them for external use, then you should use one of #newExternalSemaphore, #newExternalSemaphoreDo: and #newExternalSemaphores:. If you want to unregister more than one external objects at the same time, then #unregisterExternalObjects: is the method you're looking for. + + Implementation details: + I maintain a single instance (#current), which can automatically synchronize with externalObjectsArray. + All accesses are protected by the semaphore instance variable. + To ensure fast access, I keep track of the indexes of the external objects in the externalObjectArray in my indexesByObjects IdentityDictionary. + To ensure fast insertion, I keep track of the free slots of the externalObjectsArray in the freeSlotIndexes OrderedCollection. The access pattern is LIFO to avoid unnecessary growth and reordering of the OrderedCollection. + I can grow the externalObjectsArray (see #ensureFreeSlot), but I never shrink it.! + ExternalObjectTable class + instanceVariableNames: 'current'! Item was added: + ----- Method: ExternalObjectTable class>>cleanUp: (in category 'initialize-release') ----- + cleanUp: aggressive + "It's safe to release the instance" + + self reset! Item was added: + ----- Method: ExternalObjectTable class>>current (in category 'accessing') ----- + current + + ^current ifNil: [ + | newInstance | + newInstance := self new. + " Check again, because another process might have registered another instance. " + current ifNil: [ current := newInstance ] ]! Item was added: + ----- Method: ExternalObjectTable class>>reset (in category 'accessing') ----- + reset + + current := nil! Item was added: + ----- Method: ExternalObjectTable>>clearExternalObjects (in category 'accessing') ----- + clearExternalObjects + "Clear the array of objects that have been registered for use in non-Smalltalk code." + + semaphore critical: [ + Smalltalk specialObjectsArray at: 39 put: Array new. + self + initializeCaches; + synchronizeExternalObjectsArrayAndForceUpdate: true ]! Item was added: + ----- Method: ExternalObjectTable>>ensureFreeSlot (in category 'private') ----- + ensureFreeSlot + "Make sure there's at least one free slot." + + | oldSize newSize newExternalObjectsArray specialObjectsArray | + freeSlotIndexes isEmpty ifFalse: [ ^self ]. + oldSize := externalObjectsArray size. + newSize := oldSize + 20. "Linear growth is not really a problem, because we never shrink the array." + newExternalObjectsArray := externalObjectsArray species new: newSize. + newExternalObjectsArray + replaceFrom: 1 + to: oldSize + with: externalObjectsArray + startingAt: 1. + specialObjectsArray := Smalltalk specialObjectsArray. + (specialObjectsArray at: 39) == externalObjectsArray + ifFalse: [ + "We're not in sync. Try again." + ^self + synchronizeExternalObjectsArrayAndForceUpdate: true; + ensureFreeSlot ]. + specialObjectsArray at: 39 put: newExternalObjectsArray. + externalObjectsArray := newExternalObjectsArray. + newSize to: oldSize + 1 by: -1 do: [ :each | + freeSlotIndexes addFirst: each ]. + Smalltalk maxExternalSemaphores ifNotNil: [ :maxExternalSemaphores | + "Make sure that those new external semaphores can be signaled by the VM. This is not entirely safe, but not incrementing at all is worse." + newSize > maxExternalSemaphores ifTrue: [ + Smalltalk maxExternalSemaphores: newSize ] ] + + ! Item was added: + ----- Method: ExternalObjectTable>>externalObjects (in category 'accessing') ----- + externalObjects + "Return a copy of the externalObjectsArray." + + ^semaphore critical: [ + self synchronizeExternalObjectsArrayAndForceUpdate: false. + externalObjectsArray copy ]! Item was added: + ----- Method: ExternalObjectTable>>externalObjectsArray: (in category 'private') ----- + externalObjectsArray: anArray + "Update the index mapping using anArray as the new externalObjectsArray." + + externalObjectsArray := anArray. + freeSlotIndexes reset. + indexesByObjects removeAll. + 1 to: externalObjectsArray size do: [ :index | + (anArray at: index) + ifNil: [ freeSlotIndexes addFirst: index ] + ifNotNil: [ :object | indexesByObjects at: object put: index ] ]! Item was added: + ----- Method: ExternalObjectTable>>initialize (in category 'initialize-release') ----- + initialize + + semaphore := Semaphore forMutualExclusion. + self initializeCaches! Item was added: + ----- Method: ExternalObjectTable>>initializeCaches (in category 'private') ----- + initializeCaches + + freeSlotIndexes := OrderedCollection new. + indexesByObjects := IdentityDictionary new! Item was added: + ----- Method: ExternalObjectTable>>newExternalSemaphore (in category 'accessing') ----- + newExternalSemaphore + "Create and register a new Semaphore, and return an array containing itself and its index." + + | newSemaphore | + ^{ + newSemaphore := Semaphore new. + semaphore critical: [ + self + synchronizeExternalObjectsArrayAndForceUpdate: false; + safelyRegisterNewExternalObject: newSemaphore ] }! Item was added: + ----- Method: ExternalObjectTable>>newExternalSemaphoreDo: (in category 'accessing') ----- + newExternalSemaphoreDo: aBlock + "Create and register a new Semaphore, then evaluate aBlock with it and its index." + + | newSemaphore | + ^aBlock + value: (newSemaphore := Semaphore new) + value: (semaphore critical: [ + self + synchronizeExternalObjectsArrayAndForceUpdate: false; + safelyRegisterNewExternalObject: newSemaphore ])! Item was added: + ----- Method: ExternalObjectTable>>newExternalSemaphores: (in category 'accessing') ----- + newExternalSemaphores: count + "Create and register multiple Semaphores, and return an array containing the semaphores and their indexes in separate arrays." + + | semaphores indexes | + semaphores := Array new: count. + 1 to: count do: [ :index | semaphores at: index put: Semaphore new ]. + indexes := Array new: count. + semaphore critical: [ + self synchronizeExternalObjectsArrayAndForceUpdate: false. + 1 to: count do: [ :index | + indexes at: index put: ( + self safelyRegisterNewExternalObject: (semaphores at: index)) ] ]. + ^{ semaphores. indexes }! Item was added: + ----- Method: ExternalObjectTable>>registerExternalObject: (in category 'accessing') ----- + registerExternalObject: anObject + "Register the given object in the external objects array and return its index. If it is already there, just return its index." + + anObject ifNil: [ ^nil ]. + ^semaphore critical: [ + self + synchronizeExternalObjectsArrayAndForceUpdate: false; + safelyRegisterExternalObject: anObject ]! Item was added: + ----- Method: ExternalObjectTable>>safelyRegisterExternalObject: (in category 'private') ----- + safelyRegisterExternalObject: anObject + + | index | + (index := indexesByObjects at: anObject ifAbsent: nil) ifNotNil: [ + (externalObjectsArray at: index) == anObject ifTrue: [ ^index ]. + "indexesByObjects is out of sync. Try again." + ^self + synchronizeExternalObjectsArrayAndForceUpdate: true; + safelyRegisterExternalObject: anObject ]. + ^self safelyRegisterNewExternalObject: anObject! Item was added: + ----- Method: ExternalObjectTable>>safelyRegisterNewExternalObject: (in category 'private') ----- + safelyRegisterNewExternalObject: anObject + + | index | + self ensureFreeSlot. + index := freeSlotIndexes removeLast. + (externalObjectsArray at: index) ifNotNil: [ + "Free slot is not empty. Try again." + ^self + synchronizeExternalObjectsArrayAndForceUpdate: true; + safelyRegisterNewExternalObject: anObject ]. + externalObjectsArray at: index put: anObject. + indexesByObjects at: anObject put: index. + ^index! Item was added: + ----- Method: ExternalObjectTable>>safelyUnregisterExternalObject: (in category 'private') ----- + safelyUnregisterExternalObject: anObject + + (indexesByObjects removeKey: anObject ifAbsent: nil) + ifNotNil: [ :index | + (externalObjectsArray at: index) == anObject ifFalse: [ + "We're not in sync. Try again." + ^self + synchronizeExternalObjectsArrayAndForceUpdate: true; + safelyUnregisterExternalObject: anObject ]. + externalObjectsArray at: index put: nil. + freeSlotIndexes add: index ] + ifNil: [ + "Check if we're just out of sync." + (externalObjectsArray instVarsInclude: anObject) ifFalse: [ ^self ]. + "We're not in sync. Try again." + ^self + synchronizeExternalObjectsArrayAndForceUpdate: true; + safelyUnregisterExternalObject: anObject ]! Item was added: + ----- Method: ExternalObjectTable>>synchronizeExternalObjectsArrayAndForceUpdate: (in category 'private') ----- + synchronizeExternalObjectsArrayAndForceUpdate: forceUpdate + + | actualExternalObjectsArray | + actualExternalObjectsArray := Smalltalk specialObjectsArray at: 39. + (actualExternalObjectsArray == externalObjectsArray and: [ forceUpdate not ]) + ifTrue: [ ^self ]. + self externalObjectsArray: actualExternalObjectsArray! Item was added: + ----- Method: ExternalObjectTable>>unregisterExternalObject: (in category 'accessing') ----- + unregisterExternalObject: anObject + "Unregister the given object from the external objects array. Do nothing if it isn't registered." + + anObject ifNil: [ ^self ]. + semaphore critical: [ + self + synchronizeExternalObjectsArrayAndForceUpdate: false; + safelyUnregisterExternalObject: anObject ]! Item was added: + ----- Method: ExternalObjectTable>>unregisterExternalObjects: (in category 'accessing') ----- + unregisterExternalObjects: aCollection + "Unregister the given objects from the external objects array. Do nothing if they aren't registered." + + semaphore critical: [ + self synchronizeExternalObjectsArrayAndForceUpdate: false. + aCollection do: [ :each | + each ifNotNil: [ + self safelyUnregisterExternalObject: each ] ] ]! Item was removed: - Object subclass: #ExternalSemaphoreTable - instanceVariableNames: '' - classVariableNames: 'ProtectTable' - poolDictionaries: '' - category: 'System-Support'! - - !ExternalSemaphoreTable commentStamp: '<historical>' prior: 0! - By John M McIntosh johnmci(a)smalltalkconsulting.com - This class was written to mange the external semaphore table. When I was writing a Socket test server I discovered various race conditions on the access to the externalSemaphore table. This new class uses class side methods to restrict access using a mutex semaphore. It seemed cleaner to deligate the reponsibility here versus adding more code and another class variable to SystemDictionary - - Note that in Smalltalk recreateSpecialObjectsArray we still directly play with the table.! Item was removed: - ----- Method: ExternalSemaphoreTable class>>clearExternalObjects (in category 'accessing') ----- - clearExternalObjects - "Clear the array of objects that have been registered for use in non-Smalltalk code." - - ProtectTable critical: [Smalltalk specialObjectsArray at: 39 put: Array new]. - ! Item was removed: - ----- Method: ExternalSemaphoreTable class>>externalObjects (in category 'accessing') ----- - externalObjects - ^ProtectTable critical: [Smalltalk specialObjectsArray at: 39].! Item was removed: - ----- Method: ExternalSemaphoreTable class>>initialize (in category 'initialize') ----- - initialize - ProtectTable := Semaphore forMutualExclusion! Item was removed: - ----- Method: ExternalSemaphoreTable class>>registerExternalObject: (in category 'accessing') ----- - registerExternalObject: anObject - ^ ProtectTable critical: [self safelyRegisterExternalObject: anObject] - ! Item was removed: - ----- Method: ExternalSemaphoreTable class>>safelyRegisterExternalObject: (in category 'accessing') ----- - safelyRegisterExternalObject: anObject - "Register the given object in the external objects array and return its index. If it is already there, just return its index." - - | objects firstEmptyIndex obj sz newObjects | - objects := Smalltalk specialObjectsArray at: 39. - - "find the first empty slot" - firstEmptyIndex := 0. - 1 to: objects size do: [:i | - obj := objects at: i. - obj == anObject ifTrue: [^ i]. "object already there, just return its index" - (obj == nil and: [firstEmptyIndex = 0]) ifTrue: [firstEmptyIndex := i]]. - - "if no empty slots, expand the array" - firstEmptyIndex = 0 ifTrue: [ - sz := objects size. - newObjects := objects species new: sz + 20. "grow linearly" - newObjects replaceFrom: 1 to: sz with: objects startingAt: 1. - firstEmptyIndex := sz + 1. - Smalltalk specialObjectsArray at: 39 put: newObjects. - objects := newObjects]. - - objects at: firstEmptyIndex put: anObject. - ^ firstEmptyIndex - ! Item was removed: - ----- Method: ExternalSemaphoreTable class>>safelyUnregisterExternalObject: (in category 'accessing') ----- - safelyUnregisterExternalObject: anObject - "Unregister the given object in the external objects array. Do nothing if it isn't registered. - JMM change to return if we clear the element, since it should only appear once in the array" - - | objects | - anObject ifNil: [^ self]. - objects := Smalltalk specialObjectsArray at: 39. - 1 to: objects size do: [:i | - (objects at: i) == anObject ifTrue: - [objects at: i put: nil. - ^self]]. - ! Item was removed: - ----- Method: ExternalSemaphoreTable class>>unregisterExternalObject: (in category 'accessing') ----- - unregisterExternalObject: anObject - ProtectTable critical: [self safelyUnregisterExternalObject: anObject] - ! Item was changed: + ----- Method: SmalltalkImage>>clearExternalObjects (in category 'external objects') ----- - ----- Method: SmalltalkImage>>clearExternalObjects (in category 'special objects') ----- clearExternalObjects "Clear the array of objects that have been registered for use in non-Smalltalk code." "Smalltalk clearExternalObjects" + ExternalObjectTable current clearExternalObjects - ExternalSemaphoreTable clearExternalObjects ! Item was changed: + ----- Method: SmalltalkImage>>externalObjects (in category 'external objects') ----- - ----- Method: SmalltalkImage>>externalObjects (in category 'special objects') ----- externalObjects "Return an array of objects that have been registered for use in non-Smalltalk code. Smalltalk objects should be referrenced by external code only via indirection through this array, thus allowing the objects to move during compaction. This array can be cleared when the VM re-starts, since variables in external code do not survive snapshots. Note that external code should not attempt to access a Smalltalk object, even via this mechanism, while garbage collection is in progress." + "Note that this is just a copy of the array used by the VM." "Smalltalk externalObjects" + ^ExternalObjectTable current externalObjects - ^ ExternalSemaphoreTable externalObjects ! Item was added: + ----- Method: SmalltalkImage>>newExternalSemaphore (in category 'external objects') ----- + newExternalSemaphore + "Create and register a new Semaphore, and return an array containing itself and its index." + + ^ExternalObjectTable current newExternalSemaphore! Item was added: + ----- Method: SmalltalkImage>>newExternalSemaphoreDo: (in category 'external objects') ----- + newExternalSemaphoreDo: aBlock + "Create and register a new Semaphore, then evaluate aBlock with it and its index." + + ^ExternalObjectTable current newExternalSemaphoreDo: aBlock! Item was added: + ----- Method: SmalltalkImage>>newExternalSemaphores: (in category 'external objects') ----- + newExternalSemaphores: count + "Create and register multiple Semaphores, and return an array containing the semaphores and their indexes in separate arrays." + + ^ExternalObjectTable current newExternalSemaphores: count! Item was changed: + ----- Method: SmalltalkImage>>registerExternalObject: (in category 'external objects') ----- - ----- Method: SmalltalkImage>>registerExternalObject: (in category 'special objects') ----- registerExternalObject: anObject "Register the given object in the external objects array and return its index. If it is already there, just return its index." + ^ExternalObjectTable current registerExternalObject: anObject! - ^ExternalSemaphoreTable registerExternalObject: anObject! Item was changed: + ----- Method: SmalltalkImage>>unregisterExternalObject: (in category 'external objects') ----- - ----- Method: SmalltalkImage>>unregisterExternalObject: (in category 'special objects') ----- unregisterExternalObject: anObject "Unregister the given object in the external objects array. Do nothing if it isn't registered." + ExternalObjectTable current unregisterExternalObject: anObject! - ExternalSemaphoreTable unregisterExternalObject: anObject! Item was added: + ----- Method: SmalltalkImage>>unregisterExternalObjects: (in category 'external objects') ----- + unregisterExternalObjects: aCollection + "Unregister the given objects from the external objects array. Do nothing if they aren't registered." + + ExternalObjectTable current unregisterExternalObjects: aCollection!

1 0

The Trunk: System-ul.688.mcz
by commits＠source.squeak.org 27 Oct '14

27 Oct '14

1 0

The Trunk: System-ul.688.mcz
by commits＠source.squeak.org 27 Oct '14

27 Oct '14

1 0

The Trunk: Collections-ul.586.mcz
by commits＠source.squeak.org 27 Oct '14

27 Oct '14

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.586.mcz ==================== Summary ==================== Name: Collections-ul.586 Author: ul Time: 27 October 2014, 12:52:51.886 am UUID: 4c460675-3065-4b48-aa30-52ad67e15076 Ancestors: Collections-cmm.585 Symbol table changes: - ensure that enumerations stay consistent - avoid read-write and write-write race conditions - added a safe #condenseNewSymbols method, which is a replacement for former unsafe methods (#shutDown: and #compactSymbolTable). It's also automatically triggered whenever there are more than 1000 NewSymbols. - deprecated #compactSymbolTable - updated some comments Note that interning many symbols is a bit slower, but thread safety is more important. =============== Diff against Collections-cmm.585 =============== Item was changed: ----- Method: Symbol class>>allSymbolTablesDo: (in category 'class initialization') ----- allSymbolTablesDo: aBlock + + | originalNewSymbols originalSymbolTable | + originalNewSymbols := NewSymbols. + originalSymbolTable := SymbolTable. + originalNewSymbols do: aBlock. + originalSymbolTable do: aBlock.! - - NewSymbols do: aBlock. - SymbolTable do: aBlock.! Item was changed: ----- Method: Symbol class>>allSymbolTablesDo:after: (in category 'class initialization') ----- allSymbolTablesDo: aBlock after: aSymbol + | originalNewSymbols originalSymbolTable | + originalNewSymbols := NewSymbols. + originalSymbolTable := SymbolTable. + (originalNewSymbols includes: aSymbol) - (NewSymbols includes: aSymbol) ifTrue: [ + originalNewSymbols do: aBlock after: aSymbol. + originalSymbolTable do: aBlock after: aSymbol ] - NewSymbols do: aBlock after: aSymbol. - SymbolTable do: aBlock after: aSymbol ] ifFalse: [ + originalSymbolTable do: aBlock after: aSymbol. + originalNewSymbols do: aBlock after: aSymbol ] - SymbolTable do: aBlock after: aSymbol. - NewSymbols do: aBlock after: aSymbol ] ! Item was changed: ----- Method: Symbol class>>allSymbols (in category 'access') ----- allSymbols "Answer all interned symbols" + | originalNewSymbols originalSymbolTable | + originalNewSymbols := NewSymbols. + originalSymbolTable := SymbolTable. ^Array + new: originalNewSymbols slowSize + originalSymbolTable slowSize - new: NewSymbols slowSize + SymbolTable slowSize streamContents:[ :stream | stream + nextPutAll: originalNewSymbols; + nextPutAll: originalSymbolTable ] - nextPutAll: NewSymbols; - nextPutAll: SymbolTable ] ! Item was changed: ----- Method: Symbol class>>cleanUp (in category 'class initialization') ----- cleanUp "Flush caches" + self condenseNewSymbols! - self compactSymbolTable.! Item was changed: ----- Method: Symbol class>>compactSymbolTable (in category 'class initialization') ----- compactSymbolTable "Reduce the size of the symbol table so that it holds all existing symbols with 25% free space." + self deprecated: 'Use #condenseNewSymbols instead'. + self condenseNewSymbols! - | oldSize | - Smalltalk garbageCollect. - oldSize := SymbolTable capacity. - SymbolTable compact. - ^(oldSize - SymbolTable capacity) printString, ' slot(s) reclaimed'! Item was added: + ----- Method: Symbol class>>condenseNewSymbols (in category 'private') ----- + condenseNewSymbols + "Move all symbols from NewSymbols to SymbolTable, and compact SymbolTable." + + | originalNewSymbols originalSymbolTable newNewSymbols newSymbolTable | + originalNewSymbols := NewSymbols. + originalSymbolTable := SymbolTable. + newNewSymbols := WeakSet new. + newSymbolTable := originalSymbolTable copy + addAll: originalNewSymbols; + compact; + yourself. + originalNewSymbols == NewSymbols ifFalse: [ + "Some other process has modified the symbols. Try again." + ^self condenseNewSymbols ]. + NewSymbols := newNewSymbols. + SymbolTable := newSymbolTable! Item was changed: ----- Method: Symbol class>>intern: (in category 'instance creation') ----- intern: aStringOrSymbol + | originalNewSymbols | + originalNewSymbols := NewSymbols. ^(self lookup: aStringOrSymbol) ifNil:[ + | aClass aSymbol newNewSymbols | - | aClass aSymbol | aStringOrSymbol isSymbol ifTrue:[ aSymbol := aStringOrSymbol. ] ifFalse:[ aClass := aStringOrSymbol isOctetString ifTrue:[ByteSymbol] ifFalse:[WideSymbol]. aSymbol := aClass new: aStringOrSymbol size. aSymbol string: aStringOrSymbol. ]. + newNewSymbols := originalNewSymbols copyWith: aSymbol. + originalNewSymbols == NewSymbols + ifTrue: [ + NewSymbols := newNewSymbols. + newNewSymbols size > 1000 ifTrue: [ self condenseNewSymbols ]. + aSymbol ] + ifFalse: [ + "Some other process has modified the symbols. Try again." + self intern: aStringOrSymbol ] ]! - NewSymbols add: aSymbol. - aSymbol].! Item was changed: ----- Method: Symbol class>>lookup: (in category 'instance creation') ----- lookup: aStringOrSymbol + | originalNewSymbols originalSymbolTable | + originalNewSymbols := NewSymbols. + originalSymbolTable := SymbolTable. + ^(originalNewSymbols like: aStringOrSymbol) ifNil: [ + originalSymbolTable like: aStringOrSymbol ]! - ^(SymbolTable like: aStringOrSymbol) ifNil: [ - NewSymbols like: aStringOrSymbol - ]! Item was changed: ----- Method: Symbol class>>rehash (in category 'private') ----- + rehash + "Rebuild the hash table, reclaiming unreferenced Symbols. This method will intern all symbols. You're probably looking for #condenseNewSymbols instead." - rehash "Symbol rehash" - "Rebuild the hash table, reclaiming unreferenced Symbols." + | originalNewSymbols originalSymbolTable newNewSymbols newSymbolTable | + originalNewSymbols := NewSymbols. + originalSymbolTable := SymbolTable. + newNewSymbols := WeakSet new. + newSymbolTable := WeakSet withAll: self allSubInstances. + originalNewSymbols == NewSymbols ifFalse: [ + "Some other process has modified the symbols. Try again." + ^self rehash ]. + NewSymbols := newNewSymbols. + SymbolTable := newSymbolTable! - SymbolTable := WeakSet withAll: self allSubInstances. - NewSymbols := WeakSet new.! Item was changed: ----- Method: Symbol class>>shutDown: (in category 'private') ----- shutDown: aboutToQuit + self condenseNewSymbols! - SymbolTable addAll: NewSymbols. - NewSymbols := WeakSet new.!

1 0

The Trunk: Collections-ul.586.mcz
by commits＠source.squeak.org 27 Oct '14

27 Oct '14

1 0

The Trunk: Collections-ul.586.mcz
by commits＠source.squeak.org 27 Oct '14

27 Oct '14

1 0

The Trunk: Monticello-mtf.603.mcz
by commits＠source.squeak.org 26 Oct '14

26 Oct '14

Matthew Fulmer uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-mtf.603.mcz ==================== Summary ==================== Name: Monticello-mtf.603 Author: mtf Time: 26 October 2014, 6:53:22.573 am UUID: a68bf6b3-1e73-4d62-9fce-cc860422ba2e Ancestors: Monticello-ul.602 Print the right thing for class-side traits =============== Diff against Monticello-ul.602 =============== Item was changed: ----- Method: MCClassDefinition>>printClassSideDefinitionOn: (in category 'printing') ----- printClassSideDefinitionOn: stream stream nextPutAll: self className; nextPutAll: ' class '; + cr; tab. + self hasClassTraitComposition ifTrue: [ + stream + nextPutAll: 'uses: '; + nextPutAll: self classTraitCompositionString; + cr; tab ]. + stream - cr; tab; nextPutAll: 'instanceVariableNames: '; store: self classInstanceVariablesString! Item was added: + ----- Method: MCTraitDefinition>>printClassSideDefinitionOn: (in category 'printing') ----- + printClassSideDefinitionOn: stream + stream + nextPutAll: self className; + nextPutAll: ' classTrait '; + cr; tab; + nextPutAll: 'uses: '; + nextPutAll: self classTraitCompositionString!

1 0

← Newer
1
2
3
4
5
6
7
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Packages October 2014