Patrick Rein uploaded a new version of EToys to project The Trunk:
http://source.squeak.org/trunk/EToys-pre.137.mcz
==================== Summary ====================
Name: EToys-pre.137
Author: pre
Time: 20 May 2016, 10:17:16.147592 am
UUID: f4fdcfc9-f4e7-431b-84bc-41ba3fec9f27
Ancestors: EToys-mt.136
Moves UpdatingRectangleMorph to MorphicExtras
=============== Diff against EToys-mt.136 ===============
Item was removed:
- RectangleMorph subclass: #UpdatingRectangleMorph
- instanceVariableNames: 'target lastValue getSelector putSelector contents'
- classVariableNames: ''
- poolDictionaries: ''
- category: 'Etoys-Scripting Support'!
-
- !UpdatingRectangleMorph commentStamp: '<historical>' prior: 0!
- Intended for use as a color swatch coupled to a color obtained from the target, but made just slightly more general than that.!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>contents (in category 'accessing') -----
- contents
- ^ contents!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>contents: (in category 'accessing') -----
- contents: c
- contents := c!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>defaultBorderColor (in category 'initialization') -----
- defaultBorderColor
- "answer the default border color/fill style for the receiver"
- ^ Color lightGray lighter!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>getSelector (in category 'accessing') -----
- getSelector
- "Answer the getSelector"
-
- ^ getSelector!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>getSelector: (in category 'accessing') -----
- getSelector: aSymbol
-
- getSelector := aSymbol.
- !
Item was removed:
- ----- Method: UpdatingRectangleMorph>>handlesMouseDown: (in category 'event handling') -----
- handlesMouseDown: evt
- ^putSelector notNil!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>isEtoyReadout (in category 'accessing') -----
- isEtoyReadout
- "Answer whether the receiver can serve as an etoy readout"
-
- ^ true!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>mouseUp: (in category 'event handling') -----
- mouseUp: evt
-
- self changeColorTarget: self selector: #setTargetColor: originalColor: color hand: evt hand.!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>putSelector (in category 'accessing') -----
- putSelector
- ^ putSelector!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>putSelector: (in category 'accessing') -----
- putSelector: aSymbol
- putSelector := aSymbol!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>readFromTarget (in category 'target access') -----
- readFromTarget
- "Read the color value from my target"
-
- | v |
- (target isNil or: [getSelector isNil]) ifTrue: [^contents].
- target isMorph ifTrue: [target isInWorld ifFalse: [^contents]].
- v := self valueProvider perform: getSelector.
- lastValue := v.
- ^v!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>setTargetColor: (in category 'setting') -----
- setTargetColor: aColor
- "Set my target's color as indicated"
-
- putSelector ifNotNil:
- [self color: aColor.
- contents := aColor.
- self valueProvider perform: self putSelector withArguments: (Array with: aColor)]
- !
Item was removed:
- ----- Method: UpdatingRectangleMorph>>step (in category 'stepping and presenter') -----
- step
- | s |
- super step.
- s := self readFromTarget.
- s = contents ifFalse:
- [self contents: s.
- self color: s]
- !
Item was removed:
- ----- Method: UpdatingRectangleMorph>>stepTime (in category 'testing') -----
- stepTime
-
- ^ 50!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>target (in category 'accessing') -----
- target
-
- ^ target
- !
Item was removed:
- ----- Method: UpdatingRectangleMorph>>target: (in category 'accessing') -----
- target: anObject
-
- target := anObject.
- !
Item was removed:
- ----- Method: UpdatingRectangleMorph>>userEditsAllowed (in category 'accessing') -----
- userEditsAllowed
- "Answer whether it is suitable for a user to change the value represented by this readout"
-
- ^ putSelector notNil!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>valueProvider (in category 'setting') -----
- valueProvider
- "Answer the object to which my get/set messages should be sent. This is inefficient and contorted in order to support grandfathered content for an earlier design"
-
- ^ target isMorph
- ifTrue:
- [target topRendererOrSelf player ifNil: [target]]
- ifFalse:
- [target]!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>veryDeepFixupWith: (in category 'copying') -----
- veryDeepFixupWith: deepCopier
- "If target and arguments fields were weakly copied, fix them here. If they were in the tree being copied, fix them up, otherwise point to the originals!!!!"
-
- super veryDeepFixupWith: deepCopier.
- target := deepCopier references at: target ifAbsent: [target].!
Item was removed:
- ----- Method: UpdatingRectangleMorph>>veryDeepInner: (in category 'copying') -----
- veryDeepInner: deepCopier
- "Copy all of my instance variables. Some need to be not copied at all, but shared. Warning!!!! Every instance variable defined in this class must be handled. We must also implement veryDeepFixupWith:. See DeepCopier class comment."
-
- super veryDeepInner: deepCopier.
- "target := target. Weakly copied"
- lastValue := lastValue veryDeepCopyWith: deepCopier.
- "getSelector := getSelector. a Symbol"
- "putSelector := putSelector. a Symbol"
- contents := contents veryDeepCopyWith: deepCopier.!
Patrick Rein uploaded a new version of PreferenceBrowser to project The Trunk:
http://source.squeak.org/trunk/PreferenceBrowser-pre.60.mcz
==================== Summary ====================
Name: PreferenceBrowser-pre.60
Author: pre
Time: 20 May 2016, 10:12:16.873592 am
UUID: b7bf981d-b37d-4f6a-a298-921f729da05d
Ancestors: PreferenceBrowser-kfr.59
Removes the unused useGradientFill method and thereby also the PreferenceBrowser dependency on the Balloon package
=============== Diff against PreferenceBrowser-kfr.59 ===============
Item was removed:
- ----- Method: PBColorPreferenceView>>useGradientFill (in category 'user interface') -----
- useGradientFill
-
- "Make receiver use a solid fill style (e.g., a simple color)"
-
-
- | color1 color2 fill |
- self preference preferenceValue isGradientFill ifTrue:[^self]. "Already done"
- color1 := Color white darker.
- color2 := self preference preferenceValue asColor.
- fill := GradientFillStyle ramp: {0.0 -> color1. 1.0 -> color2}.
- fill origin: ActiveWorld topLeft.
- fill direction: 0 @ ActiveWorld bounds extent y.
- fill normal: ActiveWorld bounds extent x @ 0.
- fill radial: false.
- self preference preferenceValue: fill.
- button label: self preference preferenceValue asString;
- color: self preference preferenceValue!
Patrick Rein uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-pre.344.mcz
==================== Summary ====================
Name: Tests-pre.344
Author: pre
Time: 20 May 2016, 10:10:49.235592 am
UUID: d144be16-8a8e-49d2-9bf8-9bf4304cb55d
Ancestors: Tests-pre.343
Adds the ToolBuilder dependency to the PreferenceBrowser dependency test. As a temporary measure during the move to a ToolBuilder-based implementation it points directly to ToolBuilder-Morphic
=============== Diff against Tests-pre.343 ===============
Item was changed:
----- Method: PackageDependencyTest>>testPreferenceBrowser (in category 'tests') -----
testPreferenceBrowser
self testPackage: #PreferenceBrowser dependsExactlyOn: #(
#'Chronology-Core'
Collections
Graphics
Kernel
Morphic
MorphicExtras
System
Tools
+ #'ToolBuilder-Morphic' "Work in progress. Should become ToolBuilder --pre"
).!
Patrick Rein uploaded a new version of Regex-Tests-Core to project The Trunk:
http://source.squeak.org/trunk/Regex-Tests-Core-pre.6.mcz
==================== Summary ====================
Name: Regex-Tests-Core-pre.6
Author: pre
Time: 19 May 2016, 8:50:59.559548 pm
UUID: e1cbdf20-9ce2-4e4a-b1d8-574186c2e746
Ancestors: Regex-Tests-Core-ul.5
Adjustments to the Regex tests for optional subexpressions in multiple quantifiers. These tests demonstrate the different behavior when nesting subexpressions in quantifiers and the other way round.
=============== Diff against Regex-Tests-Core-ul.5 ===============
Item was added:
+ ----- Method: RxMatcherTest>>testOptionalMultipleQuantifiedSubexpression (in category 'testing') -----
+ testOptionalMultipleQuantifiedSubexpression
+ <timeout: 0.1>
+
+ self runRegex: #('((aa?){2})'
+ '' false nil
+ 'a' false nil
+ 'aa' true (1 'aa')
+ 'baaa' true (2 'aaa'))!
Item was changed:
----- Method: RxMatcherTest>>testOptionalNestedIntoMultipleQuantified (in category 'testing') -----
testOptionalNestedIntoMultipleQuantified
<timeout: 0.1>
self runRegex: #('(aa?){2}'
'' false nil
'a' false nil
'aa' true (1 'aa')
+ 'baaa' true (2 'a'))!
- 'baaa' true (2 'aaa'))!
Levente Uzonyi uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-ul.1024.mcz
==================== Summary ====================
Name: Kernel-ul.1024
Author: ul
Time: 20 May 2016, 1:19:14.472859 am
UUID: 68c736cc-d98c-4303-a68e-312488b5c51a
Ancestors: Kernel-eem.1023
Copied the fallback code of LargePositiveInteger >> #replaceFrom:to:with:startingAt: from its parent class and extended it to make it compatible with the primitive as well.
=============== Diff against Kernel-eem.1023 ===============
Item was changed:
----- Method: LargePositiveInteger>>replaceFrom:to:with:startingAt: (in category 'system primitives') -----
replaceFrom: start to: stop with: replacement startingAt: repStart
"Primitive. This destructively replaces elements from start to stop in the receiver starting at index, repStart, in the collection, replacement. Answer the receiver. Range checks are performed in the primitive only. Optional. See Object documentation whatIsAPrimitive."
+
+ | index replacementIndex |
<primitive: 105>
+ replacementIndex := repStart.
+ index := start.
+ replacement isInteger ifTrue: [
+ "This branch is only here to accept SmallInteger replacements not handled by the primitive."
+ [ index <= stop ] whileTrue: [
+ self digitAt: index put: (replacement digitAt: replacementIndex).
+ index := index + 1.
+ replacementIndex := replacementIndex + 1 ].
+ ^self ].
+ "Primitive compatible variant which doesn't support SmallInteger replacements."
+ [ index <= stop ] whileTrue: [
+ self basicAt: index put: (replacement basicAt: replacementIndex).
+ index := index + 1.
+ replacementIndex := replacementIndex + 1 ]!
- ^ super replaceFrom: start to: stop with: replacement startingAt: repStart!
Patrick Rein uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-pre.343.mcz
==================== Summary ====================
Name: Tests-pre.343
Author: pre
Time: 19 May 2016, 6:24:26.418731 pm
UUID: e46cc1be-f541-4e22-b763-0cb981f3769f
Ancestors: Tests-pre.342
Reverts accidential change to the PackageDependencyTest which actually resides in the inbox
=============== Diff against Tests-pre.342 ===============
Item was changed:
----- Method: PackageDependencyTest>>testPreferenceBrowser (in category 'tests') -----
testPreferenceBrowser
self testPackage: #PreferenceBrowser dependsExactlyOn: #(
#'Chronology-Core'
Collections
Graphics
Kernel
Morphic
MorphicExtras
System
Tools
- #'ToolBuilder-Morphic'
- EToys
- Balloon
).!
Patrick Rein uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-pre.342.mcz
==================== Summary ====================
Name: Tests-pre.342
Author: pre
Time: 19 May 2016, 5:56:44.520731 pm
UUID: 9f7000bc-c8e8-497d-80cc-40ced18f376b
Ancestors: Tests-pre.341
As discussed several times on the mailing list the ExceptionTests>>testHandlerFromAction test is a feature request test and should be regarded as an expectedFailure.
=============== Diff against Tests-eem.340 ===============
Item was changed:
----- Method: ExceptionTests>>expectedFailures (in category 'testing-outer') -----
expectedFailures
+ "This test is a feature request. For more information on this issue visit:
+ http://forum.world.st/The-Inbox-Tests-TestRunner-156-mcz-tc4643910.html#a46…
+ http://forum.world.st/ExceptionTests-Wrong-error-handler-tc4848699.html
+ http://forum.world.st/ExceptionTests-gt-testHandlerFromAction-fails-tc48728…"
+
+ ^ #(testHandlerFromAction).!
- ^ #().!
Item was changed:
----- Method: PackageDependencyTest>>testPreferenceBrowser (in category 'tests') -----
testPreferenceBrowser
self testPackage: #PreferenceBrowser dependsExactlyOn: #(
#'Chronology-Core'
Collections
Graphics
Kernel
Morphic
MorphicExtras
System
Tools
+ #'ToolBuilder-Morphic'
+ EToys
+ Balloon
).!