Packages June 2018

packages@lists.squeakfoundation.org

1 participants
79 discussions

The Trunk: Kernel-eem.1181.mcz
by commits＠source.squeak.org 18 Jun '18

18 Jun '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1181.mcz ==================== Summary ==================== Name: Kernel-eem.1181 Author: eem Time: 17 June 2018, 4:48:17.581384 pm UUID: c1e480cd-6fb8-4810-af4b-0ac2298a044a Ancestors: Kernel-eem.1180 Move Context>>blockCopy: to deprecated (BlockContext is in deprecated). This breaks Kernel's dependency on deprecated. =============== Diff against Kernel-eem.1180 =============== Item was removed: - ----- Method: Context>>blockCopy: (in category 'controlling') ----- - blockCopy: numArgs - "Primitive. Distinguish a block of code from its enclosing method by - creating a new BlockContext for that block. The compiler inserts into all - methods that contain blocks the bytecodes to send the message - blockCopy:. Do not use blockCopy: in code that you write!! Only the - compiler can decide to send the message blockCopy:. Fail if numArgs is - not a SmallInteger. Optional. No Lookup. See Object documentation - whatIsAPrimitive." - - <primitive: 80> - ^ (BlockContext newForMethod: self method) - home: self home - startpc: pc + 2 - nargs: numArgs!

1 0

The Trunk: 60Deprecated-eem.22.mcz
by commits＠source.squeak.org 18 Jun '18

18 Jun '18

Eliot Miranda uploaded a new version of 60Deprecated to project The Trunk: http://source.squeak.org/trunk/60Deprecated-eem.22.mcz ==================== Summary ==================== Name: 60Deprecated-eem.22 Author: eem Time: 17 June 2018, 4:46:55.256723 pm UUID: 49040366-ae77-47cd-aaea-1574270b7780 Ancestors: 60Deprecated-pre.21 BlockContext is in deprecated. Add the only reference to it in Kernel (now an unsent message) to break the dependency. =============== Diff against 60Deprecated-pre.21 =============== Item was added: + ----- Method: Context>>blockCopy: (in category '*60Deprecated-controlling') ----- + blockCopy: numArgs + "Primitive. Distinguish a block of code from its enclosing method by + creating a new BlockContext for that block. The compiler inserts into all + methods that contain blocks the bytecodes to send the message + blockCopy:. Do not use blockCopy: in code that you write!! Only the + compiler can decide to send the message blockCopy:. Fail if numArgs is + not a SmallInteger. Optional. No Lookup. See Object documentation + whatIsAPrimitive." + + <primitive: 80> + ^ (BlockContext newForMethod: self method) + home: self home + startpc: pc + 2 + nargs: numArgs!

1 0

The Trunk: Graphics-eem.399.mcz
by commits＠source.squeak.org 18 Jun '18

18 Jun '18

Eliot Miranda uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-eem.399.mcz ==================== Summary ==================== Name: Graphics-eem.399 Author: eem Time: 17 June 2018, 3:49:31.430583 pm UUID: 06730754-91ab-4e8b-9461-8911c2feca0b Ancestors: Graphics-mt.398 Form>>hackBits: must use btyesPerBasicElement:, not bytesPerElement:, to not be confused by classes such as ShortIntegerArray which pack shorts into words. Note that on Spur this isn't necessary now that 16-bit indexability is supported directly. =============== Diff against Graphics-mt.398 =============== Item was changed: ----- Method: Form>>hackBits: (in category 'private') ----- hackBits: bitThing "This method provides an initialization so that BitBlt may be used, eg, to copy ByteArrays and other non-pointer objects efficiently. The resulting form looks 4 wide, 8 deep, and bitThing-size-in-words high." width := 4. depth := 8. bitThing class isBits ifFalse: [self error: 'bitThing must be a non-pointer object']. + height := bitThing basicSize * bitThing bytesPerBasicElement // width. - height := bitThing basicSize * bitThing bytesPerElement // width. bits := bitThing!

1 0

The Trunk: Tests-eem.401.mcz
by commits＠source.squeak.org 17 Jun '18

17 Jun '18

Eliot Miranda uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-eem.401.mcz ==================== Summary ==================== Name: Tests-eem.401 Author: eem Time: 17 June 2018, 2:52:24.947642 pm UUID: 070c7737-c1af-4b75-b796-a71f0e497af1 Ancestors: Tests-ul.400 Refactor the BitmapStreamTests to use assert:equals: to ease debugging the failing tests there-in. =============== Diff against Tests-ul.400 =============== Item was changed: ----- Method: BitmapStreamTests>>testOtherClasses (in category 'tests-misc') ----- testOtherClasses #(WordArrayForSegment FloatArray PointArray IntegerArray SoundBuffer String ShortPointArray ShortIntegerArray WordArray Array ByteArray Bitmap ColorArray ) do: [:s | | a | a := (Smalltalk at: s) new: 3. + self assert: a byteSize equals: a basicSize * a bytesPerBasicElement. ] - self assert: (a basicSize * a bytesPerBasicElement = a byteSize). ] ! Item was changed: ----- Method: BitmapStreamTests>>testShortIntegerArrayReadRefStream2 (in category 'tests-ShortIntegerArray') ----- testShortIntegerArrayReadRefStream2 | refStrm | refStrm := ReferenceStream on: #[20 6 17 83 104 111 114 116 73 110 116 101 103 101 114 65 114 114 97 121 0 0 0 2 0 0 0 1 0 2 0 3 ] readStream. + self assert: (ShortIntegerArray with: 0 with: 1 with: 2 with: 3) + equals: refStrm next! - self assert: (refStrm next = (ShortIntegerArray with: 0 with: 1 with: 2 with: 3)).! Item was changed: ----- Method: BitmapStreamTests>>testShortIntegerArrayWithRefStream2 (in category 'tests-ShortIntegerArray') ----- testShortIntegerArrayWithRefStream2 array := ShortIntegerArray with: 0 with: 1 with: 2 with: 3. self validateRefStream. + self + assert: #[20 6 17 83 104 111 114 116 73 110 116 101 103 101 114 65 114 114 97 121 0 0 0 2 0 0 0 1 0 2 0 3] + equals: stream byteStream contents - self assert: stream byteStream contents = #[20 6 17 83 104 111 114 116 73 110 116 101 103 101 114 65 114 114 97 121 0 0 0 2 0 0 0 1 0 2 0 3] ! Item was changed: ----- Method: BitmapStreamTests>>testShortIntegerArrayWithSmartRefStream2 (in category 'tests-ShortIntegerArray') ----- testShortIntegerArrayWithSmartRefStream2 array := ShortIntegerArray with: 0 with: 1 with: 2 with: 3. self validateSmartRefStream. + self assert: #[0 0 0 2 0 0 0 1 0 2 0 3 33 13 13] equals: (stream contents asByteArray last: 15) - self assert: (stream contents asByteArray last: 15) = #[0 0 0 2 0 0 0 1 0 2 0 3 33 13 13] ! Item was changed: ----- Method: BitmapStreamTests>>testShortPointArrayWithRefStream2 (in category 'tests-ShortPointArray') ----- testShortPointArrayWithRefStream2 array := ShortPointArray with: 0@1 with: 2@3. self validateRefStream. + self + assert: #[20 6 15 83 104 111 114 116 80 111 105 110 116 65 114 114 97 121 0 0 0 2 0 0 0 1 0 2 0 3] + equals: stream byteStream contents - self assert: stream byteStream contents = #[20 6 15 83 104 111 114 116 80 111 105 110 116 65 114 114 97 121 0 0 0 2 0 0 0 1 0 2 0 3 ] ! Item was changed: ----- Method: BitmapStreamTests>>testShortPointArrayWithSmartRefStream2 (in category 'tests-ShortPointArray') ----- testShortPointArrayWithSmartRefStream2 array := ShortPointArray with: 0@1 with: 2@3. self validateSmartRefStream. + self assert: #[0 0 0 2 0 0 0 1 0 2 0 3 33 13 13] equals: (stream contents asByteArray last: 15) - self assert: (stream contents asByteArray last: 15) = #[0 0 0 2 0 0 0 1 0 2 0 3 33 13 13 ] ! Item was changed: ----- Method: BitmapStreamTests>>testShortRunArrayWithSmartRefStream2 (in category 'tests-ShortRunArray') ----- testShortRunArrayWithSmartRefStream2 array := self createSampleShortRunArray. self validateSmartRefStream. + self assert: #[0 0 0 4 0 1 0 0 0 2 0 1 0 3 0 2 0 4 0 3 33 13 13] equals: (stream contents asByteArray last: 23) - self assert: (stream contents asByteArray last: 23) = #[0 0 0 4 0 1 0 0 0 2 0 1 0 3 0 2 0 4 0 3 33 13 13 ] ! Item was changed: ----- Method: BitmapStreamTests>>validateImageSegment (in category 'private') ----- validateImageSegment "array is set up with an array." | other filename | filename := 'bitmapStreamTest.extSeg'. FileDirectory default deleteFileNamed: filename ifAbsent: [ ]. (ImageSegment copyFromRootsForExport: {array}) writeForExport: filename. other := (FileDirectory default readOnlyFileNamed: filename) fileInObjectAndCode. + self assert: other originalRoots first equals: array. - self assert: array = other originalRoots first. "clean up disk" FileDirectory default deleteFileNamed: filename ifAbsent: [ ]! Item was changed: ----- Method: BitmapStreamTests>>validateRefStream (in category 'private') ----- validateRefStream "array is set up with an array." | other rwstream | rwstream := RWBinaryOrTextStream on: (ByteArray new: array basicSize * 6). stream := ReferenceStream on: rwstream. stream nextPut: array; close. rwstream position: 0. stream := ReferenceStream on: rwstream. other := stream next. stream close. + self assert: other equals: array! - self assert: array = other! Item was changed: ----- Method: BitmapStreamTests>>validateRefStreamOnDisk (in category 'private') ----- validateRefStreamOnDisk "array is set up with an array." | other filename | filename := 'bitmapStreamTest.ref'. FileDirectory default deleteFileNamed: filename ifAbsent: [ ]. stream := ReferenceStream fileNamed: filename. stream nextPut: array; close. stream := ReferenceStream fileNamed: filename. other := stream next. stream close. + self assert: other equals: array. - self assert: array = other. "clean up disk" FileDirectory default deleteFileNamed: filename ifAbsent: [ ]! Item was changed: ----- Method: BitmapStreamTests>>validateSmartRefStream (in category 'private') ----- validateSmartRefStream "array is set up with an array." | other | stream := RWBinaryOrTextStream on: (ByteArray new: array basicSize * 6). stream binary. stream fileOutClass: nil andObject: array. stream position: 0. stream binary. other := stream fileInObjectAndCode. + self assert: other equals: array! - self assert: array = other! Item was changed: ----- Method: BitmapStreamTests>>validateSmartRefStreamOnDisk (in category 'private') ----- validateSmartRefStreamOnDisk "array is set up with an array." | other filename | filename := 'bitmapStreamTest.ref'. FileDirectory default deleteFileNamed: filename ifAbsent: [ ]. stream := FileDirectory default fileNamed: filename. stream fileOutClass: nil andObject: array. stream close. stream := FileDirectory default fileNamed: filename. other := stream fileInObjectAndCode. stream close. + self assert: other equals: array. - self assert: array = other. "clean up disk" FileDirectory default deleteFileNamed: filename ifAbsent: [ ]!

1 0

The Trunk: Tools-eem.822.mcz
by commits＠source.squeak.org 17 Jun '18

17 Jun '18

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.822.mcz ==================== Summary ==================== Name: Tools-eem.822 Author: eem Time: 17 June 2018, 2:22:00.563889 pm UUID: 22ddf529-3821-4bed-b1cf-e74753d6d8f3 Ancestors: Tools-eem.821 Robustness for when a class is reoved from under the browser's feet. =============== Diff against Tools-eem.821 =============== Item was changed: ----- Method: Browser>>hasClassSelected (in category 'class list') ----- hasClassSelected + ^ selectedClassName notNil and: [(Smalltalk classNamed: selectedClassName) notNil]! - ^ selectedClassName notNil.!

1 0

The Trunk: Compiler-eem.387.mcz
by commits＠source.squeak.org 17 Jun '18

17 Jun '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.387.mcz ==================== Summary ==================== Name: Compiler-eem.387 Author: eem Time: 16 June 2018, 6:15:08.755516 pm UUID: 2a8c2667-3328-4cd4-a7c9-c98e04d6ddf2 Ancestors: Compiler-eem.386 Fix the decompiler for the full lock regime. There isn't much in the decompiler that directly refers to the method inst var (most accesses use self method, which answers the sender inst var of InstructionStream). But case statements is one of them (specifically myExits := myExits reject: [ :e | e isNil or: [ e < 0 or: [ e > method endPC ] ] ]). The bug was that doClosureCopy:copiedValues: was only setting up sender but not method and so case statements were mishandled within full blocks (e.g. in LanguageEditor>>asHtml:) becausde the wrong endPC was being used. =============== Diff against Compiler-eem.386 =============== Item was changed: ----- Method: Decompiler>>doClosureCopy:copiedValues: (in category 'control') ----- doClosureCopy: aCompiledBlock copiedValues: blockCopiedValues | savedTemps savedTempVarCount savedNumLocalTemps savedMethod savedPC blockArgs blockTemps blockTempsOffset block | savedTemps := tempVars. savedTempVarCount := tempVarCount. savedNumLocalTemps := numLocalTemps. numLocalTemps := aCompiledBlock numTemps - aCompiledBlock numArgs - blockCopiedValues size. blockTempsOffset := aCompiledBlock numArgs + blockCopiedValues size. (blockStartsToTempVars notNil "implies we were intialized with temp names." and: [blockStartsToTempVars includesKey: aCompiledBlock]) ifTrue: [tempVars := blockStartsToTempVars at: aCompiledBlock] ifFalse: [blockArgs := (1 to: aCompiledBlock numArgs) collect: [:i| (constructor codeTemp: i - 1 named: 't', (tempVarCount + i) printString) beBlockArg]. blockTemps := (1 to: numLocalTemps) collect: [:i| constructor codeTemp: i + blockTempsOffset - 1 named: 't', (tempVarCount + i + aCompiledBlock numArgs) printString]. tempVars := blockArgs, blockCopiedValues, blockTemps]. tempVarCount := tempVarCount + aCompiledBlock numArgs + numLocalTemps. savedMethod := self method. savedPC := pc. + super method: (method := aCompiledBlock) pc: aCompiledBlock initialPC. - super method: aCompiledBlock pc: aCompiledBlock initialPC. block := [self blockTo: aCompiledBlock endPC] + ensure: [super method: (method := savedMethod) pc: savedPC]. - ensure: [super method: savedMethod pc: savedPC]. stack addLast: ((constructor codeArguments: (tempVars copyFrom: 1 to: aCompiledBlock numArgs) temps: (tempVars copyFrom: blockTempsOffset + 1 to: blockTempsOffset + numLocalTemps) block: block) pc: aCompiledBlock -> pc; "c.f. BytecodeEncoder>>pc" yourself). tempVars := savedTemps. tempVarCount := savedTempVarCount. numLocalTemps := savedNumLocalTemps!

1 0

The Trunk: Compiler-eem.386.mcz
by commits＠source.squeak.org 17 Jun '18

17 Jun '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.386.mcz ==================== Summary ==================== Name: Compiler-eem.386 Author: eem Time: 16 June 2018, 5:46:30.6679 pm UUID: b7853f0c-81c4-46cf-bc35-b572d22887b7 Ancestors: Compiler-eem.385 Fix a number of failing decompilation tests due to the last statement of a block being known to answer nil by the compiler side. The root cause was my test in BlockNode>>printStatementsOn:indent: that assumed that blocks with arguments never answered nil. =============== Diff against Compiler-eem.385 =============== Item was changed: ----- Method: BlockNode>>printStatementsOn:indent: (in category 'printing') ----- printStatementsOn: aStream indent: levelOrZero | len shown thisStatement level | level := 1 max: levelOrZero. + comment ifNotNil: + [self printCommentOn: aStream indent: level. + aStream crtab: level]. - comment == nil - ifFalse: - [self printCommentOn: aStream indent: level. - aStream crtab: level]. len := shown := statements size. (levelOrZero = 0 "top level" and: [statements last isReturnSelf]) ifTrue: [shown := 1 max: shown - 1] + ifFalse: ["should a trailing nil be printed or not? Not if it is an implicit result, not if the last statement answers nil." + ((arguments size > 0 and: [len = 0]) + or: [(statements at: len) == NodeNil + and: [len = 1 + or: [len > 1 + and: [(statements at: len - 1) isMessageNode + and: [(statements at: len - 1) isNilIf + or: [(statements at: len - 1) isOptimizedWhileLoop]]]]]]) - ifFalse: ["should a trailing nil be printed or not? Not if it is an implicit result." - (arguments size = 0 - and: [len >= 1 - and: [(statements at: len) == NodeNil - and: [len = 1 - or: [len > 1 - and: [(statements at: len - 1) isMessageNode - and: [(statements at: len - 1) isNilIf]]]]]]) ifTrue: [shown := shown - 1]]. 1 to: shown do: [:i | thisStatement := statements at: i. thisStatement printOn: aStream indent: level. i < shown ifTrue: [aStream nextPut: $.; crtab: level]. (thisStatement comment ~~ nil and: [thisStatement comment size > 0]) ifTrue: [i = shown ifTrue: [aStream crtab: level]. thisStatement printCommentOn: aStream indent: level. i < shown ifTrue: [aStream crtab: level]]]! Item was added: + ----- Method: MessageNode>>isOptimizedWhileLoop (in category 'testing') ----- + isOptimizedWhileLoop + ^special > 0 + and: [#(transformWhile: transformRepeat:) includes: (MacroTransformers at: special)]!

1 0

The Trunk: Compiler-eem.385.mcz
by commits＠source.squeak.org 17 Jun '18

17 Jun '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.385.mcz ==================== Summary ==================== Name: Compiler-eem.385 Author: eem Time: 16 June 2018, 4:29:33.44317 pm UUID: 07c5fc8e-5463-4db6-912a-fdc0125ce7df Ancestors: Compiler-eem.384 The scanner for spotting closure creation bytecodes in methods must identify full block closure creations. =============== Diff against Compiler-eem.384 =============== Item was changed: ----- Method: EncoderForSistaV1 class>>createClosureScanBlock (in category 'compiled method support') ----- createClosureScanBlock "Answer a block argument for InstructionStream>>scanFor: that answers true + for block closure creation bytecodes. Note that with this interface we can't answer - for block closure creation bytecodes. ote that with this interface we can't answer true for the extension in front of a push closure bytecode and so the interface may have to change at some point." + "* 224 11100000 aaaaaaaa Extend A (Ext A = Ext A prev * 256 + Ext A) + * 225 11100001 bbbbbbbb Extend B (Ext B = Ext B prev * 256 + Ext B) + ** 249 11111001 xxxxxxxx siyyyyyy push Closure Compiled block literal index xxxxxxxx (+ Extend A * 256) numCopied yyyyyy receiverOnStack: s = 1 ignoreOuterContext: i = 1 + ** 250 11111010 eeiiikkk jjjjjjjj Push Closure Num Copied iii (+ExtA//16*8) Num Args kkk (+ ExtA\\16*8) BlockSize jjjjjjjj (+ExtB*256). ee = num extensions" + ^[:b| b >= 249 and: [b <= 250]]! - "* 224 11100000 aaaaaaaa Extend A (Ext A = Ext A prev * 256 + Ext A) - * 225 11100001 bbbbbbbb Extend B (Ext B = Ext B prev * 256 + Ext B) - ** 250 11111010 eeiiikkk jjjjjjjj Push Closure Num Copied iii (+ExtA//16*8) Num Args kkk (+ ExtA\\16*8) BlockSize jjjjjjjj (+ExtB*256). ee = num extensions" - ^[:b| b = 250]!

1 0

The Trunk: Kernel-eem.1180.mcz
by commits＠source.squeak.org 17 Jun '18

17 Jun '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1180.mcz ==================== Summary ==================== Name: Kernel-eem.1180 Author: eem Time: 16 June 2018, 4:25:25.529049 pm UUID: 5c0c1399-ebc8-4f60-aa94-a11fe33553d7 Ancestors: Kernel-eem.1179 No need to scan the last two literals when updating in postCopy. =============== Diff against Kernel-eem.1179 =============== Item was changed: ----- Method: CompiledMethod>>postCopy (in category 'copying') ----- postCopy | penultimateLiteral | (penultimateLiteral := self penultimateLiteral) isMethodProperties ifTrue: [self penultimateLiteral: penultimateLiteral copy]. self encoderClass supportsFullBlocks ifTrue: + [1 to: self numLiterals - 2 do: - [1 to: self numLiterals do: [:index| | lit | (lit := self literalAt: index) isCompiledCode ifTrue: [lit outerCode: self; postCopy]]]!

1 0

The Trunk: Kernel-eem.1179.mcz
by commits＠source.squeak.org 17 Jun '18

17 Jun '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1179.mcz ==================== Summary ==================== Name: Kernel-eem.1179 Author: eem Time: 16 June 2018, 3:48:39.465427 pm UUID: 6fef2fe4-bb58-4546-a532-eb7da951cc4c Ancestors: Kernel-eem.1178 Fix copying of methods containing full blocks. After creating the copy, full blocks need to update their outerCode to the copy, otherwise they are left pointing at the original. Symptom: debugging a doit with full blocks, as soon as one steps into a block temp names disappear because the original gets copied with temp names, but any contained block method doesn't update to refer to the copy holding temp names, remaining referring to the original that has no temp names. =============== Diff against Kernel-eem.1178 =============== Item was added: + ----- Method: CompiledBlock>>postCopy (in category 'copying') ----- + postCopy + 1 to: self numLiterals - 1 do: + [:index| | lit | + (lit := self literalAt: index) isCompiledCode ifTrue: + [lit outerCode: self; postCopy]]! Item was changed: ----- Method: CompiledMethod>>postCopy (in category 'copying') ----- postCopy | penultimateLiteral | (penultimateLiteral := self penultimateLiteral) isMethodProperties ifTrue: + [self penultimateLiteral: penultimateLiteral copy]. + self encoderClass supportsFullBlocks ifTrue: + [1 to: self numLiterals do: + [:index| | lit | + (lit := self literalAt: index) isCompiledCode ifTrue: + [lit outerCode: self; postCopy]]]! - [self penultimateLiteral: penultimateLiteral copy]!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Packages June 2018