Packages July 2018

packages@lists.squeakfoundation.org

1 participants
49 discussions

The Trunk: KernelTests-eem.344.mcz
by commits＠source.squeak.org 27 Jul '18

27 Jul '18

Eliot Miranda uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-eem.344.mcz ==================== Summary ==================== Name: KernelTests-eem.344 Author: eem Time: 26 July 2018, 8:43:56.697782 pm UUID: 59075a46-0387-4cec-a4a3-0f224c9e0f0d Ancestors: KernelTests-ul.343 Tests for Mutex that parallel SemaphoreTest =============== Diff against KernelTests-ul.343 =============== Item was added: + ClassTestCase subclass: #MutexTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Processes'! + + !MutexTest commentStamp: 'eem 7/26/2018 20:42' prior: 0! + MutexTest provides SUnit tests for Mutex locks. c.f. SemaphoreTest.! Item was added: + ----- Method: MutexTest>>criticalError (in category 'private') ----- + criticalError + Processor activeProcess terminate! Item was added: + ----- Method: MutexTest>>testCritical (in category 'testing') ----- + testCritical + | lock | + lock := Mutex new. + [lock critical: [self criticalError]] forkAt: Processor userInterruptPriority. + self deny: lock isOwned! Item was added: + ----- Method: MutexTest>>testCriticalIfError (in category 'testing') ----- + testCriticalIfError + | lock | + lock := Mutex new. + [lock critical: [self criticalError ifError: []]] forkAt: Processor userInterruptPriority. + self deny: lock isOwned! Item was added: + ----- Method: MutexTest>>testMutexAfterCriticalWait (in category 'testing') ----- + testMutexAfterCriticalWait "self run: #testMutexAfterCriticalWait" + "This tests whether a process that has just left the primitiveEnterCriticalSection in Mutex>>critical: + leaves it with the mutex correctly released." + | lock p | + lock := Mutex new. + p := [lock critical: []] newProcess. + p priority: Processor activePriority - 1. + lock critical: "We now own it; p can't enter properly" + [p resume. + "wait until p enters the critical section; it doesn't own the Mutex so is blocked..." + [p suspendingList == lock] whileFalse: [(Delay forMilliseconds: 10) wait]. + self deny: lock isEmpty]. + "p is waiting on lock; on our exiting critical: p is now the notional owner. Terminate before it has a chance to run". + p terminate. + self deny: lock isOwned. + self assert: lock isEmpty! Item was added: + ----- Method: MutexTest>>testMutexInCriticalWait (in category 'testing') ----- + testMutexInCriticalWait "self run: #testMutexInCriticalWait" + "This tests whether a mutex that has got past the primitiveEnterCriticalSection in Mutex>>critical: + leaves it unowned." + | lock sock proc | + lock := Mutex new. + sock := Semaphore new. + proc := [lock critical: [sock wait]] fork. + Processor yield. + self assert: proc suspendingList == sock. + proc terminate. + self deny: lock isOwned. + self assert: lock isEmpty!

1 0

The Trunk: Kernel-eem.1182.mcz
by commits＠source.squeak.org 27 Jul '18

27 Jul '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1182.mcz ==================== Summary ==================== Name: Kernel-eem.1182 Author: eem Time: 26 July 2018, 8:33:34.998936 pm UUID: 4d10c2e2-c1b7-4ba0-b208-b018f0f099e9 Ancestors: Kernel-eem.1181 Add an accessor for Mutex being owned, for use in tests. =============== Diff against Kernel-eem.1181 =============== Item was added: + ----- Method: Mutex>>isOwned (in category 'testing') ----- + isOwned + "Answer if the receiver is owned. DO NOT USE THIS IN NORMAL CODE. + This exists for the MutexTests so they don't have to use e.g. instVarNamed:. + N.B. don't use notNil because that is a real send and preemptable." + ^nil ~~ owner!

1 0

The Trunk: Collections-cmm.803.mcz
by commits＠source.squeak.org 26 Jul '18

26 Jul '18

Chris Muller uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-cmm.803.mcz ==================== Summary ==================== Name: Collections-cmm.803 Author: cmm Time: 26 July 2018, 4:01:33.780963 pm UUID: d6d9dcd4-56c1-4242-9bf8-18d2caa66516 Ancestors: Collections-dtl.802, Collections-cmm.801 Merge. =============== Diff against Collections-dtl.802 =============== Item was changed: ----- Method: Text class>>string:runs: (in category 'private') ----- string: aString runs: anArray + ^self basicNew setString: aString setRuns: anArray! - ^self basicNew setString: aString setRunsChecking: anArray! Item was changed: ----- Method: Text>>setString:setRunsChecking: (in category 'private') ----- setString: aString setRunsChecking: aRunArray + "Check runs and do the best you can to make them fit..." + - | stringSize runsSize | string := aString. + "check the runs" aRunArray ifNil: [^ aString asText]. + (aRunArray isKindOf: RunArray) ifFalse: [^ aString asText]. + aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. + aRunArray size = aString size ifFalse: [^ aString asText]. + runs := aRunArray.! - "Check runs and do the best you can to make them fit..." - aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. "raise error here?" - runsSize := aRunArray size. - stringSize := string size. - runs := stringSize = runsSize - ifTrue: [aRunArray] - ifFalse: [ stringSize > runsSize - ifTrue: [aRunArray addLast: {} times: stringSize - runsSize] - ifFalse: [aRunArray copyFrom: 1 to: stringSize]].!

1 0

The Trunk: Tools-eem.827.mcz
by commits＠source.squeak.org 26 Jul '18

26 Jul '18

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.827.mcz ==================== Summary ==================== Name: Tools-eem.827 Author: eem Time: 25 July 2018, 3:12:22.772831 pm UUID: 005a00a2-4a38-4aa5-b361-569231851539 Ancestors: Tools-cmm.826 Implement tempsAndValues in ContextVariablesInspector, allowing 'all temp vars' to display integers in the default integer base. [Leave Context>>tempsAndValues for now; someone can clean up the duplication later if desired.] =============== Diff against Tools-cmm.826 =============== Item was changed: ----- Method: ContextVariablesInspector>>selection (in category 'selecting') ----- selection "Refer to the comment in Inspector|selection." + ^selectionIndex + caseOf: { + [0] -> ['']. + [1] -> [object]. + [2] -> [object actualStackSize > 0 ifTrue: [object top] ifFalse: ['']]. + [3] -> [self tempsAndValues] } + otherwise: + [object debuggerMap namedTempAt: selectionIndex - 3 in: object]! - selectionIndex = 0 ifTrue:[^'']. - selectionIndex = 1 ifTrue: [^object]. - selectionIndex = 2 ifTrue: [^object actualStackSize > 0 ifTrue: [object top] ifFalse: ['']]. - selectionIndex = 3 ifTrue: [^object tempsAndValues]. - ^object debuggerMap namedTempAt: selectionIndex - 3 in: object! Item was added: + ----- Method: ContextVariablesInspector>>tempsAndValues (in category 'selecting') ----- + tempsAndValues + "Answer a string of the temporary variables and their current values" + | debuggerMap integerClasses aStream | + aStream := WriteStream on: (String new: 100). + debuggerMap := object debuggerMap. + integerClasses := Integer allSubclasses. + (debuggerMap tempNamesForContext: object) doWithIndex: + [:title :index | | temp | + aStream nextPutAll: title; nextPut: $:; space; tab. + temp := debuggerMap namedTempAt: index in: object. + (integerClasses identityIndexOf: (object objectClass: temp)) ~= 0 + ifTrue: [temp storeOn: aStream base: self defaultIntegerBase] + ifFalse: [object print: temp on: aStream]. + aStream cr]. + ^aStream contents!

1 0

The Trunk: Graphics-tpr.400.mcz
by commits＠source.squeak.org 23 Jul '18

23 Jul '18

tim Rowledge uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-tpr.400.mcz ==================== Summary ==================== Name: Graphics-tpr.400 Author: tpr Time: 23 July 2018, 11:09:20.311791 am UUID: 83d0ab30-01d7-4753-9fee-577471f5cd22 Ancestors: Graphics-eem.399 Update the font summary string to a Text with appropriate font settings that match the name of the font being described. It doesn't show up in the help browser correctly because of problems as described in http://forum.world.st/Improving-SqueakToolsHelp-class-fontSizeSummary-revea… When we fix that, the fonts summary will magically look better. =============== Diff against Graphics-eem.399 =============== Item was changed: ----- Method: TextStyle class>>fontSizeSummaryContents (in category 'utilities') ----- fontSizeSummaryContents + ^ Text streamContents: - ^ String streamContents: [:aStream | self knownTextStyles do: [:aStyleName | aStream nextPutAll: + (aStyleName asText addAttribute: (TextFontReference toFont: (TextStyle named: aStyleName) defaultFont)), ' ', - aStyleName, ' ', (self fontPointSizesFor: aStyleName) asArray storeString. aStream cr]].!

1 0

The Trunk: Graphics-tpr.400.mcz
by commits＠source.squeak.org 23 Jul '18

23 Jul '18

1 0

The Trunk: Morphic-kfr.1460.mcz
by commits＠source.squeak.org 22 Jul '18

22 Jul '18

Karl Ramberg uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-kfr.1460.mcz ==================== Summary ==================== Name: Morphic-kfr.1460 Author: kfr Time: 22 July 2018, 10:25:54.130642 am UUID: de03a3c8-ca7e-3e44-b5f1-8cb9dc1a576f Ancestors: Morphic-dtl.1459 Fix TheWorldMainDockingBar preferences showing menus. Add 'collapse all windows' to Windows menu Add MethodFinder to Tools Menu =============== Diff against Morphic-dtl.1459 =============== Item was changed: ----- Method: TheWorldMainDockingBar class>>setMenuPreference:to: (in category 'preferences') ----- setMenuPreference: aPreferenceSymbol to: aBoolean | project | (project := Project current) isMorphic ifTrue: [ project projectPreferenceFlagDictionary at: aPreferenceSymbol put: aBoolean. + (aBoolean ~= (Preferences preferenceAt: aPreferenceSymbol)) - (aBoolean ~= (Preferences perform: aPreferenceSymbol)) ifTrue: [Preferences setPreference: aPreferenceSymbol toValue: aBoolean]]. self updateInstances.! Item was changed: ----- Method: TheWorldMainDockingBar>>listWindowsOn: (in category 'submenu - windows') ----- listWindowsOn: menu | windows | windows := self allVisibleWindows sorted: [:winA :winB | ((winA model isNil or: [winB model isNil]) or: [winA model name = winB model name]) ifTrue: [winA label < winB label] ifFalse: [winA model name < winB model name]]. windows ifEmpty: [ menu addItem: [ :item | item contents: 'No Windows' translated; isEnabled: false ] ]. windows do: [ :each | | windowColor | windowColor := (each model respondsTo: #windowColorToUse) ifTrue: [each model windowColorToUse] ifFalse: [UserInterfaceTheme current get: #uniformWindowColor for: Model]. menu addItem: [ :item | item contents: (self windowMenuItemLabelFor: each); icon: (self colorIcon: windowColor); target: each; selector: #comeToFront; subMenuUpdater: self selector: #windowMenuFor:on: arguments: { each }; action: [ each beKeyWindow; expand ] ] ]. menu addLine; + add: 'Collapse all windows' target: (Project current world) selector: #collapseAllWindows; add: 'Close all windows' target: self selector: #closeAllWindowsUnsafe; addItem: [:item | item contents: 'Close all windows without changes'; target: self; icon: MenuIcons smallBroomIcon; selector: #closeAllWindows]; add: 'Close all windows but workspaces' target: self selector: #closeAllWindowsButWorkspaces.! Item was added: + ----- Method: TheWorldMainDockingBar>>messageNamesMenuItemOn: (in category 'submenu - tools') ----- + messageNamesMenuItemOn: menu + + menu addItem: [:item | + item + contents: 'Message Names' translated; + help: 'Open the Message Names tool' translated; + icon: (self colorIcon: MessageNames basicNew windowColorToUse); + target: StandardToolSet; + selector: #openMessageNames]! Item was changed: ----- Method: TheWorldMainDockingBar>>toolsMenuOn: (in category 'construction') ----- toolsMenuOn: aDockingBar aDockingBar addItem: [ :item | item contents: 'Tools' translated; addSubMenu: [ :menu | self browserMenuItemOn: menu; workspaceMenuItemOn: menu; transcriptMenuItemOn: menu; testRunnerMenuItemOn: menu; + methodFinderMenuItemOn: menu; + messageNamesMenuItemOn: menu. - methodFinderMenuItemOn: menu. menu addLine. self monticelloBrowserMenuItemOn: menu; monticelloConfigurationsMenuItemOn: menu; simpleChangeSorterMenuItemOn: menu; dualChangeSorterMenuItemOn: menu. menu addLine. self processBrowserMenuItemOn: menu; preferenceBrowserMenuItemOn: menu; fileListMenuItemOn: menu. ] ]!

1 0

The Trunk: Collections-dtl.802.mcz
by commits＠source.squeak.org 19 Jul '18

19 Jul '18

David T. Lewis uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-dtl.802.mcz ==================== Summary ==================== Name: Collections-dtl.802 Author: dtl Time: 19 July 2018, 12:40:11.186143 am UUID: 95497d30-f52f-4f82-ac8c-3e65cfa30df1 Ancestors: Collections-cmm.801 Change Text class>>string:runs: to call setString:setRunsChecking: instead of setString:setRuns: to prevent creating a Text with run length not matching string length. This fixes the problem originally reported by Tim Johnson in http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-July/199461.html Add patch by K K Subbu to fix instantiating text when the string and the runarray are of mismatched lengths. This allows a filein to retain text attributes even if the runarray does not match the string length, as may be the case for a fileIn that had been edited externally (otherwise the text will be converted to a string without the intended attributes). Name: Collections-kks.803 Author: kks Time: 14 July 2018, 11:14:34.247017 pm UUID: c6ea08ba-fcdd-46f8-89c0-c61d0d524531 Ancestors: Collections-dtl.802 Attempt to retain as much styling as possible while filing in text from streams where the runs may fall short or extend beyond the string. Based on Bob's suggestions at http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-July/199530.html =============== Diff against Collections-cmm.801 =============== Item was changed: ----- Method: Text class>>string:runs: (in category 'private') ----- string: aString runs: anArray + ^self basicNew setString: aString setRunsChecking: anArray! - ^self basicNew setString: aString setRuns: anArray! Item was changed: ----- Method: Text>>setString:setRunsChecking: (in category 'private') ----- setString: aString setRunsChecking: aRunArray + | stringSize runsSize | - "Check runs and do the best you can to make them fit..." - string := aString. - "check the runs" aRunArray ifNil: [^ aString asText]. - (aRunArray isKindOf: RunArray) ifFalse: [^ aString asText]. - aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. - aRunArray size = aString size ifFalse: [^ aString asText]. + "Check runs and do the best you can to make them fit..." + aRunArray runs size = aRunArray values size ifFalse: [^ aString asText]. "raise error here?" + runsSize := aRunArray size. + stringSize := string size. + runs := stringSize = runsSize + ifTrue: [aRunArray] + ifFalse: [ stringSize > runsSize + ifTrue: [aRunArray addLast: {} times: stringSize - runsSize] + ifFalse: [aRunArray copyFrom: 1 to: stringSize]].! - runs := aRunArray.!

1 0

The Trunk: CollectionsTests-dtl.293.mcz
by commits＠source.squeak.org 19 Jul '18

19 Jul '18

David T. Lewis uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-dtl.293.mcz ==================== Summary ==================== Name: CollectionsTests-dtl.293 Author: dtl Time: 19 July 2018, 12:41:00.027981 am UUID: 4671abff-5dac-4ad8-b907-7afbbdf39fe6 Ancestors: CollectionsTests-cmm.292 Unit tests to cover text creation from a fileIn or from parameters when the length of the text string does not match the length of the associated runarray. These tests cover the enhancement from Collections-kks.803 (treated inbox, and included in Collections-dtl.802 in trunk). =============== Diff against CollectionsTests-cmm.292 =============== Item was added: + ----- Method: TextTest>>testSetStringSetRunsChecking (in category 'tests runs checking') ----- + testSetStringSetRunsChecking + "Normal case of creating a Text from a string and a run array with matching size" + + | aString runs aText newText | + aString := 'The best way to predict the future'. + runs := (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self assert: aString size = runs size. + + aText := (Text string: 'The best way to predict the future' runs: (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself))). + + newText := Text basicNew setString: aString setRunsChecking: runs. + self assert: newText equals: aText. + self assert: newText runs size = aString size. + self assert: runs equals: newText runs. + self assert: 6 equals: aText runs values size. + self assert: 6 equals: newText runs values size. + + + ! Item was added: + ----- Method: TextTest>>testSetStringSetRunsCheckingLongRuns (in category 'tests runs checking') ----- + testSetStringSetRunsCheckingLongRuns + "Creating text from a string and a long run array should create a valid Text instance, + and should retain text styling if possible." + + | aString aText newText lastRunTooLong oneRunTooMany | + aString := 'The best way to predict the future'. + lastRunTooLong := (RunArray runs: #(4 4 8 7 5 100) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self deny: aString size = lastRunTooLong size. + + oneRunTooMany := (RunArray runs: #(4 4 8 7 5 6 4) values: ((Array new: 7) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 7 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself)). + + self deny: aString size = oneRunTooMany size. + + aText := (Text string: 'The best way to predict the future' runs: (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself))). + + self assert: 6 equals: aText runs values size. + + newText := Text basicNew setString: aString setRunsChecking: lastRunTooLong. + self assert: newText equals: aText. + self assert: newText runs size = aString size. + self assert: 6 equals: newText runs values size. + + newText := Text basicNew setString: aString setRunsChecking: oneRunTooMany. + self assert: newText equals: aText. + self assert: newText runs size = aString size. + self assert: 6 equals: newText runs values size. + + + + ! Item was added: + ----- Method: TextTest>>testSetStringSetRunsCheckingShortRuns (in category 'tests runs checking') ----- + testSetStringSetRunsCheckingShortRuns + "Creating text from a string and a short run array should create a valid Text instance, + and should retain text styling if possible." + + | aString aText newText lastRunTooShort missingLastRun | + aString := 'The best way to predict the future'. + lastRunTooShort := (RunArray runs: #(4 4 8 7 5 1) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self deny: aString size = lastRunTooShort size. + + missingLastRun := (RunArray runs: #(4 4 8 7 5) values: ((Array new: 5) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); yourself)). + + self deny: aString size = missingLastRun size. + + aText := (Text string: 'The best way to predict the future' runs: (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself))). + + self assert: 6 equals: aText runs values size. + + "Compensate for short run array, either by adding a run or by extending length + of the last run. In either case, the run array should have size of 6 or greater, not + size 1 as would be the case if the text formatting had been discarded." + newText := Text basicNew setString: aString setRunsChecking: lastRunTooShort. + self assert: newText equals: aText. + self assert: newText runs size = aString size. + self assert: newText runs values size >= 6. + self assert: 7 equals: newText runs values size. "add one run to account for missing run length" + + newText := Text basicNew setString: aString setRunsChecking: missingLastRun. + self assert: newText equals: aText. "n.b. Two Texts are considered equal if they have the same characters" + self assert: newText runs size = aString size. + self assert: 6 equals: newText runs values size. + + + ! Item was added: + ----- Method: TextTest>>testWriteReadChunk (in category 'tests fileIn/Out') ----- + testWriteReadChunk + "Create a text from string and runs with matching lenghts. Verify that writing to + chunk format and reading from that chunk results in a copy of the original text." + + | aString runs aText chunk readFromChunk | + aString := 'The best way to predict the future'. + runs := (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self assert: aString size = runs size. + aText := Text basicNew setString: aString setRunsChecking: runs. + chunk := '' writeStream nextChunkPutWithStyle: aText; yourself; contents. + readFromChunk := UTF8TextConverter new nextChunkTextFromStream: (ReadStream on: chunk). + + self assert: readFromChunk equals: aText. + self assert: readFromChunk runs size = aString size. + self assert: runs equals: readFromChunk runs. + self assert: 6 equals: aText runs values size. + self assert: 6 equals: readFromChunk runs values size. + ! Item was added: + ----- Method: TextTest>>testWriteReadChunkShortRunCount (in category 'tests fileIn/Out') ----- + testWriteReadChunkShortRunCount + "Create a text from string and runs, where the string length is less than the + runs length. This is a condition that might occur if a chunk fileout was edited + by hand, leaving runs that extend beyond the bounds of the run array. In this + case, the fileIn should result in a reasonable Text instance without errors related + to the runs that exceed the string length." + + | aString runs aText chunk readFromChunk | + aString := 'The best way to predict'. " the future". + runs := (RunArray runs: #(4 4 8 7 5) values: ((Array new: 5) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); yourself)). + + self deny: aString size = runs size. + aText := Text basicNew setString: aString setRunsChecking: runs. + chunk := '' writeStream nextChunkPutWithStyle: aText; yourself; contents. + readFromChunk := UTF8TextConverter new nextChunkTextFromStream: (ReadStream on: chunk). + + self assert: readFromChunk equals: aText. + self assert: readFromChunk runs size = aString size. + self assert: readFromChunk runs size > 1. + self assert: 4 equals: aText runs values size. + self assert: 4 equals: readFromChunk runs values size. + ! Item was added: + ----- Method: TextTest>>testWriteReadChunkShortRunLength (in category 'tests fileIn/Out') ----- + testWriteReadChunkShortRunLength + "Create a text from string and runs, where the run length is less than the string + length. The fileIn should result in a reasonable Text instance without errors related + to the run length mismatch." + + | aString runs aText chunk readFromChunk | + aString := 'The best way to predict the future'. + runs := (RunArray runs: #(4 4 8 7 5 1) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self deny: aString size = runs size. + aText := Text basicNew setString: aString setRunsChecking: runs. + chunk := '' writeStream nextChunkPutWithStyle: aText; yourself; contents. + readFromChunk := UTF8TextConverter new nextChunkTextFromStream: (ReadStream on: chunk). + + self assert: readFromChunk equals: aText. + self assert: readFromChunk runs size = aString size. + self assert: readFromChunk runs size > 1. + self assert: aText runs values size equals: readFromChunk runs values size. + ! Item was added: + ----- Method: TextTest>>testWriteReadChunkShortString (in category 'tests fileIn/Out') ----- + testWriteReadChunkShortString + "Create a text from string and runs, where the run entries are fewer than required + to match the string length. The fileIn should result in a reasonable Text instance + without errors related to the run length mismatch." + + | aString runs aText chunk readFromChunk | + aString := 'The best way to predict the future'. + runs := (RunArray runs: #(4 4 8 7 5 6) values: ((Array new: 6) at: 1 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 1; yourself); yourself); at: 2 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 3 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 3; yourself); yourself); at: 4 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); at: 5 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 4; yourself); yourself); at: 6 put: ((Array new: 1) at: 1 put: (TextFontChange basicNew instVarAt: 1 put: 2; yourself); yourself); yourself)). + + self assert: aString size = runs size. + aText := Text basicNew setString: aString setRunsChecking: runs. + chunk := '' writeStream nextChunkPutWithStyle: aText; yourself; contents. + readFromChunk := UTF8TextConverter new nextChunkTextFromStream: (ReadStream on: chunk). + + self assert: readFromChunk equals: aText. + self assert: readFromChunk runs size = aString size. + self assert: readFromChunk runs size > 1. + self assert: aText runs values size equals: readFromChunk runs values size. + !

1 0

The Trunk: CollectionsTests-cmm.292.mcz
by commits＠source.squeak.org 15 Jul '18

15 Jul '18

Chris Muller uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-cmm.292.mcz ==================== Summary ==================== Name: CollectionsTests-cmm.292 Author: cmm Time: 15 July 2018, 4:35:41.160412 pm UUID: 8202d04e-6911-4849-8fe8-d2171640b1e3 Ancestors: CollectionsTests-dtl.291 It turns out better and more consistent for String>>#condensedIntoOneLine to do a uniform conversion than trimBlanks. =============== Diff against CollectionsTests-dtl.291 =============== Item was changed: ----- Method: StringTest>>testCondensedIntoOneLine (in category 'tests - converting') ----- testCondensedIntoOneLine + self assert: ' abc d ' condensedIntoOneLine = ' abc d '. - self assert: ' abc d ' condensedIntoOneLine = 'abc d'. self assert: ' (2 to: 10 by: 2) + ' condensedIntoOneLine = ' (2 to: 10 by: 2) '. - ' condensedIntoOneLine = '(2 to: 10 by: 2)'. "all blanks" self assert: (((0 to: 255) collect: [ : each | each asCharacter ] + thenSelect: [ : each | each isSeparator ]) as: String) condensedIntoOneLine = String space. - thenSelect: [ : each | each isSeparator ]) as: String) condensedIntoOneLine = String empty. "no blanks" self assert: 'abcd' condensedIntoOneLine = 'abcd'. + "Ensure every 'abcd' in this CompiledMethod is the same one for validity of next assertion." - "Ensure every 'abcd' in this CompiledMethod is the same one." self assert: 'abcd' == 'abcd'. "supposed to always copy no matter what" self assert: 'abcd' condensedIntoOneLine ~~ 'abcd'!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Packages July 2018