Packages November 2019

packages@lists.squeakfoundation.org

1 participants
135 discussions

The Trunk: Tests-mt.423.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-mt.423.mcz ==================== Summary ==================== Name: Tests-mt.423 Author: mt Time: 22 November 2019, 11:30:50.652303 am UUID: 0048a1fb-aa80-ad40-a372-764aee7c7c9b Ancestors: Tests-mt.422 Adds tests for Warning. =============== Diff against Tests-mt.422 =============== Item was added: + TestCase subclass: #WarningTests + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-Exceptions'! Item was added: + ----- Method: WarningTests>>tearDown (in category 'running') ----- + tearDown + + Warning resetAllWarnings. + super tearDown.! Item was added: + ----- Method: WarningTests>>test01Signal (in category 'tests') ----- + test01Signal + + self should: [Warning signal] raise: Warning.! Item was added: + ----- Method: WarningTests>>test02Resume (in category 'tests') ----- + test02Resume + + self + assert: 42 + equals: ([Warning signal] on: Warning do: [:w | w resume: 42]).! Item was added: + ----- Method: WarningTests>>test03MessageText (in category 'tests') ----- + test03MessageText + + self + assert: 'Hello, World!!' + equals: ([Warning signal: 'Hello, World!!'] on: Warning do: [:w | w messageText]).! Item was added: + ----- Method: WarningTests>>test04SuppressWarnings (in category 'tests') ----- + test04SuppressWarnings + + self should: [Warning signal] raise: Warning. + Warning suppressWarnings. + self shouldnt: [Warning signal] raise: Warning.! Item was added: + ----- Method: WarningTests>>test05SuppressAndResetOnStartUp (in category 'tests') ----- + test05SuppressAndResetOnStartUp + + self should: [Warning signal] raise: Warning. + Warning suppressAndResetOnStartUp. + self shouldnt: [Warning signal] raise: Warning. + Warning startUp: true. + self should: [Warning signal] raise: Warning.! Item was added: + ----- Method: WarningTests>>test06SuppressDeprecations (in category 'tests') ----- + test06SuppressDeprecations + + self should: [self deprecated] raise: Deprecation. + Deprecation suppressWarnings. + self shouldnt: [self deprecated] raise: Deprecation.!

1 0

The Trunk: Compiler-ct.404.mcz
by commits＠source.squeak.org 21 Nov '19

21 Nov '19

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.404.mcz ==================== Summary ==================== Name: Compiler-ct.404 Author: ct Time: 17 June 2019, 10:51:02.869037 pm UUID: 19e019f5-3ff6-0143-926d-e29c155cc4be Ancestors: Compiler-eem.403 Fix a defect in Parser>>#parseCue:noPattern:ifFail: Full failure case description: Run the following statement: Compiler evaluate: '''''''' In the appearing error window, enter any valid smalltalk expression and save it. Before loading this commit, it will give you a NonBooleanError as doItFlag was set too late (and so was not passed to SyntaxErrorNotification). =============== Diff against Compiler-eem.403 =============== Item was changed: ----- Method: Parser>>parseCue:noPattern:ifFail: (in category 'public access') ----- parseCue: aCue noPattern: noPattern ifFail: aBlock "Answer a MethodNode for the argument, sourceStream, that is the root of a parse tree. Parsing is done with respect to the CompilationCue to resolve variables. Errors in parsing are reported to the cue's requestor; otherwise aBlock is evaluated. The argument noPattern is a Boolean that is true if the the sourceStream does not contain a method header (i.e., for DoIts)." | methNode repeatNeeded myStream s p subSelection | myStream := aCue sourceStream. [repeatNeeded := false. p := myStream position. s := myStream upToEnd. myStream position: p. + doitFlag := noPattern. self encoder init: aCue notifying: self. self init: myStream cue: aCue failBlock: [^ aBlock value]. subSelection := self interactive and: [cue requestor selectionInterval = (p + 1 to: p + s size)]. - doitFlag := noPattern. failBlock:= aBlock. [methNode := self method: noPattern context: cue context] on: ReparseAfterSourceEditing do: [ :ex | repeatNeeded := true. properties := nil. "Avoid accumulating pragmas and primitives Number" myStream := ex newSource ifNil: [subSelection ifTrue: [ReadStream on: cue requestor text string from: cue requestor selectionInterval first to: cue requestor selectionInterval last] ifFalse: [ReadStream on: cue requestor text string]] ifNotNil: [:src | myStream := src readStream]]. repeatNeeded] whileTrue: [encoder := self encoder class new]. methNode sourceText: s. ^methNode !

1 0

The Trunk: Compiler-ct.405.mcz
by commits＠source.squeak.org 21 Nov '19

21 Nov '19

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.405.mcz ==================== Summary ==================== Name: Compiler-ct.405 Author: ct Time: 29 June 2019, 11:38:21.90343 pm UUID: 500db9b5-d4f6-c24e-8e91-fea4521def76 Ancestors: Compiler-ct.404 Add resumption logic to SyntaxErrorNotification =============== Diff against Compiler-eem.403 =============== Item was changed: ----- Method: Parser>>parseCue:noPattern:ifFail: (in category 'public access') ----- parseCue: aCue noPattern: noPattern ifFail: aBlock "Answer a MethodNode for the argument, sourceStream, that is the root of a parse tree. Parsing is done with respect to the CompilationCue to resolve variables. Errors in parsing are reported to the cue's requestor; otherwise aBlock is evaluated. The argument noPattern is a Boolean that is true if the the sourceStream does not contain a method header (i.e., for DoIts)." | methNode repeatNeeded myStream s p subSelection | myStream := aCue sourceStream. [repeatNeeded := false. p := myStream position. s := myStream upToEnd. myStream position: p. + doitFlag := noPattern. self encoder init: aCue notifying: self. self init: myStream cue: aCue failBlock: [^ aBlock value]. subSelection := self interactive and: [cue requestor selectionInterval = (p + 1 to: p + s size)]. - doitFlag := noPattern. failBlock:= aBlock. [methNode := self method: noPattern context: cue context] on: ReparseAfterSourceEditing do: [ :ex | repeatNeeded := true. properties := nil. "Avoid accumulating pragmas and primitives Number" myStream := ex newSource ifNil: [subSelection ifTrue: [ReadStream on: cue requestor text string from: cue requestor selectionInterval first to: cue requestor selectionInterval last] ifFalse: [ReadStream on: cue requestor text string]] ifNotNil: [:src | myStream := src readStream]]. repeatNeeded] whileTrue: [encoder := self encoder class new]. methNode sourceText: s. ^methNode ! Item was added: + ----- Method: SyntaxErrorNotification>>isResumable (in category 'accessing') ----- + isResumable + + ^ true! Item was added: + ----- Method: SyntaxErrorNotification>>resume: (in category 'accessing') ----- + resume: source + + self reparse: source notifying: nil ifFail: nil. + ^ super resumeUnchecked: self defaultResumeValue!

1 0

The Trunk: Compiler-ct.406.mcz
by commits＠source.squeak.org 21 Nov '19

21 Nov '19

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.406.mcz ==================== Summary ==================== Name: Compiler-ct.406 Author: ct Time: 29 June 2019, 11:38:56.93143 pm UUID: d6e9e7fc-f54b-044d-bc18-790786074075 Ancestors: Compiler-ct.405 Fix SyntaxErrorNotification>>#messageText implementation (Error>>#messageText is never nil) =============== Diff against Compiler-eem.403 =============== Item was changed: ----- Method: Parser>>parseCue:noPattern:ifFail: (in category 'public access') ----- parseCue: aCue noPattern: noPattern ifFail: aBlock "Answer a MethodNode for the argument, sourceStream, that is the root of a parse tree. Parsing is done with respect to the CompilationCue to resolve variables. Errors in parsing are reported to the cue's requestor; otherwise aBlock is evaluated. The argument noPattern is a Boolean that is true if the the sourceStream does not contain a method header (i.e., for DoIts)." | methNode repeatNeeded myStream s p subSelection | myStream := aCue sourceStream. [repeatNeeded := false. p := myStream position. s := myStream upToEnd. myStream position: p. + doitFlag := noPattern. self encoder init: aCue notifying: self. self init: myStream cue: aCue failBlock: [^ aBlock value]. subSelection := self interactive and: [cue requestor selectionInterval = (p + 1 to: p + s size)]. - doitFlag := noPattern. failBlock:= aBlock. [methNode := self method: noPattern context: cue context] on: ReparseAfterSourceEditing do: [ :ex | repeatNeeded := true. properties := nil. "Avoid accumulating pragmas and primitives Number" myStream := ex newSource ifNil: [subSelection ifTrue: [ReadStream on: cue requestor text string from: cue requestor selectionInterval first to: cue requestor selectionInterval last] ifFalse: [ReadStream on: cue requestor text string]] ifNotNil: [:src | myStream := src readStream]]. repeatNeeded] whileTrue: [encoder := self encoder class new]. methNode sourceText: s. ^methNode ! Item was added: + ----- Method: SyntaxErrorNotification>>isResumable (in category 'accessing') ----- + isResumable + + ^ true! Item was changed: ----- Method: SyntaxErrorNotification>>messageText (in category 'accessing') ----- messageText ^ super messageText + ifEmpty: [messageText := code]! - ifNil: [messageText := code]! Item was added: + ----- Method: SyntaxErrorNotification>>resume: (in category 'accessing') ----- + resume: source + + self reparse: source notifying: nil ifFail: nil. + ^ super resumeUnchecked: self defaultResumeValue!

1 0

The Trunk: Compiler-ct.407.mcz
by commits＠source.squeak.org 21 Nov '19

21 Nov '19

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.407.mcz ==================== Summary ==================== Name: Compiler-ct.407 Author: ct Time: 30 June 2019, 2:10:51.53343 pm UUID: 63066cad-d45d-6a42-a0fa-c39e18b44ae6 Ancestors: Compiler-ct.406 Fix SyntaxErrorNotification coverage (see example in http://forum.world.st/The-Inbox-Compiler-ct-404-mcz-tp5100414p5100430.html) =============== Diff against Compiler-eem.403 =============== Item was changed: ----- Method: Parser>>parseCue:noPattern:ifFail: (in category 'public access') ----- parseCue: aCue noPattern: noPattern ifFail: aBlock "Answer a MethodNode for the argument, sourceStream, that is the root of a parse tree. Parsing is done with respect to the CompilationCue to resolve variables. Errors in parsing are reported to the cue's requestor; otherwise aBlock is evaluated. The argument noPattern is a Boolean that is true if the the sourceStream does not contain a method header (i.e., for DoIts)." | methNode repeatNeeded myStream s p subSelection | myStream := aCue sourceStream. [repeatNeeded := false. p := myStream position. s := myStream upToEnd. myStream position: p. + doitFlag := noPattern. + [self encoder init: aCue notifying: self. - self encoder init: aCue notifying: self. self init: myStream cue: aCue failBlock: [^ aBlock value]. subSelection := self interactive and: [cue requestor selectionInterval = (p + 1 to: p + s size)]. - doitFlag := noPattern. failBlock:= aBlock. + methNode := self method: noPattern context: cue context] - [methNode := self method: noPattern context: cue context] on: ReparseAfterSourceEditing do: [ :ex | repeatNeeded := true. properties := nil. "Avoid accumulating pragmas and primitives Number" myStream := ex newSource ifNil: [subSelection ifTrue: [ReadStream on: cue requestor text string from: cue requestor selectionInterval first to: cue requestor selectionInterval last] ifFalse: [ReadStream on: cue requestor text string]] ifNotNil: [:src | myStream := src readStream]]. repeatNeeded] whileTrue: [encoder := self encoder class new]. methNode sourceText: s. ^methNode ! Item was added: + ----- Method: SyntaxErrorNotification>>isResumable (in category 'accessing') ----- + isResumable + + ^ true! Item was changed: ----- Method: SyntaxErrorNotification>>messageText (in category 'accessing') ----- messageText ^ super messageText + ifEmpty: [messageText := code]! - ifNil: [messageText := code]! Item was added: + ----- Method: SyntaxErrorNotification>>resume: (in category 'accessing') ----- + resume: source + + self reparse: source notifying: nil ifFail: nil. + ^ super resume: self defaultResumeValue!

1 0

The Trunk: Compiler-mt.413.mcz
by commits＠source.squeak.org 21 Nov '19

21 Nov '19

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-mt.413.mcz ==================== Summary ==================== Name: Compiler-mt.413 Author: mt Time: 21 November 2019, 4:23:15.551156 pm UUID: db181638-e223-5648-8bea-f5084f9c44ad Ancestors: Compiler-mt.412, Compiler-ct.407 Merges Compiler-ct.407. We can now programmatically handle syntax errors: [Compiler evaluate: '3+?'] on: SyntaxErrorNotification do: [:ex | ex resume: '3+4']. =============== Diff against Compiler-mt.412 =============== Item was changed: ----- Method: Parser>>parseCue:noPattern:ifFail: (in category 'public access') ----- parseCue: aCue noPattern: noPattern ifFail: aBlock "Answer a MethodNode for the argument, sourceStream, that is the root of a parse tree. Parsing is done with respect to the CompilationCue to resolve variables. Errors in parsing are reported to the cue's requestor; otherwise aBlock is evaluated. The argument noPattern is a Boolean that is true if the the sourceStream does not contain a method header (i.e., for DoIts)." | methNode repeatNeeded myStream s p subSelection | myStream := aCue sourceStream. [repeatNeeded := false. p := myStream position. s := myStream upToEnd. myStream position: p. - - doitFlag := noPattern. - failBlock:= aBlock. + doitFlag := noPattern. + [self encoder init: aCue notifying: self. - self encoder init: aCue notifying: self. self init: myStream cue: aCue failBlock: [^ aBlock value]. subSelection := self interactive and: [cue requestor selectionInterval = (p + 1 to: p + s size)]. + failBlock:= aBlock. + methNode := self method: noPattern context: cue context] - [methNode := self method: noPattern context: cue context] on: ReparseAfterSourceEditing do: [ :ex | repeatNeeded := true. properties := nil. "Avoid accumulating pragmas and primitives Number" myStream := ex newSource ifNil: [subSelection ifTrue: [ReadStream on: cue requestor text string from: cue requestor selectionInterval first to: cue requestor selectionInterval last] ifFalse: [ReadStream on: cue requestor text string]] ifNotNil: [:src | myStream := src readStream]]. repeatNeeded] whileTrue: [encoder := self encoder class new]. methNode sourceText: s. ^methNode ! Item was added: + ----- Method: SyntaxErrorNotification>>isResumable (in category 'accessing') ----- + isResumable + + ^ true! Item was changed: ----- Method: SyntaxErrorNotification>>messageText (in category 'accessing') ----- messageText ^ super messageText + ifEmpty: [messageText := code]! - ifNil: [messageText := code]! Item was added: + ----- Method: SyntaxErrorNotification>>resume: (in category 'accessing') ----- + resume: source + + self reparse: source notifying: nil ifFail: nil. + ^ super resume: self defaultResumeValue!

1 0

The Trunk: ShoutCore-mt.76.mcz
by commits＠source.squeak.org 21 Nov '19

21 Nov '19

Marcel Taeumel uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-mt.76.mcz ==================== Summary ==================== Name: ShoutCore-mt.76 Author: mt Time: 21 November 2019, 3:51:18.231156 pm UUID: c0aa1566-69f3-1845-8993-0f5f67fcdb96 Ancestors: ShoutCore-eem.75 Fixes a bug with syntax highlighting for dead context's in the debugger. =============== Diff against ShoutCore-eem.75 =============== Item was changed: ----- Method: SHParserST80>>initializeInstanceVariables (in category 'parse support') ----- initializeInstanceVariables instanceVariables := classOrMetaClass ifNil: [ #() ] ifNotNil: [ classOrMetaClass allInstVarNames asArray ]. allowUnderscoreAssignments := Scanner allowUnderscoreAsAssignment. allowUnderscoreSelectors := Scanner prefAllowUnderscoreSelectors. allowBlockArgumentAssignment := Scanner allowBlockArgumentAssignment. sourcePosition := 1. arguments ifNil: [ arguments := OrderedCollection with: nil ] ifNotNil: [ arguments reset; addLast: nil ]. temporaries ifNil: [ temporaries := OrderedCollection with: nil ] ifNotNil: [ temporaries reset; addLast: nil ]. + (context notNil and: [ context isDead not ]) + ifTrue: [ self initializeVariablesFromContext ]. - context ifNotNil: [ self initializeVariablesFromContext ]. bracketDepth := 0. ranges ifNil: [ ranges := OrderedCollection new: 40 "Covers over 80% of all methods." ] ifNotNil: [ ranges reset ]! Item was changed: ----- Method: SHParserST80>>initializeVariablesFromContext (in category 'parse support') ----- initializeVariablesFromContext | contextSourcePcIndex contextSourceParser | contextSourcePcIndex := (context debuggerMap rangeForPC: context pc in: context method + contextIsActiveContext: true "... to really use the context's pc.") - contextIsActiveContext: true "little white lie to work in every situation") start. contextSourceParser := self class new classOrMetaClass: context method methodClass; environment: self environment; source: (context method getSource first: contextSourcePcIndex); yourself. contextSourceParser parse. arguments := contextSourceParser activeArguments. temporaries := contextSourceParser activeTemporaries.!

1 0

The Trunk: Morphic-mt.1591.mcz
by commits＠source.squeak.org 21 Nov '19

21 Nov '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1591.mcz ==================== Summary ==================== Name: Morphic-mt.1591 Author: mt Time: 21 November 2019, 9:01:23.586593 am UUID: f1318c24-447a-cd4f-b557-b2f8ac23d7a6 Ancestors: Morphic-mt.1590 Fixes the same bug about splitter positioning. :-) The issue was that the splitter's position did not match its internal state (leftOrTop or rightOrBottom). =============== Diff against Morphic-mt.1590 =============== Item was changed: ----- Method: BorderedMorph>>addPaneHSplitterAtBottomOfRow: (in category 'resize handling') ----- addPaneHSplitterAtBottomOfRow: someMorphs | targetY minX maxX splitter | targetY := someMorphs first layoutFrame bottomFraction. minX := (someMorphs detectMin: [:each | each layoutFrame leftFraction]) layoutFrame leftFraction. maxX := (someMorphs detectMax: [:each | each layoutFrame rightFraction]) layoutFrame rightFraction. splitter := ProportionalSplitterMorph new beSplitsTopAndBottom; yourself. splitter layoutFrame: (LayoutFrame fractions: (minX @ targetY corner: maxX @ targetY) + offsets: ((someMorphs first layoutFrame leftOffset ifNil: [0]) @ 0 + corner: (someMorphs first layoutFrame rightOffset ifNil: [0]) @ AbstractResizerMorph gripThickness)). - offsets: (((someMorphs first layoutFrame leftOffset ifNil: [0]) @ 0 - corner: (someMorphs first layoutFrame rightOffset ifNil: [0]) @ AbstractResizerMorph gripThickness) - translateBy: 0 @ (someMorphs first layoutFrame bottomOffset ifNil: [0]))). self addMorphBack: (splitter position: self position).! Item was changed: ----- Method: BorderedMorph>>addPaneVSplitterAtRightOfColumn: (in category 'resize handling') ----- addPaneVSplitterAtRightOfColumn: someMorphs | targetX minY maxY splitter | targetX := someMorphs first layoutFrame rightFraction. + minY := (someMorphs detectMin: [:each | each layoutFrame topFraction]) layoutFrame topFraction. maxY := (someMorphs detectMax: [:each | each layoutFrame bottomFraction]) layoutFrame bottomFraction. + splitter := ProportionalSplitterMorph new beSplitsLeftAndRight; yourself. - splitter := ProportionalSplitterMorph new. splitter layoutFrame: (LayoutFrame fractions: (targetX @ minY corner: targetX @ maxY) + offsets: (0 @ (someMorphs first layoutFrame topOffset ifNil: [0]) + corner: (AbstractResizerMorph gripThickness@ (someMorphs first layoutFrame bottomOffset ifNil: [0])))). - offsets: ((0 @ (someMorphs first layoutFrame topOffset ifNil: [0]) corner: (AbstractResizerMorph gripThickness@ (someMorphs first layoutFrame bottomOffset ifNil: [0]))) translateBy: (someMorphs first layoutFrame rightOffset ifNil: [0]) @ 0)). self addMorphBack: (splitter position: self position).!

1 0

The Trunk: ToolBuilder-Morphic-mt.250.mcz
by commits＠source.squeak.org 20 Nov '19

20 Nov '19

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.250.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.250 Author: mt Time: 20 November 2019, 7:40:57.866371 pm UUID: 77b0d634-25aa-9d41-a669-dc0946e46fee Ancestors: ToolBuilder-Morphic-mt.249 Fixes tree-label bug in file dialogs. Label selector has to be there first. See PluggableTreeMorph >> #printNode:. It is then cached in IndentingListItemMorph. =============== Diff against ToolBuilder-Morphic-mt.249 =============== Item was changed: ----- Method: MorphicToolBuilder>>buildPluggableTree: (in category 'widgets required') ----- buildPluggableTree: aSpec | widget | widget := self treeClass new. self register: widget id: aSpec name. + widget getLabelSelector: aSpec label. + widget getIconSelector: aSpec icon. + widget model: aSpec model. widget nodeClass: aSpec nodeClass. widget getRootsSelector: aSpec roots. widget getChildrenSelector: aSpec getChildren. widget hasChildrenSelector: aSpec hasChildren. widget getSelectedSelector: aSpec getSelected. widget setSelectedSelector: aSpec setSelected. widget getSelectedPathSelector: aSpec getSelectedPath. widget setSelectedPathSelector: aSpec setSelectedPath. widget setSelectedParentSelector: aSpec setSelectedParent. - widget getLabelSelector: aSpec label. - widget getIconSelector: aSpec icon. widget getHelpSelector: aSpec help. widget getMenuSelector: aSpec menu. widget keystrokeActionSelector: aSpec keyPress. widget autoDeselect: aSpec autoDeselect. widget doubleClickSelector: aSpec doubleClick. widget dropItemSelector: aSpec dropItem. widget wantsDropSelector: aSpec dropAccept. widget dragItemSelector: aSpec dragItem. widget dragStartedSelector: aSpec dragStarted. widget columns: aSpec columns. "Override default scroll bar policies if needed. Widget will use preference values otherwise." aSpec hScrollBarPolicy ifNotNil: [:policy | policy caseOf: { [#always] -> [widget alwaysShowHScrollBar]. [#never] -> [widget hideHScrollBarIndefinitely]. [#whenNeeded] -> [widget showHScrollBarOnlyWhenNeeded]. } ]. aSpec vScrollBarPolicy ifNotNil: [:policy | policy caseOf: { [#always] -> [widget alwaysShowVScrollBar]. [#never] -> [widget hideVScrollBarIndefinitely]. [#whenNeeded] -> [widget showVScrollBarOnlyWhenNeeded]. } ]. self setFrame: aSpec frame in: widget. self setLayoutHintsFor: widget spec: aSpec. parent ifNotNil:[self add: widget to: parent]. " panes ifNotNil:[ aSpec roots ifNotNil:[panes add: aSpec roots]. ]. " ^widget!

1 0

The Trunk: Morphic-mt.1590.mcz
by commits＠source.squeak.org 20 Nov '19

20 Nov '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1590.mcz ==================== Summary ==================== Name: Morphic-mt.1590 Author: mt Time: 20 November 2019, 4:18:13.982237 pm UUID: ecbe5a17-bdc5-554e-a2dc-d29638ee6752 Ancestors: Morphic-mt.1589 Fixes a bug with splitter positioning under certain conditions in the PropotionalLayout. =============== Diff against Morphic-mt.1589 =============== Item was added: + ----- Method: BorderedMorph>>addPaneHSplitterAtBottomOfRow: (in category 'resize handling') ----- + addPaneHSplitterAtBottomOfRow: someMorphs + + | targetY minX maxX splitter | + targetY := someMorphs first layoutFrame bottomFraction. + + minX := (someMorphs detectMin: [:each | each layoutFrame leftFraction]) layoutFrame leftFraction. + maxX := (someMorphs detectMax: [:each | each layoutFrame rightFraction]) layoutFrame rightFraction. + + splitter := ProportionalSplitterMorph new beSplitsTopAndBottom; yourself. + splitter layoutFrame: (LayoutFrame + fractions: (minX @ targetY corner: maxX @ targetY) + offsets: (((someMorphs first layoutFrame leftOffset ifNil: [0]) @ 0 + corner: (someMorphs first layoutFrame rightOffset ifNil: [0]) @ AbstractResizerMorph gripThickness) + translateBy: 0 @ (someMorphs first layoutFrame bottomOffset ifNil: [0]))). + + self addMorphBack: (splitter position: self position).! Item was removed: - ----- Method: BorderedMorph>>addPaneHSplitterBetween:and: (in category 'resize handling') ----- - addPaneHSplitterBetween: topMorph and: bottomMorphs - - | targetY minX maxX splitter | - targetY := topMorph layoutFrame bottomFraction. - - minX := (bottomMorphs detectMin: [:each | each layoutFrame leftFraction]) layoutFrame leftFraction. - maxX := (bottomMorphs detectMax: [:each | each layoutFrame rightFraction]) layoutFrame rightFraction. - splitter := ProportionalSplitterMorph new beSplitsTopAndBottom; yourself. - splitter layoutFrame: (LayoutFrame - fractions: (minX @ targetY corner: maxX @ targetY) - offsets: (((topMorph layoutFrame leftOffset ifNil: [0]) @ 0 - corner: (topMorph layoutFrame rightOffset ifNil: [0]) @ AbstractResizerMorph gripThickness) - translateBy: 0 @ (topMorph layoutFrame bottomOffset ifNil: [0]))). - - self addMorphBack: (splitter position: self position).! Item was changed: ----- Method: BorderedMorph>>addPaneHSplitters (in category 'resize handling') ----- addPaneHSplitters | remaining targetY sameY | remaining := self paneMorphs reject: [:each | each layoutFrame bottomFraction = 1 or: [each layoutFrame hasFixedHeight]]. [remaining notEmpty] whileTrue: [targetY := remaining first layoutFrame bottomFraction. sameY := self paneMorphs select: [:each | each layoutFrame bottomFraction = targetY]. + self addPaneHSplitterAtBottomOfRow: sameY. - self addPaneHSplitterBetween: remaining first and: sameY. remaining := remaining copyWithoutAll: sameY]! Item was added: + ----- Method: BorderedMorph>>addPaneVSplitterAtRightOfColumn: (in category 'resize handling') ----- + addPaneVSplitterAtRightOfColumn: someMorphs + + | targetX minY maxY splitter | + targetX := someMorphs first layoutFrame rightFraction. + minY := (someMorphs detectMin: [:each | each layoutFrame topFraction]) layoutFrame topFraction. + maxY := (someMorphs detectMax: [:each | each layoutFrame bottomFraction]) layoutFrame bottomFraction. + + splitter := ProportionalSplitterMorph new. + splitter layoutFrame: (LayoutFrame + fractions: (targetX @ minY corner: targetX @ maxY) + offsets: ((0 @ (someMorphs first layoutFrame topOffset ifNil: [0]) corner: (AbstractResizerMorph gripThickness@ (someMorphs first layoutFrame bottomOffset ifNil: [0]))) translateBy: (someMorphs first layoutFrame rightOffset ifNil: [0]) @ 0)). + + self addMorphBack: (splitter position: self position).! Item was removed: - ----- Method: BorderedMorph>>addPaneVSplitterBetween:and: (in category 'resize handling') ----- - addPaneVSplitterBetween: leftMorph and: rightMorphs - - | targetX minY maxY splitter | - targetX := leftMorph layoutFrame rightFraction. - minY := (rightMorphs detectMin: [:each | each layoutFrame topFraction]) layoutFrame topFraction. - maxY := (rightMorphs detectMax: [:each | each layoutFrame bottomFraction]) layoutFrame bottomFraction. - - splitter := ProportionalSplitterMorph new. - splitter layoutFrame: (LayoutFrame - fractions: (targetX @ minY corner: targetX @ maxY) - offsets: ((0 @ (leftMorph layoutFrame topOffset ifNil: [0]) corner: (AbstractResizerMorph gripThickness@ (leftMorph layoutFrame bottomOffset ifNil: [0]))) translateBy: (leftMorph layoutFrame rightOffset ifNil: [0]) @ 0)). - - self addMorphBack: (splitter position: self position).! Item was changed: ----- Method: BorderedMorph>>addPaneVSplitters (in category 'resize handling') ----- addPaneVSplitters | remaining targetX sameX | remaining := self paneMorphs reject: [:each | each layoutFrame rightFraction = 1 or: [each layoutFrame hasFixedWidth]]. [remaining notEmpty] whileTrue: [targetX := remaining first layoutFrame rightFraction. sameX := self paneMorphs select: [:each | each layoutFrame rightFraction = targetX]. + self addPaneVSplitterAtRightOfColumn: sameX. - self addPaneVSplitterBetween: remaining first and: sameX. remaining := remaining copyWithoutAll: sameX]!

1 0

← Newer
1
2
3
4
5
6
7
8
...
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Packages November 2019