Packages July 2019

packages@lists.squeakfoundation.org

1 participants
67 discussions

The Trunk: System-mt.1071.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1071.mcz ==================== Summary ==================== Name: System-mt.1071 Author: mt Time: 12 July 2019, 10:02:46.159568 am UUID: dc0cb024-484b-a145-af9c-e10b103db241 Ancestors: System-mt.1070 Refactoring of #literalsDo: - Step 3 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against System-mt.1070 =============== Item was changed: ----- Method: DeepCopier>>checkClass: (in category 'like fullCopy') ----- checkClass: aClass | meth | "Check that no indexes of instance vars have changed in certain classes. If you get an error in this method, an implementation of veryDeepCopyWith: needs to be updated. The idea is to catch a change while it is still in the system of the programmer who made it." self checkBasicClasses. "Unlikely, but important to catch when it does happen." "Every class that implements veryDeepInner: must copy all its inst vars. Danger is that a user will add a new instance variable and forget to copy it. So check that the last one is mentioned in the copy method." (aClass includesSelector: #veryDeepInner:) ifTrue: [ ((aClass compiledMethodAt: #veryDeepInner:) writesField: aClass instSize) ifFalse: [ aClass instSize > 0 ifTrue: [ self warnIverNotCopiedIn: aClass sel: #veryDeepInner:]]]. (aClass includesSelector: #veryDeepCopyWith:) ifTrue: [ meth := aClass compiledMethodAt: #veryDeepCopyWith:. + (meth size > 20) & (meth hasLiteral: #veryDeepCopyWith:) not ifTrue: [ - (meth size > 20) & (meth literals includes: #veryDeepCopyWith:) not ifTrue: [ (meth writesField: aClass instSize) ifFalse: [ self warnIverNotCopiedIn: aClass sel: #veryDeepCopyWith:]]]. ! Item was changed: ----- Method: DeepCopier>>checkVariables (in category 'like fullCopy') ----- checkVariables "Check that no indexes of instance vars have changed in certain classes. If you get an error in this method, an implementation of veryDeepCopyWith: needs to be updated. The idea is to catch a change while it is still in the system of the programmer who made it. DeepCopier new checkVariables " self checkBasicClasses. "Every class that implements veryDeepInner: must copy all its inst vars. Danger is that a user will add a new instance variable and forget to copy it. So check that the last one is mentioned in the copy method." (self systemNavigation allClassesImplementing: #veryDeepInner:) do: [:aClass | ((aClass compiledMethodAt: #veryDeepInner:) writesField: aClass instSize) ifFalse: [aClass instSize > 0 ifTrue: [self warnIverNotCopiedIn: aClass sel: #veryDeepInner:]]]. (self systemNavigation allClassesImplementing: #veryDeepCopyWith:) do: [:aClass | | meth | meth := aClass compiledMethodAt: #veryDeepCopyWith:. + meth size > 20 & (meth hasLiteral: #veryDeepCopyWith:) not - meth size > 20 & (meth literals includes: #veryDeepCopyWith:) not ifTrue: [(meth writesField: aClass instSize) ifFalse: [self warnIverNotCopiedIn: aClass sel: #veryDeepCopyWith:]]]! Item was changed: ----- Method: SystemDictionary>>isThisBindingReferred: (in category 'classes and traits') ----- isThisBindingReferred: binding self systemNavigation allSelectorsAndMethodsDo: [ :behavior :selector :method | (method instVarsInclude: binding) ifTrue: [ + method allLiteralsDo: [ :literal | "Avoid possible false positives from the primitive." - method literalsDo: [ :literal | "Avoid possible false positives from the primitive." literal == binding ifTrue: [ ^true ] ] ] ]. ^false! Item was changed: Object subclass: #SystemNavigation instanceVariableNames: 'browserClass hierarchyBrowserClass environment' + classVariableNames: 'Authors AuthorsInverted Default' - classVariableNames: 'Authors AuthorsInverted Default ThoroughSenders' poolDictionaries: '' category: 'System-Support'! !SystemNavigation commentStamp: 'mha 8/26/2010 09:02' prior: 0! I support the navigation of the system. I act as a facade but as I could require some state or different way of navigating the system all my behavior are on the instance side. For example if you want to look at all methods you have written or changed in the current image do SystemNavigation new browseAllSelect: [ :method | method fileIndex > 1 "only look at changes file" and: [ method timeStamp beginsWith: 'your-initials-here' ] ]. ! Item was removed: - ----- Method: SystemNavigation class>>thoroughSenders (in category 'preferences') ----- - thoroughSenders - "Accessor for the system-wide preference" - - <preference: 'Thorough senders.' - category: #general - description: 'If true, then ''senders'' browsers will dive inside structured literals in their search.' - type: #Boolean> - ^ThoroughSenders ifNil: [ true ]! Item was removed: - ----- Method: SystemNavigation class>>thoroughSenders: (in category 'preferences') ----- - thoroughSenders: aBoolean - "Accessor for the system-wide preference" - - ThoroughSenders := aBoolean! Item was changed: ----- Method: SystemNavigation>>allCallsOn:fromBehaviors:sorted: (in category 'query') ----- allCallsOn: aLiteral fromBehaviors: behaviors sorted: sorted "Answer a collection of all the methods implemented by behaviors that call on aLiteral even deeply embedded in literal arrays." | result | result := OrderedCollection new. + behaviors do: [:behavior | + behavior selectorsAndMethodsDo: [:selector :method | + (method hasLiteral: aLiteral) + ifTrue: [result addLast: method methodReference]]]. + sorted ifTrue: [result sort]. - CompiledCode - scanBlocksForLiteral: aLiteral - do: [:primaryScanner :secondaryScanner | | thorough | - "Possibly search for literals embedded in literal arrays or pragmas, etc." - thorough := self class thoroughSenders. - behaviors do: - [ :behavior | - behavior selectorsAndMethodsDo: - [ :selector :method | - (method - refersTo: aLiteral - primaryBytecodeScanner: primaryScanner - secondaryBytecodeScanner: secondaryScanner - thorough: thorough) ifTrue: - [result addLast: (MethodReference class: behavior selector: selector)]]]]. - sorted ifTrue: - [result sort]. ^result! Item was changed: ----- Method: SystemNavigation>>allCallsOn:fromMethodReferences:sorted: (in category 'query') ----- allCallsOn: aLiteral fromMethodReferences: methodReferences sorted: sorted "Answer a collection of all the methods implemented by behaviors that call on aLiteral even deeply embedded in literal arrays." | result | + result := methodReferences select: [:reference | + reference compiledMethod + ifNil: [false] + ifNotNil: [:method | method hasLiteral: aLiteral]]. + sorted ifTrue: [result sort]. - result := CompiledCode - scanBlocksForLiteral: aLiteral - do: [:primaryScanner :secondaryScanner | | thorough | - "Possibly search for literals embedded in literal arrays or pragmas, etc." - thorough := self class thoroughSenders. - methodReferences select: - [ :reference | - reference compiledMethod - ifNil: [false] - ifNotNil: - [:method| - method - refersTo: aLiteral - primaryBytecodeScanner: primaryScanner - secondaryBytecodeScanner: secondaryScanner - thorough: thorough]]]. - sorted ifTrue: - [result sort]. ^result! Item was changed: ----- Method: SystemNavigation>>allCallsOnClass: (in category 'query') ----- allCallsOnClass: aBehavior "Answer a sorted collection of all the methods that refer to aBehavior." | theClass result | theClass := aBehavior theNonMetaClass. result := self + allCallsOn: theClass name - allCallsOn: ( - self class thoroughSenders - ifTrue: [ theClass name ] - ifFalse: [ theClass environment bindingOf: theClass name ]) fromBehaviors: self allBehaviors sorted: false. theClass environment allClassesDo: [ :class | (class sharedPools includes: theClass) ifTrue: [ result add: (ClassReference class: class) ] ]. ^result sort! Item was changed: ----- Method: SystemNavigation>>allGlobalRefsWithout: (in category 'query') ----- allGlobalRefsWithout: classesAndMessagesPair "Answer a set of symbols that may be refs to Global names. In some sense we should only need the associations, but this will also catch, eg, HTML tag types. This method computes its result in the absence of specified classes and messages." "may be a problem if namespaces are introduced as for the moment only Smalltalk is queried. sd 29/4/03" | globalRefs absentClasses absentSelectors | globalRefs := IdentitySet new: CompiledMethod instanceCount. absentClasses := classesAndMessagesPair first. absentSelectors := classesAndMessagesPair second. "sd 29/04/03" Cursor execute showWhile: [self environment allClassesDo: [:cls | ((absentClasses includes: cls name) ifTrue: [{}] ifFalse: [{cls. cls class}]) do: [:cl | (absentSelectors isEmpty ifTrue: [cl selectors] ifFalse: [cl selectors copyWithoutAll: absentSelectors]) do: [:sel | "Include all capitalized symbols for good measure" + (cl compiledMethodAt: sel) allLiteralsDo: [:m | - (cl compiledMethodAt: sel) literalsDo: [:m | ((m isSymbol) and: [m size > 0 and: [m first canBeGlobalVarInitial]]) ifTrue: [globalRefs add: m]. + ]]]]]. - (m isMemberOf: Array) - ifTrue: [m - do: [:x | ((x isSymbol) - and: [x size > 0 - and: [x first canBeGlobalVarInitial]]) - ifTrue: [globalRefs add: x]]]. - m isVariableBinding - ifTrue: [m key - ifNotNil: [globalRefs add: m key]]]]]]]. ^ globalRefs! Item was changed: ----- Method: SystemNavigation>>allSentMessagesWithout: (in category 'query') ----- allSentMessagesWithout: classesAndMessagesPair "Answer the set of selectors which are sent somewhere in the system, computed in the absence of the supplied classes and messages." | sent absentClasses absentSelectors | sent := IdentitySet new: CompiledMethod instanceCount. absentClasses := classesAndMessagesPair first. absentSelectors := classesAndMessagesPair second. "sd 29/04/03" Cursor execute showWhile: [ self environment allClassesAndTraitsDo: [:cls | ((absentClasses includes: cls name) ifTrue: [{}] ifFalse: [{cls. cls classSide}]) do: [:each | (absentSelectors isEmpty ifTrue: [each selectors] ifFalse: [each selectors copyWithoutAll: absentSelectors]) do: [:sel | "Include all sels, but not if sent by self" + (each compiledMethodAt: sel) allLiteralsDo: [:m | - (each compiledMethodAt: sel) literalsDo: [:m | (m isSymbol) ifTrue: ["might be sent" m == sel ifFalse: [sent add: m]]. + ]]]]]. - (m isMemberOf: Array) - ifTrue: ["might be performed" - m - do: [:x | (x isSymbol) - ifTrue: [x == sel - ifFalse: [sent add: x]]]]]]]]]. "The following may be sent without being in any literal frame" Smalltalk specialSelectorNames do: [:sel | sent add: sel]. Smalltalk presumedSentMessages do: [:sel | sent add: sel]. ^ sent.!

1 0

The Trunk: Kernel-mt.1245.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1245.mcz ==================== Summary ==================== Name: Kernel-mt.1245 Author: mt Time: 12 July 2019, 10:02:20.401568 am UUID: 2ce0ef20-a760-4d4a-b6bd-c4383a6efd4d Ancestors: Kernel-mt.1244 Refactoring of #literalsDo: - Step 3 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against Kernel-mt.1244 =============== Item was removed: - ----- Method: AdditionalMethodState>>hasLiteralThorough: (in category 'testing') ----- - hasLiteralThorough: literal - "Answer true if any literal in these properties is literal, - even if embedded in array structure." - 1 to: self basicSize do: [:i | - | propertyOrPragma "<Association|Pragma>" | - propertyOrPragma := self basicAt: i. - (propertyOrPragma isVariableBinding - ifTrue: [propertyOrPragma key == literal - or: [propertyOrPragma value == literal - or: [propertyOrPragma value isArray - and: [propertyOrPragma value hasLiteral: literal]]]] - ifFalse: [propertyOrPragma hasLiteral: literal]) ifTrue: - [^true]]. - ^false! Item was changed: ----- Method: Behavior>>whichSelectorsReferTo: (in category 'testing method dictionary') ----- whichSelectorsReferTo: literal "Answer a Set of selectors whose methods access the argument as a literal." + | who | + who := IdentitySet new. + self selectorsAndMethodsDo: [:selector :method | + (method hasLiteral: literal) + ifTrue: [who add: selector]]. + ^ who - ^self whichSelectorsReferTo: literal thorough: false "Rectangle whichSelectorsReferTo: #+."! Item was removed: - ----- Method: Behavior>>whichSelectorsReferTo:thorough: (in category 'testing method dictionary') ----- - whichSelectorsReferTo: aLiteral thorough: thorough - "Answer a set of selectors whose methods access the argument as a literal. - If thorough is true, then dives into the compact literal notation, and pragmas, - etc, making it slow but thorough " - - | who | - who := IdentitySet new. - CompiledCode - scanBlocksForLiteral: aLiteral - do: [:primaryScanner :secondaryScanner | - self selectorsAndMethodsDo: - [ :selector :method | - (method - refersTo: aLiteral - primaryBytecodeScanner: primaryScanner - secondaryBytecodeScanner: secondaryScanner - thorough: thorough) ifTrue: - [who add: selector]]]. - ^who! Item was removed: - ----- Method: CompiledMethod>>refersTo:bytecodeScanner:thorough: (in category 'scanning') ----- - refersTo: literal bytecodeScanner: scanBlockOrNil thorough: thorough - "Override to check method properties" - | maybeProperties | - (super refersTo: literal bytecodeScanner: scanBlockOrNil thorough: thorough) ifTrue: - [^true]. - ^thorough - and: [(maybeProperties := self penultimateLiteral) isSymbol not - and: [(maybeProperties hasLiteralThorough: literal) - or: [literal isVariableBinding - and: [literal key isSymbol - and: [maybeProperties hasLiteralThorough: literal key]]]]]!

1 0

The Trunk: Collections-mt.843.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.843.mcz ==================== Summary ==================== Name: Collections-mt.843 Author: mt Time: 12 July 2019, 10:01:59.574568 am UUID: 7eec09f6-7031-2b40-af5a-8468dba01848 Ancestors: Collections-mt.842 Refactoring of #literalsDo: - Step 3 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against Collections-mt.842 =============== Item was changed: ----- Method: Dictionary>>unreferencedKeys (in category 'removing') ----- unreferencedKeys "| uk | (Time millisecondsToRun: [uk := TextConstants unreferencedKeys]) -> uk" ^'Scanning for references . . .' displayProgressFrom: 0 to: Smalltalk classNames size * 2 during: [ :bar | | currentClass n associations referencedAssociations | currentClass := nil. n := 0. associations := self associations asIdentitySet. referencedAssociations := IdentitySet new: associations size. self systemNavigation allSelectorsAndMethodsDo: [ :behavior :selector :method | behavior == currentClass ifFalse: [ currentClass := behavior. bar value: (n := n + 1) ]. + method allLiteralsDo: [ :literal | - method literalsDo: [ :literal | (literal isVariableBinding and: [ associations includes: literal ]) ifTrue: [ referencedAssociations add: literal ] ] ]. (associations reject: [ :assoc | referencedAssociations includes: assoc ]) collect: [ :assoc| assoc key ] ]!

1 0

The Trunk: 60Deprecated-mt.39.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of 60Deprecated to project The Trunk: http://source.squeak.org/trunk/60Deprecated-mt.39.mcz ==================== Summary ==================== Name: 60Deprecated-mt.39 Author: mt Time: 12 July 2019, 10:00:59.145568 am UUID: c876b270-643e-414c-853b-9ec38a9b2fb3 Ancestors: 60Deprecated-mt.38 Refactoring of #literalsDo: - Step 2 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against 60Deprecated-mt.38 =============== Item was added: + ----- Method: CompiledBlock>>allSubLiterals (in category '*60Deprecated-literals') ----- + allSubLiterals + | literalsExceptOuter unfoldedSubLiterals | + literalsExceptOuter := self literals allButLast. + unfoldedSubLiterals := literalsExceptOuter + select: [:lit| lit isCompiledCode] + thenCollect: [:blockMethod| blockMethod allSubLiterals]. + unfoldedSubLiterals ifEmpty: + [^literalsExceptOuter]. + ^literalsExceptOuter, (unfoldedSubLiterals fold: [:a :b| a, b])! Item was added: + ----- Method: CompiledCode>>messagesDo:encoderClass:visitedSet: (in category '*60Deprecated-private') ----- + messagesDo: aBlock encoderClass: encoderClass visitedSet: visitedSet + "The inner engine for messagesDo:" + + | scanner | + scanner := InstructionStream on: self. + scanner scanFor: [ :x | + | selector | + (selector := encoderClass selectorToSendOrItselfFor: scanner in: self at: scanner pc) == scanner + ifFalse: + [(visitedSet ifAbsentAdd: selector) ifTrue: + [aBlock value: selector]] + ifTrue: + [(encoderClass blockMethodOrNilFor: scanner in: self at: scanner pc) ifNotNil: + [:blockMethod| + blockMethod messagesDo: aBlock encoderClass: encoderClass visitedSet: visitedSet]]. + false "keep scanning" ]! Item was added: + ----- Method: CompiledCode>>refersTo:bytecodeScanner:thorough: (in category '*60Deprecated-literals') ----- + refersTo: literal bytecodeScanner: scanBlockOrNil thorough: thorough + "Answer if the receiver refers to the literal. If the scan block is non-nil, then + use it to find the literal in bytecode. If thorough is true, dive down into + literal arrays and method properties to locate references to the literal there-in." + 2 to: (self isCompiledBlock + ifTrue: [self numLiterals] "exclude outerCode or methodClass" + ifFalse: [self numLiterals - 1]) "exclude selector/properties and methodClass" + do: [:i| | lit | + lit := self objectAt: i. + (literal == lit or: [literal literalEqual: lit]) ifTrue: [^true]. "== for Float bindingOf: #NaN since NaN ~= NaN" + lit isCompiledCode + ifTrue: + [(lit refersTo: literal bytecodeScanner: scanBlockOrNil thorough: thorough) ifTrue: + [^true]] + ifFalse: + [thorough ifTrue: + [lit isVariableBinding + ifTrue: + [literal == lit key ifTrue: [^true]] + ifFalse: + [(lit isArray + and: [(lit hasLiteral: literal) + or: [literal isVariableBinding + and: [literal key isSymbol + and: [lit hasLiteral: literal key]]]]) ifTrue: + [^true]]]]]. + scanBlockOrNil ifNotNil: + [(self scanFor: scanBlockOrNil) ifTrue: + [^true]]. + ^false! Item was added: + ----- Method: CompiledCode>>refersTo:primaryBytecodeScanner:secondaryBytecodeScanner:thorough: (in category '*60Deprecated-literals') ----- + refersTo: literal primaryBytecodeScanner: primaryScanBlockOrNil secondaryBytecodeScanner: secondaryScanBlockOrNil thorough: thorough + "Answer if the receiver refers to the literal. If the scan blocks are non-nil, then + use them to find the literal in bytecode. If thorough is true, dive down into + literal arrays and method properties to locate references to the literal there-in." + ^self + refersTo: literal + bytecodeScanner: (self signFlag + ifTrue: [secondaryScanBlockOrNil] + ifFalse: [primaryScanBlockOrNil]) + thorough: thorough! Item was added: + ----- Method: CompiledMethod>>hasLiteralThorough: (in category '*60Deprecated-literals') ----- + hasLiteralThorough: literal + "Answer true if any literal in this method is literal, + even if embedded in array structure." + + (self penultimateLiteral isMethodProperties + and: [self penultimateLiteral hasLiteralThorough: literal]) ifTrue:[^true]. + 2 to: self numLiterals - 1 "exclude superclass + selector/properties" + do:[:index | | lit | + (((lit := self objectAt: index) literalEqual: literal) + or: [(lit isVariableBinding and: [lit key == literal]) + or: [lit isArray and: [lit hasLiteral: literal]]]) ifTrue: + [^ true]]. + ^ false ! Item was added: + ----- Method: CompiledMethod>>refersToLiteral: (in category '*60Deprecated-literals') ----- + refersToLiteral:aLiteral + + ^self hasLiteral: aLiteral.!

1 0

The Trunk: Kernel-mt.1244.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1244.mcz ==================== Summary ==================== Name: Kernel-mt.1244 Author: mt Time: 12 July 2019, 9:59:41.866568 am UUID: d585f898-09cc-094b-98ed-a74204c82019 Ancestors: Kernel-mt.1243 Refactoring of #literalsDo: - Step 2 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against Kernel-mt.1243 =============== Item was removed: - ----- Method: AdditionalMethodState>>hasLiteralSuchThat: (in category 'testing') ----- - hasLiteralSuchThat: aBlock - "Answer true if litBlock returns true for any literal in this array, even if embedded in further array structure. - This method is only intended for private use by CompiledMethod hasLiteralSuchThat:" - 1 to: self basicSize do: [:i | - | propertyOrPragma "<Association|Pragma>" | - propertyOrPragma := self basicAt: i. - (propertyOrPragma isVariableBinding - ifTrue: [(aBlock value: propertyOrPragma key) - or: [(aBlock value: propertyOrPragma value) - or: [propertyOrPragma value isArray - and: [propertyOrPragma value hasLiteralSuchThat: aBlock]]]] - ifFalse: [propertyOrPragma hasLiteralSuchThat: aBlock]) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledBlock>>allLiterals (in category 'literals') ----- - allLiterals - ^self homeMethod allLiterals! Item was removed: - ----- Method: CompiledBlock>>allSubLiterals (in category 'literals') ----- - allSubLiterals - | literalsExceptOuter unfoldedSubLiterals | - literalsExceptOuter := self literals allButLast. - unfoldedSubLiterals := literalsExceptOuter - select: [:lit| lit isCompiledCode] - thenCollect: [:blockMethod| blockMethod allSubLiterals]. - unfoldedSubLiterals ifEmpty: - [^literalsExceptOuter]. - ^literalsExceptOuter, (unfoldedSubLiterals fold: [:a :b| a, b])! Item was added: + ----- Method: CompiledBlock>>codeLiteralsDo: (in category 'literals') ----- + codeLiteralsDo: aBlock + "Overwritten to not cause infinite loop." + + aBlock value: self. + + self literalsDo: [:literal | + (literal isCompiledCode and: [literal ~~ self outerCode]) ifTrue: [ + literal codeLiteralsDo: aBlock]].! Item was removed: - ----- Method: CompiledBlock>>hasLiteral: (in category 'literals') ----- - hasLiteral: literal - "Answer whether the receiver references the argument, literal." - 2 to: self numLiterals do: "exclude outerCode" - [:index | | lit | - lit := self objectAt: index. - (lit literalEqual: literal) ifTrue: - [^true]. - (lit isCompiledCode and: [lit hasLiteral: literal]) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledBlock>>hasLiteralSuchThat: (in category 'literals') ----- - hasLiteralSuchThat: litBlock - "Answer true if litBlock returns true for any literal in this method, even if embedded in array structure." - 2 to: self numLiterals do: "exclude outerCode" - [:index | | lit | - lit := self objectAt: index. - ((litBlock value: lit) - or: [(lit isArray or: [lit isCompiledCode]) and: [lit hasLiteralSuchThat: litBlock]]) ifTrue: - [^true]]. - ^false! Item was changed: ----- Method: CompiledCode>>allLiterals (in category 'literals') ----- allLiterals + "Skip compiled-code objects. Keep literal arrays, bindings, etc." + + ^ Array streamContents: [:result | + self allLiteralsDo: [:literal | result nextPut: literal]]! - self subclassResponsibility! Item was added: + ----- Method: CompiledCode>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + "Enumerate all literals thoroughly. Follow nested instances of CompiledCode. Do not treat compiled code as literals here." + + self codeLiteralsDo: [:compiledCode | compiledCode literalsDo: [:literal | + literal isCompiledCode ifFalse: [literal allLiteralsDo: aBlock] ]]. + + "Enumerate special selectors." + self flag: #todo. + + "Enumerate special literals such as true and false." + self flag: #todo.! Item was added: + ----- Method: CompiledCode>>codeLiterals (in category 'literals') ----- + codeLiterals + + ^ Array streamContents: [:stream | + self codeLiteralsDo: [:compiledCode | stream nextPut: compiledCode]]! Item was added: + ----- Method: CompiledCode>>codeLiteralsDo: (in category 'literals') ----- + codeLiteralsDo: aBlock + "Enumerate all literals that represent instances of CompiledCode. This is especially required for SistaV1." + + aBlock value: self. + + self literalsDo: [:literal | literal isCompiledCode ifTrue: [ + literal codeLiteralsDo: aBlock]].! Item was added: + ----- Method: CompiledCode>>hasLiteral: (in category 'literals') ----- + hasLiteral: aLiteral + "Since we cannot enumerate this code's special literals, we have to overwrite this method to invoke the encoder scanner explicitely." + + | scanBlock | + (super hasLiteral: aLiteral) ifTrue: [^ true]. + + scanBlock := self class + scanBlocksForLiteral: aLiteral + do: [:primaryScanner :secondaryScanner | + "E.g., scanner for SistaV1 or scanner for V3PlusClosures" + self signFlag ifTrue: [secondaryScanner] ifFalse: [primaryScanner]]. + + self codeLiteralsDo: [:compiledCode | + (compiledCode scanFor: scanBlock) ifTrue: [^ true]]. + + ^ false! Item was added: + ----- Method: CompiledCode>>hasMethodReturn (in category 'testing') ----- + hasMethodReturn + "Answer whether the receiver has a method-return ('^') in its code." + + | scanner | + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: [:x | (scanner willReturn + and: [scanner willBlockReturn not]) + "and: [scanner willReturnTopFromMethod not]" "-> Not supported in EncoderForSistaV1"]) + ifTrue: [^ true]]. + ^ false! Item was added: + ----- Method: CompiledCode>>isQuick (in category 'testing') ----- + isQuick + + self subclassResponsibility.! Item was changed: ----- Method: CompiledCode>>literals (in category 'literals') ----- literals + + ^ Array streamContents: [:result | + self literalsDo: [:lit | result nextPut: lit]]! - "Answer an Array of the literals referenced by the receiver." - | literals numberLiterals | - literals := Array new: (numberLiterals := self numLiterals). - 1 to: numberLiterals do: - [:index | - literals at: index put: (self objectAt: index + 1)]. - ^literals! Item was added: + ----- Method: CompiledCode>>literalsDo: (in category 'literals') ----- + literalsDo: aBlock + "Evaluate aBlock for each of the literals referenced by the receiver. Note that this (raw) enumeration addresses *all* objects stored *after* the method header and *before* the first byte code. If you require a deep and meaningful enumeration of literals use #allLiteralsDo: or #codeLiteralsDo:." + + 1 to: self numLiterals do: [:index | + aBlock value: (self literalAt: index)].! Item was changed: ----- Method: CompiledCode>>messages (in category 'scanning') ----- messages "Answer a Set of all the message selectors sent by this method." + | result | + result := Set new. + self messagesDo: [:selector | result add: selector]. + ^ result! - | encoderClass scanner aSet | - encoderClass := self encoderClass. - aSet := Set new. - scanner := InstructionStream on: self. - scanner scanFor: [ :x | - | selector | - (selector := encoderClass selectorToSendOrItselfFor: scanner in: self at: scanner pc) == scanner - ifFalse: - [aSet add: selector] - ifTrue: - [(encoderClass blockMethodOrNilFor: scanner in: self at: scanner pc) ifNotNil: - [:blockMethod| aSet addAll: blockMethod messages]]. - false "keep scanning" ]. - ^aSet! Item was added: + ----- Method: CompiledCode>>messagesDo: (in category 'scanning') ----- + messagesDo: workBlock + "Evaluate aBlock with all the message selectors sent by me. Duplicate sends possible." + + | scanner selector | + self isQuick ifTrue: [^ self]. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + scanner scanFor: [ :x | + (selector := scanner selectorToSendOrSelf) == scanner + ifFalse: [workBlock value: selector]. + false "keep scanning" ] ].! Item was removed: - ----- Method: CompiledCode>>messagesDo:encoderClass:visitedSet: (in category 'private') ----- - messagesDo: aBlock encoderClass: encoderClass visitedSet: visitedSet - "The inner engine for messagesDo:" - - | scanner | - scanner := InstructionStream on: self. - scanner scanFor: [ :x | - | selector | - (selector := encoderClass selectorToSendOrItselfFor: scanner in: self at: scanner pc) == scanner - ifFalse: - [(visitedSet ifAbsentAdd: selector) ifTrue: - [aBlock value: selector]] - ifTrue: - [(encoderClass blockMethodOrNilFor: scanner in: self at: scanner pc) ifNotNil: - [:blockMethod| - blockMethod messagesDo: aBlock encoderClass: encoderClass visitedSet: visitedSet]]. - false "keep scanning" ]! Item was removed: - ----- Method: CompiledCode>>refersTo:bytecodeScanner:thorough: (in category 'literals') ----- - refersTo: literal bytecodeScanner: scanBlockOrNil thorough: thorough - "Answer if the receiver refers to the literal. If the scan block is non-nil, then - use it to find the literal in bytecode. If thorough is true, dive down into - literal arrays and method properties to locate references to the literal there-in." - 2 to: (self isCompiledBlock - ifTrue: [self numLiterals] "exclude outerCode or methodClass" - ifFalse: [self numLiterals - 1]) "exclude selector/properties and methodClass" - do: [:i| | lit | - lit := self objectAt: i. - (literal == lit or: [literal literalEqual: lit]) ifTrue: [^true]. "== for Float bindingOf: #NaN since NaN ~= NaN" - lit isCompiledCode - ifTrue: - [(lit refersTo: literal bytecodeScanner: scanBlockOrNil thorough: thorough) ifTrue: - [^true]] - ifFalse: - [thorough ifTrue: - [lit isVariableBinding - ifTrue: - [literal == lit key ifTrue: [^true]] - ifFalse: - [(lit isArray - and: [(lit hasLiteral: literal) - or: [literal isVariableBinding - and: [literal key isSymbol - and: [lit hasLiteral: literal key]]]]) ifTrue: - [^true]]]]]. - scanBlockOrNil ifNotNil: - [(self scanFor: scanBlockOrNil) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledCode>>refersTo:primaryBytecodeScanner:secondaryBytecodeScanner:thorough: (in category 'literals') ----- - refersTo: literal primaryBytecodeScanner: primaryScanBlockOrNil secondaryBytecodeScanner: secondaryScanBlockOrNil thorough: thorough - "Answer if the receiver refers to the literal. If the scan blocks are non-nil, then - use them to find the literal in bytecode. If thorough is true, dive down into - literal arrays and method properties to locate references to the literal there-in." - ^self - refersTo: literal - bytecodeScanner: (self signFlag - ifTrue: [secondaryScanBlockOrNil] - ifFalse: [primaryScanBlockOrNil]) - thorough: thorough! Item was changed: ----- Method: CompiledCode>>scanFor: (in category 'scanning') ----- scanFor: byteOrClosure "Answer whether the receiver contains the argument as a bytecode, if it is a number, or evaluates to true if a block. If a block it can take from one to four bytes." | s end | ^(s := InstructionStream on: self) scanFor: (byteOrClosure isBlock ifTrue: [byteOrClosure numArgs caseOf: { [1] -> [byteOrClosure]. [2] -> [[:byte| byteOrClosure value: byte value: s secondByte]]. [3] -> [end := self endPC - 2. [:byte| s pc <= end and: [byteOrClosure value: byte value: s secondByte value: s thirdByte]]]. [4] -> [end := self endPC - 3. [:byte| s pc <= end and: [byteOrClosure value: byte value: s secondByte value: s thirdByte value: s fourthByte]]] }] ifFalse: [[:instr | instr = byteOrClosure]]) " + SystemNavigation default browseAllSelect: [:m | m scanFor: 134] - Smalltalk browseAllSelect: [:m | m scanFor: 134] "! Item was added: + ----- Method: CompiledCode>>sendsMessage: (in category 'testing') ----- + sendsMessage: aSelector + + self messagesDo: [:selector | + selector = aSelector ifTrue: [^ true]]. + ^ false! Item was added: + ----- Method: CompiledCode>>sendsSelector: (in category 'testing') ----- + sendsSelector: aSelector + + self flag: #todo. "mt: Deprecate? AST/Refactoring project needs it..." + ^ self sendsMessage: aSelector! Item was added: + ----- Method: CompiledCode>>sendsToSuper (in category 'testing') ----- + sendsToSuper + "Answer whether the receiver sends any message to super." + + | scanner | + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass superSendScanBlockUsing: scanner)) + ifTrue: [^ true]]. + ^ false! Item was removed: - ----- Method: CompiledMethod>>allLiterals (in category 'literals') ----- - allLiterals - | literals unfoldedSubLiterals | - literals := self literals. - unfoldedSubLiterals := literals - select: [:lit| lit isCompiledCode] - thenCollect: [:blockMethod| blockMethod allSubLiterals]. - unfoldedSubLiterals ifEmpty: - [^literals]. - ^literals, (unfoldedSubLiterals fold: [:a :b| a, b])! Item was added: + ----- Method: CompiledMethod>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + "Overwritten to skip certain (raw) literals." + + " Exclude method selector (or properties) and the method's class." + 1 to: self numLiterals - 2 do: [:index | + (self literalAt: index) allLiteralsDo: aBlock]. + + "Enumerate method selector only through additional method state." + self penultimateLiteral isMethodProperties + ifTrue: [self penultimateLiteral allLiteralsDo: aBlock]. + + "Enumerate special selectors." + self flag: #todo. + + "Enumerate special literals such as true and false." + self flag: #todo.! Item was removed: - ----- Method: CompiledMethod>>hasLiteral: (in category 'literals') ----- - hasLiteral: literal - "Answer whether the receiver references the argument, literal." - 2 to: self numLiterals - 1 do: "exclude selector/properties & methodClass" - [:index | | lit | - lit := self objectAt: index. - (lit literalEqual: literal) ifTrue: - [^true]. - (lit isCompiledCode and: [lit hasLiteral: literal]) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledMethod>>hasLiteralSuchThat: (in category 'literals') ----- - hasLiteralSuchThat: litBlock - "Answer true if litBlock returns true for any literal in this method, even if embedded in array structure." - (self penultimateLiteral isMethodProperties - and: [self penultimateLiteral hasLiteralSuchThat: litBlock]) ifTrue: - [^true]. - 2 to: self numLiterals + 1 do: - [:index | | lit | - lit := self objectAt: index. - ((litBlock value: lit) - or: [(lit isArray or: [lit isCompiledCode]) and: [lit hasLiteralSuchThat: litBlock]]) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledMethod>>hasLiteralThorough: (in category 'literals') ----- - hasLiteralThorough: literal - "Answer true if any literal in this method is literal, - even if embedded in array structure." - - (self penultimateLiteral isMethodProperties - and: [self penultimateLiteral hasLiteralThorough: literal]) ifTrue:[^true]. - 2 to: self numLiterals - 1 "exclude superclass + selector/properties" - do:[:index | | lit | - (((lit := self objectAt: index) literalEqual: literal) - or: [(lit isVariableBinding and: [lit key == literal]) - or: [lit isArray and: [lit hasLiteral: literal]]]) ifTrue: - [^ true]]. - ^ false ! Item was removed: - ----- Method: CompiledMethod>>literalsDo: (in category 'literals') ----- - literalsDo: aBlock - "Evaluate aBlock for each of the literals referenced by the receiver." - 1 to: self numLiterals do: - [:index | - aBlock value: (self objectAt: index + 1)]! Item was removed: - ----- Method: CompiledMethod>>messages (in category 'scanning') ----- - messages - "Answer a Set of all the message selectors sent by this method." - - | scanner aSet | - aSet := Set new. - scanner := InstructionStream on: self. - scanner scanFor: [ :x | - | selector | - (selector := scanner selectorToSendOrSelf) == scanner ifFalse: [ - aSet add: selector ]. - false "keep scanning" ]. - ^aSet! Item was removed: - ----- Method: CompiledMethod>>messagesDo: (in category 'scanning') ----- - messagesDo: aBlock - "Evaluate aBlock exactly once with all the message selectors sent by me." - - self isQuick ifFalse: - [self messagesDo: aBlock - encoderClass: self encoderClass - visitedSet: IdentitySet new]! Item was changed: ----- Method: CompiledMethod>>messagesSequence (in category 'scanning') ----- messagesSequence - "Answer a Set of all the message selectors sent by this method." + self flag: #todo. "mt: Better change #messages to return an array instead of a set?" + ^ self messages asArray! - ^Array streamContents: - [:str| | scanner | - scanner := InstructionStream on: self. - scanner scanFor: - [:x | | selectorOrSelf | - (selectorOrSelf := scanner selectorToSendOrSelf) == scanner ifFalse: - [str nextPut: selectorOrSelf]. - false "keep scanning"]]! Item was changed: ----- Method: CompiledMethod>>objectForDataStream: (in category 'file in/out') ----- objectForDataStream: refStrm + "Reconfigure pragma. Example: #(#FFTPlugin #primitiveFFTTransformData 0 0). See FFT >> #pluginTransformData:." + + self primitive = 117 ifTrue: [(self literalAt: 1) at: 4 put: 0].! - - self primitive = 117 ifTrue: [self literals first at: 4 put: 0]. - ! Item was changed: ----- Method: CompiledMethod>>readsField: (in category 'scanning') ----- readsField: varIndex + "Answer whether the receiver loads the instance variable indexed by the argument." + - "Answer whether the receiver loads the instance variable indexed by the argument." | varIndexCode scanner | varIndexCode := varIndex - 1. + self isQuick ifTrue: [^ self isReturnField and: [self returnField = varIndexCode]]. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass instVarReadScanBlockFor: varIndexCode using: scanner)) + ifTrue: [^ true]]. + + ^ false! - self isQuick ifTrue: - [^self isReturnField and: [self returnField = varIndexCode]]. - scanner := InstructionStream on: self. - ^scanner scanFor:(self encoderClass instVarReadScanBlockFor: varIndexCode using: scanner)! Item was changed: ----- Method: CompiledMethod>>readsRef: (in category 'scanning') ----- readsRef: variableBinding "Answer whether the receiver reads the value of the argument." "eem 5/24/2008 Rewritten to no longer assume the compler uses the most compact encoding available (for EncoderForLongFormV3 support)." + | litIndex scanner | + (litIndex := self indexOfLiteral: variableBinding) = 0 + ifTrue: [^false]. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass bindingReadScanBlockFor: litIndex - 1 using: scanner)) + ifTrue: [^ true]]. + + ^ false! - (litIndex := self indexOfLiteral: variableBinding) = 0 ifTrue: - [^false]. - scanner := InstructionStream on: self. - ^scanner scanFor: (self encoderClass bindingReadScanBlockFor: litIndex - 1 using: scanner)! Item was removed: - ----- Method: CompiledMethod>>refersToLiteral: (in category 'literals') ----- - refersToLiteral:aLiteral - - ^self hasLiteral: aLiteral.! Item was removed: - ----- Method: CompiledMethod>>sendsSelector: (in category 'literals') ----- - sendsSelector: aSelector - | scanner | - scanner := InstructionStream on: self. - scanner scanFor: - [:x | - scanner selectorToSendOrSelf == aSelector ifTrue: - [^true]. - false "keep scanning"]. - ^false! Item was removed: - ----- Method: CompiledMethod>>sendsToSuper (in category 'scanning') ----- - sendsToSuper - "Answer whether the receiver sends any message to super." - | scanner | - scanner := InstructionStream on: self. - ^scanner scanFor: (self encoderClass superSendScanBlockUsing: scanner)! Item was changed: ----- Method: CompiledMethod>>writesField: (in category 'scanning') ----- writesField: varIndex + "Answer whether the receiver stores into the instance variable indexed by the argument." - "Answer whether the receiver stores into the instance variable indexed - by the argument." + | varIndexCode scanner | + self isQuick ifTrue: [^ false]. + varIndexCode := varIndex - 1. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass instVarWriteScanBlockFor: varIndex - 1 using: scanner)) + ifTrue: [^ true]]. + + ^ false! - | scanner | - self isQuick ifTrue: [^false]. - scanner := InstructionStream on: self. - ^scanner scanFor: (self encoderClass instVarWriteScanBlockFor: varIndex - 1 using: scanner)! Item was changed: ----- Method: CompiledMethod>>writesRef: (in category 'scanning') ----- writesRef: variableBinding "Answer whether the receiver writes the value of the argument." "eem 5/24/2008 Rewritten to no longer assume the compler uses the most compact encoding available (for EncoderForLongFormV3 support)." + | litIndex scanner | + (litIndex := self indexOfLiteral: variableBinding) = 0 + ifTrue: [^ false]. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass bindingWriteScanBlockFor: litIndex - 1 using: scanner)) + ifTrue: [^ true]]. + + ^ false! - (litIndex := self indexOfLiteral: variableBinding) = 0 ifTrue: - [^false]. - scanner := InstructionStream on: self. - ^scanner scanFor: (self encoderClass bindingWriteScanBlockFor: litIndex - 1 using: scanner)! Item was removed: - ----- Method: Pragma>>hasLiteralSuchThat: (in category 'testing') ----- - hasLiteralSuchThat: aBlock - "Answer true if litBlock returns true for any literal in the receiver, even if embedded in further array structure. - This method is only intended for private use by CompiledMethod hasLiteralSuchThat:" - ^(aBlock value: keyword) - or: [arguments hasLiteralSuchThat: aBlock]!

1 0

The Trunk: Collections-mt.842.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.842.mcz ==================== Summary ==================== Name: Collections-mt.842 Author: mt Time: 12 July 2019, 9:59:20.039568 am UUID: 3515a0c8-a91a-5b47-a466-71ea1e2d5b85 Ancestors: Collections-mt.841 Refactoring of #literalsDo: - Step 2 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against Collections-mt.841 =============== Item was removed: - ----- Method: Array>>hasLiteral: (in category 'private') ----- - hasLiteral: literal - "Answer true if literal is identical to any literal in this array, even - if imbedded in further array structure. This method is only intended - for private use by CompiledMethod hasLiteralSymbol:" - - | lit | - 1 to: self size do: - [:index | - ((lit := self at: index) literalEqual: literal) ifTrue: [^true]. - (Array == lit class and: [lit hasLiteral: literal]) ifTrue: [^true]]. - ^false! Item was removed: - ----- Method: Array>>hasLiteralSuchThat: (in category 'private') ----- - hasLiteralSuchThat: testBlock - "Answer true if testBlock returns true for any literal in this array, even if imbedded in further Arrays or CompiledMethods. This method is only intended for private use by CompiledMethod hasLiteralSuchThat:" - | lit | - 1 to: self size do: [:index | - (testBlock value: (lit := self at: index)) ifTrue: [^ true]. - (lit hasLiteralSuchThat: testBlock) ifTrue: [^ true]]. - ^ false! Item was changed: + ----- Method: Array>>literalEqual: (in category 'literals') ----- - ----- Method: Array>>literalEqual: (in category 'comparing') ----- literalEqual: other self class == other class ifFalse: [^ false]. self size = other size ifFalse: [^ false]. self with: other do: [:e1 :e2 | (e1 literalEqual: e2) ifFalse: [^ false]]. ^ true!

1 0

The Trunk: Environments-mt.74.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of Environments to project The Trunk: http://source.squeak.org/trunk/Environments-mt.74.mcz ==================== Summary ==================== Name: Environments-mt.74 Author: mt Time: 12 July 2019, 9:57:37.434568 am UUID: b2ca73b4-da07-6347-bf46-d721c411037b Ancestors: Environments-pre.73 Refactoring of #literalsDo: - Step 1 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against Environments-pre.73 =============== Item was changed: + ----- Method: Alias>>literalEqual: (in category 'literals') ----- - ----- Method: Alias>>literalEqual: (in category 'error handling') ----- literalEqual: other "Two aliases are equal if they have the same source" ^ self species = other species and: [self source == other source]! Item was added: + ----- Method: Binding>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + + "I am a literal." + aBlock value: self. + + self key allLiteralsDo: aBlock. + self value allLiteralsDo: aBlock.! Item was changed: + ----- Method: ClassBinding>>literalEqual: (in category 'literals') ----- - ----- Method: ClassBinding>>literalEqual: (in category 'comparing') ----- literalEqual: other "Class bindings are equal when the bind the same class" ^ self species = other species and: [self value = other value]! Item was changed: + ----- Method: Global>>literalEqual: (in category 'literals') ----- - ----- Method: Global>>literalEqual: (in category 'comparing') ----- literalEqual: other "Globals are only equal to themselves, since another global with the same name could have a different value in the future." ^ self == other!

1 0

The Trunk: System-mt.1070.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1070.mcz ==================== Summary ==================== Name: System-mt.1070 Author: mt Time: 12 July 2019, 9:57:13.091568 am UUID: 7fd7c3dd-86d3-2244-8971-02c8e55dca46 Ancestors: System-mt.1069 Refactoring of #literalsDo: - Step 1 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against System-mt.1069 =============== Item was added: + ----- Method: WrappedBreakpoint>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + "This method is necessary to show the breakpoint-flag in the browser." + + aBlock value: #break. + method allLiteralsDo: aBlock.! Item was changed: ----- Method: WrappedBreakpoint>>literalsDo: (in category 'literals') ----- literalsDo: aBlock "This method is necessary to show the breakpoint-flag in the browser." aBlock value: #break. + method literalsDo: aBlock.! - method literalsDo: aBlock!

1 0

The Trunk: Kernel-mt.1243.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1243.mcz ==================== Summary ==================== Name: Kernel-mt.1243 Author: mt Time: 12 July 2019, 9:56:47.949568 am UUID: 741f1855-ce1a-4d48-b741-9eeed6a4d7a0 Ancestors: Kernel-eem.1242 Refactoring of #literalsDo: - Step 1 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against Kernel-eem.1242 =============== Item was added: + ----- Method: AdditionalMethodState>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + + 1 to: self basicSize do: [:index | + (self basicAt: index) allLiteralsDo: aBlock].! Item was added: + ----- Method: Object>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + + self flag: #discuss. "mt: Better implement this only on Symbol, Array, Number, Binding, etc. instead of Object?" + aBlock value: self.! Item was added: + ----- Method: Object>>hasLiteral: (in category 'literals') ----- + hasLiteral: literal + + ^ self hasLiteralSuchThat: [:lit | lit literalEqual: literal]! Item was changed: + ----- Method: Object>>hasLiteralSuchThat: (in category 'literals') ----- - ----- Method: Object>>hasLiteralSuchThat: (in category 'testing') ----- hasLiteralSuchThat: testBlock - "This is the end of the imbedded structure path so return false." + self allLiteralsDo: [:literal | + (testBlock value: literal) ifTrue: [^ true]]. + ^ false! Item was added: + ----- Method: Pragma>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + + keyword allLiteralsDo: aBlock. + arguments allLiteralsDo: aBlock.! Item was changed: + ----- Method: Pragma>>hasLiteral: (in category 'literals') ----- - ----- Method: Pragma>>hasLiteral: (in category 'testing') ----- hasLiteral: aLiteral + "Extra support for #hasLiteralTest:." + + ^ (super hasLiteral: aLiteral) - ^keyword == aLiteral - or: [(arguments hasLiteral: aLiteral) or: [keyword == #hasLiteralTest: and: [ + self methodClass theNonMetaClass perform: arguments first with: aLiteral]]! - self methodClass theNonMetaClass perform: arguments first with: aLiteral]]]!

1 0

The Trunk: Collections-mt.841.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.841.mcz ==================== Summary ==================== Name: Collections-mt.841 Author: mt Time: 12 July 2019, 9:56:25.049568 am UUID: 2d41256f-bbb4-f54d-9d84-87c482bfa9dd Ancestors: Collections-mt.840 Refactoring of #literalsDo: - Step 1 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against Collections-mt.840 =============== Item was added: + ----- Method: Array>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + + "I am a literal." + aBlock value: self. + + "All my elements are literals." + self do: [:each | each allLiteralsDo: aBlock].! Item was added: + ----- Method: Association>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + "This strategy origins from a former implementation of CompiledMethod >> #hasLiteralThorough: as well as AdditionalMethodState >> #hasLiteralSuchThat:." + + "I am a literal." + aBlock value: self. + + "All my components are literals." + self key allLiteralsDo: aBlock. + self value allLiteralsDo: aBlock.! Item was changed: + ----- Method: Association>>literalEqual: (in category 'literals') ----- - ----- Method: Association>>literalEqual: (in category 'testing') ----- literalEqual: otherLiteral "Answer true if the receiver and otherLiteral represent the same literal. Variable bindings are literally equals only if identical. This is how variable sharing works, by preserving identity and changing only the value." ^self == otherLiteral!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Packages July 2019