Packages August 2019

packages@lists.squeakfoundation.org

1 participants
150 discussions

The Trunk: ToolBuilder-Morphic-ct.234.mcz
by commits＠source.squeak.org 06 Aug '19

06 Aug '19

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.234.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-ct.234 Author: ct Time: 5 August 2019, 2:50:11.900062 pm UUID: f6987fae-9cfa-4e44-927f-247f4eeb868e Ancestors: ToolBuilder-Morphic-mt.233 Extend #updateStyle(Now) to remove obsolete styling A call of #updateStyle(Now) implies that the text morph is used for styling, so it is not capable of storing other styles we could accidentally delete here. =============== Diff against ToolBuilder-Morphic-mt.233 =============== Item was changed: ----- Method: PluggableTextMorphPlus>>updateStyle (in category 'styling') ----- updateStyle self okToStyle + ifTrue: [styler styleInBackgroundProcess: textMorph contents] + ifFalse: [textMorph contents: textMorph contents asString].! - ifTrue: [styler styleInBackgroundProcess: textMorph contents].! Item was changed: ----- Method: PluggableTextMorphPlus>>updateStyleNow (in category 'styling') ----- updateStyleNow self okToStyle + ifTrue: [styler style: textMorph contents] + ifFalse: [textMorph contents: textMorph contents asString].! - ifTrue: [styler style: textMorph contents].!

1 0

The Trunk: Tools-mt.856.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.856.mcz ==================== Summary ==================== Name: Tools-mt.856 Author: mt Time: 24 July 2019, 1:18:41.968109 pm UUID: 49d7ca18-63b6-4870-acaf-a44ec7c91b84 Ancestors: Tools-mt.855 In the system browser's message list, show deprecated methods gray and struck-out when all message are listed. =============== Diff against Tools-mt.855 =============== Item was changed: ----- Method: Browser>>messageList (in category 'message list') ----- messageList + "Answer an Array of the message selectors of the currently selected message category. If no category is selected or the '-- all --' category is selected, return all method selectors. Make deprecated messages look gray and struck-out." + - "Answer an Array of the message selectors of the currently selected message category, provided that the messageCategoryListIndex is in proper range. Otherwise, answer an empty Array If messageCategoryListIndex is found to be larger than the number of categories (it happens!!), it is reset to zero." - | sel | - (sel := self messageCategoryListSelection) ifNil: - [ - ^ self classOrMetaClassOrganizer - ifNil: [Array new] - ifNotNil: [self classOrMetaClassOrganizer allMethodSelectors] - "^ Array new" - ]. + ^ (self selectedMessageCategoryName isNil or: [self selectedMessageCategoryName = ClassOrganizer allCategory]) + ifTrue: [ + self classOrMetaClassOrganizer + ifNil: [Array new] + ifNotNil: [:organizer | organizer allMethodSelectors collect: [:ea | + | method | + ea = #messageList ifTrue: [ea] ifFalse: [ + method := self selectedClassOrMetaClass compiledMethodAt: ea. + ((method hasLiteral: #deprecated scanForSpecial: false) + or: [method hasLiteral: #deprecated: scanForSpecial: false]) + ifTrue: [ea asText + addAttribute: (TextColor color: Color gray); + addAttribute: TextEmphasis struckOut; + yourself] + ifFalse: [ea]]]]] + ifFalse: [ + (self classOrMetaClassOrganizer listAtCategoryNamed: self selectedMessageCategoryName) + ifNil: [Array new]]! - ^ sel = ClassOrganizer allCategory - ifTrue: - [self classOrMetaClassOrganizer - ifNil: [Array new] - ifNotNil: [self classOrMetaClassOrganizer allMethodSelectors]] - ifFalse: - [(self classOrMetaClassOrganizer listAtCategoryNamed: self selectedMessageCategoryName ) - ifNil: [selectedMessageCategoryName := nil. Array new]]!

1 0

The Trunk: Tools-mt.864.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.864.mcz ==================== Summary ==================== Name: Tools-mt.864 Author: mt Time: 4 August 2019, 4:36:12.203381 pm UUID: cb8e1c1e-b28e-a647-a72e-1c49fe42bcc0 Ancestors: Tools-mt.856, Tools-mt.863 Merges and refines Tools-mt.856 based on the discussion on squeak-dev: http://forum.world.st/The-Inbox-Tools-mt-856-mcz-td5101574.html Note that if you notice any performance problems on slower machines, we might want to make this a preference. =============== Diff against Tools-mt.863 =============== Item was changed: ----- Method: Browser>>messageList (in category 'message list') ----- messageList + "Answer an Array of the message selectors of the currently selected message category. If no category is selected or the '-- all --' category is selected, return all method selectors. Make deprecated messages look gray and struck-out." + - "Answer an Array of the message selectors of the currently selected message category, provided that the messageCategoryListIndex is in proper range. Otherwise, answer an empty Array If messageCategoryListIndex is found to be larger than the number of categories (it happens!!), it is reset to zero." - | sel | - (sel := self messageCategoryListSelection) ifNil: - [ - ^ self classOrMetaClassOrganizer - ifNil: [Array new] - ifNotNil: [self classOrMetaClassOrganizer allMethodSelectors] - "^ Array new" - ]. + ^ (self selectedMessageCategoryName isNil or: [self selectedMessageCategoryName = ClassOrganizer allCategory]) + ifTrue: [ + self classOrMetaClassOrganizer + ifNil: [Array new] + ifNotNil: [:organizer | organizer allMethodSelectors collect: [:ea | + self formattedLabel: ea]]] + ifFalse: [ + (self classOrMetaClassOrganizer listAtCategoryNamed: self selectedMessageCategoryName) + collect: [:ea | self formattedLabel: ea]]! - ^ sel = ClassOrganizer allCategory - ifTrue: - [self classOrMetaClassOrganizer - ifNil: [Array new] - ifNotNil: [self classOrMetaClassOrganizer allMethodSelectors]] - ifFalse: - [(self classOrMetaClassOrganizer listAtCategoryNamed: self selectedMessageCategoryName ) - ifNil: [selectedMessageCategoryName := nil. Array new]]! Item was added: + ----- Method: CodeHolder>>formattedLabel: (in category 'message list') ----- + formattedLabel: aString + + ^ self + formattedLabel: aString + forSelector: aString + inClass: self selectedClassOrMetaClass! Item was added: + ----- Method: CodeHolder>>formattedLabel:forSelector:inClass: (in category 'message list') ----- + formattedLabel: aString forSelector: aSymbol inClass: aClass + "Show deprecated messages differently so that users recognize them quickly to avoid them." + + | formattedLabel | + aSymbol = #Definition + ifTrue: [aClass isDeprecated not + ifTrue: [^ aString]] + ifFalse: [(aClass compiledMethodAt: aSymbol) isDeprecated not + ifTrue: [^ aString]]. + + formattedLabel := aString asText. + + (self userInterfaceTheme deprecatedMessageAttributes ifNil: [{TextColor gray. TextEmphasis struckOut}]) do: [:textAttribute | + formattedLabel addAttribute: textAttribute]. + + ^ formattedLabel.! Item was changed: CodeHolder subclass: #MessageSet + instanceVariableNames: 'growable messageList messageListFormatted autoSelectString messageListIndex editSelection' - instanceVariableNames: 'growable messageList autoSelectString messageListIndex editSelection' classVariableNames: 'UseUnifiedMessageLabels' poolDictionaries: '' category: 'Tools-Browser'! !MessageSet commentStamp: '<historical>' prior: 0! I represent a query path of the retrieval result of making a query about methods in the system. The result is a set of methods, denoted by a message selector and the class in which the method was found. As a StringHolder, the string I represent is the source code of the currently selected method. I am typically viewed in a Message Set Browser consisting of a MessageListView and a BrowserCodeView.! Item was changed: ----- Method: MessageSet>>buildMessageListWith: (in category 'toolbuilder') ----- buildMessageListWith: builder | listSpec | listSpec := builder pluggableListSpec new. listSpec model: self; + list: #messageListFormatted; - list: #messageList; getIndex: #messageListIndex; setIndex: #messageListIndex:; icon: #messageIconAt:; help: #messageHelpAt:; menu: #messageListMenu:shifted:; keyPress: #messageListKey:from:. SystemBrowser browseWithDragNDrop ifTrue:[listSpec dragItem: #dragFromMessageList:]. ^listSpec ! Item was added: + ----- Method: MessageSet>>changed: (in category 'updating') ----- + changed: aspect + + super changed: aspect. + + aspect = #messageList ifTrue: [ + messageListFormatted := nil. + self changed: #messageListFormatted].! Item was added: + ----- Method: MessageSet>>formattedLabel: (in category 'message list') ----- + formattedLabel: aStringOrCodeReference + + self class parse: aStringOrCodeReference toClassAndSelector: [:cls :sel | + ^ self + formattedLabel: aStringOrCodeReference asString + forSelector: sel + inClass: cls]! Item was added: + ----- Method: MessageSet>>messageListFormatted (in category 'message list') ----- + messageListFormatted + + ^ messageListFormatted ifNil: [ + messageListFormatted := messageList collect: [:ea | self formattedLabel: ea]]! Item was changed: ----- Method: MessageTrace>>buildMessageListWith: (in category 'private initializing') ----- buildMessageListWith: builder | listSpec | listSpec := builder pluggableAlternateMultiSelectionListSpec new. listSpec model: self ; + list: #messageListFormatted ; - list: #messageList ; getIndex: #messageListIndex ; setIndex: #toggleSelectionAt:shifted:controlled: ; icon: #messageIconAt:; help: #messageHelpAt:; menu: #messageListMenu:shifted: ; getSelectionList: #isMessageSelectedAt: ; setSelectionList: #messageAt:beSelected: ; keyPress: #messageListKey:from:. SystemBrowser browseWithDragNDrop ifTrue: [ listSpec dragItem: #dragFromMessageList: ]. ^ listSpec!

1 0

The Trunk: Tools-mt.863.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.863.mcz ==================== Summary ==================== Name: Tools-mt.863 Author: mt Time: 4 August 2019, 4:31:03.354743 pm UUID: 02946d52-a7a1-5b45-844a-ab32966fdc99 Ancestors: Tools-mt.862 Fixes smaller bugs in message-set tool. =============== Diff against Tools-mt.862 =============== Item was changed: ----- Method: MessageSet class>>parse:toClassAndSelector: (in category 'utilities') ----- + parse: codeReferenceOrString toClassAndSelector: csBlock - parse: methodRef toClassAndSelector: csBlock "Decode strings of the form <className> [class] <selectorName>." | tuple cl | + codeReferenceOrString ifNil: [^ csBlock value: nil value: nil]. + codeReferenceOrString isCodeReference ifTrue: + [^codeReferenceOrString setClassAndSelectorIn: csBlock]. + codeReferenceOrString isEmpty ifTrue: - - - self flag: #mref. "compatibility with pre-MethodReference lists" - - methodRef ifNil: [^ csBlock value: nil value: nil]. - methodRef isString ifFalse: - [^methodRef setClassAndSelectorIn: csBlock]. - methodRef isEmpty ifTrue: [^csBlock value: nil value: nil]. + tuple := (codeReferenceOrString asString includesSubstring: '>>') + ifTrue: [(codeReferenceOrString findTokens: '>>') fold: [:a :b| (a findTokens: ' '), {b first = $# ifTrue: [b allButFirst] ifFalse: [b]}]] + ifFalse: [codeReferenceOrString asString findTokens: ' .']. - tuple := (methodRef asString includesSubstring: '>>') - ifTrue: [(methodRef findTokens: '>>') fold: [:a :b| (a findTokens: ' '), {b first = $# ifTrue: [b allButFirst] ifFalse: [b]}]] - ifFalse: [methodRef asString findTokens: ' .']. self flag: #environments. "missing information about the class environment" cl := Smalltalk at: tuple first asSymbol ifAbsent: [^ csBlock value: nil value: nil]. ^(tuple size = 2 or: [tuple size > 2 and: [(tuple at: 2) ~= 'class']]) ifTrue: [csBlock value: cl value: (tuple at: 2) asSymbol] ifFalse: [csBlock value: cl class value: (tuple at: 3) asSymbol]! Item was changed: ----- Method: MessageSet>>setClassAndSelectorIn: (in category 'private') ----- setClassAndSelectorIn: csBlock - | sel | "Decode strings of the form <className> [class] <selectorName>." + | sel | - self flag: #mref. "compatibility with pre-MethodReference lists" - sel := self selection. + ^ sel isCodeReference + ifTrue: [sel setClassAndSelectorIn: csBlock] + ifFalse: [self class parse: sel toClassAndSelector: csBlock]! - ^(sel isKindOf: MethodReference) ifTrue: [ - sel setClassAndSelectorIn: csBlock - ] ifFalse: [ - MessageSet parse: sel toClassAndSelector: csBlock - ]! Item was changed: ----- Method: MessageSet>>setFilteredList: (in category 'private') ----- setFilteredList: newList "Establish newList as the new list if appropriate, and adjust the window title accordingly; if the new list is of the same size as the old, warn and do nothing" + + | currentSelection | newList size = 0 ifTrue: [ self inform: 'Nothing would be left in the list if you did that'. ^false ]. newList size = messageList size ifTrue: [ self inform: 'That leaves the list unchanged'. ^false ]. + + messageListIndex > 0 ifTrue: + [currentSelection := messageList at: messageListIndex]. + self initializeMessageList: newList ; adjustWindowTitleAfterFiltering. + + currentSelection ifNotNil: + [messageListIndex := messageList indexOf: currentSelection ifAbsent: [1]]. + + self + changed: #messageList; + changed: #messageListIndex. + ^true!

1 0

The Trunk: Kernel-mt.1254.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1254.mcz ==================== Summary ==================== Name: Kernel-mt.1254 Author: mt Time: 4 August 2019, 4:24:58.883226 pm UUID: 196964fd-3ccf-a948-a547-59988b7fb079 Ancestors: Kernel-mt.1253 Adds a way to check deprecation state of code artifacts. =============== Diff against Kernel-mt.1253 =============== Item was added: + ----- Method: ClassDescription>>isDeprecated (in category 'testing') ----- + isDeprecated + + ^ self category includesSubstring: 'Deprecated'! Item was added: + ----- Method: CompiledMethod>>isDeprecated (in category 'testing') ----- + isDeprecated + "Note that #literalsDo: is faster than #hasLiteral: (and #hasLiteral:scanForSpecial:). We already know that 'self deprecated' should be the first statement in a deprecated method, which is directly accessible in this method's literals. No need to check compiled blocks or other nested structures. + + Note that both #isQuick and is-this-method check make no sense performance-wise. Maybe bench again in the future." + + self literalsDo: [:literal | + (#deprecated = literal or: [#deprecated: = literal]) + ifTrue: [^ true]]. + ^ false!

1 0

The Trunk: System-mt.1079.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1079.mcz ==================== Summary ==================== Name: System-mt.1079 Author: mt Time: 4 August 2019, 4:21:40.075226 pm UUID: ccfbfb85-c9a3-fd43-9800-3b622ba6d336 Ancestors: System-mt.1078 Prepare all UI themes for indicating deprecated messages in tools. =============== Diff against System-mt.1078 =============== Item was changed: ----- Method: CommunityTheme class>>addDarkToolColors: (in category 'instance creation') ----- addDarkToolColors: theme "Tool-specific colors." theme set: #failureColor for: #TestRunner to: self dbYellow; set: #errorColor for: #TestRunner to: self dbRed; set: #passColor for: #TestRunner to: self dbGreen. "Browser." + theme + set: #noClassCommentColor for: #Browser to: self dbRed; + set: #deprecatedMessageAttributes for: #CodeHolder to: { TextEmphasis struckOut. TextColor color: self dbGray }.! - theme set: #noClassCommentColor for: #Browser to: self dbRed.! Item was changed: ----- Method: MonokaiTheme class>>addDarkToolColors: (in category 'instance creation') ----- addDarkToolColors: theme "Tool-specific colors." theme set: #failureColor for: #TestRunner to: self yellow; set: #errorColor for: #TestRunner to: self red; set: #passColor for: #TestRunner to: self green; set: #failureTextColor for: #TestRunner to: self backgroundColor; set: #errorTextColor for: #TestRunner to: self backgroundColor; set: #passTextColor for: #TestRunner to: self backgroundColor. theme set: #ignoredOperationAttributes for: #MCOperationsBrowser to: {TextColor color: self grayLight}. "Browser." + theme + set: #noClassCommentColor for: #Browser to: self red; + set: #deprecatedMessageAttributes for: #CodeHolder to: { TextEmphasis struckOut. TextColor color: self grayLight }.! - theme set: #noClassCommentColor for: #Browser to: self red.! Item was changed: ----- Method: SolarizedTheme class>>addDarkToolColors: (in category 'instance creation') ----- addDarkToolColors: theme "Tool-specific colors." theme set: #failureColor for: #TestRunner to: self yellow; set: #errorColor for: #TestRunner to: self red; set: #passColor for: #TestRunner to: self green; set: #failureTextColor for: #TestRunner to: self darkBackground; set: #errorTextColor for: #TestRunner to: self darkBackground; set: #passTextColor for: #TestRunner to: self darkBackground. theme set: #ignoredOperationAttributes for: #MCOperationsBrowser to: {TextColor color: self darkContentSecondary}. "Browser." + theme + set: #noClassCommentColor for: #Browser to: self red; + set: #deprecatedMessageAttributes for: #CodeHolder to: { TextEmphasis struckOut. TextColor color: self darkContentSecondary }.! - theme set: #noClassCommentColor for: #Browser to: self red.! Item was changed: ----- Method: SolarizedTheme class>>addLightToolColors: (in category 'instance creation') ----- addLightToolColors: theme "Tool-specific colors." theme set: #failureColor for: #TestRunner to: self yellow; set: #errorColor for: #TestRunner to: self red; set: #passColor for: #TestRunner to: self green; set: #failureTextColor for: #TestRunner to: self lightBackground; set: #errorTextColor for: #TestRunner to: self lightBackground; set: #passTextColor for: #TestRunner to: self lightBackground. theme set: #ignoredOperationAttributes for: #MCOperationsBrowser to: {TextColor color: self lightContentSecondary}. "Browser." + theme + set: #noClassCommentColor for: #Browser to: self red; + set: #deprecatedMessageAttributes for: #CodeHolder to: { TextEmphasis struckOut. TextColor color: self lightContentSecondary }.! - theme set: #noClassCommentColor for: #Browser to: self red.! Item was changed: ----- Method: SqueakTheme class>>addToolColors: (in category 'instance creation') ----- addToolColors: theme "Tool-specific colors." "SUnit's TestRunner." theme set: #failureColor for: #TestRunner to: Color yellow; set: #errorColor for: #TestRunner to: Color red; set: #passColor for: #TestRunner to: Color green; derive: #failureTextColor for: #TestRunner from: #PluggableTextMorph at: #textColor; derive: #errorTextColor for: #TestRunner from: #PluggableTextMorph at: #textColor; derive: #passTextColor for: #TestRunner from: #PluggableTextMorph at: #textColor. "Monticello Tools." theme set: #revertedOperationAttributes for: #MCOperationsBrowser to: {TextEmphasis struckOut}; set: #ignoredOperationAttributes for: #MCOperationsBrowser to: {TextColor color: Color gray}. "set: #rejectedOperationAttributes for: #MCOperationsBrowser to: {TextEmphasis struckOut}; set: #acceptedOperationAttributes for: #MCOperationsBrowser to: {TextEmphasis underlined}; set: #conflictingOperationAttributes for: #MCOperationsBrowser to: {TextEmphasis bold}." "Halos." theme derive: #borderColor for: #HaloMorph from: #MenuItemMorph at: #selectionColor do: [:c | c alpha: 0.8]; derive: #borderColor for: #SelectionMorph from: #MenuItemMorph at: #selectionColor do: [:c | c twiceDarker alpha: 0.75]; derive: #color for: #SelectionMorph from: #MenuItemMorph at: #selectionColor do: [:c | c alpha: 0.08]. + "Code-browsing tools." + theme + set: #noClassCommentColor for: #Browser to: Color red; + set: #deprecatedMessageAttributes for: #CodeHolder to: { TextEmphasis struckOut. TextColor gray }. - "Browser." - theme set: #noClassCommentColor for: #Browser to: Color red. "Objects Tool." theme derive: #borderWidth for: #ObjectsTool from: #MenuMorph; derive: #borderColor for: #ObjectsTool from: #MenuMorph; derive: #borderStyle for: #ObjectsTool from: #MenuMorph; derive: #color for: #ObjectsTool from: #MenuMorph; derive: #textColor for: #ObjectsTool from: #MenuItemMorph; derive: #selectionTextColor for: #ObjectsTool from: #MenuItemMorph.! Item was changed: ----- Method: TrimTheme class>>addToolColors: (in category 'instance creation') ----- addToolColors: theme "Tool-specific colors." "SUnit's TestRunner." theme set: #failureColor for: #TestRunner to: self yellow; set: #errorColor for: #TestRunner to: self red; set: #passColor for: #TestRunner to: self green. "Monticello Tools." theme set: #revertedOperationAttributes for: #MCOperationsBrowser to: {TextEmphasis struckOut}; set: #ignoredOperationAttributes for: #MCOperationsBrowser to: {TextColor color: self gray128}. "Browser." + theme + set: #noClassCommentColor for: #Browser to: self red; + set: #deprecatedMessageAttributes for: #CodeHolder to: { TextEmphasis struckOut. TextColor color: self gray128 }.! - theme set: #noClassCommentColor for: #Browser to: self red.!

1 0

The Trunk: PackageInfo-Base-mt.71.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of PackageInfo-Base to project The Trunk: http://source.squeak.org/trunk/PackageInfo-Base-mt.71.mcz ==================== Summary ==================== Name: PackageInfo-Base-mt.71 Author: mt Time: 4 August 2019, 12:16:40.254314 pm UUID: 9a97317a-1734-6740-9988-202aa1045196 Ancestors: PackageInfo-Base-jr.70 Merges and extends PackageInfo-Base-ct.70, which I moved to treated inbox due to incompatible ancestry. Adds ifPresent-interface (known from Dictionary) to package organizer. =============== Diff against PackageInfo-Base-jr.70 =============== Item was added: + ----- Method: PackageOrganizer>>packageNamed:ifPresent: (in category 'searching') ----- + packageNamed: aString ifPresent: aBlock + ^ packages at: aString ifPresent: aBlock! Item was added: + ----- Method: PackageOrganizer>>packageNamed:ifPresent:ifAbsent: (in category 'searching') ----- + packageNamed: aString ifPresent: aBlock ifAbsent: errorBlock + ^ packages at: aString ifPresent: aBlock ifAbsent: errorBlock!

1 0

The Trunk: Tools-mt.862.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.862.mcz ==================== Summary ==================== Name: Tools-mt.862 Author: mt Time: 4 August 2019, 12:07:44.136314 pm UUID: d52b05de-7a3d-184c-9243-32be566fcea1 Ancestors: Tools-mt.861 Merges Tools-ct.858, which I moved to treated inbox due to incompatible ancestry. "Inspector: Try to keep field selection when changing object Instead of unselecting the field viewed latest when another object is assigned, keep the selection unless it is no more valid (got a phantom) Example where this is useful: debug World allMorphs, select owner in the receiver view and watch the selection while stepping a few times into #allMorphsDo:." =============== Diff against Tools-mt.861 =============== Item was changed: ----- Method: Inspector>>object: (in category 'accessing') ----- object: anObject "Set anObject to be the object being inspected by the receiver." + | oldSelection oldFields newFields commonFieldRange | - | oldIndex | anObject == object ifTrue: [self update] ifFalse: + [oldSelection := selectionIndex. + oldFields := self fieldList. - [oldIndex := selectionIndex <= 2 ifTrue: [selectionIndex] ifFalse: [0]. self inspect: anObject. + newFields := self fieldList. + commonFieldRange := ((1 to: (oldFields size min: newFields size)) + select: [:i | (oldFields at: i) = (newFields at: i)]) + ifNotEmpty: #last + ifEmpty: [0]. - oldIndex := oldIndex min: self fieldList size. self changed: #inspectObject. + self toggleIndex: (oldSelection <= commonFieldRange + ifTrue: [oldSelection] + ifFalse: [0]). - oldIndex > 0 - ifTrue: [self toggleIndex: oldIndex]. self changed: #fieldList. self changed: #contents. self changed: #helpText]!

1 0

The Trunk: Tools-mt.861.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.861.mcz ==================== Summary ==================== Name: Tools-mt.861 Author: mt Time: 4 August 2019, 12:04:31.081314 pm UUID: 7b061394-82bb-0941-b46b-304f857afa7c Ancestors: Tools-mt.860 Merges Tools-ct.857, which I moved to treated inbox due to incompatible ancestry. "Fix & refactor ChangeList>>#compareToCurrentVersion Deduplicate the code with overridden version in ClassCommentVersionBrowser, and fix a bug: As the feature is named "compare TO current version", I expect a comparison FROM the selected item to the current version, not the opposite (same as "compare to version ...")." =============== Diff against Tools-mt.860 =============== Item was added: + ----- Method: ChangeList>>compareToCurrentSource: (in category 'menu actions') ----- + compareToCurrentSource: currentSource + "If the current selection corresponds to a method in the system, then spawn a window showing the diffs as text" + + | change selectedSource | + change := changeList at: listIndex ifAbsent: [^ self]. + selectedSource := change string. + currentSource = selectedSource + ifTrue: [^ self inform: 'Exact Match']. + (StringHolder new + textContents: (TextDiffBuilder + buildDisplayPatchFrom: selectedSource + to: currentSource + inClass: change methodClass + prettyDiffs: self showingPrettyDiffs)) + openLabel: 'Comparison to Current Version'.! Item was changed: ----- Method: ChangeList>>compareToCurrentVersion (in category 'menu actions') ----- compareToCurrentVersion "If the current selection corresponds to a method in the system, then spawn a window showing the diffs as text" + | change class | + change := changeList at: listIndex ifAbsent: [^ self]. + class := change methodClass. + (class notNil and: [(class includesSelector: change methodSelector)]) + ifFalse: [^ self flash]. + ^ self compareToCurrentSource: (class sourceCodeAt: change methodSelector) asString! - | change class s1 s2 | - listIndex = 0 - ifTrue: [^ self]. - change := changeList at: listIndex. - ((class := change methodClass) notNil - and: [class includesSelector: change methodSelector]) - ifTrue: [s1 := (class sourceCodeAt: change methodSelector) asString. - s2 := change string. - s1 = s2 - ifTrue: [^ self inform: 'Exact Match']. - (StringHolder new - textContents: (TextDiffBuilder buildDisplayPatchFrom: s1 to: s2 inClass: class prettyDiffs: self showingPrettyDiffs)) - openLabel: 'Comparison to Current Version'] - ifFalse: [self flash]! Item was changed: ----- Method: ClassCommentVersionsBrowser>>compareToCurrentVersion (in category 'menu') ----- compareToCurrentVersion "If the current selection corresponds to a method in the system, then spawn a window showing the diffs as text" + ^ self compareToCurrentSource: classOfMethod organization classComment! - | change s1 s2 | - listIndex = 0 - ifTrue: [^ self]. - change := changeList at: listIndex. - s1 := classOfMethod organization classComment. - s2 := change string. - s1 = s2 - ifTrue: [^ self inform: 'Exact Match']. - (StringHolder new - textContents: (TextDiffBuilder buildDisplayPatchFrom: s1 to: s2 inClass: classOfMethod prettyDiffs: self showingPrettyDiffs)) - openLabel: 'Comparison to Current Version'!

1 0

The Trunk: Tools-mt.860.mcz
by commits＠source.squeak.org 04 Aug '19

04 Aug '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.860.mcz ==================== Summary ==================== Name: Tools-mt.860 Author: mt Time: 4 August 2019, 11:47:29.338314 am UUID: 4c9375a7-9e2f-994f-b08e-7ccb3a620b9e Ancestors: Tools-mt.859 Merges Tools-ct.855, which I moved to treated inbox due to ancestry issues. "Addition to last commit: Style content in ContextVariablesInspector completely according to doItReceiver (highlight instvars correctly)" =============== Diff against Tools-mt.859 =============== Item was changed: ----- Method: ContextVariablesInspector>>aboutToStyle:forMorph: (in category 'styling') ----- aboutToStyle: aStyler forMorph: aMorph + (super aboutToStyle: aStyler forMorph: aMorph) + ifFalse: [^ false]. + aStyler + classOrMetaClass: self doItReceiver class; + context: self doItContext. + ^ true! - aStyler context: self object. - ^ super aboutToStyle: aStyler forMorph: aMorph!

1 0

← Newer
1
...
9
10
11
12
13
14
15
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Packages August 2019