Marcel Taeumel uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-mt.1247.mcz
==================== Summary ====================
Name: System-mt.1247
Author: mt
Time: 19 November 2021, 3:34:02.688971 pm
UUID: 1a0702be-f2ef-2b46-a6eb-c37679413041
Ancestors: System-mt.1246
Adds #browseClassComment: as requested via http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-September/21639…
I decided to rename "comment of class" to "class comment" because there are no other browse-able comments. No comments for system categories. No comments for message categories. And #browseMethod: includes that method's comments already.
=============== Diff against System-mt.1246 ===============
Item was added:
+ ----- Method: ToolSet class>>browseClassComment: (in category 'browsing') -----
+ browseClassComment: aClass
+
+ self default ifNil: [^self inform: 'Cannot open Browser' translated].
+ ^ self default browseClassComment: aClass!
Marcel Taeumel uploaded a new version of HelpSystem-Core to project The Trunk:
http://source.squeak.org/trunk/HelpSystem-Core-mt.136.mcz
==================== Summary ====================
Name: HelpSystem-Core-mt.136
Author: mt
Time: 19 November 2021, 3:16:09.544971 pm
UUID: 8804b60d-2054-3f48-8532-60f3d0112165
Ancestors: HelpSystem-Core-eem.135
Move up #priority to be able to customize it for all hand-crafted HelpTopic instances, which can hold all kinds of help topics as their subtopics.
Extend SystemReference to also include a class' superclasses (see class-list menu entry "show all comments" or "browse documentation").
=============== Diff against HelpSystem-Core-eem.135 ===============
Item was changed:
Model subclass: #AbstractHelpTopic
+ instanceVariableNames: 'priority'
- instanceVariableNames: ''
classVariableNames: ''
poolDictionaries: ''
category: 'HelpSystem-Core-Model'!
!AbstractHelpTopic commentStamp: 'mt 3/24/2015 16:26' prior: 0!
A HelpTopic provides content information that can be used as a help to the user.
It can be labeled with a title and marked with an (optional) icon.
Help topics form a hierarchy since any topic is able to have zero or more
subtopics. !
Item was changed:
----- Method: AbstractHelpTopic>>priority (in category 'accessing') -----
priority
+ "A hint for tools to influence sort order. See commentary in #<=."
+
+ ^ priority!
-
- ^ nil!
Item was added:
+ ----- Method: AbstractHelpTopic>>priority: (in category 'accessing') -----
+ priority: anInteger
+
+ priority := anInteger.!
Item was changed:
----- Method: Behavior>>openHelpBrowser (in category '*HelpSystem-Core') -----
openHelpBrowser
"Set openHelpBrowser"
+ ^ HelpBrowser openOn: self asHelpTopic!
- HelpBrowser openOn: self asHelpTopic!
Item was changed:
----- Method: ClassBasedHelpTopic>>priority (in category 'accessing') -----
priority
+ "Overwritten to consider #helpClass if not already set."
+
+ ^ super priority ifNil: [self helpClass priority]!
-
- ^ self helpClass priority!
Item was changed:
AbstractHelpTopic subclass: #HelpTopic
+ instanceVariableNames: 'title key icon contents subtopics isEditable shouldStyle'
- instanceVariableNames: 'title key icon contents subtopics priority isEditable shouldStyle'
classVariableNames: ''
poolDictionaries: ''
category: 'HelpSystem-Core-Model'!
!HelpTopic commentStamp: 'mt 3/25/2015 11:27' prior: 0!
This is a configurable version of a help topic. You can define its contents, title, icon, and subtopics manually.
Help builders make use of this.!
Item was removed:
- ----- Method: HelpTopic>>priority (in category 'accessing') -----
- priority
- "A hint for tools to influence sort order."
-
- ^ priority!
Item was removed:
- ----- Method: HelpTopic>>priority: (in category 'accessing') -----
- priority: anInteger
-
- priority := anInteger.!
Item was added:
+ ----- Method: MethodListHelpTopic>>initialize (in category 'initialization') -----
+ initialize
+
+ super initialize.
+ self priority: -999.!
Item was removed:
- ----- Method: MethodListHelpTopic>>priority (in category 'accessing') -----
- priority
-
- ^ -999!
Item was changed:
----- Method: SystemReference class>>forClass: (in category 'help topic creation') -----
forClass: aClass
+
+ | root |
+ root := HelpTopic named: 'System Reference for ' translated, aClass name.
+ aClass allSuperclasses withIndexDo: [:cls :index |
+ root addSubtopic: (ClassAPIHelpTopic new
+ priority: index negated;
+ theClass: cls;
+ withSubclasses: false;
+ withMethods: true;
+ yourself)].
+ root addSubtopic: (ClassAPIHelpTopic new
+ theClass: aClass;
+ withSubclasses: true;
+ withMethods: true;
+ subclassesAsSeparateTopic: false;
+ yourself).
- |root topic |
- root := HelpTopic named: 'System reference for ', aClass name.
- topic := ClassAPIHelpTopic new theClass: aClass; withSubclasses: true; withMethods: true;
- subclassesAsSeparateTopic: false.
- root addSubtopic: topic.
^root!
Levente Uzonyi uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-ul.465.mcz
==================== Summary ====================
Name: Tests-ul.465
Author: ul
Time: 18 November 2021, 6:12:23.870228 pm
UUID: 6cbe94f9-e292-4e77-af92-6a75b75a5bd2
Ancestors: Tests-eem.464
- actualized DecompilerTests >> #decompilerFailures to make all decompiler tests pass
=============== Diff against Tests-eem.464 ===============
Item was changed:
----- Method: DecompilerTests>>decompilerFailures (in category 'utilities') -----
decompilerFailures
"Here is the list of failures: either a syntax error, a hard error or some failure to decompile correctly.
Collected initially via
DecompilerTestFailuresCollector new computeFailures.
But can be maintained manually."
"class name, selector, error class name or nil"
^#(
#(BrowserCommentTextMorph showPane SyntaxErrorNotification)
#(CodeHolder getSelectorAndSendQuery:to:with: SyntaxErrorNotification)
#(DecompilerTests testDecompileUnreachableParameter Error)
#(MVCToolBuilder setLayout:in: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
#(PNGReadWriter copyPixelsGray: SyntaxErrorNotification)
+ #(SHMCClassDefinition withAllSuperclassesDo: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
+ #(DoItFirst parse: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
+ #(TheWorldMainDockingBar listChangesOn: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
+ )!
- #(SHMCClassDefinition withAllSuperclassesDo: SyntaxErrorNotification)), "same-name block-local temps in optimized blocks"
- (Scanner allowBlockArgumentAssignment
- ifTrue: [#()]
- ifFalse:
- [#(
- #(NebraskaSenderMorph hideField: SyntaxErrorNotification)) "assigns into block argument"])!
Marcel Taeumel uploaded a new version of Protocols to project The Trunk:
http://source.squeak.org/trunk/Protocols-ct.78.mcz
==================== Summary ====================
Name: Protocols-ct.78
Author: ct
Time: 2 March 2021, 3:45:36.46717 pm
UUID: 0213a785-c806-e344-83fb-4876ec5be7ee
Ancestors: Protocols-mt.77
Refactors removal of selectors. Complements System-ct.1221.
=============== Diff against Protocols-mt.77 ===============
Item was changed:
----- Method: Lexicon>>removeMessage (in category 'menu commands') -----
removeMessage
- "Remove the selected message from the system."
+ super removeMessage ifFalse: [^ false].
+
- messageListIndex = 0 ifTrue: [^ self].
- self okToChange ifFalse: [^ self].
-
- super removeMessage.
"my #reformulateList method, called from the super #removeMethod method, will however try to preserve the selection, so we take pains to clobber it by the below..."
messageListIndex := 0.
self changed: #messageList.
self changed: #messageListIndex.
contents := nil.
self contentsChanged!