Christoph Thiede uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ct.1432.mcz
==================== Summary ====================
Name: System-ct.1432 Author: ct Time: 13 November 2023, 6:36:57.388722 pm UUID: 9bd805c2-1d3e-2c4a-acbc-0066cc40c712 Ancestors: System-dtl.1431
Fixes missing escaping in common senders of #asTextFromHtml and #format:. Note that also Texts respond to #format: since Squeak 5.3.
=============== Diff against System-dtl.1431 ===============
Item was changed: ----- Method: DeepCopier>>warnIverNotCopiedIn:sel: (in category 'like fullCopy') ----- warnIverNotCopiedIn: aClass sel: sel "Warn the user to update veryDeepCopyWith: or veryDeepInner:"
+ self inform: ('An instance variable was added to to class <b>{1}</b> and it is not copied in the method <b>{2}</b>.<br><br>Please rewrite it to handle all instance variables. See DeepCopier class comment.' translated asTextFromHtml format: {aClass name . sel}). - self inform: ('An instance variable was added to to class <b>{1}</b> and it is not copied in the method <b>{2}</b>.<br><br>Please rewrite it to handle all instance variables. See DeepCopier class comment.' translated format: { aClass name . sel}) asTextFromHtml. ToolSet browse: aClass selector: sel!
Item was changed: ----- Method: SmalltalkImage>>openSourcesAndChanges:forImage: (in category 'image, changes names') ----- openSourcesAndChanges: changesName forImage: imageName "Open the changes and sources files and install them in SourceFiles. Inform the user of problems regarding write permissions or CR/CRLF mixups." "Note: SourcesName and imageName are full paths; changesName is a local name." | sources changes msg wmsg | msg := 'Squeak cannot locate {1}.
+ Please check that the file is named properly and is in the same directory as this image.' translated. - Please check that the file is named properly and is in the same directory as this image.'. wmsg := 'Squeak cannot write to {1}.
Please check that you have write permission for this file.
+ You won''t be able to save this image correctly until you fix this.' translated. + - You won''t be able to save this image correctly until you fix this.'. - sources := Smalltalk openSources. sources ifNotNil: [sources setConverterForCode]. changes := SourceFileArray cachedChanges ifNil: [Smalltalk openChanges: changesName forImage: imageName]. changes ifNotNil: [changes setConverterForCode]. ((sources == nil or: [sources atEnd]) and: [Preferences valueOfFlag: #warnIfNoSourcesFile]) ifTrue: [Smalltalk platformName = 'Mac OS' ifTrue: [msg := msg , ' + Make sure the sources file is not an Alias.' translated]. + self inform: (msg format: { 'the sources file named ' translated , self sourcesName })]. + - Make sure the sources file is not an Alias.']. - self inform: (msg format: { 'the sources file named ' , self sourcesName })]. - (changes == nil and: [Preferences valueOfFlag: #warnIfNoChangesFile]) + ifTrue: [self inform: (msg format: { 'the changes file named ' translated , changesName })]. + - ifTrue: [self inform: (msg format: { 'the changes file named ' , changesName })]. - ((Preferences valueOfFlag: #warnIfNoChangesFile) and: [changes notNil]) ifTrue: [changes isReadOnly + ifTrue: [self inform: (wmsg format: { 'the changes file named ' translated , changesName })]. - ifTrue: [self inform: (wmsg format: { 'the changes file named ' , changesName })].
((changes next: 200) includesSubstring: String crlf) ifTrue: [self inform: ('The changes file named <b>{1}</b> has been injured by an unpacking utility. Line endings were changed from Cr to CrLf.<br><br>Please set the preferences in your decompressing program to + <b>do not convert text files</b> and unpack the system again.' translated asTextFromHtml format: { changesName })]]. + - <b>do not convert text files</b> and unpack the system again.' translated format: { changesName }) asTextFromHtml]]. - SourceFiles := Array with: sources with: changes!
Item was changed: ----- Method: Utilities class>>setAuthorInitials (in category 'identification') ----- setAuthorInitials "Put up a dialog allowing the user to specify the author's initials. Inform the user about collisions with known contributors. See SystemNavigation class >> #authors. "
| newInitials newName | newInitials := Project uiManager request: 'Please type your initials:' translated initialAnswer: AuthorInitials. newInitials ifEmpty: [^ self "No Change"].
(SystemNavigation authorsInverted at: newInitials ifPresent: [:existingNames | newName := existingNames sorted joinSeparatedBy: '/'.
(self confirm: ('Hello, <b>{1}!!</b> :-)<br><br>Our <a href="code://{3}">list of known contributors</{4}> associates the initials you have entered with this name. If this is not you, please consider alternative initials, preferably more than just a few characters, to avoid collisions.<br><br>Do you want to use these author initials?<br><br> <b>{2}</b>' translated format: { + (newName ifNil: [newInitials]) escapeEntities. + newInitials escapeEntities. - newName ifNil: [newInitials]. - newInitials. 'SystemReporter open model categoryAt: 1 put: true'. "mt: Avoid triggering the Windows Defender. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217346.html" 'a' }) asTextFromHtml) ] ifAbsent: [true]) ifTrue: [self authorInitials: newInitials].!
packages@lists.squeakfoundation.org