Hi,
Attached is the proposed fix, which performs a second lookup in case no attribute was found.
I also added clearSearchContexts to WASystemConfiguration>>#clearDescription

I loaded all configurations as described on issue 643, and the tests have gone away.
Dale - can you please confirm this?
Cheers,
Avi.
On Tue, Feb 15, 2011 at 9:27 PM, Dale Henrichs <dhenrich@vmware.com> wrote:
On 02/15/2011 11:14 AM, Philippe Marschall wrote:
2011/2/15 Philippe Marschall<philippe.marschall@gmail.com>:
2011/2/15 Dale Henrichs<dhenrich@vmware.com>:
On 02/15/2011 10:33 AM, Avi Shefi wrote:

Quoting my comment on issue 643:

   First of all use the following as first-aid to the build process:
   WAConfiguration allInstancesDo: [ :instance | instance
clearSearchContexts ].
   WAConfiguration allSubInstancesDo: [ :instance | instance
clearSearchContexts ].

Notice that this runs on all instances and subinstances of
WAConfiguration, therefore catching WAUserConfiguration too.

Again, this is an immediate fix to clear all cache. It is not intended
to run regularly...

Yes, I understand. I am able to get through the tests, but my concern is
that a post load doit needs to be executed to repair these things. I will
add the post load doit to the Metacello configuration, but I am reluctant to
us allInstances.



As for the fix, the options remain but nobody has replied.
I don't mind submitting a fix to this unless somebody thinks there's a
better solution... ?

I think making the cache more robust in the presence of stale entries is a
good idea ... if I understand things correctly, the stale entries can be
identified, so it makes sense to do a direct lookup if a stale cache entry
is encountered and then throw the error ...

Sounds good.

The other option would be to roll back the caching change, let it
incubate/stabilize more and do a 3.0.4 without issue 608.

I have at least another day or so of GemStone-specific work that I need to do with Seaside 3.0.4, so if Issue 608 can be stabilized in another couple of days or so, I'd say move forward with fixing Issue 643. Otherwise it might make sense to roll back...

Dale

_______________________________________________
seaside-dev mailing list
seaside-dev@lists.squeakfoundation.org
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev