Normally I would, but this is more complicated than a simple moving of a method. I don't know the how this method's used so I've assumed that proj is a Project-like thing, and there are no tests for this code (that I can see).

So I thought I'd ask before telling... this time :)

frank

On 03 Jun 2013, at 19:27, Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com> wrote:

tell don't ask ;)


2013/6/3 Frank Shearar <frank.shearar@gmail.com>
I just found this method. It contains this snippet:

Smalltalk isMorphic ifTrue: [
    proj createViewIfAppropriate.
] ifFalse: [
    ChangeSorter allChangeSets add: proj changeSet.
    ProjectView openAndEnter: proj.
    "Note: in MVC we get no further than the above"
].

Wouldn't that be better written by implementing

MVCProject >> #createViewIfAppropriate
    ChangeSorter allChangeSets add: proj changeSet.
    ProjectView openAndEnter: proj.

and ripping out the #isMorphic call?

frank