Am 04.05.2018 17:33:46 schrieb karl ramberg <karlramberg@gmail.com>:
Filing the change set into a a project with all flaps added I get this error.Best,Karl4 May 2018 5:29:43.636227 pmVM: Win32 - SmalltalkImage: Squeak6.0alpha [latest update: #17953]SecurityManager state:Restricted: falseFileAccess: trueSocketAccess: trueWorking Dir C:\Users\Karl\Downloads\Squeak6.0alpha-17873-64bit-\Squeak6.0alpha-17873-64bit-201712221331-WindowsTrusted Dir C:\Users\Karl\Downloads\Squeak6.0alpha-17873-64bit-\Squeak6.0alpha-17873-64bit-201712221331-Windows\KarlUntrusted Dir C:\Users\Karl\Documents\My SqueakUndefinedObject(Object)>>doesNotUnderstand: #ownerReceiver: nilArguments and temporary variables:aMessage: ownerexception: MessageNotUnderstood: UndefinedObject>>ownerresumeValue: nilReceiver's instance variables:nilGeeMailMorph(ScrollPane)>>hIsScrollbarShowingReceiver: a GeeMailMorph(2549753)Arguments and temporary variables:Receiver's instance variables:bounds: 19@16 corner: 497@660owner: a PasteUpMorph(3307392) [world]submorphs: {a ScrollBar(1492571) . a TransformMorph(3447211)}fullBounds: nilcolor: Color whiteextension: a MorphExtension (4130764) [sticky] [eventHandler = an EventHandler...etc...borderWidth: 0borderColor: Color transparentmodel: nilslotName: nilopen: falsescrollBar: a ScrollBar(1492571)scroller: a TransformMorph(3447211)retractableScrollBar: falsescrollBarOnLeft: truegetMenuSelector: nilgetMenuTitleSelector: nilhasFocus: falsehScrollBar: nilhScrollBarPolicy: nilvScrollBarPolicy: nilscrollBarThickness: niltheTextMorph: nilthePasteUp: a TextPlusPasteUpMorph(1346736)GeeMailMorph(ScrollPane)>>hShowScrollBarReceiver: a GeeMailMorph(2549753)Arguments and temporary variables:Receiver's instance variables:bounds: 19@16 corner: 497@660owner: a PasteUpMorph(3307392) [world]submorphs: {a ScrollBar(1492571) . a TransformMorph(3447211)}fullBounds: nilcolor: Color whiteextension: a MorphExtension (4130764) [sticky] [eventHandler = an EventHandler...etc...borderWidth: 0borderColor: Color transparentmodel: nilslotName: nilopen: falsescrollBar: a ScrollBar(1492571)scroller: a TransformMorph(3447211)retractableScrollBar: falsescrollBarOnLeft: truegetMenuSelector: nilgetMenuTitleSelector: nilhasFocus: falsehScrollBar: nilhScrollBarPolicy: nilvScrollBarPolicy: nilscrollBarThickness: niltheTextMorph: nilthePasteUp: a TextPlusPasteUpMorph(1346736)GeeMailMorph(ScrollPane)>>hHideOrShowScrollBarReceiver: a GeeMailMorph(2549753)Arguments and temporary variables:Receiver's instance variables:bounds: 19@16 corner: 497@660owner: a PasteUpMorph(3307392) [world]submorphs: {a ScrollBar(1492571) . a TransformMorph(3447211)}fullBounds: nilcolor: Color whiteextension: a MorphExtension (4130764) [sticky] [eventHandler = an EventHandler...etc...borderWidth: 0borderColor: Color transparentmodel: nilslotName: nilopen: falsescrollBar: a ScrollBar(1492571)scroller: a TransformMorph(3447211)retractableScrollBar: falsescrollBarOnLeft: truegetMenuSelector: nilgetMenuTitleSelector: nilhasFocus: falsehScrollBar: nilhScrollBarPolicy: nilvScrollBarPolicy: nilscrollBarThickness: niltheTextMorph: nilthePasteUp: a TextPlusPasteUpMorph(1346736)GeeMailMorph(ScrollPane)>>hideOrShowScrollBarsReceiver: a GeeMailMorph(2549753)Arguments and temporary variables:Receiver's instance variables:bounds: 19@16 corner: 497@660owner: a PasteUpMorph(3307392) [world]submorphs: {a ScrollBar(1492571) . a TransformMorph(3447211)}fullBounds: nilcolor: Color whiteextension: a MorphExtension (4130764) [sticky] [eventHandler = an EventHandler...etc...borderWidth: 0borderColor: Color transparentmodel: nilslotName: nilopen: falsescrollBar: a ScrollBar(1492571)scroller: a TransformMorph(3447211)retractableScrollBar: falsescrollBarOnLeft: truegetMenuSelector: nilgetMenuTitleSelector: nilhasFocus: falsehScrollBar: nilhScrollBarPolicy: nilvScrollBarPolicy: nilscrollBarThickness: niltheTextMorph: nilthePasteUp: a TextPlusPasteUpMorph(1346736)GeeMailMorph(ScrollPane)>>setScrollDeltasReceiver: a GeeMailMorph(2549753)Arguments and temporary variables:Receiver's instance variables:bounds: 19@16 corner: 497@660owner: a PasteUpMorph(3307392) [world]submorphs: {a ScrollBar(1492571) . a TransformMorph(3447211)}fullBounds: nilcolor: Color whiteextension: a MorphExtension (4130764) [sticky] [eventHandler = an EventHandler...etc...borderWidth: 0borderColor: Color transparentmodel: nilslotName: nilopen: falsescrollBar: a ScrollBar(1492571)scroller: a TransformMorph(3447211)retractableScrollBar: falsescrollBarOnLeft: truegetMenuSelector: nilgetMenuTitleSelector: nilhasFocus: falsehScrollBar: nilhScrollBarPolicy: nilvScrollBarPolicy: nilscrollBarThickness: niltheTextMorph: nilthePasteUp: a TextPlusPasteUpMorph(1346736)GeeMailMorph(ScrollPane)>>borderStyle:Receiver: a GeeMailMorph(2549753)Arguments and temporary variables:aBorderStyle: a SimpleBorderReceiver's instance variables:bounds: 19@16 corner: 497@660owner: a PasteUpMorph(3307392) [world]submorphs: {a ScrollBar(1492571) . a TransformMorph(3447211)}fullBounds: nilcolor: Color whiteextension: a MorphExtension (4130764) [sticky] [eventHandler = an EventHandler...etc...borderWidth: 0borderColor: Color transparentmodel: nilslotName: nilopen: falsescrollBar: a ScrollBar(1492571)scroller: a TransformMorph(3447211)retractableScrollBar: falsescrollBarOnLeft: truegetMenuSelector: nilgetMenuTitleSelector: nilhasFocus: falsehScrollBar: nilhScrollBarPolicy: nilvScrollBarPolicy: nilscrollBarThickness: niltheTextMorph: nilthePasteUp: a TextPlusPasteUpMorph(1346736)GeeMailMorph(ScrollPane)>>setDefaultParametersReceiver: a GeeMailMorph(2549753)Arguments and temporary variables:Receiver's instance variables:bounds: 19@16 corner: 497@660owner: a PasteUpMorph(3307392) [world]submorphs: {a ScrollBar(1492571) . a TransformMorph(3447211)}fullBounds: nilcolor: Color whiteextension: a MorphExtension (4130764) [sticky] [eventHandler = an EventHandler...etc...borderWidth: 0borderColor: Color transparentmodel: nilslotName: nilopen: falsescrollBar: a ScrollBar(1492571)scroller: a TransformMorph(3447211)retractableScrollBar: falsescrollBarOnLeft: truegetMenuSelector: nilgetMenuTitleSelector: nilhasFocus: falsehScrollBar: nilhScrollBarPolicy: nilvScrollBarPolicy: nilscrollBarThickness: niltheTextMorph: nilthePasteUp: a TextPlusPasteUpMorph(1346736)GeeMailMorph(ScrollPane)>>applyUserInterfaceThemeReceiver: a GeeMailMorph(2549753)Arguments and temporary variables:Receiver's instance variables:bounds: 19@16 corner: 497@660owner: a PasteUpMorph(3307392) [world]submorphs: {a ScrollBar(1492571) . a TransformMorph(3447211)}fullBounds: nilcolor: Color whiteextension: a MorphExtension (4130764) [sticky] [eventHandler = an EventHandler...etc...borderWidth: 0borderColor: Color transparentmodel: nilslotName: nilopen: falsescrollBar: a ScrollBar(1492571)scroller: a TransformMorph(3447211)retractableScrollBar: falsescrollBarOnLeft: truegetMenuSelector: nilgetMenuTitleSelector: nilhasFocus: falsehScrollBar: nilhScrollBarPolicy: nilvScrollBarPolicy: nilscrollBarThickness: niltheTextMorph: nilthePasteUp: a TextPlusPasteUpMorph(1346736)[] in [] in [] in [] in SqueakTheme(UserInterfaceTheme)>>applyReceiver: a SqueakTheme 'Squeak'Arguments and temporary variables:cc: a GeeMailMorph(2549753)o: an IdentitySet(BottomRightGripMorph NetworkTerminalMorph UpdatingTextMorph QuickGuideMorph...etc...Receiver's instance variables:properties: a Dictionary(size 330)name: 'Squeak'next: nilignoreApply: falselastScaleFactor: 1.0Array(SequenceableCollection)>>do:Receiver: {nil . false . true . {Character null . Character value: 1 . Character value: 2 . Character...etc...Arguments and temporary variables:aBlock: [closure] in [] in [] in [] in SqueakTheme(UserInterfaceTheme)>>applyindex: 482773indexLimiT: 643356Receiver's instance variables:{nil . false . true . {Character null . Character value: 1 . Character value: 2 . Character...etc...SystemNavigation>>allObjectsDo:Receiver: a SystemNavigationArguments and temporary variables:aBlock: [closure] in [] in [] in [] in SqueakTheme(UserInterfaceTheme)>>applyobject: nillastObject: nilallObjects: {nil . false . true . {Character null . Character value: 1 . Character...etc...Receiver's instance variables:browserClass: BrowserhierarchyBrowserClass: nilenvironment: Smalltalk[] in [] in [] in SqueakTheme(UserInterfaceTheme)>>applyReceiver: a SqueakTheme 'Squeak'Arguments and temporary variables:cc: an IdentitySet(BottomRightGripMorph NetworkTerminalMorph UpdatingTextMorph QuickGuideMorph...etc...Receiver's instance variables:properties: a Dictionary(size 330)name: 'Squeak'next: nilignoreApply: falselastScaleFactor: 1.0BlockClosure>>ensure:Receiver: [closure] in [] in [] in SqueakTheme(UserInterfaceTheme)>>applyArguments and temporary variables:aBlock: [closure] in CursorWithMask(Cursor)>>showWhile:complete: nilreturnValue: nilReceiver's instance variables:outerContext: [] in [] in SqueakTheme(UserInterfaceTheme)>>applystartpc: 215numArgs: 0CursorWithMask(Cursor)>>showWhile:Receiver: ((CursorWithMaskextent: 16@16depth: 1fromArray: #(2r02r11111111111111000000000...etc...Arguments and temporary variables:aBlock: [closure] in [] in [] in SqueakTheme(UserInterfaceTheme)>>applyoldcursor: ((CursorWithMaskextent: 16@16depth: 1fromArray: #(2r02r1...etc...Receiver's instance variables:bits: a Bitmap of length 16width: 16height: 16depth: 1offset: -1@ -1maskForm: Form(16x16x1)[] in [] in SqueakTheme(UserInterfaceTheme)>>applyReceiver: a SqueakTheme 'Squeak'Arguments and temporary variables:cc: an IdentitySet(BottomRightGripMorph NetworkTerminalMorph UpdatingTextMorph QuickGuideMorph...etc...Receiver's instance variables:properties: a Dictionary(size 330)name: 'Squeak'next: nilignoreApply: falselastScaleFactor: 1.0IdentitySet(Object)>>in:Receiver: an IdentitySet(BottomRightGripMorph NetworkTerminalMorph UpdatingTextMorph QuickGuideMorph...etc...Arguments and temporary variables:aBlock: [closure] in [] in SqueakTheme(UserInterfaceTheme)>>applyReceiver's instance variables:tally: 672array: {nil . BottomRightGripMorph . nil . NetworkTerminalMorph . UpdatingTextMorph...etc...[] in SqueakTheme(UserInterfaceTheme)>>applyReceiver: a SqueakTheme 'Squeak'Arguments and temporary variables:Receiver's instance variables:properties: a Dictionary(size 330)name: 'Squeak'next: nilignoreApply: falselastScaleFactor: 1.0SqueakTheme(UserInterfaceTheme)>>fixFontsAndScaleAround:Receiver: a SqueakTheme 'Squeak'Arguments and temporary variables:block: [closure] in SqueakTheme(UserInterfaceTheme)>>applyscale: nilReceiver's instance variables:properties: a Dictionary(size 330)name: 'Squeak'next: nilignoreApply: falselastScaleFactor: 1.0--- The full stack ---UndefinedObject(Object)>>doesNotUnderstand: #ownerGeeMailMorph(ScrollPane)>>hIsScrollbarShowingGeeMailMorph(ScrollPane)>>hShowScrollBarGeeMailMorph(ScrollPane)>>hHideOrShowScrollBarGeeMailMorph(ScrollPane)>>hideOrShowScrollBarsGeeMailMorph(ScrollPane)>>setScrollDeltasGeeMailMorph(ScrollPane)>>borderStyle:GeeMailMorph(ScrollPane)>>setDefaultParametersGeeMailMorph(ScrollPane)>>applyUserInterfaceTheme[] in [] in [] in [] in SqueakTheme(UserInterfaceTheme)>>applyArray(SequenceableCollection)>>do:SystemNavigation>>allObjectsDo:[] in [] in [] in SqueakTheme(UserInterfaceTheme)>>applyBlockClosure>>ensure:CursorWithMask(Cursor)>>showWhile:[] in [] in SqueakTheme(UserInterfaceTheme)>>applyIdentitySet(Object)>>in:[] in SqueakTheme(UserInterfaceTheme)>>applySqueakTheme(UserInterfaceTheme)>>fixFontsAndScaleAround:- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -SqueakTheme(UserInterfaceTheme)>>applyUndefinedObject>>DoItCompiler>>evaluateCue:ifFail:Compiler>>evaluateCue:ifFail:logged:Compiler>>evaluate:in:to:notifying:ifFail:logged:Compiler class>>evaluate:for:notifying:logged:Compiler class>>evaluate:for:logged:Compiler class>>evaluate:logged:[] in [] in MultiByteFileStream(PositionableStream)>>fileInAnnouncing:BlockClosure>>on:do:[] in MultiByteFileStream(PositionableStream)>>fileInAnnouncing:[] in [] in MorphicUIManager>>displayProgress:at:from:to:during:BlockClosure>>on:do:[] in MorphicUIManager>>displayProgress:at:from:to:during:BlockClosure>>ensure:MorphicUIManager>>displayProgress:at:from:to:during:ProgressInitiationException>>defaultResumeValueProgressInitiationException(Exception)>>resumeProgressInitiationException>>defaultActionUndefinedObject>>handleSignal:ProgressInitiationException(Exception)>>signalProgressInitiationException>>display:at:from:to:during:ProgressInitiationException class>>display:at:from:to:during:ByteString(String)>>displayProgressAt:from:to:during:ByteString(String)>>displayProgressFrom:to:during:MultiByteFileStream(PositionableStream)>>fileInAnnouncing:[] in ChangeSet class>>newChangesFromStream:named:BlockClosure>>ensure:ChangeSet class>>newChangesFromStream:named:ChangeSet class>>fileIntoNewChangeSet:SimpleServiceEntry>>performServiceFor:FileList>>executeService:MessageSend>>valuePluggableButtonMorphPlus>>performAction[] in PluggableButtonMorphPlus(PluggableButtonMorph)>>mouseUp:Array(SequenceableCollection)>>do:PluggableButtonMorphPlus(PluggableButtonMorph)>>mouseUp:PluggableButtonMorphPlus(Morph)>>handleMouseUp:MouseButtonEvent>>sentTo:PluggableButtonMorphPlus(Morph)>>handleEvent:PluggableButtonMorphPlus(Morph)>>handleFocusEvent:MorphicEventDispatcher>>doHandlingForFocusEvent:with:-- and more not shown --On Fri, May 4, 2018 at 4:49 PM, Marcel Taeumel <marcel.taeumel@hpi.de> wrote:Well, I did more changes than expected. Please find attached the current version of that refactoring and test again. Note that we have, at the moment, no support for rounded corners in inset/raised borders.Best,MarcelAm 04.05.2018 10:34:20 schrieb Marcel Taeumel <marcel.taeumel@hpi.de>:
I will merge that refactoring during the next hours. Please report any issues here and not as a response to the commit e-mails.Best,MarelAm 11.04.2018 12:01:47 schrieb Marcel Taeumel <marcel.taeumel@hpi.de>:
Hi, there.Please find attached a refactoring of BorderedMorph to make use of BorderStyle like regular morphs do. Maybe, in the future, we can get rid of BorderedMorph.It includes:- No instVar access to borderColor and borderWidth but message sends.- No #inset or #raised anymore when asking a morph for its #borderColor. Just colors.- Copying the prototypical border styles from the UI theme when used in morphs.- A post-load script that updates all your morphs in the image. Not that important but good for keeping your current tools opened.After a few days of no complaints, I will merge it into Trunk.Best,Marcel