Vm-dev January 2013

vm-dev@lists.squeakfoundation.org

27 participants
148 discussions

ffi-test-main.c fails on FreeBSD
by Gary Dunn 12 Aug '16

12 Aug '16

In conjunction with getting Open Cobalt running on FreeBSD I have been looking into the problems with SqueakFFIPrims on FreeBSD and have reached a point that is beyond my understanding. I am not sure if the fix should come from the VM side or the FreeBSD port maintainer. I needed to get source code back into the ports tree so I did a make in /usr/ports/lang/squeak. I already had the 3.9 tarball, so that just repopulated the source and did the initial build. In the "files" folder I found patch files typical for a FreeBSD port. These patch source files from a generic tarball to work with FreeBSD. The one of interest was patch-platforms__unix__plugins__SqueakFFIPrims__ffi-config which contains ----x-----x----- --- platforms/unix/plugins/SqueakFFIPrims/ffi-config.org Wed Apr 26 20:27:53 2006 +++ platforms/unix/plugins/SqueakFFIPrims/ffi-config Wed Apr 26 20:29:00 2006 @@ -39,6 +39,7 @@ case ${abi} in linux) abi=sysv;; + freebsd*) abi=sysv;; darwin*) abi=darwin;; *) abi=libffi; lib="-lffi";; esac -----x-----x----- I then had the folder work/Squeak-3.9-7/platforms/unix/plugins/SqueakFFIPrims In it is a file 00README which explains how to test FFI. It says to run ffi-test-config but I have no such file. It says to type "make" to build a test suite but the build failed. It says to try with make CPU=any ABI=libffi LIB=-lffi which also failed. I traced the problem to the gcc search paths for includes and libraries -- turns out FreeBSD only searches /usr/include and /usr/lib when the required files are in /usr/local/include and /usr/local/lib. After some fiddling I finally had a "main" to test. It failed: ffi-test-main.c failed at line 361. Here is a bit from that file, ending with line 361: ffiInitialize(); for (ul= 0; ul < 15; ++ul) ffiPushSingleFloat(fa[ul]); GO(FFITypeSingleFloat, many); f= ffiReturnFloatValue(); ffiCleanup(); CHECK(f - ff < FLT_EPSILON); I worked out the CHECK macro but could not find what FLT_EPSILON is. At that point I decided to stop and come to you for help. Where do I go from here? -- Gary Dunn, Honolulu osp(a)aloha.com http://openslate.net/ http://e9erust.blogspot.com/ Sent from Slate001

5 8

Do we have the new primitive?? [WAS] Re: [Pharo-project] IdentitySet but using #hash rather than #identityHash ?
by Mariano Martinez Peck 16 Dec '15

16 Dec '15

> All I can say is that I am impressed by the numbers it is really much >> faster. >> I still don't understand why I send this email with a subject say >> IdentitySet because what I really need is a fast/large IdentityDictionary >> :( Anyway, there's a place where we can use this LargeIdentitySet in Fuel >> I think). >> >> So Levente, you say this is not possible to adapt this for dictionary? >> can >> we contact Eliot to provide such a primitive? >> > > As promised, I uploaded my LargeIdentityDictionary implementation to > http://leves.web.elte.hu/**squeak/**LargeIdentityDictionary.st<http://leves.web.elte.hu/squeak/LargeIdentityDictionary.st>. > The numbers will be a bit worse compared to LargeIdentitySet, because of > the lack of the primitive, but it's still 2-3x faster than other solutions > (IdentityDictionary, PluggableIdentityDictionary, subclassing, etc). I'm > about to propose this primitive with other improvements on the vm-dev list. > > Hi Eliot/Levente. What is the status of this? Do we have already the new primitive? If true, how can we adapt LargeIdentitySet to use such new primitive? Thanks! > > Levente > > >> thanks >> >> On Fri, Dec 16, 2011 at 3:28 PM, Levente Uzonyi <leves(a)elte.hu> wrote: >> >> On Fri, 16 Dec 2011, Henrik Sperre Johansen wrote: >>> >>> On 16.12.2011 03:26, Levente Uzonyi wrote: >>> >>>> >>>> >>>>> How about my numbers? :) >>>>> >>>>> "Preallocate objects, so we won't count gc time." >>>>> n := 1000000. >>>>> objects := Array new: n streamContents: [ :stream | >>>>> n timesRepeat: [ stream nextPut: Object new ] ]. >>>>> >>>>> set := IdentitySet new: n. >>>>> Smalltalk garbageCollect. >>>>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "4949" >>>>> >>>>> set := LargeIdentitySet new. >>>>> Smalltalk garbageCollect. >>>>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "331" >>>>> >>>>> set := (PluggableSet new: n) >>>>> hashBlock: [ :object | object identityHash * 4096 + object class >>>>> identityHash * 64 ]; "Change this to #basicIdentityHash in Pharo" >>>>> equalBlock: [ :a :b | a == b ]; >>>>> yourself. >>>>> Smalltalk garbageCollect. >>>>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "5511" >>>>> >>>>> >>>>> I also have a LargeIdentityDictionary, which is relatively fast, but >>>>> not >>>>> as fast as LargeIdentitySet, because (for some unknown reason) we don't >>>>> have a primitive that could support it. If we had a primitive like >>>>> primitive 132 which would return the index of the element if found or >>>>> 0 if >>>>> not, then we could have a really fast LargeIdentityDictionary. >>>>> >>>>> >>>>> Levente >>>>> >>>>> Hehe yes, if writing a version fully exploiting the limited range, >>>> that's >>>> probably the approach I would go for as well. >>>> (IAssuming it's the version at http://leves.web.elte.hu/** >>>> squeak/LargeIdentitySet.st<htt**p://leves.web.elte.hu/squeak/** >>>> LargeIdentitySet.st<http://leves.web.elte.hu/squeak/LargeIdentitySet.st> >>>> > >>>> ) >>>> >>>> Mariano commented in the version at http://www.squeaksource.com/** >>>> FuelExperiments <http://www.squeaksource.com/**FuelExperiments<http://www.squeaksource.com/FuelExperiments>> >>>> that it's >>>> >>>> slow for them, which I guess is due to not adopting #identityHash calls >>>> to >>>> #basicIdentityHash calls for Pharo: >>>> ((0 to: 4095) collect: [:each | each << 22 \\ 4096 ]) asSet size -> 1 >>>> So it basically uses 1 bucket instead of 4096... Whoops. :) >>>> >>>> Uploaded a new version to the MC repository which is adapted for Pharo, >>>> on the same machine my numbers were taken from, it does the same test >>>> as I >>>> used above in 871 ms. (181 with preallocation). >>>> >>>> >>> Cool. One more thing: in Squeak the method using primitive 132 directly >>> was renamed to #instVarsInclude:, so now #pointsTo: works as expected. If >>> this was also added to Pharo, then the #pointsTo: sends should be changed >>> to #instVarsInclude:, otherwise Array can be reported as included even if >>> it wasn't added. >>> I'll upload my LargeIdentityDictionary implementation to the same place >>> this evening, since it's still 2-3 factor faster than other solutionts >>> and >>> there seem to be demand for it. >>> >>> >>> Levente >>> >>> >>> Cheers, >>>> Henry >>>> >>>> >>>> >>>> >>> >> >> -- >> Mariano >> http://marianopeck.wordpress.**com <http://marianopeck.wordpress.com> >> >> > -- Mariano http://marianopeck.wordpress.com

4 12

I need help building Cog on 64bit Linux (new Squeak server)
by Ken Causey 08 Aug '13

08 Aug '13

I've been banging my head against building Cog on the primary new Squeak server off and on now for a couple of weeks. This server is 64bit Debian. Note that I don't need and am not trying to build a 64bit VM, a 32bit VM is fine, at least for the time being. I did of course read unixbuild/HowToBuild and the notes about building on 64bit. Unfortunately that doesn't work, in fact it fails quite early during the configure step (details in a moment). So after looking around a bit I decided that it was all wrong and instead '-m32' should be in CFLAGS. Well that certainly got me a lot farther but then I run into issues linking where gcc is used but without CFLAGS and it goes all pear shaped. So with my tail between my legs I go back today and try the original suggestion again and to see if I can fix/workaround it. And in fact I'm doing that right now. But then I also decided that I should ask for help, so here I am. Details: kencausey@squeak-box4:~/source/cog/svn/Cog/unixbuild/bld$ \ ../../platforms/unix/config/configure CC="gcc -m32" CXX="g++ -m32"\ --without-npsqueak CFLAGS="-g -O2 -msse2 -D_GNU_SOURCE \ -D_FILE^J_OFFSET_BITS=64 -DNDEBUG -DITIMER_HEARTBEAT=1 \ -DNO_VM_PROFILE=1 -DCOGMTVM=0 -DDEBUGVM=0" LIBS=-lpthread \ > myconf.log 2>&1 & ... checking for gcc... gcc -m32 checking for C compiler default output file name... configure: error: C compiler cannot create executables See `config.log' for more details. excerpt from config.log: configure:1862: checking for gcc configure:1888: result: gcc -m32 configure:2132: checking for C compiler version configure:2135: gcc -m32 --version </dev/null >&5 gcc (Debian 4.4.5-8) 4.4.5 Copyright (C) 2010 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. configure:2138: $? = 0 configure:2140: gcc -m32 -v </dev/null >&5 Using built-in specs. Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Debian 4.4.5-8' --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.4 --enable-shared --enable-multiarch --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.4 --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc --with-arch-32=i586 --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix gcc version 4.4.5 (Debian 4.4.5-8) configure:2143: $? = 0 configure:2145: gcc -m32 -V </dev/null >&5 gcc: '-V' must come at the start of the command line configure:2148: $? = 1 configure:2171: checking for C compiler default output file name configure:2174: gcc -m32 -g -O2 -msse2 -D_GNU_SOURCE -D_FILE _OFFSET_BITS=64 -DNDEBUG -DITIMER_HEARTBEAT=1 -DNO_VM_PROFILE=1 -DCOGMTVM=0 -DDEBUGVM=0 conftest.c -lpthread >&5 gcc: _OFFSET_BITS=64: No such file or directory configure:2177: $? = 1 configure: failed program was: | /* confdefs.h. */ | | #define PACKAGE_NAME "" | #define PACKAGE_TARNAME "" | #define PACKAGE_VERSION "" | #define PACKAGE_STRING "" | #define PACKAGE_BUGREPORT "" | #define SQ_VERSION "4.2-0" | #define VM_VERSION "4.0-2673" | #define OS_TYPE "unix" | #define VM_HOST "x86_64-linux-gnu" | #define VM_HOST_OS "linux-gnu" | #define VM_HOST_CPU "x86_64" | /* end confdefs.h. */ | | int | main () | { | | ; | return 0; | } configure:2216: error: C compiler cannot create executables See `config.log' for more details. Ken

12 37

Issue 119 in cog: SerialPlugin primitiveOpenPortByName: ...
by cog＠googlecode.com 08 Aug '13

08 Aug '13

Status: New Owner: ---- Labels: Type-Defect Priority-Medium New issue 119 by luc.fabr...(a)gmail.com: SerialPlugin primitiveOpenPortByName: ... http://code.google.com/p/cog/issues/detail?id=119 Since VMMaker-oscog-EstebanLorenzano.166, there is a bug in the implementation of SerialPlugin>>primitiveSerialPortOpenByName: portName baudRate: baudRate stopBitsType: stopBitsType parityType: parityType dataBits: dataBits inFlowControlType: inFlowControl outFlowControlType: outFlowControl xOnByte: xOnChar xOffByte: xOffChar Find a (small) patch attached. It is simple and it works. Just need integration. Luc Attachments: VMMaker-oscog-LucFabresse.229.mcz 2.6 MB

1 1

Issue 117 in cog: primitiveRemLargeIntegers is incorrect for negative quotient
by cog＠googlecode.com 08 Aug '13

08 Aug '13

Status: Accepted Owner: nicolas....(a)gmail.com Labels: Type-Defect Priority-High New issue 117 by nicolas....(a)gmail.com: primitiveRemLargeIntegers is incorrect for negative quotient http://code.google.com/p/cog/issues/detail?id=117 Now that primitive 20 is connected (COG 2662), I had a chance to run some tests and discover a bug (stupid copy/paste from quo)... The result should be negated iff receiver negative. Attachments: InterpreterPrimitives-primitiveRemLargeIntegers.st 871 bytes

1 1

Issue 115 in cog: FFIPlugin unsignedShortAt: answer a signed short
by cog＠googlecode.com 08 Aug '13

08 Aug '13

Status: Accepted Owner: nicolas....(a)gmail.com Labels: Type-Defect Priority-Medium New issue 115 by nicolas....(a)gmail.com: FFIPlugin unsignedShortAt: answer a signed short http://code.google.com/p/cog/issues/detail?id=115 (#[255 255 255 255] unsignedShortAt: 1) -> -1 This is exactly http://bugs.squeak.org/view.php?id=1415 It was reported in 2005, integrated in 2006 in VMMaker-tpr.55.mcz... ...and is still missing in COG branch Attachments: CogIssue115_FFIPlugin_unsignedShortAt_isSigned.st 1.6 KB

1 2

Issue 114 in cog: BMPReadWriterPlugin odes not check negative width and is subject to buffer overflow
by cog＠googlecode.com 08 Aug '13

08 Aug '13

Status: Accepted Owner: nicolas....(a)gmail.com Labels: Type-Defect Priority-Medium New issue 114 by nicolas....(a)gmail.com: BMPReadWriterPlugin odes not check negative width and is subject to buffer overflow http://code.google.com/p/cog/issues/detail?id=114 This was reported and fixed by Andreas in 2006 at http://bugs.squeak.org/view.php?id=4360 And integrated in 2007 in VMMaker-tpr.64... I fail to see why it should not be in COG branch too. Attachments: CogIssue114_fix_a_BMPReadWriterPlugin_potentialBufferOverflow.st 3.4 KB

1 1

Issue 113 in cog: Fix divide-by-zero protection in JPEGReaderPlugin
by cog＠googlecode.com 08 Aug '13

08 Aug '13

Status: Accepted Owner: nicolas....(a)gmail.com Labels: Type-Defect Priority-Medium New issue 113 by nicolas....(a)gmail.com: Fix divide-by-zero protection in JPEGReaderPlugin http://code.google.com/p/cog/issues/detail?id=113 Fix divideByZero protection in JPEGReaderPlugin as discussed in http://lists.squeakfoundation.org/pipermail/vm-dev/2012-December/011671.html Attachments: CogIssue113_JPEGReaderPlugin_divideByZero_protection.st 3.5 KB

1 1

Issue 112 in cog: Literal > 16rFFFFFFFF should better be generated as unsigned long long
by cog＠googlecode.com 08 Aug '13

08 Aug '13

Status: Accepted Owner: nicolas....(a)gmail.com Labels: Type-Defect Priority-High New issue 112 by nicolas....(a)gmail.com: Literal > 16rFFFFFFFF should better be generated as unsigned long long http://code.google.com/p/cog/issues/detail?id=112 This was one change of issue 92 which was forgotten. Currently, gcc is kind enough to correct 0xffffffffffffffffUL by itself, but it issues a warning and that stinks like Undefined Behaviour. Find attached correction based on .oscog-emm.241

1 2

Issue 111 in cog: Use direction aware << and >> instead of bitShift: to avoid useless Runtime test
by cog＠googlecode.com 08 Aug '13

08 Aug '13

Status: Accepted Owner: nicolas....(a)gmail.com Labels: Type-Enhancement Priority-Medium Performance Maintainability New issue 111 by nicolas....(a)gmail.com: Use direction aware << and >> instead of bitShift: to avoid useless Runtime test http://code.google.com/p/cog/issues/detail?id=111 As reported in vm-dev mailing list "bitShift: and runtime sign discussion" http://comments.gmane.org/gmane.comp.lang.smalltalk.squeak.vm.devel/9261 in (expr bitShift: shift), some shift have well known direction for the programmer, but the CCodeGenerator is unable to guess if shift is not literal. This results in useless runtime tests. Worse, it can increase the number of C compiler warnings after inlining. I attach some changes to VMMaker (based on .oscog-eem.241 branch). For sound, there is a shift sign discussion already, so we can eventually use directed shift too (based on trunk -ul.32 branch). Attachments: VMMaker_replace_bitShift_with_directedShift.cs 12.1 KB Sound_replace_bitShift_with_directedShift.cs 1.8 KB

1 3

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev January 2013