Vm-dev October 2017

vm-dev@lists.squeakfoundation.org

29 participants
47 discussions

StackInterp/Cog>>transferTo: - assertValidExecutionPointe:r:s differences
by Ben Coman 06 May '18

06 May '18

Just curious about the difference in instructionPointer between these two... StackInterpreter>>transferTo: self assertValidExecutionPointe: instructionPointer + 1 r: framePointer s: stackPointer. CoIntepreter>>transferTo:from: self assertValidExecutionPointe: instructionPointer r: framePointer s: stackPointer. cheers -ben

3 8

Reproducible crashing the VM with a zipped fuel serialization
by stephan 13 Jan '18

13 Jan '18

I revisited my MonticelloProjects experiment yesterday, and am still crashing the vm when serializing to a compressed fuel file. I wrote about it at the time, and then gave up as the vm was less stable during that period. http://forum.world.st/Working-with-a-compressed-Fuel-file-td4869105.html and it looks like the issue referenced: http://forum.world.st/Re-Pharo-project-GZipWriteStream-crashing-my-VM-when-… To reproduce in a pharo6 image: |project| Gofer it smalltalkhubUser: 'StephanEggermont' project: 'MonticelloProjects'; package: 'MonticelloProjects'; load. project := (Smalltalk at: #MCProject) new location: 'http://smalltalkhub.com/mc/StephanEggermont/Documentation/main'. project read. project saveToFile. That reliably crashes in saveToFile. It seems to be independent of 32/64 bit and mac/linux, as I tried some variations. Stephan

3 5

VM Maker: ImageFormat-dtl.28.mcz
by commits＠source.squeak.org 31 Oct '17

31 Oct '17

David T. Lewis uploaded a new version of ImageFormat to project VM Maker: http://source.squeak.org/VMMaker/ImageFormat-dtl.28.mcz ==================== Summary ==================== Name: ImageFormat-dtl.28 Author: dtl Time: 31 October 2017, 7:40:02.075 pm UUID: cbbbfbd7-34e4-4710-8210-99a48c85b6f2 Ancestors: ImageFormat-dtl.27 Fix typo, the hypothetical 68003 is a known version number, 68004 is not. =============== Diff against ImageFormat-dtl.27 =============== Item was changed: ----- Method: ImageFormat class>>knownVersionNumbers (in category 'initialize-release') ----- knownVersionNumbers "Version numbers currently in use or likely to be used (e.g. 64-bit Cog formats)" "ImageFormat knownVersionNumbers collect: [:e | (ImageFormat fromInteger: e) description]" ^ ( self baseVersionNumbers, "the original format number variants" { 6505 . "Cog and StackVM" + 68003 . "Cog and StackVM running 64-bit image" - 68004 . "Cog and StackVM running 64-bit image" 6521 . "Spur 32 bit object memory" 68019 . "Spur 64 bit object memory (early)" 68021 . "Spur 64 bit object memory" " ... add others here as bits are allocated to represent requirements of other image formats" } ) sort. !

1 0

[OpenSmalltalk/opensmalltalk-vm] 59d036: Fix access to files with long file names on win32/...
by GitHub 31 Oct '17

31 Oct '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 59d0365754f86754546641662518135eb0770c04 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/59d0365754f8675454… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-29 (Sun, 29 Oct 2017) Changed paths: M platforms/win32/plugins/FilePlugin/sqWin32File.h Log Message: ----------- Fix access to files with long file names on win32/win64 Long path were already handled with a prefix '\\?\' thanks to ALLOC_WIN32_PATH macro defined in platforms/win32/plugins/FilePlugin/sqWin32File.h Unfortunately, when concatenating a file path shorter than MAX_PATH with a file name making the total longer than MAX_PATH, using the macro REALLOC_WIN32_PATH, there were no '\\?\' prepended, and the file access did fail... This commit does fix the REALLOC_WIN32_PATH to handle the case when path become longer than limit after growth. Commit: b4511352aa319c926e16640e7e8d4bc46cd45331 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b4511352aa319c926e… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-29 (Sun, 29 Oct 2017) Changed paths: M platforms/win32/plugins/FilePlugin/sqWin32File.h M platforms/win32/vm/sqWin32Directory.c Log Message: ----------- Fix the win32 long path name realloc fix: 1) put the 32767 protection into the REALLOC_WIN32_PATH macro 2) correct the size of alloca when we prepend path with \\?\ (alloca is forgiving, but let's not create future hard to find bugs!) 3) correct the offset where we were copying the filename part which did not take 4 prepended char into account Commit: f32c8bb4101ce232e3e47d6857d651828fb29a9b https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f32c8bb4101ce232e3… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-30 (Mon, 30 Oct 2017) Changed paths: M platforms/win32/plugins/FilePlugin/sqWin32File.h M platforms/win32/vm/sqWin32Directory.c Log Message: ----------- Fix win32 long path name with a simpler solution a la Esteban Having two macros ALLOC_WIN32_PATH and REALLOC_WIN32_PATH that do almost the same thing smells. It is a lot simpler to concatenate native utf8 path and file names, then call ALLOC_WIN32_PATH once like Esteban Lorenzano did propose, rather than doing the work on converted WCHAR win32Path. Some more details: The concatenated fullPath does not require a trailing null char because MultiByteToWideChar() invoked by ALLOC_WIN32_PATH cares of it The lastString cache is now handled in utf8 too, without trailing null either- hence we don't use strcmp() Commit: 8781f36beec601e9117add479456f7f167d892d7 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8781f36beec601e911… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-31 (Tue, 31 Oct 2017) Changed paths: M platforms/win32/vm/sqWin32Directory.c Log Message: ----------- Fix win32 long filename for Pharo too Fix a forgotten win32PathLength in a PharoVM specific code... Commit: 673162cd01b2aff70ac216010a77b340f4209475 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/673162cd01b2aff70a… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-31 (Tue, 31 Oct 2017) Changed paths: M platforms/win32/plugins/FilePlugin/sqWin32File.h M platforms/win32/vm/sqWin32Directory.c Log Message: ----------- Merge pull request #162 from OpenSmalltalk/FIX_WIN32_LONG_FILENAME Fix win32 long filename Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/945819f714fa...67…

1 0

[OpenSmalltalk/opensmalltalk-vm] 8781f3: Fix win32 long filename for Pharo too
by GitHub 30 Oct '17

30 Oct '17

Branch: refs/heads/FIX_WIN32_LONG_FILENAME Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 8781f36beec601e9117add479456f7f167d892d7 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8781f36beec601e911… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-31 (Tue, 31 Oct 2017) Changed paths: M platforms/win32/vm/sqWin32Directory.c Log Message: ----------- Fix win32 long filename for Pharo too Fix a forgotten win32PathLength in a PharoVM specific code...

1 0

[OpenSmalltalk/opensmalltalk-vm] 57052f: It's a macro substitution bug rather than code gen...
by GitHub 30 Oct '17

30 Oct '17

Branch: refs/heads/MSVCCodeGenerationBug Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 57052f1aa493e69dfb5fbe00bb825ee9bff6d634 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/57052f1aa493e69dfb… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-30 (Mon, 30 Oct 2017) Changed paths: M README.md Log Message: ----------- It's a macro substitution bug rather than code generation bug More details in the README.md

1 0

[OpenSmalltalk/opensmalltalk-vm] f32c8b: Fix win32 long path name with a simpler solution a...
by GitHub 30 Oct '17

30 Oct '17

Branch: refs/heads/FIX_WIN32_LONG_FILENAME Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f32c8bb4101ce232e3e47d6857d651828fb29a9b https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f32c8bb4101ce232e3… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-30 (Mon, 30 Oct 2017) Changed paths: M platforms/win32/plugins/FilePlugin/sqWin32File.h M platforms/win32/vm/sqWin32Directory.c Log Message: ----------- Fix win32 long path name with a simpler solution a la Esteban Having two macros ALLOC_WIN32_PATH and REALLOC_WIN32_PATH that do almost the same thing smells. It is a lot simpler to concatenate native utf8 path and file names, then call ALLOC_WIN32_PATH once like Esteban Lorenzano did propose, rather than doing the work on converted WCHAR win32Path. Some more details: The concatenated fullPath does not require a trailing null char because MultiByteToWideChar() invoked by ALLOC_WIN32_PATH cares of it The lastString cache is now handled in utf8 too, without trailing null either- hence we don't use strcmp()

1 0

Sista/Scorch callbacks v. clock jitter
by Ben Coman 30 Oct '17

30 Oct '17

hi Clement, I was watching your nice talk on Pharo Optimizing JIT Internals. At 14:40 [1] you mention VM call-back to Scorch DNU-style. I was just curious how that might affect the jitter of the DelayScheduler waiting for the timingSemaphore set by "primSignal: timingSemaphore atMilliseconds: millisecondNextTick" to be signalled by the VM? [1] https://youtu.be/yDKaHphbFow?list=PLJ5nSnWzQXi_THfKwhzxFwbXy00YTi0uv&t=883 cheers -ben P.S. Later when you say Sista will be an optional VM - curious whether Sista might be switched on/off from within the VM? or just a command line flag? or an actual different VM (which adds complexity to system management).

2 4

[OpenSmalltalk/opensmalltalk-vm] 1c93c8: Bug report reference + instructions to reproduce
by GitHub 29 Oct '17

29 Oct '17

Branch: refs/heads/MSVCCodeGenerationBug Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1c93c83c8cff7adce24d17205f048da27781151e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1c93c83c8cff7adce2… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-29 (Sun, 29 Oct 2017) Changed paths: M README.md Log Message: ----------- Bug report reference + instructions to reproduce

1 0

[OpenSmalltalk/opensmalltalk-vm] b45113: Fix the win32 long path name realloc fix:
by GitHub 29 Oct '17

29 Oct '17

Branch: refs/heads/FIX_WIN32_LONG_FILENAME Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: b4511352aa319c926e16640e7e8d4bc46cd45331 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b4511352aa319c926e… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-10-29 (Sun, 29 Oct 2017) Changed paths: M platforms/win32/plugins/FilePlugin/sqWin32File.h M platforms/win32/vm/sqWin32Directory.c Log Message: ----------- Fix the win32 long path name realloc fix: 1) put the 32767 protection into the REALLOC_WIN32_PATH macro 2) correct the size of alloca when we prepend path with \\?\ (alloca is forgiving, but let's not create future hard to find bugs!) 3) correct the offset where we were copying the filename part which did not take 4 prepended char into account

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev October 2017