Vm-dev July 2017

vm-dev@lists.squeakfoundation.org

18 participants
54 discussions

StackInterp/Cog>>transferTo: - assertValidExecutionPointe:r:s differences
by Ben Coman 06 May '18

06 May '18

Just curious about the difference in instructionPointer between these two... StackInterpreter>>transferTo: self assertValidExecutionPointe: instructionPointer + 1 r: framePointer s: stackPointer. CoIntepreter>>transferTo:from: self assertValidExecutionPointe: instructionPointer r: framePointer s: stackPointer. cheers -ben

3 8

Reproducible crashing the VM with a zipped fuel serialization
by stephan 13 Jan '18

13 Jan '18

I revisited my MonticelloProjects experiment yesterday, and am still crashing the vm when serializing to a compressed fuel file. I wrote about it at the time, and then gave up as the vm was less stable during that period. http://forum.world.st/Working-with-a-compressed-Fuel-file-td4869105.html and it looks like the issue referenced: http://forum.world.st/Re-Pharo-project-GZipWriteStream-crashing-my-VM-when-… To reproduce in a pharo6 image: |project| Gofer it smalltalkhubUser: 'StephanEggermont' project: 'MonticelloProjects'; package: 'MonticelloProjects'; load. project := (Smalltalk at: #MCProject) new location: 'http://smalltalkhub.com/mc/StephanEggermont/Documentation/main'. project read. project saveToFile. That reliably crashes in saveToFile. It seems to be independent of 32/64 bit and mac/linux, as I tried some variations. Stephan

3 5

Re: [Vm-dev] OSProcess fork issue with Debian built VM
by Max Leske 03 Aug '17

03 Aug '17

We managed to figure out that OSProcess works when we use gcc <= 4.8 on Debian. We are happy to use 4.8 for now, so we're good. It would of course be super cool if we could use the series 6 gcc as that will soon ship with Debian 9 (stretch) but it's probably not trivial to just move to a new compiler version (as seems evident from the fact that a minor version change can mess up compilation). Thanks for your help Alistair and Eliot. Cheers, Max > On 18 May 2017, at 11:00, vm-dev-request(a)lists.squeakfoundation.org wrote: > >> On 18 May 2017, at 00:50, vm-dev-request(a)lists.squeakfoundation.org <mailto:vm-dev-request@lists.squeakfoundation.org> wrote: >> >> Hi Max, Hi Alistair, >> >> On Wed, May 17, 2017 at 1:06 AM, Alistair Grant <akgrant0710(a)gmail.com <mailto:akgrant0710@gmail.com> <mailto:akgrant0710@gmail.com <mailto:akgrant0710@gmail.com>>> >> wrote: >> >>> >>> On Tue, May 16, 2017 at 04:59:24PM +0200, Alistair Grant wrote: >>>> Hi Max, >>>> >>>> On 16 May 2017 15:40, "Max Leske" <maxleske(a)gmail.com <mailto:maxleske@gmail.com> <mailto:maxleske@gmail.com <mailto:maxleske@gmail.com>>> wrote: >>>> >>>> Hi Alistair, >>>> >>>> On 16 May 2017, at 15:32, vm-dev-request@lists. >>> squeakfoundation.org <http://squeakfoundation.org/> <http://squeakfoundation.org/ <http://squeakfoundation.org/>> >>>> wrote: >>>> >>>> Hi Max, >>>> >>>> I can't answer your question directly, but just wondering why >>> you are >>>> using >>>> the itimer VM when the are known issues with external calls, and >>> not >>>> the >>>> heartbeat VM? >>>> >>>> Because of the root user issue, and also because I don't care about >>> that >>>> much at the moment. I'm still experimenting and for those >>> experiments it >>>> doesn't matter which VM I use. Thirdly, the itimer VM is the one I >>> get when >>>> I use 'curl get.pharo.org/60+vmLatest <http://get.pharo.org/60+vmLatest> <http://get.pharo.org/60+vmLatest <http://get.pharo.org/60+vmLatest>> | bash', which is convenient >>> to get >>>> the latest VM, and to minimise differences between the VM's we built >>> the >>>> same one. I will definitely consider using the threaded VM for >>> production. >>>> >>>> P.S. I would love to see OSProcess working in 32 bit mode. >>>> >>>> Well, it does work already, just not when we build the VM ourselves >>> :/ >>>> >>>> Interesting, I had the impression that for Pharo 6 OSProcess didn't work >>> in >>>> 32bits, only 64, but I'm also building my own VM. I'm away from my PC, >>> but >>>> I'll try and take a look. >>> >>> I'm seeing the same behaviour as you, i.e. OSProcess works in a VM >>> downloaded from get.pharo.org <http://get.pharo.org/> <http://get.pharo.org/ <http://get.pharo.org/>>, but locks up when using the VM I >>> compiled. >>> >> >> Have you looked at the build logs and eliminated compiler version, command >> line flags, etc? One important file is the config.h that is produced in >> the build directory. It might be informative to compare the one configure >> is producing on your systems and the one that the binary builds creates. > > Thanks for the pointer. I'll look into it. > >> >> >>> >>> Both VMs (threaded heartbeat) are based on the same source code, i.e.: >>> >>> VM: 201705022326 https://github.com/OpenSmalltalk/opensmalltalk-vm.git <https://github.com/OpenSmalltalk/opensmalltalk-vm.git> <https://github.com/OpenSmalltalk/opensmalltalk-vm.git <https://github.com/OpenSmalltalk/opensmalltalk-vm.git>> $ >>> Date: Tue May 2 16:26:41 2017 -0700 $ >>> >>> I'll try and take a look at this eventually, but I'm not sure how long >>> that will be (several weeks away, at least). >>> >>> If you figure it out, please let me know. >>> >>> Thanks! >>> Alistair >>> >> >> >> >> -- >> _,,,^..^,,,_ >> best, Eliot >

4 7

Re: [Vm-dev] [Pharo-dev] FileSystem file attributes and #isSymlink patch
by David T. Lewis 27 Jul '17

27 Jul '17

Hi Alistair, I am copying this to vm-dev for follow up on the plugin, see below. On Mon, Jul 24, 2017 at 08:09:10AM +0000, Alistair Grant wrote: > Hi All, > > I'm nearly ready to submit a patch that started with the goal of being > able to retrieve the device id and fixing FileReference>>isSymlink and > also follows Esteban's suggestion of splitting out file existence and > other attributes (which provides a performace gain). See the summary > below for a description of the changes. > > The patch involves adding a new VM plugin, FileAttriubutesPlugin. To > minimise the chance of any problems along the way I'd like to submit the > patch in three steps: > > 1. Add the VM plugin (FileAttributesPlugin) > 2. Add the code the image that allows testing of the code and plugin, > but doesn't do any integration with existing functionality. > This will allow the plugin to be tested by a few volunteers > (hopefully). > 3. Add the patches that make the switch over to the new implementation. > I think you are handling this in exactly the right way, kudos. > > Can someone point me to how to submit a new VM plugin? The code is > contained in a subclass of InterpreterPlugin. Following up on the vm-dev list: If your plugin is available in a Monticello repository, that would be great because VM builders can easily include it and try it out. Any repository would be fine for starters, or if you have an account on squeaksource.com I can add you as developer in the somewhat loosely-related DirectoryPlugin project if that is of any help. Whatever is convenient for you. Your plugin sounds like something that would be stable and require little maintenance over time, so it might make sense to pull it directly into the VMMaker package. We can discuss that vm-dev list. Once your plugin code is available, it should be straighforward to start including it in the various VM build configurations. Dave > > I've been using this as my production environment for about 2 months now > on a linux 32 bit VM. Running the full test suite results in the same > set of test failing before and after applying the patch. > > I've also ran file related tests on linux 64 bit (run the Test Runner, > select all packages with "file" as part of the name and run all the > available tests) and the full test suite on Windows 32 bit. > > The summary is: > > 1. #isSymlink now works properly on Linux (and it should also work on > MacOS and BSD). > 2. The list of file attributes available from FileReference now is: > #accessTime (new) > #changeTime (new) > #creationTime > #deviceId (new) > #exists > #gid (new) > #inode (new) > #isBlock (new) > #isCharacter (new) > #isDirectory > #isExecutable (new) > #isFIFO (new) > #isFile > #isReadable > #isRegular (new) > #isSocket (new) > #isSymlink (works) > #isWritable > #modificationTime > #numberOfHardLinks (new) > #permissions > #size > #targetFile (new) > #uid (new) > 3. FileReference>>exists is faster than before (well, at least on my > linux laptop). This is useful as it is called quite often. > 4. It is possible to retrieve symbolic link attributes, e.g. all the > attributes listed above plus the target path. > > > Given how similar MacOS and BSD are to linux, I assume that this will > all work without problem on those platforms (but it obviously needs to > be tested). > > As implied above, the changes are all backward compatible (except > the broken #isSymlink), although a couple deserve mention: > > 1. Obviously #isSymlink now answers correctly (previously it would only > answer correctly for a broken link). > 2. Requesting any of the attributes listed above (except #isSymlink) > will return the value of the target path. If the FileReference is to a > broken symbolic link, it will return the attributes of the symbolic > link (keeping existing behaviour). > 3. The attributes of a symbolic link can be retrieved using > FileReference>>symlinkAttributes. > > Overall, performance is slightly better than before. Code that > needs to access multiple attributes and is written to take advantage of > the new behaviour will see significant performance improvements. > > > If you've got this far and forgotten the original question :-) > > Can someone point me to how to submit a new VM plugin? > > > Thanks, > Alistair

2 4

[OpenSmalltalk/opensmalltalk-vm] f20ec8: Appveyor: add explicit dependency on make & wget
by GitHub 26 Jul '17

26 Jul '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f20ec8a683871b98744f9759955ea9277624648f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f20ec8a683871b9874… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-07-26 (Wed, 26 Jul 2017) Changed paths: M .appveyor.yml Log Message: ----------- Appveyor: add explicit dependency on make & wget make & wget are preinstalled in appveyor, but those instructions might help having repeatable configuration for casual developpers

1 0

[VM-dev] Problem when waiting on delay during ensure block
by Denis Kudriashov 26 Jul '17

26 Jul '17

Hi. I found interesting problem. Following script will never return: s := Semaphore new. p1 := [ [ 100 seconds asDelay wait ] ensure: [ s waitTimeoutMSecs: 50 ] ] fork. 100 milliSeconds asDelay wait. p1 terminate. If you will interrupt it by cmd+. It will show debugger. If you will close it new debugger will be opened on Unwind error. And in Squeak any attempt to close it will open same debugger again and again. I thing it is important bug. It shows that we are able to write quite simple code which will be impossible to terminate. For example #ensure: part could include business logic to send some remote notifications which will use delays. And during debug it will be easy to get this scenario. In Pharo it is more worth because unwind error leads to infinite recursion for opening debuggers and image crash after minutes. Best regards, Denis

1 0

VM Maker: ImageFormat-dtl.26.mcz
by commits＠source.squeak.org 25 Jul '17

25 Jul '17

David T. Lewis uploaded a new version of ImageFormat to project VM Maker: http://source.squeak.org/VMMaker/ImageFormat-dtl.26.mcz ==================== Summary ==================== Name: ImageFormat-dtl.26 Author: dtl Time: 25 July 2017, 8:11:17.418 am UUID: f97d3f06-0bf7-4472-aecd-0a750c9d7ca1 Ancestors: ImageFormat-dtl.25 Bit 17 of the image format number may be used as a test for 64-bit-ness for both Spur and V3. Add testBit17AsTestFor64BitImages to document this. The changes in ImageFormat-dtl.20 for format numbers 68019 and 68021 were missing test support, add it here. =============== Diff against ImageFormat-dtl.25 =============== Item was changed: ----- Method: ImageFormat class>>knownVersionNumbers (in category 'initialize-release') ----- knownVersionNumbers "Version numbers currently in use or likely to be used (e.g. 64-bit Cog formats)" "ImageFormat knownVersionNumbers collect: [:e | (ImageFormat fromInteger: e) description]" + ^ self baseVersionNumbers, "the original format number variants" - ^ self baseVersionNumbers, "the original four variants" { 6505 . "Cog and StackVM" + 68004 . "Cog and StackVM running 64-bit image" - 68003 . "Cog and StackVM running 64-bit image" 6521 . "Spur 32 bit object memory" 68019 . "Spur 64 bit object memory (early)" 68021 . "Spur 64 bit object memory" " ... add others here as bits are allocated to represent requirements of other image formats" } ! Item was changed: ----- Method: ImageFormatTest>>testAsInteger (in category 'testing') ----- testAsInteger self assert: (ImageFormat fromInteger: 6502) asInteger = 6502. self assert: (ImageFormat fromInteger: 6504) asInteger = 6504. self assert: (ImageFormat fromInteger: 68000) asInteger = 68000. self assert: (ImageFormat fromInteger: 68002) asInteger = 68002. self assert: (ImageFormat fromInteger: 6521) asInteger = 6521. self assert: (ImageFormat fromInteger: 68019) asInteger = 68019. + self assert: (ImageFormat fromInteger: 68021) asInteger = 68021. ! Item was added: + ----- Method: ImageFormatTest>>testBit17AsTestFor64BitImages (in category 'testing') ----- + testBit17AsTestFor64BitImages + "If bit 17 of the version number is 1, then the image is a 64-bit image." + + ImageFormat knownVersionNumbers do: [ :versionNumber | | is64 bit17 | + is64 := (ImageFormat fromInteger: versionNumber) is64Bit. + bit17 := versionNumber bitAt: 17. + self assert: bit17 = 1 equals:is64 + ]. + ! Item was changed: ----- Method: ImageFormatTest>>testIs32Bit (in category 'testing') ----- testIs32Bit self assert: (ImageFormat wordSize: 4) is32Bit. self assert: (ImageFormat new fromInteger: 6504) is32Bit. self deny: (ImageFormat wordSize: 8) is32Bit. self deny: (ImageFormat new fromInteger: 68002) is32Bit. self deny: (ImageFormat fromInteger: 6521) is64Bit. self assert: (ImageFormat new fromInteger: 68019) is64Bit. + self assert: (ImageFormat new fromInteger: 68021) is64Bit. ! Item was changed: ----- Method: ImageFormatTest>>testIs64Bit (in category 'testing') ----- testIs64Bit self deny: (ImageFormat wordSize: 4) is64Bit. self deny: (ImageFormat new fromInteger: 6504) is64Bit. self assert: (ImageFormat wordSize: 8) is64Bit. self assert: (ImageFormat new fromInteger: 68002) is64Bit. self deny: (ImageFormat fromInteger: 6521) is64Bit. self assert: (ImageFormat new fromInteger: 68019) is64Bit. + self assert: (ImageFormat new fromInteger: 68021) is64Bit. ! Item was changed: ----- Method: ImageFormatTest>>testIsValidVersionNumber (in category 'testing') ----- testIsValidVersionNumber self should: [ImageFormat fromInteger: 0] raise: Error. self should: [ImageFormat fromInteger: (6502 bitAnd: 16r80000000)] raise: Error. self should: [ImageFormat fromInteger: (6502 bitAt: 31 put: 1)] raise: Error. self should: [ImageFormat fromInteger: 6500] raise: Error. self should: [ImageFormat fromInteger: 6501] raise: Error. self should: [ImageFormat fromInteger: 6503] raise: Error. "Cog requires both capabilities" self should: [ImageFormat fromInteger: 68001] raise: Error. "Cog requires both capabilities" self assert: ImageFormat default isValidVersionNumber. self assert: (ImageFormat wordSize: 4 closures: false) isValidVersionNumber. self assert: (ImageFormat wordSize: 4 closures: true) isValidVersionNumber. self assert: (ImageFormat wordSize: 8 closures: false) isValidVersionNumber. self assert: (ImageFormat wordSize: 8 closures: true) isValidVersionNumber. self assert: (ImageFormat fromInteger: 6502) isValidVersionNumber. self assert: (ImageFormat fromInteger: (6502 bitAt: 31 put: 0)) isValidVersionNumber. self assert: (ImageFormat fromInteger: 6521) isValidVersionNumber. + self assert: (ImageFormat fromInteger:68000) isValidVersionNumber. + self assert: (ImageFormat fromInteger:68002) isValidVersionNumber. + self assert: (ImageFormat fromInteger:68004) isValidVersionNumber. + self assert: (ImageFormat fromInteger:68003) isValidVersionNumber. "valid but unused, as with 68019" self assert: (ImageFormat fromInteger: 68019) isValidVersionNumber. + self assert: (ImageFormat fromInteger: 68021) isValidVersionNumber. ! Item was changed: ----- Method: ImageFormatTest>>testRequiresNativeFloatWordOrder (in category 'testing') ----- testRequiresNativeFloatWordOrder "Required for Cog and StackInterpreter" | v | v := ImageFormat wordSize: 4. self deny: v requiresNativeFloatWordOrder. v setCogSupportRequirement: false. self assert: v asInteger = 6502. self deny: v requiresNativeFloatWordOrder. v setCogSupportRequirement: true. self assert: v asInteger = 6505. self assert: v requiresNativeFloatWordOrder. v setSpurSupportRequirement: true. self assert: v asInteger = 6521. v := ImageFormat wordSize: 8. self deny: v requiresNativeFloatWordOrder. v setCogSupportRequirement: false. self assert: v asInteger = 68000. self deny: v requiresNativeFloatWordOrder. v setCogSupportRequirement: true. self assert: v asInteger = 68003. self assert: v requiresNativeFloatWordOrder. v setSpurSupportRequirement: true. self assert: v asInteger = 68019. self deny: (ImageFormat wordSize: 4 cog: false) requiresNativeFloatWordOrder. self deny: (ImageFormat wordSize: 4 cog: false) requiresClosureSupport. self deny: (ImageFormat wordSize: 8 cog: false) requiresNativeFloatWordOrder. self deny: (ImageFormat wordSize: 8 cog: false) requiresClosureSupport. self assert: (ImageFormat wordSize: 4 cog: true) requiresNativeFloatWordOrder. self assert: (ImageFormat wordSize: 4 cog: true) requiresClosureSupport. self assert: (ImageFormat wordSize: 8 cog: true) requiresNativeFloatWordOrder. self assert: (ImageFormat wordSize: 8 cog: true) requiresClosureSupport. self assert: (ImageFormat fromInteger: 6521) requiresNativeFloatWordOrder. self assert: (ImageFormat fromInteger: 6521) requiresClosureSupport. self assert: (ImageFormat fromInteger: 68019) requiresNativeFloatWordOrder. self assert: (ImageFormat fromInteger: 68019) requiresClosureSupport. + self assert: (ImageFormat fromInteger: 68021) requiresNativeFloatWordOrder. + self assert: (ImageFormat fromInteger: 68021) requiresClosureSupport. + !

1 0

[OpenSmalltalk/opensmalltalk-vm] 568ec2: CogVM source as per VMMaker.oscog-eem.2258
by GitHub 22 Jul '17

22 Jul '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 568ec25bb56893b65c1de13c322f88acb626dd51 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/568ec25bb56893b65c… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-21 (Fri, 21 Jul 2017) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/BochsIA32Plugin/BochsIA32Plugin.c M src/plugins/BochsX64Plugin/BochsX64Plugin.c M src/plugins/CroquetPlugin/CroquetPlugin.c M src/plugins/GdbARMPlugin/GdbARMPlugin.c M src/plugins/HostWindowPlugin/HostWindowPlugin.c M src/plugins/IA32ABI/IA32ABI.c M src/plugins/MacMenubarPlugin/MacMenubarPlugin.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/plugins/VMProfileLinuxSupportPlugin/VMProfileLinuxSupportPlugin.c M src/plugins/VMProfileMacSupportPlugin/VMProfileMacSupportPlugin.c M src/vm/cogit.h M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2258 Interpreter: Provide primitive 248 as a don't-copy-hash alternative to primitive 72 (primitiveArrayBecomeForward, the primitive in elementsForwardIdentityTo: which implements becomeForward:. Rewrite remaining pop:;push: users in primitives to use pop:thenPush: InterpreterPlugins: Fix integer promotion in the plugin hierarchy, which is compiled as either 32 or 64 bits. Use a functional hack; size all types that are either 32 or 64 bits as 48 bits. Add the Terf primitives to the HostWindowPlugin as <option: #TerfVM>. Make positive/signedMachineIntegerFor: <inline: #always> since they're merely indirections to 64-bit and 32-bit functions, and with #always we don't bother to generate the method itself.

1 0

VM Maker: VMMaker.oscog-eem.2257.mcz
by commits＠source.squeak.org 21 Jul '17

21 Jul '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2257.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2257 Author: eem Time: 21 July 2017, 11:32:44.600471 am UUID: 7a3c75a8-72e7-4362-88b7-9a97109592a1 Ancestors: VMMaker.oscog-eem.2256 InterpreterPlugins: Add the Terf primitives to the HostWindowPlugin as <option: #TerfVM>. Hence add #TerfVM to namesDefinedAtCompileTime. Make positive/signedMachineIntegerFor: <inline: #always> since they're merely indirections to 64-bit and 32-bit functions, and with #always we don't bother to generate the method itself. =============== Diff against VMMaker.oscog-eem.2256 =============== Item was added: + ----- Method: HostWindowPlugin>>pointFromCompactPointEncoding: (in category 'support') ----- + pointFromCompactPointEncoding: encodedPoint + "Answer a point from one of the funky encoded x,y position/size values the VM uses. + The issue here is that the values can be negative, each value being in the range -32768 to 32767" + <inline: #always> + ^interpreterProxy + makePointwithxValue: (self cCoerceSimple: encodedPoint >> 16 to: #short) + yValue: (self cCoerceSimple: (encodedPoint bitAnd: 16rFFFF) to: #short)! Item was changed: ----- Method: HostWindowPlugin>>primitiveHostWindowPosition: (in category 'system primitives') ----- primitiveHostWindowPosition: windowIndex "Return the origin position of the user area of the window in pixels from the topleft corner of the screen. Fail if the windowIndex is invalid or the platform routine returns -1 to indicate failure" | pos | self primitive: 'primitiveHostWindowPosition' parameters: #(SmallInteger ). pos := self ioPositionOfWindow: windowIndex. + pos = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: pos! - pos = -1 - ifTrue: [^ interpreterProxy primitiveFail] - ifFalse: [^ interpreterProxy makePointwithxValue: pos >> 16 yValue: (pos bitAnd: 16rFFFF)]! Item was changed: ----- Method: HostWindowPlugin>>primitiveHostWindowPositionSet:x:y: (in category 'system primitives') ----- + primitiveHostWindowPositionSet: windowIndex x: x y: y + "Set the origin position of the user area of the window in pixels from the topleft corner of the screen- return the position actually set by the OS/GUI/window manager. Fail if the windowIndex is invalid or the platform routine returns -1 to indicate failure" - primitiveHostWindowPositionSet: windowIndex x: x y: y - "Set the origin position of the user area of the window in pixels from the topleft corner of the screen- return the position actually set by the OS/GUI/window manager. Fail if the windowIndex is invalid or the platform routine returns -1 to indicate failure" | pos | self primitive: 'primitiveHostWindowPositionSet' parameters: #(SmallInteger SmallInteger SmallInteger). pos := self ioPositionOfWindowSet: windowIndex x: x y: y. + pos = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: pos! - pos = -1 - ifTrue: [^ interpreterProxy primitiveFail] - ifFalse: [^ interpreterProxy makePointwithxValue: pos >> 16 yValue: (pos bitAnd: 16rFFFF)]! Item was added: + ----- Method: HostWindowPlugin>>primitiveHostWindowScreenWorkAreaPosition: (in category 'system primitives') ----- + primitiveHostWindowScreenWorkAreaPosition: windex + <option: #TerfVM> + "Answer the platform's notion of the available work area on the screen containing the given window." + | size | + self primitive: 'primitiveHostWindowScreenWorkAreaPosition' + parameters: #(SmallInteger). + size := self ioPositionOfScreenWorkArea: windex. + size = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: size! Item was added: + ----- Method: HostWindowPlugin>>primitiveHostWindowScreenWorkAreaSize: (in category 'system primitives') ----- + primitiveHostWindowScreenWorkAreaSize: windex + <option: #TerfVM> + "Answer the platform's notion of the available work area on the screen containing the given window." + | size | + self primitive: 'primitiveHostWindowScreenWorkAreaSize' + parameters: #(SmallInteger). + size := self ioSizeOfScreenWorkArea: windex. + size = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: size! Item was changed: ----- Method: HostWindowPlugin>>primitiveHostWindowSize: (in category 'system primitives') ----- primitiveHostWindowSize: windowIndex "Return the size of the user area of the window in pixels. Fail if the windowIndex is invalid or the platform routine returns -1 to indicate failure" | size | self primitive: 'primitiveHostWindowSize' parameters: #(SmallInteger ). size := self ioSizeOfWindow: windowIndex. + size = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: size! - size = -1 - ifTrue: [^ interpreterProxy primitiveFail] - ifFalse: [^ interpreterProxy makePointwithxValue: size >> 16 yValue: (size bitAnd: 16rFFFF)]! Item was changed: ----- Method: HostWindowPlugin>>primitiveHostWindowSizeSet:x:y: (in category 'system primitives') ----- primitiveHostWindowSizeSet: windowIndex x: x y: y "Set the size of the user area of the window in pixels - return what is actually set by the OS/GUI/window manager. Fail if the windowIndex is invalid or the platform routine returns -1 to indicate failure" | size | self primitive: 'primitiveHostWindowSizeSet' parameters: #(SmallInteger SmallInteger SmallInteger). size := self ioSizeOfWindowSet: windowIndex x: x y: y. + size = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: size! - size = -1 - ifTrue: [^ interpreterProxy primitiveFail] - ifFalse: [^ interpreterProxy makePointwithxValue: size >> 16 yValue: (size bitAnd: 16rFFFF)]! Item was added: + ----- Method: HostWindowPlugin>>primitiveNativeDisplayPosition: (in category 'system primitives') ----- + primitiveNativeDisplayPosition: windowHandle + <option: #TerfVM> + "Answer the origin position of the user area of the given native window in pixels from the topleft corner of the screen. + Fail if the windowHandle is invalid or the platform routine returns -1 to indicate failure" + | pos | + self primitive: 'primitiveNativeDisplayPosition' + parameters: #(Unsigned). + pos := self ioPositionOfNativeDisplay: windowHandle. + pos = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: pos! Item was added: + ----- Method: HostWindowPlugin>>primitiveNativeDisplaySize: (in category 'system primitives') ----- + primitiveNativeDisplaySize: windowHandle + <option: #TerfVM> + "Answer the size of the user area of the given native window in pixels. + Fail if the windowHandle is invalid or the platform routine returns -1 to indicate failure" + | size | + self primitive: 'primitiveNativeDisplaySize' + parameters: #(Unsigned). + size := self ioSizeOfNativeDisplay: windowHandle. + size = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: size! Item was added: + ----- Method: HostWindowPlugin>>primitiveNativeWindowPosition: (in category 'system primitives') ----- + primitiveNativeWindowPosition: windowHandle + <option: #TerfVM> + "Answer the origin position of the given native window in pixels from the topleft corner of the screen. + Fail if the windowHandle is invalid or the platform routine returns -1 to indicate failure" + | pos | + self primitive: 'primitiveNativeWindowPosition' + parameters: #(Unsigned). + pos := self ioPositionOfNativeWindow: windowHandle. + pos = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: pos! Item was added: + ----- Method: HostWindowPlugin>>primitiveNativeWindowSize: (in category 'system primitives') ----- + primitiveNativeWindowSize: windowHandle + <option: #TerfVM> + "Answer the size of the given native window in pixels. + Fail if the windowHandle is invalid or the platform routine returns -1 to indicate failure" + | size | + self primitive: 'primitiveNativeWindowSize' + parameters: #(Unsigned). + size := self ioSizeOfNativeWindow: windowHandle. + size = -1 ifTrue: + [^interpreterProxy primitiveFail]. + ^self pointFromCompactPointEncoding: size! Item was added: + ----- Method: HostWindowPlugin>>primitiveSetCursorPositionX:Y: (in category 'system primitives') ----- + primitiveSetCursorPositionX: x Y: y + <option: #TerfVM> + "Set the position of the cursor to the specified position on the desktop. + Fail if the platform routine returns -1 to indicate failure." + | result | + self primitive: 'primitiveSetCursorPosition' + parameters: #(SmallInteger SmallInteger). + result := self ioSetCursorPositionX: x Y: y. + result = -1 ifTrue: + [^interpreterProxy primitiveFail]! Item was added: + ----- Method: HostWindowPlugin>>primitiveSqueakWindowHandle (in category 'system primitives') ----- + primitiveSqueakWindowHandle + <option: #TerfVM> + "Answer the native Squeak window handle, presumably a pointer, as an unsigned integer. + This value should be usable in native calls to the window manager as well as + the argument to primitiveNativeWindowPosition:" + | handle | + <var: #handle type: 'void *'> + self primitive: 'primitiveSqueakWindowHandle'. + handle := self ioGetWindowHandle. + handle = 0 ifTrue: + [^interpreterProxy primitiveFail]. + ^interpreterProxy positiveMachineIntegerFor: (self cCoerceSimple: handle to: #sqInt)! Item was changed: ----- Method: InterpreterPlugin>>positiveMachineIntegerFor: (in category 'API access') ----- positiveMachineIntegerFor: value <var: #value type: #'usqIntptr_t'> + <inline: #always> - <inline: true> ^interpreterProxy wordSize = 8 ifTrue: [interpreterProxy positive64BitIntegerFor: value] ifFalse: [interpreterProxy positive32BitIntegerFor: value]! Item was changed: ----- Method: InterpreterPlugin>>signedMachineIntegerFor: (in category 'API access') ----- signedMachineIntegerFor: value <var: #value type: #'sqIntptr_t'> + <inline: #always> - <inline: true> ^interpreterProxy wordSize = 8 ifTrue: [interpreterProxy signed64BitIntegerFor: value] ifFalse: [interpreterProxy signed32BitIntegerFor: value]! Item was changed: ----- Method: VMBasicConstants class>>namesDefinedAtCompileTime (in category 'C translation') ----- namesDefinedAtCompileTime "Answer the set of names for variables that should be defined at compile time. Some of these get default values during simulation, and hence get defaulted in the various initializeMiscConstants methods. But that they have values should /not/ cause the code generator to do dead code elimination based on their default values." ^#( VMBIGENDIAN IMMUTABILITY STACKVM COGVM COGMTVM SPURVM PharoVM "Pharo vs Squeak" + TerfVM "Terf vs Squeak" EnforceAccessControl "Newspeak" CheckRememberedInTrampoline "IMMUTABILITY" + LLDB) "As of lldb-370.0.42 Swift-3.1, passing funciton parameters to printOopsSuchThat fails with Internal error [IRForTarget]: Couldn't rewrite one of the arguments of a function call. Turning off link time optimization with -fno-lto has no effect. hence we define some debugging functions as being <option: LLDB>"! - LLDB) "As of lldb-370.0.42 Swift-3.1, passing funciton parameters to printOopsSuchThat fails with Internal error [IRForTarget]: Couldn't rewrite one of the arguments of a function call. Turning off link time optimization with -fno0lto has no effect. hence we define some debugging functions as being <option: LLDB>"!

1 0

Re: [Vm-dev] [squeak-dev] Object new becomeForward: #normal
by Eliot Miranda 20 Jul '17

20 Jul '17

Hi Bert, [please see the "however" later on] On Tue, Jul 18, 2017 at 7:30 AM, Bert Freudenberg <bert(a)freudenbergs.de> wrote: > On Tue, Jul 18, 2017 at 4:09 PM, Levente Uzonyi <leves(a)caesar.elte.hu> > wrote: > >> On Tue, 18 Jul 2017, marcel.taeumel wrote: >> >> Hi, there. >>> >>> Why are there guards to prevent forward-becoming to immediates (chars, >>> ints) >>> but not to symbols? >>> >> >> The former is technically impossible due to different object >> representations, the latter is possible and not restricted at all. For >> example, true and false are not immediate objects, you can use #become*: on >> them to blow your image up. >> So, there's no restriction at all if it's technically possible to use >> #become*:. >> The responsibility model is the simplest here: use at your own risk. >> Since this comes up every once in a while, I suggest a comment be added >> to those methods stating the responsibility model explicitly. >> > > +1 > > *Especially* a warning that becomeForward: does modify the target's hash. > > >> I don't know how the VM handles immutability in this case, but it's >> possible that it wouldn't let #become*: affect immutable objects. > > > I think that would be fine, you should be able to become an immutable > object and vice versa. > > >> On the other hand, I'm sure it would let you change fields of immutable >> objects via #become*:, but that's not an issue in your case. > > > This is debatable ... I would rather have the VM raise an error when > trying to become a field of an immutable object. Immutable should mean > immutable, no? > Agreed. I'm modifying the Spur VM to fail becomeForward: when copyHash is true and the target object is immutable. So when we have immutable literals, #normal would be immutable and the become would fail. The operative code was containsOnlyValidBecomeObjects: array1 and: array2 twoWay: isTwoWay copyHash: copyHash ... [fieldOffset >= self baseHeaderSize] whileTrue: [... isTwoWay ifTrue: [...] ifFalse: >> [(copyHash and: [self isImmediate: oop2]) ifTrue: >> [^PrimErrInappropriate]]. fieldOffset := fieldOffset - self bytesPerOop]. ... ^0 and is now containsOnlyValidBecomeObjects: array1 and: array2 twoWay: isTwoWay copyHash: copyHash ... [fieldOffset >= self baseHeaderSize] whileTrue: [... isTwoWay ifTrue: [...] ifFalse: >> [(copyHash and: [(self isImmediate: oop2) or: [self isImmutable: oop2]]) ifTrue: >> [^PrimErrInappropriate]]. fieldOffset := fieldOffset - self bytesPerOop]. ... ^0 This was a slip on mine and Clément's part when we added read-only object support. However, it seems to me that becomerForward: doing a copyHash is itself a bug. What's the rationale for copying the receiver's hash to the target object? I've seen various frameworks use become to clean-up objects by doing aNoLongerWantedObject becomeFor4ward: nil, and with our current default implementation for becomeForward: that will cause havoc. - Bert - > > Levente >> >> This will break your image: "Object new becomeForward: #normal" >>> >>> ... because Cursor class MNU #normal ... :-) Either this is a bug or >>> forward-becoming to symbols is not intended at all. >>> >>> Best, >>> Marcel >>> >> _,,,^..^,,,_ best, Eliot

2 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev July 2017