Vm-dev November 2021

vm-dev@lists.squeakfoundation.org

11 participants
54 discussions

[OpenSmalltalk/opensmalltalk-vm] Allow choosing an image via zenity when no arguments are provided (#408)
by Leon Matthes 05 Jun '23

05 Jun '23

You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/408 -- Commit Summary -- * Add file chooser dialog to squeak.sh.in * Add file chooser dialog to bin.squeak.sh.in -- File Changes -- M platforms/unix/config/bin.squeak.sh.in (13) M platforms/unix/config/squeak.sh.in (13) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/408.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/408.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/408

4 8

[OpenSmalltalk/opensmalltalk-vm] Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) (#575)
by Ken Dickey 10 Jul '22

10 Jul '22

With libevdev, mouse and keyboard are bound to devices in /dev/input with names like "event0" and "event1". Different keyboard/mouse hw binds to different numbers, so it is important to allow overrides via shell variables. E.g. SQUEAK_MSDEV=/dev/input/event1 SQUEAK_KBDEV=/dev/input/event0 vs SQUEAK_MSDEV=/dev/input/event0 SQUEAK_KBDEV=/dev/input/event1 Mouse rebinding works, but not keyboard rebinding. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/575

1 2

[OpenSmalltalk/opensmalltalk-vm] please update branch oldTrunk (Issue #604)
by Jonas Smedegaard 04 May '22

04 May '22

The oldTrunk branch was last updated in 2016 and misses some 100 commits. Please update to be in sync with http://squeakvm.org/svn/squeak/trunk/ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/604

6 15

[OpenSmalltalk/opensmalltalk-vm] Patch callback thunkEntry to not optimize (#353)
by Guille Polito 13 Apr '22

13 Apr '22

O2 and O1 compilation produce a segmentation fault due to stack corruption (when debugging we saw some extra pushes from the stack) on callbacks return. This happens on windows 32, when compiling with mingw gcc 7.4.0. The issue can be reproduced easily by running the Alien qsort example in latest vms in both Pharo and Squeak. This PR proposes to patch just the thunkEntry function. Not optimizing just that function solves the issue in our environment, though maybe there is a more fine-grained solution. We should still investigate what is the particular optimization that causes the problem. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353 -- Commit Summary -- * Patch callback thunkEntry to not optimize, failing in win32 using gcc 7.4.0 -- File Changes -- M platforms/Cross/plugins/IA32ABI/ia32abicc.c (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353

4 4

VM Maker Inbox: BytecodeSets.spur-eem.81.mcz
by commits＠source.squeak.org 08 Apr '22

08 Apr '22

Eliot Miranda uploaded a new version of BytecodeSets to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/BytecodeSets.spur-eem.81.mcz ==================== Summary ==================== Name: BytecodeSets.spur-eem.81 Author: eem Time: 12 September 2021, 10:20:31.001161 pm UUID: d4391f21-0790-4132-9ae4-97941c8e3809 Ancestors: BytecodeSets.spur-eem.80 Proposed fix for CompiledCode>>#allLiteralsDo: by adding pushSpecialConstant:/sendSpecial:numArgs:. =============== Diff against BytecodeSets.spur-eem.80 =============== Item was changed: ----- Method: InstructionStream>>interpretNSV4ExtendedPush:for: (in category '*BytecodeSets-NewsqueakV4-decoding') ----- interpretNSV4ExtendedPush: extB for: client "Implement the extended push for non-zero extensions." "77 01001101 Push false [* 1:true, 2:nil, 3:thisContext, ..., -N: pushExplicitOuter: N, N = Extend B]" extB < 0 ifTrue: [^client pushExplicitOuter: extB negated]. extB < 2 ifTrue: + [^client pushSpecialConstant: extB = 1]. - [^client pushConstant: extB = 1]. extB = 2 ifTrue: + [^client pushSpecialConstant: nil]. - [^client pushConstant: nil]. extB = 3 ifTrue: [^client pushActiveContext]. self error: 'undefined extended push'! Item was changed: ----- Method: InstructionStream>>interpretNext2ByteNSV4Instruction:for:extA:extB:startPC: (in category '*BytecodeSets-NewsqueakV4-decoding') ----- interpretNext2ByteNSV4Instruction: bytecode for: client extA: extA extB: extB startPC: startPC "Send to the argument, client, a message that specifies the next instruction. This method handles the two-byte codes. For a table of the bytecode set, see EncoderForNewsqueakV4's class comment." | byte method | method := self method. byte := self method at: pc. pc := pc + 1. "We do an inline quasi-binary search on bytecode" bytecode < 235 ifTrue: [bytecode < 231 ifTrue: [bytecode < 229 ifTrue: [| literal | bytecode = 226 ifTrue: [^client pushReceiverVariable: (extA bitShift: 8) + byte]. literal := method literalAt: (extA bitShift: 8) + byte + 1. bytecode = 227 ifTrue: [^client pushLiteralVariable: literal]. ^client pushConstant: literal]. bytecode = 229 ifTrue: + [^client pushSpecialConstant: (extB bitShift: 8) + byte]. - [^client pushConstant: (extB bitShift: 8) + byte]. ^client pushTemporaryVariable: byte]. bytecode = 231 ifTrue: [^byte < 128 ifTrue: [client pushNewArrayOfSize: byte] ifFalse: [client pushConsArrayWithElements: byte - 128]]. bytecode = 232 ifTrue: [^client storeIntoReceiverVariable: (extA bitShift: 8) + byte]. bytecode = 233 ifTrue: [^client storeIntoLiteralVariable: (method literalAt: (extA bitShift: 8) + byte + 1)]. ^client storeIntoTemporaryVariable: byte]. bytecode < 238 ifTrue: [bytecode = 235 ifTrue: [^client popIntoReceiverVariable: (extA bitShift: 8) + byte]. bytecode = 236 ifTrue: [^client popIntoLiteralVariable: (method literalAt: (extA bitShift: 8) + byte + 1)]. ^client popIntoTemporaryVariable: byte]. bytecode < 242 ifTrue: [| selector numArgs | selector := method literalAt: (extA bitShift: 5) + (byte // 8) + 1. numArgs := (extB bitShift: 3) + (byte \\ 8). bytecode = 238 ifTrue: [^client send: selector super: false numArgs: numArgs]. bytecode = 239 ifTrue: [^client send: selector super: true numArgs: numArgs]. bytecode = 240 ifTrue: [^client sendToAbsentImplicitReceiver: selector numArgs: numArgs]. ^client sendToAbsentDynamicSuperclass: selector numArgs: numArgs]. bytecode < 245 ifTrue: [bytecode = 242 ifTrue: [^client jump: (extB bitShift: 8) + byte]. ^client jump: (extB bitShift: 8) + byte if: bytecode = 243]. bytecode = 245 ifTrue: [| selector numArgs | selector := method literalAt: (extA bitShift: 5) + (byte // 8) + 1. numArgs := (extB bitShift: 3) + (byte \\ 8). ^client sendToAbsentSelf: selector numArgs: numArgs]. "246-247 1111011 i xxxxxxxx UNASSIGNED 248-249 1111100 i xxxxxxxx UNASSIGNED" ^self unusedBytecode: client at: startPC! Item was changed: ----- Method: InstructionStream>>interpretNextNSV3InstructionFor: (in category '*BytecodeSets-NewsqueakV3-decoding') ----- interpretNextNSV3InstructionFor: client "Send to the argument, client, a message that specifies the type of the next instruction." | byte type offset method | method := self method. byte := method at: pc. type := byte // 16. offset := byte \\ 16. pc := pc+1. "We do an inline binary search on each of the possible 16 values of type." type < 8 ifTrue: [type < 4 ifTrue: [type < 2 ifTrue: [type = 0 ifTrue: [^ client pushReceiverVariable: offset]. ^ client pushTemporaryVariable: offset]. "type = 1" type = 2 ifTrue: [^ client pushConstant: (method literalAt: offset + 1)]. ^ client pushConstant: (method literalAt: offset + 17)]. "type = 3" type < 6 ifTrue: [type = 4 ifTrue: [^ client pushLiteralVariable: (method literalAt: offset + 1)]. ^ client pushLiteralVariable: (method literalAt: offset + 17)]."type = 5" type = 6 ifTrue: [offset < 8 ifTrue: [^ client popIntoReceiverVariable: offset]. ^ client popIntoTemporaryVariable: offset - 8]. "type = 7" offset = 0 ifTrue: [^ client pushReceiver]. + offset < 8 ifTrue: [^ client pushSpecialConstant: (SpecialConstants at: offset)]. - offset < 8 ifTrue: [^ client pushConstant: (SpecialConstants at: offset)]. offset = 8 ifTrue: [^ client methodReturnReceiver]. offset < 12 ifTrue: [^ client methodReturnConstant: (SpecialConstants at: offset - 8)]. offset = 12 ifTrue: [^ client methodReturnTop]. offset = 13 ifTrue: [^ client blockReturnTop]. offset = 14 ifTrue: [| byte2 | byte := method at: pc. pc := pc+1. byte2 := method at: pc. pc := pc+1. ^ client sendToDynamicSuperclass: (method literalAt: byte2 + 1) numArgs: byte]. "offset = 15" byte := method at: pc. pc := pc+1. ^ client pushImplicitReceiverForMessage: (method literalAt: byte + 1)]. type < 12 ifTrue: [type < 10 ifTrue: [type = 8 ifTrue: [^ self interpretNSV3Extension: offset in: method for: client]. "type = 9 (short jumps)" offset < 8 ifTrue: [^ client jump: offset + 1]. ^ client jump: offset - 8 + 1 if: false]. type = 10 ifTrue: "(long jumps)" [byte := method at: pc. pc := pc + 1. offset < 8 ifTrue: [^ client jump: offset - 4 * 256 + byte]. ^ client jump: (offset bitAnd: 3) * 256 + byte if: offset < 12]. "type = 11; arithmetic special selector sends" ^ client + sendSpecial: (Smalltalk specialSelectorAt: offset + 1) - send: (Smalltalk specialSelectorAt: offset + 1) - super: false numArgs: (Smalltalk specialNargsAt: offset + 1)]. type = 12 ifTrue: "non-arithmetic special selector sends" [^ client + sendSpecial: (Smalltalk specialSelectorAt: offset + 17) - send: (Smalltalk specialSelectorAt: offset + 17) - super: false numArgs: (Smalltalk specialNargsAt: offset + 17)]. "type = 13, 14 or 15" ^ client send: (method literalAt: offset + 1) super: false numArgs: type - 13 "0, 1 & 2"! Item was changed: ----- Method: InstructionStream>>interpretNextNSV4InstructionFor: (in category '*BytecodeSets-NewsqueakV4-decoding') ----- interpretNextNSV4InstructionFor: client "Send to the argument, client, a message that specifies the next instruction." | byte div16 offset method extA extB savedPC | method := self method. "For a table of the bytecode set, see EncoderForNewsqueakV4's class comment." "consume and compute any extensions first." extA := extB := 0. savedPC := pc. [byte := self method at: pc. pc := pc + 1. byte >= 224 and: [byte <= 225]] whileTrue: [| extByte | extByte := self method at: pc. pc := pc + 1. byte = 224 ifTrue: [extA := (extA bitShift: 8) + extByte] ifFalse: [extB := (extB = 0 and: [extByte > 127]) ifTrue: [extByte - 256] ifFalse: [(extB bitShift: 8) + extByte]]]. div16 := byte // 16. offset := byte \\ 16. "We do an inline quasi-binary search on each of the possible 16 values of div16" div16 < 12 ifTrue: [div16 < 4 ifTrue: [div16 < 2 ifTrue: [div16 = 0 ifTrue: [^client pushReceiverVariable: offset]. ^client pushLiteralVariable: (method literalAt: offset + 1)]. "div16 = 1" ^client pushConstant: (method literalAt: byte \\ 32 + 1)]. div16 = 4 ifTrue: [offset < 12 ifTrue: [^client pushTemporaryVariable: offset]. offset < 14 ifTrue: [offset = 12 ifTrue: [^client pushReceiver]. extB = 0 ifTrue: + [^client pushSpecialConstant: false]. - [^client pushConstant: false]. ^self interpretNSV4ExtendedPush: extB for: client]. + ^client pushSpecialConstant: offset - 14]. "0 & 1" - ^client pushConstant: offset - 14]. "0 & 1" "short sends" div16 < 7 ifTrue: "special selector sends" [div16 = 5 ifTrue: [^client + sendSpecial: (Smalltalk specialSelectorAt: offset + 1) - send: (Smalltalk specialSelectorAt: offset + 1) - super: false numArgs: (Smalltalk specialNargsAt: offset + 1)]. ^client + sendSpecial: (Smalltalk specialSelectorAt: offset + 17) - send: (Smalltalk specialSelectorAt: offset + 17) - super: false numArgs: (Smalltalk specialNargsAt: offset + 17)]. div16 < 10 ifTrue: "vanilla sends, div16 = 7, 8 & 9" [^client send: (method literalAt: offset + 1) super: false numArgs: div16 - 7]. "implicit receiver send, div16 = 10" div16 = 10 ifTrue: [^client sendToAbsentImplicitReceiver: (method literalAt: offset + 1) numArgs: 0]. "short store pops" offset < 8 ifTrue: [^client popIntoReceiverVariable: offset]. ^client popIntoTemporaryVariable: offset - 8]. "div16 >= 12" div16 < 14 ifTrue: [div16 = 12 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1]. ^client jump: offset - 7 if: true]. offset < 8 ifTrue: [^client jump: offset + 1 if: false]. offset < 11 ifTrue: [offset = 8 ifTrue: [^client methodReturnReceiver]. offset = 9 ifTrue: [^client methodReturnTop]. extA > 0 ifTrue: [^client blockReturnTopFromLevel: extA]. ^client blockReturnTop]. offset = 11 ifTrue: [^client doDup]. offset = 12 ifTrue: [^client doPop]. offset = 13 ifTrue: [^client doNop]. "222 11011110 break ? could have blockCopy: send break, but need a receiver and a pop result" "223 11011111 UNASSIGNED" ^self unusedBytecode: client at: savedPC]. "2 byte and 3 byte codes" byte < 249 ifTrue: [^self interpretNext2ByteNSV4Instruction: byte for: client extA: extA extB: extB startPC: savedPC]. ^self interpretNext3ByteNSV4Instruction: byte for: client extA: extA extB: extB startPC: savedPC!

2 1

[OpenSmalltalk/opensmalltalk-vm] Proposal for new BitBlt rules (#505)
by Juan Vuletich 26 Feb '22

26 Feb '22

In addition to the existing alpha blending rules (24 and 34), I propose 3 new additional rules. Check https://en.wikipedia.org/wiki/Alpha_compositing Existing rule 34 is a correct implementation of Alpha Blending for scaled forms, i.e. if premultiplied alpha is used. But rule 24 is a correct implementation of non-scaled forms, only for the case where destination is opaque (i.e. it's alpha is 1.0 in every pixel). If destination includes translucency (or it is completely transparent), the result is not correct. In order to fix it, the RGB of each pixel need to be divided by the pixel alpha. The proposed blendUnscaled is the basic (for non-scaled forms) alpha blending described in Wikipedia. Note that users knowing that destination background is opaque might call the faster rule 24 instead. The other two additional proposed rules are for converting to and from premultiplied alpha. EXISTING blend 24 alphaBlend resultAlpha = srcAlpha + destAlpha*(1-srcAlpha) resultRGB = srcAlpha*source + (1-srcAlpha)*dest EXISTING blendAlphaScaled 34 alphaBlendScaled resultRGBA = source + (1-srcAlpha)*dest NEW PROPOSED multiplyRGBByAlpha Non premultiplied alpha -> premultiplied alpha. Only uses destination. Alpha unmodified. For each RGB component, resultRGB = dest*destAlpha NEW PROPOSED divideRGBByAlpha Premultiplied alpha -> non premultiplied alpha. Only uses destination. Alpha unmodified. For each RGB component, resultRGB = dest/destAlpha NEW PROPOSED blendUnscaled Equivalent to blend, and then divideRGBByAlpha resultAlpha = srcAlpha + destAlpha*(1-srcAlpha) resultRGB = (srcAlpha*source + (1-srcAlpha)*dest) / resultAlpha This would allow handling of scaled (premultiplied-alpha) forms, and blending of regular forms including translucency, without the need to call slower smalltalk code to fix the results. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/505

7 12

[OpenSmalltalk/opensmalltalk-vm] primitiveTranslateStringWithTable modifies symbols in place, it should be reserved for non-literal strings only (#561)
by fmateoc 21 Feb '22

21 Feb '22

After making sure a string was not interned, ( "Symbol findInterned: 'test123'" returned nil ), I did | s | s := #TEST123. s translateToLowercase. s -> (Symbol findInterned: s) and the resulting s is a Symbol and it is not interned. To make sure that the primitive is invoked (and not its fallback code), put a halt in ByteString class >> #translate:from:to:table: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/561

2 2

[OpenSmalltalk/opensmalltalk-vm] squeak.cog.spur_linux32ARMv6_202003021730 ---- seg fault on Cuis image (#597)
by Dr. Nicola Mingotti 20 Feb '22

20 Feb '22

Hi guys, i report you that according to my latest tests with Cuis on a BeagleBone Black the VM in the title is not running. But the latest-build does run ! bye ================= output ================================== root@beaglebone:~/cuis-project# ./sqcogspurlinuxhtRPi/squeak Cuis-Smalltalk-Dev/Cuis5.0-4834-32.image Segmentation fault Wed Sep 15 15:55:11 2021 /root/cuis-project/sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730/squeak Squeak VM version: 5.0-202003021730 Tue Mar 3 09:42:45 UTC 2020 gcc 4.9.2 [Production Spur VM] Built from: CoInterpreter VMMaker.oscog-nice.2712 uuid: da64ef0b-fb0a-4770-ac16-f9b448234615 Mar 3 2020 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020 Revision: VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-97835d24-79f4-41d1-b7e9-c81bd8bf7149 4.4.0-104-generic #127~14.04.1-Ubuntu SMP Mon Dec 11 12:44:15 UTC 2017 armv7l GNU/Linux plugin path: ./sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730 [default: /root/cuis-project/sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730/] C stack backtrace & registers: r0 0x00000000 r1 0x03004c70 r2 0x03004d30 r3 0x03004c70 r4 0x00000000 r5 0xbe952e90 r6 0x03012d40 r7 0x00224250 r8 0x00000000 r9 0x00000001 r10 0x00216288 fp 0x0021a278 ip 0x000005ec sp 0xbe950ea8 lr 0x00069290 pc 0x0004fe44 *[0x0] /lib/arm-linux-gnueabihf/libc.so.6(vsprintf+0x4e)[0xb6d2a293] Smalltalk stack dump: 0xbe952e64 M SystemDictionary(Set)>findElementOrNil: 0x30cc098: a(n) SystemDictionary 0xbe952e90 I SystemDictionary(Dictionary)>at:put: 0x30cc098: a(n) SystemDictionary 0xbe952ebc I SystemDictionary>at:put: 0x30cc098: a(n) SystemDictionary 0xbe952f08 I [] in SystemDictionary>snapshot:andQuit:embedded:clearAllClassState: 0x30cc098: a(n) SystemDictionary 0x3a79bf0 s [] in BlockClosure>newProcess Most recent primitives maxIdentityHash identityHash at: at: stack page bytes 4096 available headroom 2788 minimum unused headroom 3776 (Segmentation fault) Aborted root@beaglebone:~/cuis-project# ========================================== -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/597

2 2

[OpenSmalltalk/opensmalltalk-vm] Illegal instruction `mrs x0, id_aa64isar0_el1` on aarch64 on older Linux kernels (Issue #608)
by Tony Garnock-Jones 22 Dec '21

22 Dec '21

I'm running Cog on aarch64, and because I have an old linux kernel (v3.18.140) which I cannot upgrade (it's a repurposed PostmarketOS Android device), Cog yields illegal instruction trying to execute `mrs x0, id_aa64isar0_el1`. This instruction is privileged, but later linux kernels trap and emulate it for userspace. Given that it's currently only being used to detect presence of atomic instructions (`self setHasAtomicInstructions: (idISAR0 >> 20 bitAnd: 2r1111) = 2r10`), and there's a kernel API for retrieving that specific bit of information (<https://www.kernel.org/doc/html/latest/arm64/elf_hwcaps.html> suggests HWCAP_ATOMICS), perhaps instead of using the instruction directly Cog could call the relevant `getauxval` variant? For now, I have the Stack VM running well on aarch64, so I can make progress, even if it is a little slower than it could be :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/608

2 5

[OpenSmalltalk/opensmalltalk-vm] Cannot build unix sources (missing file: bld/plugins.int) (#507)
by Christoph Thiede 21 Dec '21

21 Dec '21

I am trying to build the unix sources for this project, exactly following the `HowToBuildFromSources` manual (the easy way). But unfortunately, when running `make` I get an error that `bld/plugins.int` is missing: ``` $ make [ -d bld ] || mkdir bld [ -f bld/Makefile ] || ( cd bld; ../config/configure; ) checking for gcc... gcc # ... (75 lines skipped) checking whether to build static libraries... no /workspace/opensmalltalk-vm/src /workspace/opensmalltalk-vm/src/plugins checking sanity of generated src directory... bad missing file: /workspace/opensmalltalk-vm/platforms/unix/bld/plugins.int make: *** [Makefile:5: all] Error 1 ``` See yourself: [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#snapshot/9bc102f3-ba84-437f-a226-a8851782c41b) Is it me or is the documentation of the build process not up to date? Looking forward to your help! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/507

7 12

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev November 2021