Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Hi Marcel, this is cool. Annoyingly gmail sent the commit message to my spam folder so I've only just noticed it. Forgive me.
I would make two minor mods. One, declare static int sqFormatToPlatformFormat & platformFormatToSqFormat as private: two, use squeak, not sq, to differentiate from the public C plugin source/internal pl=ugin implementation API:
static int sqqueakFormatToPlatformFormat(int sqFormat);
static int platformFormatToSqueakFormat(int platformFormat);
And arguably using sqInt instead of int will generate better code across 32 & 64 bits.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.