On 2022-08-04 12:09, Eliot Miranda wrote:

> On Wed, Aug 3, 2022 at 5:23 PM Ken Dickey ***@***.***> wrote:
..
>> Sure. Just remove the overwritten method. If you look at the latest,
>> the offset is zero.

> OK. Fix thunkEntry to put back the offset and then I can merge the pull
> request.

riscv64abicc.c as pull request should have
...
vmcc.thunkp = thunkp;
...
which works fine without override of Callback>>addToThunkTable. No
offset required in either place.

So color me confused.

I can re-push the Alien-Core-Kend without the #addToThunkTable override
if you like, but the current pull requiest should work with
Alien-Core-Kend.124 as is.

How about accepting the pull and the Alien-Code, let me re-retest, and
we will fix any breakage from there.

Epsilon close,
-KenD


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/648/c1205692365@github.com>